azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
`botservice`: fixing an inconsistency with the URI Segments
ARM (Control Plane) API Specification Update Pull Request
Tip: overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- If this PR is in purview of ARM review then automation will add the
ARMReviewlabel. - If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [ ] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [x] Update existing version to fix swagger quality issues in S360.
- [x] Other, please clarify:
- These URI Segments are inconsistent and should be made consistent, since this is the same URI with a different HTTP Method - therefore these should support the same values (and therefore the same constant)
- Fixing this for API Versions
2021-05-01-preview,2022-06-15-preview,2023-09-15-preview,2020-06-02,2021-03-01and2022-09-15.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
Next steps that must be taken to merge this PR:- ❌ Your PR has breaking changes (label:
BreakingChangeReviewRequired). See the PR description for help. - ❌ The required check named
Swagger SpellCheckhas failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 34 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| botservice.json | 2021-05-01-preview(d7bde14) | 2021-05-01-preview(main) |
| botservice.json | 2022-06-15-preview(d7bde14) | 2022-06-15-preview(main) |
| botservice.json | 2023-09-15-preview(d7bde14) | 2023-09-15-preview(main) |
| botservice.json | 2020-06-02(d7bde14) | 2020-06-02(main) |
| botservice.json | 2021-03-01(d7bde14) | 2021-03-01(main) |
| botservice.json | 2022-09-15(d7bde14) | 2022-09-15(main) |
Only 28 items are listed, please refer to log for more details.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 10 Errors, 0 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-09 | package-preview-2023-09(d7bde14) | package-preview-2023-09(main) |
| package-2022-09 | package-2022-09(d7bde14) | package-2022-09(main) |
| package-preview-2022-06 | package-preview-2022-06(d7bde14) | package-preview-2022-06(main) |
| package-preview-2021-05 | package-preview-2021-05(d7bde14) | package-preview-2021-05(main) |
| package-2021-03-01 | package-2021-03-01(d7bde14) | package-2021-03-01(main) |
| package-2020-06-02 | package-2020-06-02(d7bde14) | package-2020-06-02(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/botservice/resource-manager/Microsoft.BotService/preview/2023-09-15-preview/botservice.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/d7bde14390faee008eb0cd2626350c19cd492180/#L1 |
|
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/botservice/resource-manager/Microsoft.BotService/stable/2022-09-15/botservice.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/d7bde14390faee008eb0cd2626350c19cd492180/#L1 |
|
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/botservice/resource-manager/Microsoft.BotService/preview/2022-06-15-preview/botservice.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/d7bde14390faee008eb0cd2626350c19cd492180/#L1 |
|
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/botservice/resource-manager/Microsoft.BotService/preview/2021-05-01-preview/botservice.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/d7bde14390faee008eb0cd2626350c19cd492180/#L1 |
|
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/botservice/resource-manager/Microsoft.BotService/stable/2021-03-01/botservice.json'. Errors encountered: TypeError: Cannot read property 'additionalProperties' of null Location: azure-rest-api-specs/blob/d7bde14390faee008eb0cd2626350c19cd492180/#L1 |
|
|
The integer type does not have a format, please add it. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2059 |
|
|
The integer type does not have a format, please add it. Location: Microsoft.BotService/preview/2022-06-15-preview/botservice.json#L2173 |
|
|
The integer type does not have a format, please add it. Location: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L2329 |
|
|
The integer type does not have a format, please add it. Location: Microsoft.BotService/stable/2021-03-01/botservice.json#L1778 |
|
|
The integer type does not have a format, please add it. Location: Microsoft.BotService/stable/2022-09-15/botservice.json#L2173 |
The following errors/warnings exist before current PR submission:
Only 28 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1412 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1465 |
|
The schema 'BotProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1536 |
|
The schema 'BotResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1749 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'BotChannel'. Properties [properties.location] conflict with ARM top level properties. Please rename these. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1797 |
|
The schema 'AlexaChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1914 |
|
The schema 'FacebookChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1957 |
|
The schema 'FacebookPage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L1997 |
|
The schema 'EmailChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2030 |
|
The schema 'MsTeamsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2109 |
|
The schema 'SkypeChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2161 |
|
The schema 'KikChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2226 |
|
The schema 'WebChatChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2267 |
|
The schema 'DirectLineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2303 |
|
The schema 'TelegramChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2345 |
|
The schema 'SmsChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2382 |
|
The schema 'SlackChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2429 |
|
The schema 'LineChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2504 |
|
The schema 'LineRegistration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2529 |
|
The schema 'DirectLineSpeechChannelProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2568 |
|
The schema 'ChannelResponseList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2704 |
|
The schema 'ConnectionItemName' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2977 |
|
The schema 'ConnectionSettingParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L2987 |
|
The schema 'ConnectionSettingProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3001 |
|
The resource ConnectionSetting does not have a corresponding delete operation. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3052 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'ConnectionSetting'. Properties [properties.name] conflict with ARM top level properties. Please rename these. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3052 |
|
Top level property names should not be repeated inside the properties bag for ARM resource 'ConnectionSetting'. Properties [properties.id] conflict with ARM top level properties. Please rename these. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3052 |
|
Tracked resource 'ConnectionSetting' must have patch operation that at least supports the update of tags. Location: Microsoft.BotService/preview/2021-05-01-preview/botservice.json#L3052 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 15 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SpellCheck: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1520:24 |
|
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1530:26 |
|
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1576:26 |
|
Unknown word (networksecurityperimeter), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.BotService/preview/2023-09-15-preview/botservice.json#L1612:24 |
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/botservice/armbotservice - 2.0.0-beta.1+ Function `*ChannelsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, *ChannelsClientDeleteOptions)` to `(context.Context, string, string, ChannelName, *ChannelsClientDeleteOptions)` + Function `*ChannelsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ChannelsClientGetOptions)` to `(context.Context, string, string, ChannelName, *ChannelsClientGetOptions)` + Type alias `EmailChannelAuthMethod` type has been changed from `float32` to `int32`
❌azure-sdk-for-js - @azure/arm-botservice - 5.0.0-beta.1+ Operation Channels.delete has a new signature + Operation Channels.get has a new signature
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.BotService [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-botservice [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group NetworkSecurityPerimeterConfigurationsOperations info [Changelog] - Model BotProperties has a new parameter network_security_perimeter_configurations info [Changelog] - Model ConnectionSettingProperties has a new parameter id info [Changelog] - Model ConnectionSettingProperties has a new parameter name
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-botservice [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group NetworkSecurityPerimeterConfigurationsOperations info [Changelog] - Model BotProperties has a new parameter network_security_perimeter_configurations info [Changelog] - Model ConnectionSettingProperties has a new parameter id info [Changelog] - Model ConnectionSettingProperties has a new parameter name
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/botservice/armbotservice [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type alias `EmailChannelAuthMethod` type has been changed from `float32` to `int32` info [Changelog] - Function `*ChannelsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, *ChannelsClientDeleteOptions)` to `(context.Context, string, string, ChannelName, *ChannelsClientDeleteOptions)` info [Changelog] - Function `*ChannelsClient.Get` parameter(s) have been changed from `(context.Context, string, string, string, *ChannelsClientGetOptions)` to `(context.Context, string, string, ChannelName, *ChannelsClientGetOptions)` info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `PublicNetworkAccessSecuredByPerimeter` added to enum type `PublicNetworkAccess` info [Changelog] - New enum type `AccessMode` with values `AccessModeAudit`, `AccessModeEnforced`, `AccessModeLearning` info [Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound` info [Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateAccepted`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`, `ProvisioningStateUpdating` info [Changelog] - New enum type `Severity` with values `SeverityError`, `SeverityWarning` info [Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient` info [Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)` info [Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.Get(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientGetOptions) (NetworkSecurityPerimeterConfigurationsClientGetResponse, error)` info [Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.NewListPager(string, string, *NetworkSecurityPerimeterConfigurationsClientListOptions) *runtime.Pager[NetworkSecurityPerimeterConfigurationsClientListResponse]` info [Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginReconcile(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginReconcileOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientReconcileResponse], error)` info [Changelog] - New struct `ErrorAdditionalInfo` info [Changelog] - New struct `ErrorDetail` info [Changelog] - New struct `ErrorResponse` info [Changelog] - New struct `NetworkSecurityPerimeter` info [Changelog] - New struct `NetworkSecurityPerimeterConfiguration` info [Changelog] - New struct `NetworkSecurityPerimeterConfigurationList` info [Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties` info [Changelog] - New struct `NspAccessRule` info [Changelog] - New struct `NspAccessRuleProperties` info [Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem` info [Changelog] - New struct `Profile` info [Changelog] - New struct `ProvisioningIssue` info [Changelog] - New struct `ProvisioningIssueProperties` info [Changelog] - New struct `ResourceAssociation` info [Changelog] - New field `NetworkSecurityPerimeterConfigurations` in struct `BotProperties` info [Changelog] - New field `ID`, `Name` in struct `ConnectionSettingProperties` info [Changelog] info [Changelog] Total 3 breaking change(s), 53 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️botservice [View full logs] [Preview Schema Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-botservice [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group NetworkSecurityPerimeterConfigurations info [Changelog] - Added Interface ErrorAdditionalInfo info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponse info [Changelog] - Added Interface NetworkSecurityPerimeter info [Changelog] - Added Interface NetworkSecurityPerimeterConfiguration info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationList info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationProperties info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationsGetOptionalParams info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationsListNextOptionalParams info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationsListOptionalParams info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationsReconcileHeaders info [Changelog] - Added Interface NetworkSecurityPerimeterConfigurationsReconcileOptionalParams info [Changelog] - Added Interface NspAccessRule info [Changelog] - Added Interface NspAccessRuleProperties info [Changelog] - Added Interface NspAccessRulePropertiesSubscriptionsItem info [Changelog] - Added Interface Profile info [Changelog] - Added Interface ProvisioningIssue info [Changelog] - Added Interface ProvisioningIssueProperties info [Changelog] - Added Interface ResourceAssociation info [Changelog] - Added Type Alias AccessMode info [Changelog] - Added Type Alias NetworkSecurityPerimeterConfigurationsGetResponse info [Changelog] - Added Type Alias NetworkSecurityPerimeterConfigurationsListNextResponse info [Changelog] - Added Type Alias NetworkSecurityPerimeterConfigurationsListResponse info [Changelog] - Added Type Alias NetworkSecurityPerimeterConfigurationsReconcileResponse info [Changelog] - Added Type Alias NspAccessRuleDirection info [Changelog] - Added Type Alias ProvisioningState info [Changelog] - Added Type Alias Severity info [Changelog] - Interface BotProperties has a new optional parameter networkSecurityPerimeterConfigurations info [Changelog] - Interface ConnectionSettingProperties has a new optional parameter id info [Changelog] - Interface ConnectionSettingProperties has a new optional parameter name info [Changelog] - Added Enum KnownAccessMode info [Changelog] - Added Enum KnownNspAccessRuleDirection info [Changelog] - Added Enum KnownProvisioningState info [Changelog] - Added Enum KnownSeverity info [Changelog] - Enum KnownPublicNetworkAccess has a new value SecuredByPerimeter info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Operation Channels.delete has a new signature info [Changelog] - Operation Channels.get has a new signature info [Changelog] - Class AzureBotService has a new signature
️⚠️ azure-powershell warning [Detail]
⚠️Warning [Logs] Generate from ef2302ee87f94b8fbcb5862490b9d612066c60e1. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.botservice.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/botservice/armbotservice | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| .Net | Azure.ResourceManager.BotService | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| JavaScript | @azure/arm-botservice | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Swagger | Microsoft.BotService | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.
![microsoft-github-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/95686?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @rkmanda @sgellock, could you take a look at this PR that addresses the BotService API issue?
Hi @wuxu92 @rkmanda, I can approve this changes from Bot Service POV, this is a good and safe change. Please help proceed this pull request.
