azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Feature/datamap tsp

Open yifan-zhou922 opened this issue 1 year ago • 34 comments

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • [ ] a private preview
  • [ ] a public preview
  • [ ] GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

yifan-zhou922 avatar Nov 14 '23 14:11 yifan-zhou922

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Swagger Validation Report

️❌BreakingChange: 477 Errors, 95 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
purviewdatamap.json 2023-09-01(6d23227) 2023-09-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L470:9
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L1151:9
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/lineage/{guid}/next/' removed or restructured?
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L2994:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TermCustomAttributes' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ClassificationAssociateRequest' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MoveEntitiesRequest' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Status' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Status_AtlasRelationship' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutoCompleteRequest' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SearchRequest' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SuggestRequest' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LastModifiedTS' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BusinessMetadata' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BusinessMetadataAttributes' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4508:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L4007:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'endpoint' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'guid' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'classificationName' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'typeName' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'categoryGuid' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'limit' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'offset' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'sort' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'termGuid' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'fileId' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'glossaryGuid' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'operationGuid' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'glossaryName' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'searchLimit' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'searchKeyword' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'depth' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'direction' removed or renamed?
New: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L8208:3
Old: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L6779:3
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 243 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.7) new version base version
package-2023-09 package-2023-09(6d23227) package-2023-09(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
:warning: SecurityDefinitionDescription Security definition should have a description.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L42
:warning: VersionPolicy 'api-version' should be a required parameter
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L58
:warning: ParameterDescription Parameter should have a description.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L101
:warning: VersionPolicy 'api-version' should be a required parameter
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L142
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L156
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L163
:warning: VersionPolicy 'api-version' should be a required parameter
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L195
:warning: ParameterDescription Parameter should have a description.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L238
:warning: ParameterDescription Parameter should have a description.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L309
:warning: ParameterDescription Parameter should have a description.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L341
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L379
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L386
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L393
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L501
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L508
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L515
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L547
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L593
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L627
:warning: AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L649
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L677
:warning: AdditionalPropertiesObject additionalProperties with type object is a common error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L691
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L716
:warning: ParameterOrder Path parameter 'guid' should appear before 'businessMetadataName'.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L720
:warning: VersionPolicy Operation does not define an 'api-version' query parameter.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L720
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L721
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L728
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L750
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L752
:warning: DeleteInOperationName 'DELETE' operation 'Entity_RemoveBusinessMetadataAttributes' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L764


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L53
:warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L54
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L117
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L119
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L137
:warning: PageableOperation Based on the response model schema, operation 'Entity_ListByGuids' might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L138
:warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L138
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L178
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L180
:warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L191
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L254
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L256
:warning: DeleteInOperationName 'DELETE' operation 'Entity_BulkDelete' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L268
:warning: VersionPolicy Operation does not define an 'api-version' query parameter.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L270
:warning: Delete204Response A delete operation should have a 204 response.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L283
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L290
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L292
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L304
:warning: VersionPolicy Operation does not define an 'api-version' query parameter.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L308
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L322
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L324
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L336
:warning: VersionPolicy Operation does not define an 'api-version' query parameter.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L340
:warning: ErrorResponse Error response should contain a x-ms-error-code header.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L360
:warning: ErrorResponse Error response schema should contain an object property named error.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L362
:warning: VersionPolicy Version segment 'v2' in path violates Azure versioning policy.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L374
:warning: PageableOperation Based on the response model schema, operation 'Entity_ListByUniqueAttributes' might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L375
:warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L375
:warning: VersionPolicy Operation does not define an 'api-version' query parameter.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L378
:warning: ParameterNamesConvention Parameter name 'attr_N:qualifiedName' should be camel case.
Location: Azure.Analytics.Purview.DataMap/stable/2023-09-01/purviewdatamap.json#L401
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking



️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from 81e485db5971b91436e418886c5847fe8af5bdf8. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1]
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[Invoke-GenerateAndBuildV2.ps1] npm notice
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 141 | [0m               [36;1mGeneratePackage `[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 141 | [0m               [36;1mGeneratePackage `[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:141
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 141 | [0m               [36;1mGeneratePackage `[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
  • Azure.Analytics.Purview.DataMap [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-python failed [Detail]
  • Code Generator Failed [Logs] Generate from 81e485db5971b91436e418886c5847fe8af5bdf8. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 81e485db5971b91436e418886c5847fe8af5bdf8. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure-rest/purview-datamap [View full logs]  [Preview SDK Changes]
    info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 81e485db5971b91436e418886c5847fe8af5bdf8. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] nt
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0k
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] ################################# 100.0%
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] npm notice
    cmderr	[generate.py] npm notice New major version of npm available! 9.5.0 -> 10.4.0
    cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[generate.py] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[generate.py] npm notice
    cmderr	[generate.py] warning: in the working copy of 'sdk/purview/azure-analytics-purview-datamap/pom.xml', CRLF will be replaced by LF the next time Git touches it
  • ️✔️azure-analytics-purview-datamap [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@MaryGao is this a know JS script issue?

03:54:45.622 cmdout 	[automation_generate.sh] Generate some other files for @azure-rest/azure-analytics-purview-datamap-rest in /mnt/vss/_work/1/s/azure-sdk-for-js/sdk/azure.analytics.purview.datamap/azure-analytics-purview-datamap-rest...
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] Error:
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/purview/Azure.Analytics.Purview.DataMap":
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] Err: Wrong package path /mnt/vss/_work/1/s/azure-sdk-for-js/sdk/azure.analytics.purview.datamap/azure-analytics-purview-datamap-rest;
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] Stderr: "undefined"
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] Stdout: "undefined"
03:54:45.634 cmderr 	[automation_generate.sh] [ERROR] ErrorStack: "undefined"
03:54:45.635 cmderr 	[automation_generate.sh] [ERROR] Cannot read properties of undefined (reading 'module')
03:54:45.641 error C 	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh

@chunyu3 , can you have a look at dotnet sdk generation failure? Can you comment if it's a spec issue?

raych1 avatar Nov 20 '23 02:11 raych1

/azp run

MaryGao avatar Nov 23 '23 01:11 MaryGao

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 23 '23 01:11 azure-pipelines[bot]

/azp run

MaryGao avatar Nov 23 '23 04:11 MaryGao

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 23 '23 04:11 azure-pipelines[bot]

Hi @MaryGao , @raych1 , please help check why the sdk generation pipeline fails. For the breaking changes, it was a model error we discovered when migrating from openAPI to typeSpec. (No SDK has been released for this version) Please help review the PR. Thanks.

yifan-zhou922 avatar Nov 24 '23 09:11 yifan-zhou922

Hi @MaryGao , @raych1 , please help check why the sdk generation pipeline fails. For the breaking changes, it was a model error we discovered when migrating from openAPI to typeSpec. (No SDK has been released for this version) Please help review the PR. Thanks.

@MaryGao JS package was generated but failed to build.

raych1 avatar Nov 27 '23 01:11 raych1

/azp run

kazrael2119 avatar Nov 28 '23 03:11 kazrael2119

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 28 '23 03:11 azure-pipelines[bot]

/azp run

yifan-zhou922 avatar Dec 04 '23 07:12 yifan-zhou922

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 04 '23 07:12 azure-pipelines[bot]

/azp run

msyyc avatar Dec 07 '23 06:12 msyyc

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 07 '23 06:12 azure-pipelines[bot]

/azp run

msyyc avatar Dec 07 '23 07:12 msyyc

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 07 '23 07:12 azure-pipelines[bot]

/azp run

yifan-zhou922 avatar Dec 08 '23 02:12 yifan-zhou922

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 02:12 azure-pipelines[bot]

/azp run

yifan-zhou922 avatar Dec 08 '23 02:12 yifan-zhou922

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 02:12 azure-pipelines[bot]

/azp run

yifan-zhou922 avatar Dec 08 '23 06:12 yifan-zhou922

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 06:12 azure-pipelines[bot]

/azp run

yifan-zhou922 avatar Dec 08 '23 10:12 yifan-zhou922

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 08 '23 10:12 azure-pipelines[bot]

/azp run

MaryGao avatar Dec 11 '23 04:12 MaryGao

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 11 '23 04:12 azure-pipelines[bot]

Issues: https://github.com/Azure/azure-sdk-pr/issues/1668

yifan-zhou922 avatar Dec 14 '23 06:12 yifan-zhou922