azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
Origin/neeleshk cdn profilelogscrubbing
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [ ] New API version. (Such PR should have been generated with OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
- If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
- If this PR is in purview of ARM review then automation will add the
ARMReviewlabel. - If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- For general PR approval workflow, see the diagram at the top of this comment.
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 18 Warnings warning [Detail]
| Compared specs (v0.10.5) | new version | base version |
|---|---|---|
| afdx.json | 2024-02-01(9320af7) | 2023-05-01(main) |
| afdx.json | 2024-02-01(9320af7) | 2023-07-01-preview(main) |
| cdn.json | 2024-02-01(9320af7) | 2023-05-01(main) |
| cdn.json | 2024-02-01(9320af7) | 2023-07-01-preview(main) |
| cdnwebapplicationfirewall.json | 2024-02-01(9320af7) | 2023-05-01(main) |
| cdnwebapplicationfirewall.json | 2024-02-01(9320af7) | 2023-07-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/keyGroups' removed or restructured? Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3546:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/keyGroups/{keyGroupName}' removed or restructured? Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3591:5 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'KeyGroup' removed or renamed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L4207:3 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4422:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'KeyGroupProperties' removed or renamed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L4207:3 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4422:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'AfdUrlSigningAction' removed or renamed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L4207:3 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4422:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'AfdUrlSigningActionParameters' removed or renamed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L4207:3 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4422:3 |
| :warning: 1007 - RemovedClientParameter | The new version is missing a client parameter that was found in the old version. Was 'keyGroupNameParameter' removed or renamed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L6272:3 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6639:3 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1019 - RemovedEnumValue | The new version is removing enum value(s) 'AfdUrlSigning' from the old version. New: Microsoft.Cdn/stable/2024-02-01/cdn.json#L4822:9 Old: Microsoft.Cdn/preview/2023-07-01-preview/cdn.json#L4738:9 |
| :warning: 1033 - RemovedProperty | The new version is missing a property found in the old version. Was 'referencedRoutePaths' renamed or removed? New: Microsoft.Cdn/stable/2024-02-01/afdx.json#L4432:7 Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4706:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-2024-02 | package-2024-02(9320af7) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L136 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L185 |
|
202 response for a LRO POST operation must not have a response schema specified. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L292 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L347 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L357 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L406 |
|
The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L406 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L458 |
|
The 'profileName' already appears in the path, please don't repeat it in the request body. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L473 |
|
A 202 response should include an Location response header. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L521 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L530 |
|
Properties of a PATCH request body must not be required, property:certificateType. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L573 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L605 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L614 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L668 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L678 |
|
The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L678 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L679 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L730 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L740 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L789 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L789 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L841 |
|
The 'profileName' already appears in the path, please don't repeat it in the request body. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L856 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L913 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L988 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L997 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L1051 |
|
The resource name parameter 'profileName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L1061 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.Cdn/stable/2024-02-01/afdx.json#L1061 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 54 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-cdn [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model Profile has a new parameter log_scrubbing info [Changelog] - Model ProfileUpdateParameters has a new parameter log_scrubbing
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] Time Time Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 1036k cmderr [init.sh] notice cmderr [init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [init.sh] npm notice cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-cdn-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/cdn/armcdn [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `ProfileScrubbingState` with values `ProfileScrubbingStateDisabled`, `ProfileScrubbingStateEnabled` info [Changelog] - New enum type `ScrubbingRuleEntryMatchOperator` with values `ScrubbingRuleEntryMatchOperatorEqualsAny` info [Changelog] - New enum type `ScrubbingRuleEntryMatchVariable` with values `ScrubbingRuleEntryMatchVariableQueryStringArgNames`, `ScrubbingRuleEntryMatchVariableRequestIPAddress`, `ScrubbingRuleEntryMatchVariableRequestURI` info [Changelog] - New enum type `ScrubbingRuleEntryState` with values `ScrubbingRuleEntryStateDisabled`, `ScrubbingRuleEntryStateEnabled` info [Changelog] - New struct `ProfileLogScrubbing` info [Changelog] - New struct `ProfileScrubbingRules` info [Changelog] - New field `LogScrubbing` in struct `ProfileProperties` info [Changelog] - New field `LogScrubbing` in struct `ProfilePropertiesUpdateParameters` info [Changelog] info [Changelog] Total 0 breaking change(s), 18 additive change(s).
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk. exit code: False[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mCannot find path[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m | [31;1mit does not exist.[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk artifact[0m
❌Azure.ResourceManager.Cdn [View full logs] [Preview SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-cdn [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface ProfileLogScrubbing info [Changelog] - Added Interface ProfileScrubbingRules info [Changelog] - Added Type Alias ProfileScrubbingState info [Changelog] - Added Type Alias ScrubbingRuleEntryMatchOperator info [Changelog] - Added Type Alias ScrubbingRuleEntryMatchVariable info [Changelog] - Added Type Alias ScrubbingRuleEntryState info [Changelog] - Interface Profile has a new optional parameter logScrubbing info [Changelog] - Interface ProfileUpdateParameters has a new optional parameter logScrubbing info [Changelog] - Added Enum KnownProfileScrubbingState info [Changelog] - Added Enum KnownScrubbingRuleEntryMatchOperator info [Changelog] - Added Enum KnownScrubbingRuleEntryMatchVariable info [Changelog] - Added Enum KnownScrubbingRuleEntryState
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️⚠️ azure-powershell warning [Detail]
⚠️Warning [Logs] Generate from d0b7d3ee619efe3476564fffdd701f8301f86db5. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.cdn.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/cdn/armcdn | https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=851108e03bb940c6b6c0a7c7c254ab6a |
| JavaScript | @azure/arm-cdn | https://apiview.dev/Assemblies/Review/d03c7f4c0d164abd85030a921f78f9ad?revisionId=e3bcee742921401f88fa1b63935a2a8f |
| Java | azure-resourcemanager-cdn-generated | https://apiview.dev/Assemblies/Review/a857fa609d3c43b09808544a49c0693b?revisionId=8e1c1069dc774fc7966323229a7d2ef8 |
| Swagger | Microsoft.Cdn | https://apiview.dev/Assemblies/Review/903c889b8b1e4bf9bd097f6d66eb1cdd?revisionId=1db92a2ce67840c79ac99957e6a12966 |
Hi @neelesh06! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @neelesh06! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Please follow this guide and also check the pipeline failures
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
{
Please fix Model Validations errors shown in PR.
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/afdx.json:1 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)
we have same PR raised in the private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/16861 please review private repo PR as well along with this PR.
here is the work item to fix the model validation errors https://msazure.visualstudio.com/One/_workitems/edit/25074634.
"type": "string",
Please define the state as its own definition, and do $ref here and all other places, instead of defining it multiple times.
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2969 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)
"ProfileScrubbingRules": {
Need to add/update any examples for this newly added property?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2932 in 0f2797f. [](commit_id = 0f2797f9b450491eca644be474d83df22e62a5b4, deletion_comment = False)
"ProfileScrubbingRules": {Need to add/update any examples for this newly added property?
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2932 in 0f2797f. [](commit_id = 0f2797f, deletion_comment = False)
Profiles_Create.json has defined the new property ProfileScrubbingRules.
"type": "string",Please define the state as its own definition, and do $ref here and all other places, instead of defining it multiple times.
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/stable/2024-02-01/cdn.json:2969 in 0f2797f. [](commit_id = 0f2797f, deletion_comment = False)
Do you mean the logscrubbing because we define this 2 times. I created new $def for logscrubbing and using $ref of this definition both the places.