azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Feature/cplat 2023 09 01

Open D1v38om83r opened this issue 1 year ago • 4 comments

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
  • [x] I commit to follow the Breaking Change Policy.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy, follow the process outlined in the High-level Breaking Change Process doc.

Getting help

  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For additional help, see https://aka.ms/azsdk/support/spectools.

D1v38om83r avatar Jul 11 '23 22:07 D1v38om83r

Hi, @D1v38om83r! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    computeRPCommon.json 2023-09-01(4703bfe) 2023-07-01(main)
    virtualMachine.json 2023-09-01(4703bfe) 2023-07-01(main)
    virtualMachineScaleSet.json 2023-09-01(4703bfe) 2023-07-01(main)
    ️❌LintDiff: 9 Errors, 19 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.6) new version base version
    package-2023-09-01 package-2023-09-01(4703bfe) package-2023-09-01(feature/cplat-2023-09-01)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    GetCollectionResponseSchema The response in the GET collection operation 'VirtualMachineApplications_List' does not match the response definition in the individual GET operation 'VirtualMachineApplications_Get' .
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L36
    RPC-Get-V1-10
    XmsIdentifierValidation Missing identifier packageReferenceId in array item property
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1167
    GetCollectionResponseSchema The response in the GET collection operation 'VirtualMachineApplications_List' does not match the response definition in the individual GET operation 'VirtualMachineApplications_Get' .
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1898
    RPC-Get-V1-10
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/VMApplications'
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1898
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/VMApplications/{applicationName}'
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1954
    ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1961
    RPC-Get-V1-08
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2202
    ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3748
    RPC-Get-V1-08
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3871
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1223
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1251
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1905
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L1961
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2033
    :warning: PutInOperationName 'PUT' operation 'VirtualMachineApplications_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2095
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2097
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2170
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: VirtualMachineApplication_With_InstanceView
    Location: ComputeRP/stable/2023-09-01/virtualMachine.json#L2213
    :warning: PageableOperation Based on the response model schema, operation 'VirtualMachineScaleSetApplications_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1034
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1040
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1093
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1148
    :warning: PutInOperationName 'PUT' operation 'VirtualMachineScaleSetApplications_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1210
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L1212
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3742
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3748
    :warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3832
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: VirtualMachineScaleSetVirtualMachineApplication_GetWithInstanceView
    Location: ComputeRP/stable/2023-09-01/virtualMachineScaleSet.json#L3882


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GetCollectionResponseSchema The response in the GET collection operation 'VirtualMachineRunCommands_List' does not match the response definition in the individual GET operation 'VirtualMachineRunCommands_Get' .
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L36
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Compute/operations' does not match the ARM specification. Please standardize the schema.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L52
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L53
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L152
    MissingTypeObject The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L178
    MissingTypeObject The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L194
    MissingTypeObject The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L213
    MissingTypeObject The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L238
    MissingTypeObject The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L251
    MissingTypeObject The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L287
    MissingTypeObject The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L355
    MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L369
    MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L403
    MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L418
    MissingTypeObject The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L439
    MissingTypeObject The schema 'ImageReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L640
    MissingTypeObject The schema 'KeyVaultSecretReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L691
    MissingTypeObject The schema 'KeyVaultKeyReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L717
    MissingTypeObject The schema 'DiskEncryptionSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L734
    MissingTypeObject The schema 'VirtualHardDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L773
    MissingTypeObject The schema 'DiffDiskSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L871
    MissingTypeObject The schema 'ManagedDiskParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L884
    MissingTypeObject The schema 'OSDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L906
    MissingTypeObject The schema 'DataDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L971
    MissingTypeObject The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1052
    MissingTypeObject The schema 'UefiSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1079
    MissingTypeObject The schema 'SecurityProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1092
    MissingTypeObject The schema 'AdditionalCapabilities' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1286
    MissingTypeObject The schema 'AdditionalUnattendContent' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1299
    MissingTypeObject The schema 'WinRMListener' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2023-09-01/computeRPCommon.json#L1342
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2023-09-01
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - sdk/resourcemanager/compute/armcompute - 6.0.0
    +	Function `*timeRFC3339.Parse` has been removed
    +	Function `*timeRFC3339.UnmarshalText` has been removed
    +	Function `timeRFC3339.MarshalText` has been removed


    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.Compute [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️❌ azure-sdk-for-java failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated/pom.xml'
      Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated/pom.xml'
    • azure-resourcemanager-compute-generated [View full logs
      error	Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated/pom.xml'
      error	The following packages are still pending:
      error		azure-resourcemanager-compute-generated
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/compute/armcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `timeRFC3339.MarshalText` has been removed
      info	[Changelog] - Function `*timeRFC3339.Parse` has been removed
      info	[Changelog] - Function `*timeRFC3339.UnmarshalText` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*ClientFactory.NewVirtualMachineApplicationsClient() *VirtualMachineApplicationsClient`
      info	[Changelog] - New function `*ClientFactory.NewVirtualMachineScaleSetApplicationsClient() *VirtualMachineScaleSetApplicationsClient`
      info	[Changelog] - New function `*ClientFactory.NewVirtualMachineScaleSetVirtualMachineApplicationsClient() *VirtualMachineScaleSetVirtualMachineApplicationsClient`
      info	[Changelog] - New function `NewVirtualMachineApplicationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualMachineApplicationsClient, error)`
      info	[Changelog] - New function `*VirtualMachineApplicationsClient.BeginDelete(context.Context, string, string, string, *VirtualMachineApplicationsClientBeginDeleteOptions) (*runtime.Poller[VirtualMachineApplicationsClientDeleteResponse], error)`
      info	[Changelog] - New function `*VirtualMachineApplicationsClient.Get(context.Context, string, string, string, *VirtualMachineApplicationsClientGetOptions) (VirtualMachineApplicationsClientGetResponse, error)`
      info	[Changelog] - New function `*VirtualMachineApplicationsClient.GetInstanceView(context.Context, string, string, string, *VirtualMachineApplicationsClientGetInstanceViewOptions) (VirtualMachineApplicationsClientGetInstanceViewResponse, error)`
      info	[Changelog] - New function `*VirtualMachineApplicationsClient.NewListPager(string, string, *VirtualMachineApplicationsClientListOptions) *runtime.Pager[VirtualMachineApplicationsClientListResponse]`
      info	[Changelog] - New function `*VirtualMachineApplicationsClient.BeginPut(context.Context, string, string, string, VMApplicationWithInstanceView, *VirtualMachineApplicationsClientBeginPutOptions) (*runtime.Poller[VirtualMachineApplicationsClientPutResponse], error)`
      info	[Changelog] - New function `NewVirtualMachineScaleSetApplicationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualMachineScaleSetApplicationsClient, error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetApplicationsClient.BeginDelete(context.Context, string, string, string, *VirtualMachineScaleSetApplicationsClientBeginDeleteOptions) (*runtime.Poller[VirtualMachineScaleSetApplicationsClientDeleteResponse], error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetApplicationsClient.Get(context.Context, string, string, string, *VirtualMachineScaleSetApplicationsClientGetOptions) (VirtualMachineScaleSetApplicationsClientGetResponse, error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetApplicationsClient.List(context.Context, string, string, *VirtualMachineScaleSetApplicationsClientListOptions) (VirtualMachineScaleSetApplicationsClientListResponse, error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetApplicationsClient.BeginPut(context.Context, string, string, string, VMApplicationProxyResource, *VirtualMachineScaleSetApplicationsClientBeginPutOptions) (*runtime.Poller[VirtualMachineScaleSetApplicationsClientPutResponse], error)`
      info	[Changelog] - New function `NewVirtualMachineScaleSetVirtualMachineApplicationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VirtualMachineScaleSetVirtualMachineApplicationsClient, error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetVirtualMachineApplicationsClient.GetInstanceView(context.Context, string, string, string, string, *VirtualMachineScaleSetVirtualMachineApplicationsClientGetInstanceViewOptions) (VirtualMachineScaleSetVirtualMachineApplicationsClientGetInstanceViewResponse, error)`
      info	[Changelog] - New function `*VirtualMachineScaleSetVirtualMachineApplicationsClient.NewGetPager(string, string, string, string, *VirtualMachineScaleSetVirtualMachineApplicationsClientGetOptions) *runtime.Pager[VirtualMachineScaleSetVirtualMachineApplicationsClientGetResponse]`
      info	[Changelog] - New function `dateTimeRFC3339.MarshalText() ([]byte, error)`
      info	[Changelog] - New function `*dateTimeRFC3339.Parse(string) error`
      info	[Changelog] - New function `*dateTimeRFC3339.UnmarshalText([]byte) error`
      info	[Changelog] - New struct `VMApplicationProxyResource`
      info	[Changelog] - New struct `VMApplicationWithInstanceView`
      info	[Changelog] - New struct `VMGalleryApplicationInstanceView`
      info	[Changelog] - New struct `VMGalleryApplicationInstanceViewAction`
      info	[Changelog] - New struct `VMGalleryApplicationWithInstanceView`
      info	[Changelog] - New struct `VirtualMachineApplicationsProxyResourceListResult`
      info	[Changelog] - New field `NextLink` in struct `ApplicationProfile`
      info	[Changelog] - New field `ProvisioningState` in struct `VMGalleryApplication`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 34 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.2
      cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.2>
      cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[initScript.sh] npm notice
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from 0c05eaf4d49b8c8fed5a5754337c341b75f14e35. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.compute.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.compute.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/compute/armcompute https://apiview.dev/Assemblies/Review/0b4f511d20dc468ba0dd4c581bd6316a
    Swagger Microsoft.Compute https://apiview.dev/Assemblies/Review/80677de3e3e74000b166108e23cfb967

    Hi @D1v38om83r, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.

    Requesting ARM review for new operations

    grizzlytheodore avatar Oct 17 '23 18:10 grizzlytheodore

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @rkmanda could you please review again?

    grizzlytheodore avatar Nov 01 '23 23:11 grizzlytheodore