azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
[Hub Generated] Review request for Microsoft.ContainerRegistry to add version stable/2023-07-01
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
- [x] I commit to follow the Breaking Change Policy.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
- If you want for the ARM team to review this PR, you must add the
ARMReviewlabel. - The automation may automatically add the
ARMReviewlabel, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy, follow the process outlined in the High-level Breaking Change Process doc.
Getting help
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For additional help, see https://aka.ms/azsdk/support/spectools.
Hi, @AntonioVT! Thank you for your pull request. To help get your PR merged:
Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. ![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️🔄BreakingChange inProgress [Detail]
️❌Breaking Change(Cross-Version): 13 Errors, 74 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| containerregistry.json | 2023-07-01(05a2ef1) | 2022-12-01(main) |
| containerregistry.json | 2023-07-01(05a2ef1) | 2023-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L18:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L66:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L294:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/packages/{packageType}/archives/{archiveName}/versions/{archiveVersionName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L345:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L797:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L845:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/connectedRegistries/{connectedRegistryName}/deactivate' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1079:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1412:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/exportPipelines/{exportPipelineName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1457:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1684:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/importPipelines/{importPipelineName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1729:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1968:5 |
| :warning: 1005 - RemovedPath | The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerRegistry/registries/{registryName}/pipelineRuns/{pipelineRunName}' removed or restructured? Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L2013:5 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'Archive' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ArchiveProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ArchivePackageSourceProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateParameters' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ArchiveUpdateProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ConnectedRegistry' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ConnectedRegistryProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ActivationProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'ParentProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'LoginServerProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'LoggingProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'SyncProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'TlsProperties' removed or renamed? New: Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json#L2604:3 Old: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4085:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-2023-07 | package-2023-07(05a2ef1) | default(main) |
The following errors/warnings exist before current PR submission:
Only 26 items are listed, please refer to log for more details.
️❌Avocado: 15 Errors, 1 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/listPolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/updatePolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/importPipelines is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/pipelineRuns is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/connectedRegistries/{}/deactivate is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/packages/{}/archives/{}/versions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/containerregistry/resource-manager/readme.md json: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json |
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-07 |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/containerregistry/armcontainerregistry - Approved - 1.1.0-beta.4+ Enum `ActivationStatus` has been removed + Enum `AuditLogStatus` has been removed + Enum `AzureADAuthenticationAsArmPolicyStatus` has been removed + Enum `CertificateType` has been removed + Enum `ConnectedRegistryMode` has been removed + Enum `ConnectionState` has been removed + Enum `LogLevel` has been removed + Enum `PipelineOptions` has been removed + Enum `PipelineRunSourceType` has been removed + Enum `PipelineRunTargetType` has been removed + Enum `PipelineSourceType` has been removed + Enum `TLSStatus` has been removed + Field `AnonymousPullEnabled` of struct `RegistryPropertiesUpdateParameters` has been removed + Field `AnonymousPullEnabled` of struct `RegistryProperties` has been removed + Field `AzureADAuthenticationAsArmPolicy`, `SoftDeletePolicy` of struct `Policies` has been removed + Function `*ClientFactory.NewConnectedRegistriesClient` has been removed + Function `*ClientFactory.NewExportPipelinesClient` has been removed + Function `*ClientFactory.NewImportPipelinesClient` has been removed + Function `*ClientFactory.NewPipelineRunsClient` has been removed + Function `*ConnectedRegistriesClient.BeginCreate` has been removed + Function `*ConnectedRegistriesClient.BeginDeactivate` has been removed + Function `*ConnectedRegistriesClient.BeginDelete` has been removed + Function `*ConnectedRegistriesClient.BeginUpdate` has been removed + Function `*ConnectedRegistriesClient.Get` has been removed + Function `*ConnectedRegistriesClient.NewListPager` has been removed + Function `*ExportPipelinesClient.BeginCreate` has been removed + Function `*ExportPipelinesClient.BeginDelete` has been removed + Function `*ExportPipelinesClient.Get` has been removed + Function `*ExportPipelinesClient.NewListPager` has been removed + Function `*ImportPipelinesClient.BeginCreate` has been removed + Function `*ImportPipelinesClient.BeginDelete` has been removed + Function `*ImportPipelinesClient.Get` has been removed + Function `*ImportPipelinesClient.NewListPager` has been removed + Function `*PipelineRunsClient.BeginCreate` has been removed + Function `*PipelineRunsClient.BeginDelete` has been removed + Function `*PipelineRunsClient.Get` has been removed + Function `*PipelineRunsClient.NewListPager` has been removed + Function `NewConnectedRegistriesClient` has been removed + Function `NewExportPipelinesClient` has been removed + Function `NewImportPipelinesClient` has been removed + Function `NewPipelineRunsClient` has been removed + Struct `ActivationProperties` has been removed + Struct `AzureADAuthenticationAsArmPolicy` has been removed + Struct `ConnectedRegistryListResult` has been removed + Struct `ConnectedRegistryProperties` has been removed + Struct `ConnectedRegistryUpdateParameters` has been removed + Struct `ConnectedRegistryUpdateProperties` has been removed + Struct `ConnectedRegistry` has been removed + Struct `ExportPipelineListResult` has been removed + Struct `ExportPipelineProperties` has been removed + Struct `ExportPipelineTargetProperties` has been removed + Struct `ExportPipeline` has been removed + Struct `ImportPipelineListResult` has been removed + Struct `ImportPipelineProperties` has been removed + Struct `ImportPipelineSourceProperties` has been removed + Struct `ImportPipeline` has been removed + Struct `LoggingProperties` has been removed + Struct `LoginServerProperties` has been removed + Struct `ParentProperties` has been removed + Struct `PipelineRunListResult` has been removed + Struct `PipelineRunProperties` has been removed + Struct `PipelineRunRequest` has been removed + Struct `PipelineRunResponse` has been removed + Struct `PipelineRunSourceProperties` has been removed + Struct `PipelineRunTargetProperties` has been removed + Struct `PipelineRun` has been removed + Struct `PipelineSourceTriggerDescriptor` has been removed + Struct `PipelineSourceTriggerProperties` has been removed + Struct `PipelineTriggerDescriptor` has been removed + Struct `PipelineTriggerProperties` has been removed + Struct `ProgressProperties` has been removed + Struct `SoftDeletePolicy` has been removed + Struct `StatusDetailProperties` has been removed + Struct `SyncProperties` has been removed + Struct `SyncUpdateProperties` has been removed + Struct `TLSCertificateProperties` has been removed + Struct `TLSProperties` has been removed + Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
❌azure-sdk-for-js - @azure/arm-containerregistry - Approved - 11.0.0-beta.1+ Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
❌azure-sdk-for-python-track2 - track2_azure-mgmt-containerregistry - Approved - 10.1.0+ Model Policies no longer has parameter azure_ad_authentication_as_arm_policy + Model Policies no longer has parameter soft_delete_policy + Model Registry no longer has parameter anonymous_pull_enabled + Model RegistryUpdateParameters no longer has parameter anonymous_pull_enabled
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-containerregistry [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model Policies no longer has parameter azure_ad_authentication_as_arm_policy info [Changelog] - Model Policies no longer has parameter soft_delete_policy info [Changelog] - Model Registry no longer has parameter anonymous_pull_enabled info [Changelog] - Model RegistryUpdateParameters no longer has parameter anonymous_pull_enabled
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-containerregistry-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-containerregistry [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group CacheRules info [Changelog] - Added operation group CredentialSets info [Changelog] - Added Interface AuthCredential info [Changelog] - Added Interface CacheRule info [Changelog] - Added Interface CacheRulesCreateHeaders info [Changelog] - Added Interface CacheRulesCreateOptionalParams info [Changelog] - Added Interface CacheRulesDeleteHeaders info [Changelog] - Added Interface CacheRulesDeleteOptionalParams info [Changelog] - Added Interface CacheRulesGetOptionalParams info [Changelog] - Added Interface CacheRulesListNextOptionalParams info [Changelog] - Added Interface CacheRulesListOptionalParams info [Changelog] - Added Interface CacheRulesListResult info [Changelog] - Added Interface CacheRulesUpdateHeaders info [Changelog] - Added Interface CacheRulesUpdateOptionalParams info [Changelog] - Added Interface CacheRuleUpdateParameters info [Changelog] - Added Interface CredentialHealth info [Changelog] - Added Interface CredentialSet info [Changelog] - Added Interface CredentialSetListResult info [Changelog] - Added Interface CredentialSetsCreateHeaders info [Changelog] - Added Interface CredentialSetsCreateOptionalParams info [Changelog] - Added Interface CredentialSetsDeleteHeaders info [Changelog] - Added Interface CredentialSetsDeleteOptionalParams info [Changelog] - Added Interface CredentialSetsGetOptionalParams info [Changelog] - Added Interface CredentialSetsListNextOptionalParams info [Changelog] - Added Interface CredentialSetsListOptionalParams info [Changelog] - Added Interface CredentialSetsUpdateHeaders info [Changelog] - Added Interface CredentialSetsUpdateOptionalParams info [Changelog] - Added Interface CredentialSetUpdateParameters info [Changelog] - Added Interface ErrorAdditionalInfo info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponseAutoGenerated info [Changelog] - Added Interface IdentityPropertiesAutoGenerated info [Changelog] - Added Interface UserIdentityPropertiesAutoGenerated info [Changelog] - Added Type Alias CacheRulesCreateResponse info [Changelog] - Added Type Alias CacheRulesDeleteResponse info [Changelog] - Added Type Alias CacheRulesGetResponse info [Changelog] - Added Type Alias CacheRulesListNextResponse info [Changelog] - Added Type Alias CacheRulesListResponse info [Changelog] - Added Type Alias CacheRulesUpdateResponse info [Changelog] - Added Type Alias CredentialHealthStatus info [Changelog] - Added Type Alias CredentialName info [Changelog] - Added Type Alias CredentialSetsCreateResponse info [Changelog] - Added Type Alias CredentialSetsDeleteResponse info [Changelog] - Added Type Alias CredentialSetsGetResponse info [Changelog] - Added Type Alias CredentialSetsListNextResponse info [Changelog] - Added Type Alias CredentialSetsListResponse info [Changelog] - Added Type Alias CredentialSetsUpdateResponse info [Changelog] - Added Enum KnownCredentialHealthStatus info [Changelog] - Added Enum KnownCredentialName info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail info [Changelog] - Type of parameter identity of interface Task is changed from IdentityProperties to IdentityPropertiesAutoGenerated info [Changelog] - Type of parameter identity of interface TaskRun is changed from IdentityProperties to IdentityPropertiesAutoGenerated info [Changelog] - Type of parameter identity of interface TaskRunUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated info [Changelog] - Type of parameter identity of interface TaskUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️containerregistry [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
️✔️Az.containerregistry.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.containerregistry.DefaultTag
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.ContainerRegistry [View full logs] [Release SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d5631d7fbffb672434457b5f2f16cdc6691356f9. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail` info [Changelog] - Enum `ActivationStatus` has been removed info [Changelog] - Enum `AuditLogStatus` has been removed info [Changelog] - Enum `AzureADAuthenticationAsArmPolicyStatus` has been removed info [Changelog] - Enum `CertificateType` has been removed info [Changelog] - Enum `ConnectedRegistryMode` has been removed info [Changelog] - Enum `ConnectionState` has been removed info [Changelog] - Enum `LogLevel` has been removed info [Changelog] - Enum `PipelineOptions` has been removed info [Changelog] - Enum `PipelineRunSourceType` has been removed info [Changelog] - Enum `PipelineRunTargetType` has been removed info [Changelog] - Enum `PipelineSourceType` has been removed info [Changelog] - Enum `TLSStatus` has been removed info [Changelog] - Function `*ClientFactory.NewConnectedRegistriesClient` has been removed info [Changelog] - Function `*ClientFactory.NewExportPipelinesClient` has been removed info [Changelog] - Function `*ClientFactory.NewImportPipelinesClient` has been removed info [Changelog] - Function `*ClientFactory.NewPipelineRunsClient` has been removed info [Changelog] - Function `NewConnectedRegistriesClient` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.BeginCreate` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.BeginDeactivate` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.BeginDelete` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.Get` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.NewListPager` has been removed info [Changelog] - Function `*ConnectedRegistriesClient.BeginUpdate` has been removed info [Changelog] - Function `NewExportPipelinesClient` has been removed info [Changelog] - Function `*ExportPipelinesClient.BeginCreate` has been removed info [Changelog] - Function `*ExportPipelinesClient.BeginDelete` has been removed info [Changelog] - Function `*ExportPipelinesClient.Get` has been removed info [Changelog] - Function `*ExportPipelinesClient.NewListPager` has been removed info [Changelog] - Function `NewImportPipelinesClient` has been removed info [Changelog] - Function `*ImportPipelinesClient.BeginCreate` has been removed info [Changelog] - Function `*ImportPipelinesClient.BeginDelete` has been removed info [Changelog] - Function `*ImportPipelinesClient.Get` has been removed info [Changelog] - Function `*ImportPipelinesClient.NewListPager` has been removed info [Changelog] - Function `NewPipelineRunsClient` has been removed info [Changelog] - Function `*PipelineRunsClient.BeginCreate` has been removed info [Changelog] - Function `*PipelineRunsClient.BeginDelete` has been removed info [Changelog] - Function `*PipelineRunsClient.Get` has been removed info [Changelog] - Function `*PipelineRunsClient.NewListPager` has been removed info [Changelog] - Struct `ActivationProperties` has been removed info [Changelog] - Struct `AzureADAuthenticationAsArmPolicy` has been removed info [Changelog] - Struct `ConnectedRegistry` has been removed info [Changelog] - Struct `ConnectedRegistryListResult` has been removed info [Changelog] - Struct `ConnectedRegistryProperties` has been removed info [Changelog] - Struct `ConnectedRegistryUpdateParameters` has been removed info [Changelog] - Struct `ConnectedRegistryUpdateProperties` has been removed info [Changelog] - Struct `ExportPipeline` has been removed info [Changelog] - Struct `ExportPipelineListResult` has been removed info [Changelog] - Struct `ExportPipelineProperties` has been removed info [Changelog] - Struct `ExportPipelineTargetProperties` has been removed info [Changelog] - Struct `ImportPipeline` has been removed info [Changelog] - Struct `ImportPipelineListResult` has been removed info [Changelog] - Struct `ImportPipelineProperties` has been removed info [Changelog] - Struct `ImportPipelineSourceProperties` has been removed info [Changelog] - Struct `LoggingProperties` has been removed info [Changelog] - Struct `LoginServerProperties` has been removed info [Changelog] - Struct `ParentProperties` has been removed info [Changelog] - Struct `PipelineRun` has been removed info [Changelog] - Struct `PipelineRunListResult` has been removed info [Changelog] - Struct `PipelineRunProperties` has been removed info [Changelog] - Struct `PipelineRunRequest` has been removed info [Changelog] - Struct `PipelineRunResponse` has been removed info [Changelog] - Struct `PipelineRunSourceProperties` has been removed info [Changelog] - Struct `PipelineRunTargetProperties` has been removed info [Changelog] - Struct `PipelineSourceTriggerDescriptor` has been removed info [Changelog] - Struct `PipelineSourceTriggerProperties` has been removed info [Changelog] - Struct `PipelineTriggerDescriptor` has been removed info [Changelog] - Struct `PipelineTriggerProperties` has been removed info [Changelog] - Struct `ProgressProperties` has been removed info [Changelog] - Struct `SoftDeletePolicy` has been removed info [Changelog] - Struct `StatusDetailProperties` has been removed info [Changelog] - Struct `SyncProperties` has been removed info [Changelog] - Struct `SyncUpdateProperties` has been removed info [Changelog] - Struct `TLSCertificateProperties` has been removed info [Changelog] - Struct `TLSProperties` has been removed info [Changelog] - Field `AzureADAuthenticationAsArmPolicy`, `SoftDeletePolicy` of struct `Policies` has been removed info [Changelog] - Field `AnonymousPullEnabled` of struct `RegistryProperties` has been removed info [Changelog] - Field `AnonymousPullEnabled` of struct `RegistryPropertiesUpdateParameters` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New struct `ErrorAdditionalInfo` info [Changelog] - New struct `ErrorDetail` info [Changelog] - New struct `ErrorResponseForContainerRegistry` info [Changelog] info [Changelog] Total 114 breaking change(s), 6 additive change(s).
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/containerregistry/armcontainerregistry | https://apiview.dev/Assemblies/Review/ad8fc6a8d96e4d598008cd905a6e4ed3 |
| Java | azure-resourcemanager-containerregistry-generated | https://apiview.dev/Assemblies/Review/b3ce38b076004d3bafe44df2f0b449d7 |
| JavaScript | @azure/arm-containerregistry | https://apiview.dev/Assemblies/Review/6e51de982a84461d8b2ca24335d374d1 |
| .Net | Azure.ResourceManager.ContainerRegistry | There is no API change compared with the previous version |
No commit pushedDate could be found for PR 24771 in repo Azure/azure-rest-api-specs
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @AntonioVT! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.
You cannot proceed with merging this PR until you complete one of the following action items:
ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.
ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.
ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then proceed as explained in ACTION ITEM ALTERNATIVE B.
This applies even if the breaking change tool fails with internal runtime error. In such case a manual breaking change review is necessary.
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
Hi @AntonioVT! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic Validation | Fix-SemanticValidation-Error | High |
| Model Validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | High |
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.
Hi Swagger/ARM review team. The PR includes the following changes:
- Add Cache Rules and Credential Sets resource types/operations to GA version
- Fix properties that were meant to be readonly (IdentityProperties and UserIdentityProperties properties)
Regarding the CI issues, I think they are false positives:
Avocado: Issues are related to older api versions, this should be fixed in a separate PR Semantic Validation, Model Validation, LintDiff: These are passing ️️✔️
cc @rkmanda @msyyc @tadelesh
Avocado CI false positive, CI results here, analysis below:
I noticed two issues in the Avocado CI that are being marked as errors, however I don't think this is accurate. The errors are "MISSING_APIS_IN_DEFAULT_TAG".
In Summary, the errors are related to paths that are not supported in this stable version because we either have stopped supporting those paths long time ago, or they are preview feature paths.
-
The API path "/subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/listPolicies" and ".../updatePolicies" is no longer supported.
- The last stable API version that supports it is 2017-10-01. The next GA version is 2019-05-01 and doesn't include that path anymore. The last stable version is 2022-12-01 and it also doesn't include the paths mentioned.
-
The API path "/subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipeline*", "importPipeline*", "pipelineRuns*", etc are PREVIEW path operations.
- These features are not ready to be in stable version. These errors are being flagged from the 2023-06-01-preview version. This comparison should be done with another preview version, but not with the current stable version.
Hi @raych1, there's currently a CI failure in the SDK Azure-sdk-for-go pipeline. There's a duplicate schema "ErrorResponse" with certain differences between our containerregistry.json and containerregistry_build.json.
The containerregistry.json is now using the ARM ErrorResponse definition from common-types/v5/types.json. However, since this change is not present in containerregistry_build.json, it's being considered a breaking change. I believe we can add a directive to use a specific schema and fix the CI. This was done in our previous preview release here.
The differences between our custom ErrorResponse and types.json ErrorResponse definitions can be found here: ACR ResponseError definitions (local definition, old version) CommonTypes ResponseError definitions (external definition, current version)
In summary, there are new properties which are optional, they are not decorated with the "required" swagger attribute (details and additionalInfo properties under ErrorDetail).
Avocado CI false positive, CI results here, analysis below:
I noticed two issues in the Avocado CI that are being marked as errors, however I don't think this is accurate. The errors are "MISSING_APIS_IN_DEFAULT_TAG".
In Summary, the errors are related to paths that are not supported in this stable version because we either have stopped supporting those paths long time ago, or they are preview feature paths.
The API path "/subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/listPolicies" and ".../updatePolicies" is no longer supported.
- The last stable API version that supports it is 2017-10-01. The next GA version is 2019-05-01 and doesn't include that path anymore. The last stable version is 2022-12-01 and it also doesn't include the paths mentioned.
The API path "/subscriptions/{}/resourceGroups/{}/providers/Microsoft.ContainerRegistry/registries/{}/exportPipeline*", "importPipeline*", "pipelineRuns*", etc are PREVIEW path operations.
- These features are not ready to be in stable version. These errors are being flagged from the 2023-06-01-preview version. This comparison should be done with another preview version, but not with the current stable version.
Sorry for the issue, and thank you for the explanation.
Based on your description, you ran into these limitations:
- https://github.com/Azure/azure-sdk-tools/issues/6627
- https://github.com/Azure/azure-sdk-tools/issues/6655
I just updated the doc to mention how to handle the bullet 1. from your case.
I will add now Approved-Avocado to suppress the Avocado failures.
Hi @raych1, there's currently a CI failure in the SDK Azure-sdk-for-go pipeline. There's a duplicate schema "ErrorResponse" with certain differences between our containerregistry.json and containerregistry_build.json.
The containerregistry.json is now using the ARM ErrorResponse definition from common-types/v5/types.json. However, since this change is not present in containerregistry_build.json, it's being considered a breaking change. I believe we can add a directive to use a specific schema and fix the CI. This was done in our previous preview release here.
The differences between our custom ErrorResponse and types.json ErrorResponse definitions can be found here: ACR ResponseError definitions (local definition, old version) CommonTypes ResponseError definitions (external definition, current version)
In summary, there are new properties which are optional, they are not decorated with the "required" swagger attribute (
detailsandadditionalInfoproperties underErrorDetail).
@AntonioVT , we can add directive to bypass this issue. However, can you use the same referenced ErrorResponse or use a different name in next new api version?
@Alancere , can you help add the directive for go readme?
Hi @raych1, there's currently a CI failure in the SDK Azure-sdk-for-go pipeline. There's a duplicate schema "ErrorResponse" with certain differences between our containerregistry.json and containerregistry_build.json. The containerregistry.json is now using the ARM ErrorResponse definition from common-types/v5/types.json. However, since this change is not present in containerregistry_build.json, it's being considered a breaking change. I believe we can add a directive to use a specific schema and fix the CI. This was done in our previous preview release here. The differences between our custom ErrorResponse and types.json ErrorResponse definitions can be found here: ACR ResponseError definitions (local definition, old version) CommonTypes ResponseError definitions (external definition, current version) In summary, there are new properties which are optional, they are not decorated with the "required" swagger attribute (
detailsandadditionalInfoproperties underErrorDetail).@AntonioVT , we can add directive to bypass this issue. However, can you use the same referenced
ErrorResponseor use a different name in next new api version?@Alancere , can you help add the directive for go readme?
Yes, we will reference the ARM defined ErrorResponsewhen when we release a new containerregsitry_build API.
"201": {
Should use 202 for async PATCH, and also use location header, see https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch #Resolved
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"201": {
Same for this #Resolved
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"201": {Should use 202 for async PATCH, and also use location header, see https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4f, deletion_comment = False)
@zizw123 CacheRules and CredentialSet PATCH behavior is the same as the rest of ACR proxy resources. We had a discussion with @visingla-ms when we released this feature (in 2023-01-01 preview API) and determined that it was OK to keep the current behavior in our APIs. Could we keep the current behavior?
Thread references: https://github.com/Azure/azure-rest-api-specs/pull/21727#issuecomment-1335998198 https://github.com/Azure/azure-rest-api-specs/pull/21727#issuecomment-1336056854
@ms-zhenhua I have synced offline with @zizw123 regarding our current PATCH behavior across all of our APIs. Our backend is already returning the 201. We have a work item to migrate our PATCH operations across all resources, dev ops link below. I have removed the ARMChangesRequested label. Could you help us resume the PR review please?
24778096 [RP] Migrate RP resources PATCH operations to follow ARM RPC
},
LRO-Delete does not need 200
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:200 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"201": {
resolved with https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096#
In reply to: 1666239876
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"201": {
resolved with https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096#
In reply to: 1666239285
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
},
LRO-Delete does not need 200
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:479 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"provisioningState": {
duplicated with that in "CacheRuleProperties". Consider defining a common model #Resolved
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:2804 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
"AuthCredential": {
please double check to use x-ms-secret for credential properties https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret #Resolved
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:2883 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)
Hi @ms-zhenhua, regarding
- LRO-Delete, I have deleted the 200 status response. I have confirmed our backend doesn't support it, so it was unnecessary to have it in swagger. I have created WI [RP] [Swagger] Review and Remove 200 Status code in LRO-Delete operations in registry/child resources so we review/fix instances where this is happening for next api version.
- Duplicate properties across different properties, I have created [RP] [Swagger] Review and update/define common models. There are a lot of instances where this is happening, and this should be included in our swagger generation tooling. Do you have a concern with keeping it for this PR as is?
- x-ms-secret, is not applicable to our scenario. The contents are a keyvault URI, not sensitive data. We also had this observation in our initial PR (preview) Thread here (last paragraph).
Thanks!
"201": {
LRO-Patch should use 200 and 202
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:265 in 05a2ef1. [](commit_id = 05a2ef1a79e67477beb5a3e184559379849655ad, deletion_comment = False)
"201": {
same as above
Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:541 in 05a2ef1. [](commit_id = 05a2ef1a79e67477beb5a3e184559379849655ad, deletion_comment = False)