azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

`securitycenter`: fix yaml

Open ziyeqf opened this issue 1 year ago • 7 comments

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [ ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [x] Other, please clarify:
    • fix yaml error in readme.md file

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [ ] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
  • [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
  • [ ] I commit to follow the Breaking Change Policy.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy, follow the process outlined in the High-level Breaking Change Process doc.

Getting help

  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For additional help, see https://aka.ms/azsdk/support/spectools.

ziyeqf avatar Jun 28 '23 06:06 ziyeqf

Hi, @ziyeqf Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-05 package-2023-05(9334f05) default(main)
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-js - @azure/arm-security - Approved - 6.0.0-beta.5
    +	Class SecurityCenter has a new signature
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.SecurityCenter [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/security/armsecurity [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `HealthDataClassification.Scope` has been changed from `*ScopeName` to `*string`
      info	[Changelog] - Enum `ScopeName` has been removed
      info	[Changelog] - Function `*ClientFactory.NewHealthReportClient` has been removed
      info	[Changelog] - Function `NewHealthReportClient` has been removed
      info	[Changelog] - Function `*HealthReportClient.Get` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `ServerVulnerabilityAssessmentsAzureSettingSelectedProvider` with values `ServerVulnerabilityAssessmentsAzureSettingSelectedProviderMdeTvm`
      info	[Changelog] - New enum type `ServerVulnerabilityAssessmentsSettingKind` with values `ServerVulnerabilityAssessmentsSettingKindAzureServersSetting`
      info	[Changelog] - New enum type `ServerVulnerabilityAssessmentsSettingKindName` with values `ServerVulnerabilityAssessmentsSettingKindNameAzureServersSetting`
      info	[Changelog] - New enum type `SettingNameAutoGenerated` with values `SettingNameAutoGeneratedCurrent`
      info	[Changelog] - New function `*AzureServersSetting.GetServerVulnerabilityAssessmentsSetting() *ServerVulnerabilityAssessmentsSetting`
      info	[Changelog] - New function `*ClientFactory.NewDefenderForStorageClient() *DefenderForStorageClient`
      info	[Changelog] - New function `*ClientFactory.NewServerVulnerabilityAssessmentsSettingsClient() *ServerVulnerabilityAssessmentsSettingsClient`
      info	[Changelog] - New function `NewDefenderForStorageClient(azcore.TokenCredential, *arm.ClientOptions) (*DefenderForStorageClient, error)`
      info	[Changelog] - New function `*DefenderForStorageClient.Create(context.Context, string, SettingNameAutoGenerated, DefenderForStorageSetting, *DefenderForStorageClientCreateOptions) (DefenderForStorageClientCreateResponse, error)`
      info	[Changelog] - New function `*DefenderForStorageClient.Get(context.Context, string, SettingNameAutoGenerated, *DefenderForStorageClientGetOptions) (DefenderForStorageClientGetResponse, error)`
      info	[Changelog] - New function `*HealthReportsClient.Get(context.Context, string, string, *HealthReportsClientGetOptions) (HealthReportsClientGetResponse, error)`
      info	[Changelog] - New function `PossibleServerVulnerabilityAssessmentsSettingKindValues() []ServerVulnerabilityAssessmentsSettingKind`
      info	[Changelog] - New function `*ServerVulnerabilityAssessmentsSetting.GetServerVulnerabilityAssessmentsSetting() *ServerVulnerabilityAssessmentsSetting`
      info	[Changelog] - New function `NewServerVulnerabilityAssessmentsSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServerVulnerabilityAssessmentsSettingsClient, error)`
      info	[Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.CreateOrUpdate(context.Context, ServerVulnerabilityAssessmentsSettingKindName, ServerVulnerabilityAssessmentsSettingClassification, *ServerVulnerabilityAssessmentsSettingsClientCreateOrUpdateOptions) (ServerVulnerabilityAssessmentsSettingsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.Delete(context.Context, ServerVulnerabilityAssessmentsSettingKindName, *ServerVulnerabilityAssessmentsSettingsClientDeleteOptions) (ServerVulnerabilityAssessmentsSettingsClientDeleteResponse, error)`
      info	[Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.Get(context.Context, ServerVulnerabilityAssessmentsSettingKindName, *ServerVulnerabilityAssessmentsSettingsClientGetOptions) (ServerVulnerabilityAssessmentsSettingsClientGetResponse, error)`
      info	[Changelog] - New function `*ServerVulnerabilityAssessmentsSettingsClient.NewListBySubscriptionPager(*ServerVulnerabilityAssessmentsSettingsClientListBySubscriptionOptions) *runtime.Pager[ServerVulnerabilityAssessmentsSettingsClientListBySubscriptionResponse]`
      info	[Changelog] - New struct `AzureServersSetting`
      info	[Changelog] - New struct `DefenderForStorageSetting`
      info	[Changelog] - New struct `DefenderForStorageSettingProperties`
      info	[Changelog] - New struct `MalwareScanningProperties`
      info	[Changelog] - New struct `OnUploadProperties`
      info	[Changelog] - New struct `OperationStatusAutoGenerated`
      info	[Changelog] - New struct `ResourceAutoGenerated`
      info	[Changelog] - New struct `SensitiveDataDiscoveryProperties`
      info	[Changelog] - New struct `ServerVulnerabilityAssessmentsAzureSettingProperties`
      info	[Changelog] - New struct `ServerVulnerabilityAssessmentsSettingsList`
      info	[Changelog] - New field `AffectedDefendersSubPlans`, `ReportAdditionalData` in struct `HealthReportProperties`
      info	[Changelog] - New field `LastScannedDate`, `Reason` in struct `StatusAutoGenerated`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 45 additive change(s).
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Code Generator Failed [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-security [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias DefenderForStorageGetResponse
      info	[Changelog]   - Added Type Alias EnvironmentDataUnion
      info	[Changelog]   - Added Type Alias EnvironmentType
      info	[Changelog]   - Added Type Alias GcpOrganizationalDataUnion
      info	[Changelog]   - Added Type Alias GetSensitivitySettingsOperationResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsGetResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceAssignmentsListResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleConditionOperator
      info	[Changelog]   - Added Type Alias GovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Type Alias GovernanceRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesExecuteResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesGetResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesListNextResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesListResponse
      info	[Changelog]   - Added Type Alias GovernanceRulesOperationResultsResponse
      info	[Changelog]   - Added Type Alias GovernanceRuleSourceResourceType
      info	[Changelog]   - Added Type Alias GovernanceRuleType
      info	[Changelog]   - Added Type Alias HealthReportsGetResponse
      info	[Changelog]   - Added Type Alias HealthReportsListNextResponse
      info	[Changelog]   - Added Type Alias HealthReportsListResponse
      info	[Changelog]   - Added Type Alias IsEnabled
      info	[Changelog]   - Added Type Alias MinimalSeverity
      info	[Changelog]   - Added Type Alias MipIntegrationStatus
      info	[Changelog]   - Added Type Alias OperationResult
      info	[Changelog]   - Added Type Alias Roles
      info	[Changelog]   - Added Type Alias ScanningMode
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationGetResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListNextResponse
      info	[Changelog]   - Added Type Alias SecurityConnectorApplicationsListResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsGetResponse
      info	[Changelog]   - Added Type Alias SecurityOperatorsListResponse
      info	[Changelog]   - Added Type Alias SensitivitySettingsListResponse
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsAzureSettingSelectedProvider
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingKind
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingKindName
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingsGetResponse
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingsListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingsListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias ServerVulnerabilityAssessmentsSettingUnion
      info	[Changelog]   - Added Type Alias SettingNameAutoGenerated
      info	[Changelog]   - Added Type Alias StatusName
      info	[Changelog]   - Added Type Alias SubPlan
      info	[Changelog]   - Added Type Alias Type
      info	[Changelog]   - Added Type Alias UpdateSensitivitySettingsResponse
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface AlertsSimulateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter cloudRoleArn
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning has a new optional parameter configuration
      info	[Changelog]   - Interface ScanProperties has a new optional parameter lastScanTime
      info	[Changelog]   - Type of parameter offeringType of interface CloudOffering is changed from "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "InformationProtectionAws" to "CspmMonitorAws" | "DefenderForContainersAws" | "DefenderForServersAws" | "DefenderForDatabasesAws" | "InformationProtectionAws" | "CspmMonitorGcp" | "DefenderForServersGcp" | "DefenderForDatabasesGcp" | "DefenderForContainersGcp" | "CspmMonitorGithub" | "CspmMonitorAzureDevOps" | "DefenderCspmAws" | "DefenderCspmGcp" | "DefenderForDevOpsGithub" | "DefenderForDevOpsAzureDevOps" | "CspmMonitorGitLab" | "DefenderForDevOpsGitLab"
      info	[Changelog]   - Added Enum KnownApplicationConditionOperator
      info	[Changelog]   - Added Enum KnownApplicationSourceResourceType
      info	[Changelog]   - Added Enum KnownCode
      info	[Changelog]   - Added Enum KnownEnvironmentType
      info	[Changelog]   - Added Enum KnownGovernanceRuleConditionOperator
      info	[Changelog]   - Added Enum KnownGovernanceRuleOwnerSourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleSourceResourceType
      info	[Changelog]   - Added Enum KnownGovernanceRuleType
      info	[Changelog]   - Added Enum KnownIsEnabled
      info	[Changelog]   - Added Enum KnownMinimalSeverity
      info	[Changelog]   - Added Enum KnownMipIntegrationStatus
      info	[Changelog]   - Added Enum KnownOperationResult
      info	[Changelog]   - Added Enum KnownRoles
      info	[Changelog]   - Added Enum KnownScanningMode
      info	[Changelog]   - Added Enum KnownServerVulnerabilityAssessmentsAzureSettingSelectedProvider
      info	[Changelog]   - Added Enum KnownServerVulnerabilityAssessmentsSettingKind
      info	[Changelog]   - Added Enum KnownServerVulnerabilityAssessmentsSettingKindName
      info	[Changelog]   - Added Enum KnownSettingNameAutoGenerated
      info	[Changelog]   - Added Enum KnownStatusName
      info	[Changelog]   - Added Enum KnownSubPlan
      info	[Changelog]   - Added Enum KnownType
      info	[Changelog]   - Enum KnownAlertStatus has a new value InProgress
      info	[Changelog]   - Enum KnownBundleType has a new value CosmosDbs
      info	[Changelog]   - Enum KnownCloudName has a new value AzureDevOps
      info	[Changelog]   - Enum KnownCloudName has a new value Github
      info	[Changelog]   - Enum KnownCloudName has a new value GitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorAzureDevOps
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGithub
      info	[Changelog]   - Enum KnownOfferingType has a new value CspmMonitorGitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderCspmAws
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderCspmGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForContainersGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesAws
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDatabasesGcp
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsAzureDevOps
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsGithub
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForDevOpsGitLab
      info	[Changelog]   - Enum KnownOfferingType has a new value DefenderForServersGcp
      info	[Changelog]   - Enum KnownSettingName has a new value WdatpUnifiedSolution
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Alerts.simulate
      info	[Changelog]   - Removed operation SecurityContacts.update
      info	[Changelog]   - Operation AllowedConnections.get has a new signature
      info	[Changelog]   - Class SecurityCenter has a new signature
      info	[Changelog]   - Interface AlertsSuppressionRulesListNextOptionalParams no longer has parameter alertType
      info	[Changelog]   - Interface DefenderForServersAwsOfferingArcAutoProvisioning no longer has parameter servicePrincipalSecretMetadata
      info	[Changelog]   - Interface IotSecuritySolutionListByResourceGroupNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IotSecuritySolutionListBySubscriptionNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IotSecuritySolutionsAnalyticsAggregatedAlertListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface IotSecuritySolutionsAnalyticsRecommendationListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface RegulatoryComplianceAssessmentsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface RegulatoryComplianceControlsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface RegulatoryComplianceStandardsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SecureScoreControlsListBySecureScoreNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface SecureScoreControlsListNextOptionalParams no longer has parameter expand
      info	[Changelog]   - Interface TasksListByHomeRegionNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TasksListByResourceGroupNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TasksListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Type of parameter value of interface ExternalSecuritySolutionList is changed from ExternalSecuritySolutionUnion[] to ExternalSecuritySolution[]
      info	[Changelog]   - Removed Enum KnownAlertNotifications
      info	[Changelog]   - Removed Enum KnownAlertsToAdmins
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-security [View full logs]  [Release SDK Changes]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • security/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from c65b388b4a5c99fa36c4614a52f3d6fa1610df16. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.security.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.security.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/security/armsecurity https://apiview.dev/Assemblies/Review/7c5756c8b4f3484f9de16a758f1dd55e
    Java azure-resourcemanager-security https://apiview.dev/Assemblies/Review/4caf2991fe4b49728bb5f2c0247143e8
    .Net Azure.ResourceManager.SecurityCenter There is no API change compared with the previous version
    JavaScript @azure/arm-security https://apiview.dev/Assemblies/Review/4a5b2f7a8ea54443b4b5afb35424c30a

    Hi @ziyeqf! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    ARM review not required. Removing label

    raosuhas avatar Jul 11 '23 19:07 raosuhas

    If this type of change cannot be merged - nothing can be merged.

    eliagrady avatar Jul 12 '23 09:07 eliagrady

    @ziyeqf have you investigated the CI failures? Even though this change might be simple there does still appear to be issues that need to be fixed with this readme.

    weshaggard avatar Jul 18 '23 22:07 weshaggard

    @weshaggard what I'm saying is that the CI will fail even on "empty" PRs - this is what we're trying to fix here - there's a problem right now with the committed code on the main branch, this PR will get us closer to having confidence in the CI pipeline.

    also - possible duplicate of this PR: https://github.com/Azure/azure-rest-api-specs/pull/24457/files where it did get signoff for JS and GO sdks

    eliagrady avatar Jul 19 '23 12:07 eliagrady

    @eliagrady I would suggest trying to use this PR to get main to a green state. I understand this might be one step along the way but why not continue to get the others fixed so things are in a good state?

    weshaggard avatar Jul 19 '23 16:07 weshaggard

    @eliagrady I would suggest trying to use this PR to get main to a green state. I understand this might be one step along the way but why not continue to get the others fixed so things are in a good state?

    If I thought there is a single commit that would make us green, I would have subscribed to this idea without skipping a beat. Unfortunately I don’t think it can be resolved within a single PR, and I am trying to make subtle non additive changes such that we will get to green again. If you disagree I’d be happy to hear your thoughts on this, goal being getting to green.

    eliagrady avatar Jul 19 '23 17:07 eliagrady

    Definitely agree with the goal of getting green. However, what I'm not sure on is why we cannot keep iterating on this PR to get there? I don't think each of these incremental steps needs to be merged to main before we get them all fixed.

    weshaggard avatar Jul 19 '23 18:07 weshaggard

    duplicate of https://github.com/Azure/azure-rest-api-specs/pull/24457

    eliagrady avatar Jul 31 '23 08:07 eliagrady

    this js sdk breaking is not caused by this pr

    kazrael2119 avatar Aug 07 '23 08:08 kazrael2119