azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

[Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-06-01-preview

Open jikuma opened this issue 2 years ago • 24 comments

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

jikuma avatar Jun 13 '23 20:06 jikuma

Hi, @jikuma Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 4 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    containerregistry.json 2023-06-01-preview(447ede9) 2022-12-01(main)
    containerregistry.json 2023-06-01-preview(447ede9) 2023-01-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4810:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2580:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4815:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2584:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4889:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2729:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4894:9
    Old: Microsoft.ContainerRegistry/stable/2022-12-01/containerregistry.json#L2733:9


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4810:9
    Old: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L4149:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4815:9
    Old: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L4153:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4889:9
    Old: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L4226:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L4894:9
    Old: Microsoft.ContainerRegistry/preview/2023-01-01-preview/containerregistry.json#L4230:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-06-preview package-2023-06-preview(447ede9) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L639
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L639
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L729
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L761
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L921
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L921
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1011
    ConsistentPatchProperties The property 'properties.syncProperties' in the request body either not apppear in the resource model or has the wrong level.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1038
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1043
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1080
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1254
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1254
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1344
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1376
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1501
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1533
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1533
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1625
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1654
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1654
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1773
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1805
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1805
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1908
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1908
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1912
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1950
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L1950
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L2089
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.ContainerRegistry/preview/2023-06-01-preview/containerregistry.json#L2089
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/containerregistry/resource-manager/readme.md
    tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-06-preview
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 109 Errors, 0 Warnings failed [Detail]

    Tag package-2023-06-preview; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 104, untested: 0, failed: 59, passed: 45

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 404,
    errorCode: undefined,
    errorMessage: undefined
    Source: runtime
    OperationId: Registries_GetPrivateLinkResource
    INVALID_CONTENT_TYPE Invalid Content-Type (application/octet-stream). These are supported: application/json
    Source: response
    OperationId: Registries_GetPrivateLinkResource
    INVALID_RESPONSE_BODY Body is required in response but not provided
    Source: response
    OperationId: Registries_GetPrivateLinkResource
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidExpiry,
    errorMessage: Expiry Date '12/31/2020 3:59:59 PM +00:00' is invalid. The expiration date should be in the future. For more information on repository permissions, please visit https://aka.ms/acr/repo-permissions.
    Source: runtime
    OperationId: Registries_GenerateCredentials
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: Registries_GenerateCredentials
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ContainerRegistry/registries/read' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-KjbaXL-24426/providers/Microsoft.ContainerRegistry/registries/registry4ms0du', however the linked subscription '10000000-0000-0000-0000-000000000000' was not found.
    Source: runtime
    OperationId: Registries_ImportImage
    INVALID_RESPONSE_CODE The swagger file does not define '403' response code
    Source: response
    OperationId: Registries_ImportImage
    SERVER_ERROR statusCode: 503,
    errorCode: ServiceUnavailable,
    errorMessage: Unable to perform put/subscriptions/resourceGroups/registries/packages/. Please try after some time.
    Source: runtime
    OperationId: Archives_Create
    PATTERN String does not match pattern ^[a-zA-Z]*$: packagetm2xn6f
    Source: request
    OperationId: Archives_Create
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: Archives_Create
    SERVER_ERROR statusCode: 503,
    errorCode: ServiceUnavailable,
    errorMessage: Unable to perform get/subscriptions/resourceGroups/registries/packages/. Please try after some time.
    Source: runtime
    OperationId: Archives_List
    PATTERN String does not match pattern ^[a-zA-Z]*$: packagetm2xn6f
    Source: request
    OperationId: Archives_List
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: Archives_List
    SERVER_ERROR statusCode: 503,
    errorCode: ServiceUnavailable,
    errorMessage: Unable to perform get/subscriptions/resourceGroups/registries/packages/. Please try after some time.
    Source: runtime
    OperationId: Archives_Get
    PATTERN String does not match pattern ^[a-zA-Z]*$: packagetm2xn6f
    Source: request
    OperationId: Archives_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: Archives_Get
    SERVER_ERROR statusCode: 503,
    errorCode: ServiceUnavailable,
    errorMessage: Unable to perform patch/subscriptions/resourceGroups/registries/packages/. Please try after some time.
    Source: runtime
    OperationId: Archives_Update
    PATTERN String does not match pattern ^[a-zA-Z]*$: packagetm2xn6f
    Source: request
    OperationId: Archives_Update
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: status
    Source: response
    OperationId: Archives_Update
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidScopeString,
    errorMessage: Scope value myRepository is invalid.
    The acceptable patterns are 'repository', 'repository:tag', 'repository:', 'repository/', 'repository/*:tag' or an empty string.
    The respository and tag names follow the standardized docker repository and tag naming conventions.
    For more information, please visit https://docs.microsoft.com/en-us/rest/api/containerregistry/webhooks/create#webhook
    Source: runtime
    OperationId: Webhooks_Create
    INVALID_RESPONSE_CODE The swagger file does not define '400' response code
    Source: response
    OperationId: Webhooks_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerRegistry/registries/registry4ms0du/webhooks/webhookngaw3h5' under resource group 'apiTest-KjbaXL-24426' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Webhooks_Get
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: Webhooks_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerRegistry/registries/registry4ms0du/webhooks/webhookngaw3h5' under resource group 'apiTest-KjbaXL-24426' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Webhooks_Update
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: Webhooks_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Failed to perform 'action' on resource(s) of type 'registries/webhooks/ping', because the parent resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-KjbaXL-24426/providers/Microsoft.ContainerRegistry/registries/registry4ms0du/webhooks/webhookngaw3h5' could not be found.
    Source: runtime
    OperationId: Webhooks_Ping
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: Webhooks_Ping
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Failed to perform 'action' on resource(s) of type 'registries/webhooks/getCallbackConfig', because the parent resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-KjbaXL-24426/providers/Microsoft.ContainerRegistry/registries/registry4ms0du/webhooks/webhookngaw3h5' could not be found.
    Source: runtime
    OperationId: Webhooks_GetCallbackConfig
    INVALID_RESPONSE_CODE The swagger file does not define '404' response code
    Source: response
    OperationId: Webhooks_GetCallbackConfig
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Failed to perform 'action' on resource(s) of type 'registries/webhooks/listEvents', because the parent resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-KjbaXL-24426/providers/Microsoft.ContainerRegistry/registries/registry4ms0du/webhooks/webhookngaw3h5' could not be found.
    Source: runtime
    OperationId: Webhooks_ListEvents
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️All merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking



    azure-sdk-for-js - @azure/arm-containerregistry - Approved - 11.0.0-beta.1
    +	Type of parameter identity of interface Task is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    +	Type of parameter identity of interface TaskRun is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    +	Type of parameter identity of interface TaskRunUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    +	Type of parameter identity of interface TaskUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.ContainerRegistry [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerregistry [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerregistry/armcontainerregistry [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `PackageSourceType` with values `PackageSourceTypeRemote`
      info	[Changelog] - New function `NewArchiveVersionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchiveVersionsClient, error)`
      info	[Changelog] - New function `*ArchiveVersionsClient.BeginCreate(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginCreateOptions) (*runtime.Poller[ArchiveVersionsClientCreateResponse], error)`
      info	[Changelog] - New function `*ArchiveVersionsClient.BeginDelete(context.Context, string, string, string, string, string, *ArchiveVersionsClientBeginDeleteOptions) (*runtime.Poller[ArchiveVersionsClientDeleteResponse], error)`
      info	[Changelog] - New function `*ArchiveVersionsClient.Get(context.Context, string, string, string, string, string, *ArchiveVersionsClientGetOptions) (ArchiveVersionsClientGetResponse, error)`
      info	[Changelog] - New function `*ArchiveVersionsClient.NewListPager(string, string, string, string, *ArchiveVersionsClientListOptions) *runtime.Pager[ArchiveVersionsClientListResponse]`
      info	[Changelog] - New function `NewArchivesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ArchivesClient, error)`
      info	[Changelog] - New function `*ArchivesClient.BeginCreate(context.Context, string, string, string, string, Archive, *ArchivesClientBeginCreateOptions) (*runtime.Poller[ArchivesClientCreateResponse], error)`
      info	[Changelog] - New function `*ArchivesClient.BeginDelete(context.Context, string, string, string, string, *ArchivesClientBeginDeleteOptions) (*runtime.Poller[ArchivesClientDeleteResponse], error)`
      info	[Changelog] - New function `*ArchivesClient.Get(context.Context, string, string, string, string, *ArchivesClientGetOptions) (ArchivesClientGetResponse, error)`
      info	[Changelog] - New function `*ArchivesClient.NewListPager(string, string, string, *ArchivesClientListOptions) *runtime.Pager[ArchivesClientListResponse]`
      info	[Changelog] - New function `*ArchivesClient.Update(context.Context, string, string, string, string, ArchiveUpdateParameters, *ArchivesClientUpdateOptions) (ArchivesClientUpdateResponse, error)`
      info	[Changelog] - New function `*ClientFactory.NewArchiveVersionsClient() *ArchiveVersionsClient`
      info	[Changelog] - New function `*ClientFactory.NewArchivesClient() *ArchivesClient`
      info	[Changelog] - New struct `Archive`
      info	[Changelog] - New struct `ArchiveListResult`
      info	[Changelog] - New struct `ArchivePackageSourceProperties`
      info	[Changelog] - New struct `ArchiveProperties`
      info	[Changelog] - New struct `ArchiveUpdateParameters`
      info	[Changelog] - New struct `ArchiveUpdateProperties`
      info	[Changelog] - New struct `ArchiveVersion`
      info	[Changelog] - New struct `ArchiveVersionListResult`
      info	[Changelog] - New struct `ArchiveVersionProperties`
      info	[Changelog] - New struct `DebianArchivePackageSourceProperties`
      info	[Changelog] - New struct `DebianArchiveProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 37 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface ExportPipelinesListOptionalParams
      info	[Changelog]   - Added Interface ExportPipelineTargetProperties
      info	[Changelog]   - Added Interface IdentityPropertiesAutoGenerated
      info	[Changelog]   - Added Interface ImportPipeline
      info	[Changelog]   - Added Interface ImportPipelineListResult
      info	[Changelog]   - Added Interface ImportPipelinesCreateHeaders
      info	[Changelog]   - Added Interface ImportPipelinesCreateOptionalParams
      info	[Changelog]   - Added Interface ImportPipelinesDeleteHeaders
      info	[Changelog]   - Added Interface ImportPipelinesDeleteOptionalParams
      info	[Changelog]   - Added Interface ImportPipelinesGetOptionalParams
      info	[Changelog]   - Added Interface ImportPipelinesListNextOptionalParams
      info	[Changelog]   - Added Interface ImportPipelinesListOptionalParams
      info	[Changelog]   - Added Interface ImportPipelineSourceProperties
      info	[Changelog]   - Added Interface LoggingProperties
      info	[Changelog]   - Added Interface LoginServerProperties
      info	[Changelog]   - Added Interface ParentProperties
      info	[Changelog]   - Added Interface PipelineRun
      info	[Changelog]   - Added Interface PipelineRunListResult
      info	[Changelog]   - Added Interface PipelineRunRequest
      info	[Changelog]   - Added Interface PipelineRunResponse
      info	[Changelog]   - Added Interface PipelineRunsCreateHeaders
      info	[Changelog]   - Added Interface PipelineRunsCreateOptionalParams
      info	[Changelog]   - Added Interface PipelineRunsDeleteHeaders
      info	[Changelog]   - Added Interface PipelineRunsDeleteOptionalParams
      info	[Changelog]   - Added Interface PipelineRunsGetOptionalParams
      info	[Changelog]   - Added Interface PipelineRunsListNextOptionalParams
      info	[Changelog]   - Added Interface PipelineRunsListOptionalParams
      info	[Changelog]   - Added Interface PipelineRunSourceProperties
      info	[Changelog]   - Added Interface PipelineRunTargetProperties
      info	[Changelog]   - Added Interface PipelineSourceTriggerDescriptor
      info	[Changelog]   - Added Interface PipelineSourceTriggerProperties
      info	[Changelog]   - Added Interface PipelineTriggerDescriptor
      info	[Changelog]   - Added Interface PipelineTriggerProperties
      info	[Changelog]   - Added Interface ProgressProperties
      info	[Changelog]   - Added Interface SoftDeletePolicy
      info	[Changelog]   - Added Interface StatusDetailProperties
      info	[Changelog]   - Added Interface SyncProperties
      info	[Changelog]   - Added Interface SyncUpdateProperties
      info	[Changelog]   - Added Interface TlsCertificateProperties
      info	[Changelog]   - Added Interface TlsProperties
      info	[Changelog]   - Added Interface UserIdentityPropertiesAutoGenerated
      info	[Changelog]   - Added Type Alias ActivationStatus
      info	[Changelog]   - Added Type Alias ArchivesCreateResponse
      info	[Changelog]   - Added Type Alias ArchivesDeleteResponse
      info	[Changelog]   - Added Type Alias ArchivesGetResponse
      info	[Changelog]   - Added Type Alias ArchivesListNextResponse
      info	[Changelog]   - Added Type Alias ArchivesListResponse
      info	[Changelog]   - Added Type Alias ArchivesUpdateResponse
      info	[Changelog]   - Added Type Alias ArchiveVersionsCreateResponse
      info	[Changelog]   - Added Type Alias ArchiveVersionsDeleteResponse
      info	[Changelog]   - Added Type Alias ArchiveVersionsGetResponse
      info	[Changelog]   - Added Type Alias ArchiveVersionsListNextResponse
      info	[Changelog]   - Added Type Alias ArchiveVersionsListResponse
      info	[Changelog]   - Added Type Alias AuditLogStatus
      info	[Changelog]   - Added Type Alias AzureADAuthenticationAsArmPolicyStatus
      info	[Changelog]   - Added Type Alias CacheRulesCreateResponse
      info	[Changelog]   - Added Type Alias CacheRulesGetResponse
      info	[Changelog]   - Added Type Alias CacheRulesListNextResponse
      info	[Changelog]   - Added Type Alias CacheRulesListResponse
      info	[Changelog]   - Added Type Alias CacheRulesUpdateResponse
      info	[Changelog]   - Added Type Alias CertificateType
      info	[Changelog]   - Added Type Alias ConnectedRegistriesCreateResponse
      info	[Changelog]   - Added Type Alias ConnectedRegistriesGetResponse
      info	[Changelog]   - Added Type Alias ConnectedRegistriesListNextResponse
      info	[Changelog]   - Added Type Alias ConnectedRegistriesListResponse
      info	[Changelog]   - Added Type Alias ConnectedRegistriesUpdateResponse
      info	[Changelog]   - Added Type Alias ConnectedRegistryMode
      info	[Changelog]   - Added Type Alias ConnectionState
      info	[Changelog]   - Added Type Alias CredentialHealthStatus
      info	[Changelog]   - Added Type Alias CredentialName
      info	[Changelog]   - Added Type Alias CredentialSetsCreateResponse
      info	[Changelog]   - Added Type Alias CredentialSetsGetResponse
      info	[Changelog]   - Added Type Alias CredentialSetsListNextResponse
      info	[Changelog]   - Added Type Alias CredentialSetsListResponse
      info	[Changelog]   - Added Type Alias CredentialSetsUpdateResponse
      info	[Changelog]   - Added Type Alias ExportPipelinesCreateResponse
      info	[Changelog]   - Added Type Alias ExportPipelinesGetResponse
      info	[Changelog]   - Added Type Alias ExportPipelinesListNextResponse
      info	[Changelog]   - Added Type Alias ExportPipelinesListResponse
      info	[Changelog]   - Added Type Alias ImportPipelinesCreateResponse
      info	[Changelog]   - Added Type Alias ImportPipelinesGetResponse
      info	[Changelog]   - Added Type Alias ImportPipelinesListNextResponse
      info	[Changelog]   - Added Type Alias ImportPipelinesListResponse
      info	[Changelog]   - Added Type Alias LogLevel
      info	[Changelog]   - Added Type Alias PackageSourceType
      info	[Changelog]   - Added Type Alias PipelineOptions
      info	[Changelog]   - Added Type Alias PipelineRunsCreateResponse
      info	[Changelog]   - Added Type Alias PipelineRunsGetResponse
      info	[Changelog]   - Added Type Alias PipelineRunsListNextResponse
      info	[Changelog]   - Added Type Alias PipelineRunsListResponse
      info	[Changelog]   - Added Type Alias PipelineRunSourceType
      info	[Changelog]   - Added Type Alias PipelineRunTargetType
      info	[Changelog]   - Added Type Alias PipelineSourceType
      info	[Changelog]   - Added Type Alias TlsStatus
      info	[Changelog]   - Interface Policies has a new optional parameter azureADAuthenticationAsArmPolicy
      info	[Changelog]   - Interface Policies has a new optional parameter softDeletePolicy
      info	[Changelog]   - Interface Registry has a new optional parameter anonymousPullEnabled
      info	[Changelog]   - Interface RegistryUpdateParameters has a new optional parameter anonymousPullEnabled
      info	[Changelog]   - Added Enum KnownActivationStatus
      info	[Changelog]   - Added Enum KnownAuditLogStatus
      info	[Changelog]   - Added Enum KnownAzureADAuthenticationAsArmPolicyStatus
      info	[Changelog]   - Added Enum KnownCertificateType
      info	[Changelog]   - Added Enum KnownConnectedRegistryMode
      info	[Changelog]   - Added Enum KnownConnectionState
      info	[Changelog]   - Added Enum KnownCredentialHealthStatus
      info	[Changelog]   - Added Enum KnownCredentialName
      info	[Changelog]   - Added Enum KnownLogLevel
      info	[Changelog]   - Added Enum KnownPackageSourceType
      info	[Changelog]   - Added Enum KnownPipelineOptions
      info	[Changelog]   - Added Enum KnownPipelineRunSourceType
      info	[Changelog]   - Added Enum KnownPipelineRunTargetType
      info	[Changelog]   - Added Enum KnownPipelineSourceType
      info	[Changelog]   - Added Enum KnownTlsStatus
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Type of parameter identity of interface Task is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskRun is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskRunUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
      info	[Changelog]   - Type of parameter identity of interface TaskUpdateParameters is changed from IdentityProperties to IdentityPropertiesAutoGenerated
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerregistry [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 9025f6894e0df9ebbfcd19a04c967c1c6737bfe6. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.containerregistry.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.containerregistry.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerregistry/armcontainerregistry https://apiview.dev/Assemblies/Review/ce33c55b0fd74acf955be8b8c771fb4e
    .Net Azure.ResourceManager.ContainerRegistry There is no API change compared with the previous version
    Java azure-resourcemanager-containerregistry-generated https://apiview.dev/Assemblies/Review/80ad62fd5d7d47d4a6d9237e7ebf58de
    JavaScript @azure/arm-containerregistry https://apiview.dev/Assemblies/Review/89761aaaed744ad88128f26765807640

    Hi @jikuma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Hi @jikuma, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    /azp run unifiedPipeline

    jikuma avatar Jun 13 '23 21:06 jikuma

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Jun 13 '23 21:06 azure-pipelines[bot]

    /azp run unifiedPipeline

    jikuma avatar Jun 13 '23 21:06 jikuma

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Jun 13 '23 21:06 azure-pipelines[bot]

    Hi @jikuma, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    WI to fix the suppression Task 24264387: Use ARM common error response instead of ACR Error Response.

    jikuma avatar Jun 13 '23 22:06 jikuma

    /azp run unifiedPipeline

    jikuma avatar Jun 13 '23 22:06 jikuma

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Jun 13 '23 22:06 azure-pipelines[bot]

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    Hi @jikuma, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    /azp run unifiedPipeline

    jikuma avatar Jun 13 '23 23:06 jikuma

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Jun 13 '23 23:06 azure-pipelines[bot]

    /azp run unifiedPipeline

    jikuma avatar Jun 14 '23 00:06 jikuma

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Jun 14 '23 00:06 azure-pipelines[bot]

    @raych1 please review the GO breaking change @qiaozha please review the JS breaking change

    ankhyk avatar Jun 14 '23 06:06 ankhyk

    Approving the suppression and the PR based on our discussion and https://github.com/Azure/azure-rest-api-specs/pull/22777

    zizw123 avatar Jun 16 '23 17:06 zizw123

    @jikuma The PR is good to go, if can you remove the suppression and we can approve the PR without the suppression, so that this can be tracked via S360

    zizw123 avatar Jun 16 '23 19:06 zizw123

    Thanks you @zizw123, I have started the deployment with the new api version, once the ARM manifest is applied, we can merge the swagger.

    jikuma avatar Jun 21 '23 17:06 jikuma

    @rkmanda RP deployment with this change is complete. Can we merge this PR now. Please le me know if you need more info.

    jikuma avatar Jul 11 '23 17:07 jikuma

    @tadelesh We are planning to use this directive to fix the AutoGenerated issue avoid breaking https://github.com/Azure/azure-rest-api-specs/pull/24905/files#diff-ffa8a1b9f0b1e7035317d1a86e8aef6a504ca280349c5ff8c85ce5971d2f7f43R21-R45

    qiaozha avatar Jul 20 '23 05:07 qiaozha

    /azp run

    tadelesh avatar Jul 21 '23 02:07 tadelesh

    No commit pushedDate could be found for PR 24426 in repo Azure/azure-rest-api-specs

    azure-pipelines[bot] avatar Jul 21 '23 02:07 azure-pipelines[bot]

    /azp run

    tadelesh avatar Jul 21 '23 03:07 tadelesh

    No commit pushedDate could be found for PR 24426 in repo Azure/azure-rest-api-specs

    azure-pipelines[bot] avatar Jul 21 '23 03:07 azure-pipelines[bot]

    /azp run

    Alancere avatar Jul 21 '23 08:07 Alancere