azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
[Cdn] Add new preview API: 2023-07-01-preview
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [X] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. July 2023
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. July 2023
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[X] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[X] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
-
[X] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @jessicl-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, @jessicl-ms your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 7 Warnings warning [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| afdx.json | 2023-07-01-preview(2a01bf8) | 2023-05-01(main) |
| afdx.json | 2023-07-01-preview(2a01bf8) | 2022-11-01-preview(main) |
| cdn.json | 2023-07-01-preview(2a01bf8) | 2023-05-01(main) |
| cdn.json | 2023-07-01-preview(2a01bf8) | 2022-11-01-preview(main) |
| cdnwebapplicationfirewall.json | 2023-07-01-preview(2a01bf8) | 2023-05-01(main) |
| cdnwebapplicationfirewall.json | 2023-07-01-preview(2a01bf8) | 2022-11-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-preview-2023-07 | package-preview-2023-07(2a01bf8) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'Certificate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4482 |
|
The schema 'CustomerCertificate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4508 |
|
The schema 'AFDDomainListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4661 |
|
The schema 'AFDDomainProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4693 |
|
The schema 'AFDDomainUpdatePropertiesParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4756 |
|
The schema 'DomainValidationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4781 |
|
The schema 'AFDDomainHttpsParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4796 |
|
The schema 'SecurityPolicyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4955 |
|
The schema 'AFDEndpointProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5001 |
|
The schema 'AFDEndpointListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5023 |
|
The schema 'AFDEndpointPropertiesUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5058 |
|
The schema 'SecretListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5109 |
|
The schema 'SecretProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5141 |
|
The schema 'RuleSetListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5340 |
|
The schema 'AFDOriginUpdatePropertiesParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5428 |
|
The schema 'SharedPrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5507 |
|
The schema 'AFDOriginListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5544 |
|
The schema 'AFDOriginGroupUpdatePropertiesParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5599 |
|
The schema 'AFDOriginGroupListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5658 |
|
The schema 'RouteListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5675 |
|
The schema 'RouteUpdatePropertiesParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5731 |
|
The schema 'RuleListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5869 |
|
The schema 'RuleUpdatePropertiesParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L5927 |
|
The schema 'AfdErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6146 |
|
The schema 'MetricsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6156 |
|
The schema 'RankingsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6239 |
|
The schema 'ContinentsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6297 |
|
The schema 'ResourcesResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6327 |
|
The schema 'WafMetricsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6389 |
|
The schema 'WafRankingsResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L6469 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/cdn/armcdn - Approved - 2.0.0+ Enum `MetricsResponseGranularity` has been removed + Enum `MetricsResponseSeriesItemUnit` has been removed + Enum `WafMetricsResponseGranularity` has been removed + Enum `WafMetricsResponseSeriesItemUnit` has been removed + Function `*ClientFactory.NewValidateClient` has been removed + Function `*ValidateClient.Secret` has been removed + Function `NewValidateClient` has been removed + Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead. + Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead. + Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain` + Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity` + Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit` + Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity` + Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
❌azure-sdk-for-js - @azure/arm-cdn - Approved - 9.0.0+ Class CdnManagementClient has a new signature + Class CdnManagementClient no longer has parameter validate + Removed Enum KnownMetricsResponseGranularity + Removed Enum KnownMetricsResponseSeriesItemUnit + Removed Enum KnownWafMetricsResponseGranularity + Removed operation group Validate + Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity + Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity + Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit + Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit
❌azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - Approved - 12.0.0+ Removed operation group ValidateOperations + Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https + Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.1.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-cdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation AFDProfilesOperations.begin_upgrade info [Changelog] - Added operation AFDProfilesOperations.check_endpoint_name_availability info [Changelog] - Added operation AFDProfilesOperations.validate_secret info [Changelog] - Added operation ProfilesOperations.begin_can_migrate info [Changelog] - Added operation ProfilesOperations.begin_migrate info [Changelog] - Added operation ProfilesOperations.begin_migration_commit info [Changelog] - Model AFDDomain has a new parameter extended_properties info [Changelog] - Model AFDDomainProperties has a new parameter extended_properties info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter certificate_authority info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter expiration_date info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter secret_source info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject_alternative_names info [Changelog] - Model AzureFirstPartyManagedCertificateParameters has a new parameter thumbprint info [Changelog] - Model CdnWebApplicationFirewallPolicy has a new parameter extended_properties info [Changelog] - Model Profile has a new parameter extended_properties info [Changelog] - Model Profile has a new parameter identity info [Changelog] - Model ProfileUpdateParameters has a new parameter identity info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Removed operation group ValidateOperations info [Changelog] - Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https info [Changelog] - Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-cdn-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/cdn/armcdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain` info [Changelog] - Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity` info [Changelog] - Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit` info [Changelog] - Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity` info [Changelog] - Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit` info [Changelog] - Enum `MetricsResponseGranularity` has been removed info [Changelog] - Enum `MetricsResponseSeriesItemUnit` has been removed info [Changelog] - Enum `WafMetricsResponseGranularity` has been removed info [Changelog] - Enum `WafMetricsResponseSeriesItemUnit` has been removed info [Changelog] - Function `*ClientFactory.NewValidateClient` has been removed info [Changelog] - Function `NewValidateClient` has been removed info [Changelog] - Function `*ValidateClient.Secret` has been removed info [Changelog] - Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead. info [Changelog] - Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead. info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `ProfileResourceStateAbortingMigration`, `ProfileResourceStateCommittingMigration`, `ProfileResourceStateMigrated`, `ProfileResourceStateMigrating`, `ProfileResourceStatePendingMigrationCommit` added to enum type `ProfileResourceState` info [Changelog] - New enum type `CanMigrateDefaultSKU` with values `CanMigrateDefaultSKUPremiumAzureFrontDoor`, `CanMigrateDefaultSKUStandardAzureFrontDoor` info [Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned` info [Changelog] - New enum type `MetricsGranularity` with values `MetricsGranularityP1D`, `MetricsGranularityPT1H`, `MetricsGranularityPT5M` info [Changelog] - New enum type `MetricsSeriesUnit` with values `MetricsSeriesUnitBitsPerSecond`, `MetricsSeriesUnitBytes`, `MetricsSeriesUnitCount`, `MetricsSeriesUnitMilliSeconds` info [Changelog] - New enum type `WafMetricsGranularity` with values `WafMetricsGranularityP1D`, `WafMetricsGranularityPT1H`, `WafMetricsGranularityPT5M` info [Changelog] - New enum type `WafMetricsSeriesUnit` with values `WafMetricsSeriesUnitCount` info [Changelog] - New function `*AFDProfilesClient.CheckEndpointNameAvailability(context.Context, string, string, CheckEndpointNameAvailabilityInput, *AFDProfilesClientCheckEndpointNameAvailabilityOptions) (AFDProfilesClientCheckEndpointNameAvailabilityResponse, error)` info [Changelog] - New function `*AFDProfilesClient.BeginUpgrade(context.Context, string, string, ProfileUpgradeParameters, *AFDProfilesClientBeginUpgradeOptions) (*runtime.Poller[AFDProfilesClientUpgradeResponse], error)` info [Changelog] - New function `*AFDProfilesClient.ValidateSecret(context.Context, string, string, ValidateSecretInput, *AFDProfilesClientValidateSecretOptions) (AFDProfilesClientValidateSecretResponse, error)` info [Changelog] - New function `*ProfilesClient.BeginCanMigrate(context.Context, string, CanMigrateParameters, *ProfilesClientBeginCanMigrateOptions) (*runtime.Poller[ProfilesClientCanMigrateResponse], error)` info [Changelog] - New function `*ProfilesClient.BeginMigrate(context.Context, string, MigrationParameters, *ProfilesClientBeginMigrateOptions) (*runtime.Poller[ProfilesClientMigrateResponse], error)` info [Changelog] - New function `*ProfilesClient.BeginMigrationCommit(context.Context, string, string, *ProfilesClientBeginMigrationCommitOptions) (*runtime.Poller[ProfilesClientMigrationCommitResponse], error)` info [Changelog] - New struct `CanMigrateParameters` info [Changelog] - New struct `CanMigrateProperties` info [Changelog] - New struct `CanMigrateResult` info [Changelog] - New struct `DeepCreatedCustomDomain` info [Changelog] - New struct `DeepCreatedCustomDomainProperties` info [Changelog] - New struct `ManagedServiceIdentity` info [Changelog] - New struct `MigrateResult` info [Changelog] - New struct `MigrateResultProperties` info [Changelog] - New struct `MigrationErrorType` info [Changelog] - New struct `MigrationParameters` info [Changelog] - New struct `MigrationWebApplicationFirewallMapping` info [Changelog] - New struct `ProfileChangeSKUWafMapping` info [Changelog] - New struct `ProfileUpgradeParameters` info [Changelog] - New struct `UserAssignedIdentity` info [Changelog] - New field `ExtendedProperties` in struct `AFDDomainProperties` info [Changelog] - New field `CertificateAuthority`, `ExpirationDate`, `SecretSource`, `Subject`, `SubjectAlternativeNames`, `Thumbprint` in struct `AzureFirstPartyManagedCertificateParameters` info [Changelog] - New field `Identity` in struct `Profile` info [Changelog] - New field `ExtendedProperties` in struct `ProfileProperties` info [Changelog] - New field `Identity` in struct `ProfileUpdateParameters` info [Changelog] - New field `ExtendedProperties` in struct `WebApplicationFirewallPolicyProperties` info [Changelog] info [Changelog] Total 14 breaking change(s), 68 additive change(s).
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mFailed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] [0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mCannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1mit does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] [0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m | [31;1mFailed to generate sdk artifact cmderr [Invoke-GenerateAndBuildV2.ps1] [0m
❌Azure.ResourceManager.Cdn [View full logs] [Release SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-cdn [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added operation Profiles.beginCanMigrateAndWait info [Changelog] - Added operation Profiles.beginMigrate info [Changelog] - Added operation Profiles.beginMigrateAndWait info [Changelog] - Added operation Profiles.beginMigrationCommit info [Changelog] - Added operation Profiles.beginMigrationCommitAndWait info [Changelog] - Added Interface AfdCustomDomainsCreateHeaders info [Changelog] - Added Interface AfdCustomDomainsDeleteHeaders info [Changelog] - Added Interface AfdCustomDomainsRefreshValidationTokenHeaders info [Changelog] - Added Interface AfdCustomDomainsUpdateHeaders info [Changelog] - Added Interface AfdEndpointsCreateHeaders info [Changelog] - Added Interface AfdEndpointsDeleteHeaders info [Changelog] - Added Interface AfdEndpointsPurgeContentHeaders info [Changelog] - Added Interface AfdEndpointsUpdateHeaders info [Changelog] - Added Interface AfdOriginGroupsCreateHeaders info [Changelog] - Added Interface AfdOriginGroupsDeleteHeaders info [Changelog] - Added Interface AfdOriginGroupsUpdateHeaders info [Changelog] - Added Interface AfdOriginsCreateHeaders info [Changelog] - Added Interface AfdOriginsDeleteHeaders info [Changelog] - Added Interface AfdOriginsUpdateHeaders info [Changelog] - Added Interface AfdProfilesCheckEndpointNameAvailabilityOptionalParams info [Changelog] - Added Interface AfdProfilesUpgradeHeaders info [Changelog] - Added Interface AfdProfilesUpgradeOptionalParams info [Changelog] - Added Interface AfdProfilesValidateSecretOptionalParams info [Changelog] - Added Interface CanMigrateParameters info [Changelog] - Added Interface CanMigrateResult info [Changelog] - Added Interface CustomDomainsCreateHeaders info [Changelog] - Added Interface CustomDomainsDeleteHeaders info [Changelog] - Added Interface CustomDomainsDisableCustomHttpsHeaders info [Changelog] - Added Interface CustomDomainsEnableCustomHttpsHeaders info [Changelog] - Added Interface EndpointsCreateHeaders info [Changelog] - Added Interface EndpointsDeleteHeaders info [Changelog] - Added Interface EndpointsLoadContentHeaders info [Changelog] - Added Interface EndpointsPurgeContentHeaders info [Changelog] - Added Interface EndpointsStartHeaders info [Changelog] - Added Interface EndpointsStopHeaders info [Changelog] - Added Interface EndpointsUpdateHeaders info [Changelog] - Added Interface ManagedServiceIdentity info [Changelog] - Added Interface MigrateResult info [Changelog] - Added Interface MigrationErrorType info [Changelog] - Added Interface MigrationParameters info [Changelog] - Added Interface MigrationWebApplicationFirewallMapping info [Changelog] - Added Interface OriginGroupsCreateHeaders info [Changelog] - Added Interface OriginGroupsDeleteHeaders info [Changelog] - Added Interface OriginGroupsUpdateHeaders info [Changelog] - Added Interface OriginsCreateHeaders info [Changelog] - Added Interface OriginsDeleteHeaders info [Changelog] - Added Interface OriginsUpdateHeaders info [Changelog] - Added Interface PoliciesCreateOrUpdateHeaders info [Changelog] - Added Interface PoliciesUpdateHeaders info [Changelog] - Added Interface ProfileChangeSkuWafMapping info [Changelog] - Added Interface ProfilesCanMigrateHeaders info [Changelog] - Added Interface ProfilesCanMigrateOptionalParams info [Changelog] - Added Interface ProfilesCreateHeaders info [Changelog] - Added Interface ProfilesDeleteHeaders info [Changelog] - Added Interface ProfilesMigrateHeaders info [Changelog] - Added Interface ProfilesMigrateOptionalParams info [Changelog] - Added Interface ProfilesMigrationCommitHeaders info [Changelog] - Added Interface ProfilesMigrationCommitOptionalParams info [Changelog] - Added Interface ProfilesUpdateHeaders info [Changelog] - Added Interface ProfileUpgradeParameters info [Changelog] - Added Interface RoutesCreateHeaders info [Changelog] - Added Interface RoutesDeleteHeaders info [Changelog] - Added Interface RoutesUpdateHeaders info [Changelog] - Added Interface RulesCreateHeaders info [Changelog] - Added Interface RulesDeleteHeaders info [Changelog] - Added Interface RuleSetsDeleteHeaders info [Changelog] - Added Interface RulesUpdateHeaders info [Changelog] - Added Interface SecretsCreateHeaders info [Changelog] - Added Interface SecretsDeleteHeaders info [Changelog] - Added Interface SecurityPoliciesCreateHeaders info [Changelog] - Added Interface SecurityPoliciesDeleteHeaders info [Changelog] - Added Interface SecurityPoliciesPatchHeaders info [Changelog] - Added Interface UserAssignedIdentity info [Changelog] - Added Type Alias AfdProfilesCheckEndpointNameAvailabilityResponse info [Changelog] - Added Type Alias AfdProfilesUpgradeResponse info [Changelog] - Added Type Alias AfdProfilesValidateSecretResponse info [Changelog] - Added Type Alias CanMigrateDefaultSku info [Changelog] - Added Type Alias ManagedServiceIdentityType info [Changelog] - Added Type Alias MetricsGranularity info [Changelog] - Added Type Alias MetricsSeriesUnit info [Changelog] - Added Type Alias ProfilesCanMigrateResponse info [Changelog] - Added Type Alias ProfilesMigrateResponse info [Changelog] - Added Type Alias WafMetricsGranularity info [Changelog] - Added Type Alias WafMetricsSeriesUnit info [Changelog] - Interface AFDDomain has a new optional parameter extendedProperties info [Changelog] - Interface AFDDomainProperties has a new optional parameter extendedProperties info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter certificateAuthority info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter expirationDate info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter secretSource info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subject info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subjectAlternativeNames info [Changelog] - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter thumbprint info [Changelog] - Interface CdnWebApplicationFirewallPolicy has a new optional parameter extendedProperties info [Changelog] - Interface Profile has a new optional parameter extendedProperties info [Changelog] - Interface Profile has a new optional parameter identity info [Changelog] - Interface ProfileUpdateParameters has a new optional parameter identity info [Changelog] - Added Enum KnownCanMigrateDefaultSku info [Changelog] - Added Enum KnownManagedServiceIdentityType info [Changelog] - Added Enum KnownMetricsGranularity info [Changelog] - Added Enum KnownMetricsSeriesUnit info [Changelog] - Added Enum KnownWafMetricsGranularity info [Changelog] - Added Enum KnownWafMetricsSeriesUnit info [Changelog] - Enum KnownProfileResourceState has a new value AbortingMigration info [Changelog] - Enum KnownProfileResourceState has a new value CommittingMigration info [Changelog] - Enum KnownProfileResourceState has a new value Migrated info [Changelog] - Enum KnownProfileResourceState has a new value Migrating info [Changelog] - Enum KnownProfileResourceState has a new value PendingMigrationCommit info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation group Validate info [Changelog] - Class CdnManagementClient has a new signature info [Changelog] - Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity info [Changelog] - Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit info [Changelog] - Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity info [Changelog] - Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit info [Changelog] - Class CdnManagementClient no longer has parameter validate info [Changelog] - Removed Enum KnownMetricsResponseGranularity info [Changelog] - Removed Enum KnownMetricsResponseSeriesItemUnit info [Changelog] - Removed Enum KnownWafMetricsResponseGranularity
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.1.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.1.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs]Release - Generate from 6d479c6fcf9107c9093f1274daf1edf7f49f91a6. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.cdn.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.cdn.DefaultTag
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/cdn/armcdn | Create ApiView timeout. Package is too large and we cannot create ApiView for it. |
| Java | azure-resourcemanager-cdn-generated | https://apiview.dev/Assemblies/Review/545ba4d9a19f4f4ca56e3e72070d1b6f |
| JavaScript | @azure/arm-cdn | https://apiview.dev/Assemblies/Review/bef3efc4d186462aa066c43ae4a32915 |
Hi @jessicl-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
@jessicl-ms pls check validation and fix them https://github.com/Azure/azure-rest-api-specs/pull/24387#issuecomment-1585491643 refer to https://github.com/Azure/azure-rest-api-specs/pull/24387#issuecomment-1585494110
Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
Please also follow this to update the PR
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
Hi @jessicl-ms! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.
You cannot proceed with merging this PR until you complete one of the following action items:
ACTION ITEM ALTERNATIVE A: Fix the breaking change.
Please consult the documentation provided in the relevant validation failures.
ACTION ITEM ALTERNATIVE B: Request approval.
Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the process described in the High-level Breaking Change Process doc.
ACTION ITEM ALTERNATIVE C: Report false positive.
If you think there are no breaking changes, i.e. the validation should pass yet it fails, then please explain why in a PR comment and @ the PR assignee.
Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
Please also follow this to update the PR
@zizw123 I fixed my commit history. You should find 3 commits as of now:
- Copy latest stable version 2023-05-01 to preview directory
- Rename that copy to 2023-07-01-preview version
- Changes relevant to new preview api version and all api validation fixes.
@JackTn I addressed as many of the validation pipeline failures and comments. There are some additional failures that I address in the comments below. Please take another look!
This preview API version contains api for preview feature UrlSigningKey. This feature was previously present in cdn.json API definition in Private Preview state. We have already notified customers currently using the previous APIs about breakings changes (<20 total customers). The previous definition in cdn.json was also for a different resource SKU. The current changes are specifically targeted for afdx.json definitions for customers using Azure Frontdoor Standard/Premium SKU. There should be no overlap between the previous and future customers using this preview feature.
Breaking Change (Cross-Version)
- The validation pipeline shows this error. I'm not sure how to resolve it. Please advise!
"new":"https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2023-05-01/afdx.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.54/common/temp/node_modules/.pnpm/https://github.com/[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nFATAL: swagger-document/emitter - FAILED\nFATAL: Error: Error retrieving '$.definitions.UrlSigningAction.type' (Error: Trying to retrieve 'type' from mapping that contains no such key)\n Error: Error retrieving '$.definitions.UrlSigningAction.type' (Error: Trying to retrieve 'type' from mapping that contains no such key)\n"
Swagger SDK Breaking Change Tracking:
- I had copied over cdn.json and cdnwebapplicationfirewall.json from 2023-05-01 version. There should not be any changes to these files. However, the validation pipeline is identifying changes to those resources. Why is that?
Swagger Model Validation:
- It is taking issue with preview/2023-07-01-preview/examples/Rules_Create_AfdUrlSigningAction.json, but the lines the error message links to in the afdx.json Swagger are not the right ones. Do you know why it's referencing the wrong part of the API? Is it because we are reusing the same model names between cdn.json and afdx.json?
- Error Missing_Resource_Id says
id is required to return in response of GET/PUT resource calls but not being provided. These example files are for cdn.json API definitions which have not been changed in this PR. Can these be ignored?
Swagger LintDiff, ~[Staging] Swagger LintDiff
- Is there a way around Error PutRequestResponseSchemeArm? We do not want a PATCH API available for this resource.
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'KeyGroups_CreateUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: [Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635](https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635) - What kind of error response is error LroErrorContent looking for? This new resource is suing the same lro error we are using for other preexisting operations.
- Is Error DeleteResponseCodes saying I need to remove 200 response from delete API?
SDK azure-sdk-for-net-track2, SDK azure-powershell
Do these validations only succeed if all other validations are succeeding?
@jessicl-ms Thanks for explanations . @rkmanda are these errors can be acceptable?
Swagger LintDiff, ~[Staging] Swagger LintDiff
- Is there a way around Error PutRequestResponseSchemeArm? We do not want a PATCH API available for this resource.
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'KeyGroups_CreateUpdate' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: [Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635](https://github.com/Azure/azure-rest-api-specs/blob/87428d4c15b9ace4427ab68a762c46b623e4d26b/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L3635)- What kind of error response is error LroErrorContent looking for? This new resource is suing the same lro error we are using for other preexisting operations.
- Is Error DeleteResponseCodes saying I need to remove 200 response from delete API?
The failure for PutRequestResponseSchemeArm is a false alarm. Please apply a suppression for it.
The failure for LroErrorContent can be fixed by switching to the use of the standard error definition for ARM - https://github.com/Azure/azure-rest-api-specs/blob/8b70e81ab1b526c468b5dbd68affd30595cfc329/specification/common-types/resource-management/v5/types.json#L302C1-L303C1
Also fix the warnings to use common types so that you are making use of the common type definitions - ParameterNotUsingCommonTypes
DeleteResponseCodes A long-running delete must not return a 200 status code. It MUST return a 202 accepted when the delete request is accepted and a long running workflow is initiated for the delete operation. It MUST also return a 204 if the resource does not exist.
"202": {
PUT must not return a 202
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3685 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)
"final-state-via": "azure-async-operation"
remove this, you dont need to specify the final-state-via for control plane APIs
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3705 in e804d9d. [](commit_id = e804d9deaedf7ca9365aaae37e282802c29b446e, deletion_comment = False)
"200": {
remove. Async delete only needs to respond with 202 or 204
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3737 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)
"$ref": "./cdn.json#/definitions/ProxyResource"
use common-types
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:4616 in 8b70e81. [](commit_id = 8b70e81ab1b526c468b5dbd68affd30595cfc329, deletion_comment = False)
Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - https://aka.ms/azsdk/support/specreview-channel.
Please indicate that this is an ARM-related question in the title of your post by including "[ARM Query]" in the title.
Hi @jessicl-ms, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
I opened an issue for the failure in the breaking changes PR check. I also manually compared adfx.json with the prior version and saw no potential breaking changes.
Marked this pull request as draft as there is some more work need to do
"final-state-via": "azure-async-operation"remove this, you dont need to specify the final-state-via for control plane APIs
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3705 in e804d9d. [](commit_id = e804d9d, deletion_comment = False)
Removed
"200": {remove. Async delete only needs to respond with 202 or 204
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3737 in 8b70e81. [](commit_id = 8b70e81, deletion_comment = False)
Removed
"202": {PUT must not return a 202
Refers to: specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-07-01-preview/afdx.json:3685 in 8b70e81. [](commit_id = 8b70e81, deletion_comment = False)
Request to this API are async and may not complete immediately. We have been using 202 to indicate that the operation was accepted and initiated. Could we keep 202 as PUT response?