azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
Updating OperationResults Model and examples
Adding OperationResults resource under Location path, changing model and examples for the same. Adding the same in both API versions
Hi, @ayushiaks Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| agfood.json | 2020-05-12-preview(651dbfb) | 2020-05-12-preview(main) |
| agfood.json | 2021-09-01-preview(651dbfb) | 2021-09-01-preview(main) |
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AgFoodPlatform/farmBeats/{farmBeatsResourceName}/operationResults/{operationResultsId}' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L721:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L279:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L721:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2021-09 | package-preview-2021-09(651dbfb) | package-preview-2021-09(main) |
| package-2020-05-12-preview | package-2020-05-12-preview(651dbfb) | package-2020-05-12-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9 |
|
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L10 |
|
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L56 |
|
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L102 |
|
The parameters:extensionId,farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L148 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L466 |
|
The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L510 |
|
The parameters:farmBeatsResourceName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L571 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L596 |
|
The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1093 |
|
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L1167 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L9 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L166 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L383 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L513 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L868 |
|
The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L868 |
|
The response in the GET collection operation 'PrivateEndpointConnections_ListByResource' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' . Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1051 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1051 |
|
The response in the GET collection operation 'PrivateLinkResources_ListByResource' does not match the response definition in the individual GET operation 'PrivateLinkResources_Get' . Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1099 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1099 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1147 |
|
The resource name parameter 'subResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1147 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1206 |
|
The 'solutionId' already appears in the path, please don't repeat it in the request body. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1229 |
|
The resource name parameter 'farmBeatsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1363 |
|
The top-level resource 'FarmBeatsExtension' does not have list by subscription operation, please add it. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1868 |
|
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1937 |
|
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1980 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-agrifood - Approved - 1.0.0b3+ Removed operation FarmBeatsModelsOperations.get_operation_result
❌azure-sdk-for-go - sdk/resourcemanager/agrifood/armagrifood - Approved - 0.8.0+ Function `*FarmBeatsModelsClient.GetOperationResult` has been removed
❌azure-sdk-for-js - @azure/arm-agrifood - 1.0.0-beta.5+ Removed operation FarmBeatsModels.getOperationResult
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from d53897865f8d06f7132de49e8015207e75cf86f7. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-agrifood [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group OperationResultsOperations info [Changelog] - Model ApiProperties has a new parameter api_freshness_time_in_minutes info [Changelog] - Model ArmAsyncOperation has a new parameter error info [Changelog] - Model FarmBeatsSolutionProperties has a new parameter action_ids info [Changelog] - Model FarmBeatsSolutionProperties has a new parameter saa_s_application_id info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model ApiProperties no longer has parameter api_freshness_window_in_minutes info [Changelog] - Operation SolutionsOperations.create_or_update has a new required parameter solution_id info [Changelog] - Operation SolutionsOperations.delete has a new required parameter solution_id info [Changelog] - Operation SolutionsOperations.get has a new required parameter solution_id info [Changelog] - Removed operation FarmBeatsModelsOperations.get_operation_result
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d53897865f8d06f7132de49e8015207e75cf86f7. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/agrifood/armagrifood [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*ExtensionsClient.Create` has been removed info [Changelog] - Function `*ExtensionsClient.Update` has been removed info [Changelog] - Function `*FarmBeatsModelsClient.GetOperationResult` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New function `*ExtensionsClient.CreateOrUpdate(context.Context, string, string, string, *ExtensionsClientCreateOrUpdateOptions) (ExtensionsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `NewOperationResultsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationResultsClient, error)` info [Changelog] - New function `*OperationResultsClient.Get(context.Context, string, string, *OperationResultsClientGetOptions) (OperationResultsClientGetResponse, error)` info [Changelog] - New function `NewSolutionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SolutionsClient, error)` info [Changelog] - New function `*SolutionsClient.CreateOrUpdate(context.Context, string, string, string, *SolutionsClientCreateOrUpdateOptions) (SolutionsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*SolutionsClient.Delete(context.Context, string, string, string, *SolutionsClientDeleteOptions) (SolutionsClientDeleteResponse, error)` info [Changelog] - New function `*SolutionsClient.Get(context.Context, string, string, string, *SolutionsClientGetOptions) (SolutionsClientGetResponse, error)` info [Changelog] - New function `*SolutionsClient.NewListPager(string, string, *SolutionsClientListOptions) *runtime.Pager[SolutionsClientListResponse]` info [Changelog] - New function `NewSolutionsDiscoverabilityClient(azcore.TokenCredential, *arm.ClientOptions) (*SolutionsDiscoverabilityClient, error)` info [Changelog] - New function `*SolutionsDiscoverabilityClient.Get(context.Context, string, *SolutionsDiscoverabilityClientGetOptions) (SolutionsDiscoverabilityClientGetResponse, error)` info [Changelog] - New function `*SolutionsDiscoverabilityClient.NewListPager(*SolutionsDiscoverabilityClientListOptions) *runtime.Pager[SolutionsDiscoverabilityClientListResponse]` info [Changelog] - New struct `APIProperties` info [Changelog] - New struct `ArmAsyncOperationError` info [Changelog] - New struct `ExtensionInstallationRequest` info [Changelog] - New struct `FarmBeatsSolution` info [Changelog] - New struct `FarmBeatsSolutionListResponse` info [Changelog] - New struct `FarmBeatsSolutionProperties` info [Changelog] - New struct `Insight` info [Changelog] - New struct `InsightAttachment` info [Changelog] - New struct `MarketplaceOfferDetails` info [Changelog] - New struct `Measure` info [Changelog] - New struct `OperationResultsClient` info [Changelog] - New struct `ResourceParameter` info [Changelog] - New struct `Solution` info [Changelog] - New struct `SolutionEvaluatedOutput` info [Changelog] - New struct `SolutionInstallationRequest` info [Changelog] - New struct `SolutionListResponse` info [Changelog] - New struct `SolutionProperties` info [Changelog] - New struct `SolutionsClient` info [Changelog] - New struct `SolutionsDiscoverabilityClient` info [Changelog] - New field `Error` in struct `ArmAsyncOperation` info [Changelog] - New field `AdditionalAPIProperties` in struct `ExtensionProperties` info [Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties` info [Changelog] info [Changelog] Total 3 breaking change(s), 52 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d53897865f8d06f7132de49e8015207e75cf86f7. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-agrifood [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group OperationResults info [Changelog] - Added operation group Solutions info [Changelog] - Added operation group SolutionsDiscoverability info [Changelog] - Added operation Extensions.createOrUpdate info [Changelog] - Added Interface ApiProperties info [Changelog] - Added Interface ArmAsyncOperationError info [Changelog] - Added Interface ExtensionInstallationRequest info [Changelog] - Added Interface ExtensionsCreateOrUpdateOptionalParams info [Changelog] - Added Interface FarmBeatsSolution info [Changelog] - Added Interface FarmBeatsSolutionListResponse info [Changelog] - Added Interface FarmBeatsSolutionProperties info [Changelog] - Added Interface Insight info [Changelog] - Added Interface InsightAttachment info [Changelog] - Added Interface MarketplaceOfferDetails info [Changelog] - Added Interface Measure info [Changelog] - Added Interface OperationResultsGetOptionalParams info [Changelog] - Added Interface ResourceParameter info [Changelog] - Added Interface Solution info [Changelog] - Added Interface SolutionEvaluatedOutput info [Changelog] - Added Interface SolutionInstallationRequest info [Changelog] - Added Interface SolutionListResponse info [Changelog] - Added Interface SolutionProperties info [Changelog] - Added Interface SolutionsCreateOrUpdateOptionalParams info [Changelog] - Added Interface SolutionsDeleteOptionalParams info [Changelog] - Added Interface SolutionsDiscoverabilityGetOptionalParams info [Changelog] - Added Interface SolutionsDiscoverabilityListNextOptionalParams info [Changelog] - Added Interface SolutionsDiscoverabilityListOptionalParams info [Changelog] - Added Interface SolutionsGetOptionalParams info [Changelog] - Added Interface SolutionsListNextOptionalParams info [Changelog] - Added Interface SolutionsListOptionalParams info [Changelog] - Added Type Alias ExtensionsCreateOrUpdateResponse info [Changelog] - Added Type Alias OperationResultsGetResponse info [Changelog] - Added Type Alias SolutionsCreateOrUpdateResponse info [Changelog] - Added Type Alias SolutionsDiscoverabilityGetResponse info [Changelog] - Added Type Alias SolutionsDiscoverabilityListNextResponse info [Changelog] - Added Type Alias SolutionsDiscoverabilityListResponse info [Changelog] - Added Type Alias SolutionsGetResponse info [Changelog] - Added Type Alias SolutionsListNextResponse info [Changelog] - Added Type Alias SolutionsListResponse info [Changelog] - Interface ArmAsyncOperation has a new optional parameter error info [Changelog] - Interface Extension has a new optional parameter additionalApiProperties info [Changelog] - Interface PrivateEndpointConnection has a new optional parameter groupIds info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation Extensions.create info [Changelog] - Removed operation Extensions.update info [Changelog] - Removed operation FarmBeatsModels.getOperationResult info [Changelog] - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionCategories info [Changelog] - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter extensionIds info [Changelog] - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter maxPageSize info [Changelog] - Interface ExtensionsListByFarmBeatsNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter extensionCategories info [Changelog] - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionIds info [Changelog] - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter farmBeatsExtensionNames info [Changelog] - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter maxPageSize info [Changelog] - Interface FarmBeatsExtensionsListNextOptionalParams no longer has parameter publisherIds info [Changelog] - Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter maxPageSize info [Changelog] - Interface FarmBeatsModelsListByResourceGroupNextOptionalParams no longer has parameter skipToken info [Changelog] - Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter maxPageSize info [Changelog] - Interface FarmBeatsModelsListBySubscriptionNextOptionalParams no longer has parameter skipToken
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from d53897865f8d06f7132de49e8015207e75cf86f7. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-agrifood [View full logs] [Release SDK Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs]Release - Generate from d53897865f8d06f7132de49e8015207e75cf86f7. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.agrifood [View full logs] [Release SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/agrifood/armagrifood | https://apiview.dev/Assemblies/Review/a16b5dcbb0794a3cb1f68000f3f501bb |
| Java | azure-resourcemanager-agrifood | https://apiview.dev/Assemblies/Review/e8fc52b9043847fbafeed1a1ebe92ab9 |
| JavaScript | @azure/arm-agrifood | https://apiview.dev/Assemblies/Review/c89c77b1e5294ce3829048f59a2b4487 |
Thank you for your contribution ayushiaks! We will review the pull request and get back to you soon.
Hi @ayushiaks, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi @ayushiaks, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
@qiliao123 @tadelesh @msyyc for awareness of the breaks (that should be in preview)
