azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Add Metadata service stable version 2023-02-01

Open samuelkuangms opened this issue 3 years ago • 5 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [X] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

samuelkuangms avatar Jan 11 '23 00:01 samuelkuangms

Hi, @samuelkuangms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    Metadata.json 2023-02-01(5c7497d) 2022-12-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    :warning: 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    New: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L644:9
    Old: Microsoft.SecurityInsights/preview/2022-12-01-preview/Metadata.json#L720:9
    :warning: 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    New: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L473:9
    Old: Microsoft.SecurityInsights/preview/2022-12-01-preview/Metadata.json#L549:9
    :warning: 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    Old: Microsoft.SecurityInsights/preview/2022-12-01-preview/Metadata.json#L250:9
    :warning: 1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
    New: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L353:5
    Old: Microsoft.SecurityInsights/preview/2022-12-01-preview/Metadata.json#L353:5
    ️❌LintDiff: 4 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-02 package-2023-02(5c7497d) package-2023-02(release-Sentinel-2023-02-01)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ResourceNameRestriction The resource name parameter 'metadataName' should be defined with a 'pattern' restriction.
    Location: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L97
    RPC-Uri-V1-05
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L266
    RPC-Patch-V1-02
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L266
    RPC-Patch-V1-02
    XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L505
    ️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    INCONSISTENT_API_VERSION The API version of the swagger is inconsistent with its file path.
    readme: specification/securityinsights/resource-manager/readme.md
    json: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json
    ️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 9 Errors, 0 Warnings failed [Detail]
    Rule Message
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L38:14
    ExampleUrl: 2023-02-01/examples/metadata/GetAllMetadata.json#L2:17
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: api-version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L630:28
    ExampleUrl: 2023-02-01/examples/metadata/GetAllMetadata.json#L3:20
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L38:14
    ExampleUrl: 2023-02-01/examples/metadata/GetAllMetadataOData.json#L2:17
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: api-version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L630:28
    ExampleUrl: 2023-02-01/examples/metadata/GetAllMetadataOData.json#L3:20
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L98:14
    ExampleUrl: 2023-02-01/examples/metadata/GetMetadata.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L141:17
    ExampleUrl: 2023-02-01/examples/metadata/DeleteMetadata.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L184:14
    ExampleUrl: 2023-02-01/examples/metadata/PutMetadata.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L184:14
    ExampleUrl: 2023-02-01/examples/metadata/PutMetadataMinimal.json#L2:17
    INVALID_REQUEST_PARAMETER api-version 2023-02-01 is not equal to swagger version
    Url: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L239:16
    ExampleUrl: 2023-02-01/examples/metadata/PatchMetadata.json#L2:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 2.0.0b2
    +	Model AlertDetailsOverride no longer has parameter alert_dynamic_properties
    +	Model Bookmark no longer has parameter entity_mappings
    +	Model Bookmark no longer has parameter tactics
    +	Model Bookmark no longer has parameter techniques
    +	Model FusionAlertRule no longer has parameter scenario_exclusion_patterns
    +	Model FusionAlertRule no longer has parameter source_settings
    +	Model FusionAlertRuleTemplate no longer has parameter source_settings
    +	Model Incident no longer has parameter provider_incident_id
    +	Model Incident no longer has parameter provider_name
    +	Model Incident no longer has parameter team_information
    +	Model IncidentAdditionalData no longer has parameter provider_incident_url
    +	Model IncidentAdditionalData no longer has parameter techniques
    +	Model IoTDeviceEntity no longer has parameter device_sub_type
    +	Model IoTDeviceEntity no longer has parameter importance
    +	Model IoTDeviceEntity no longer has parameter is_authorized
    +	Model IoTDeviceEntity no longer has parameter is_programming
    +	Model IoTDeviceEntity no longer has parameter is_scanner
    +	Model IoTDeviceEntity no longer has parameter nic_entity_ids
    +	Model IoTDeviceEntity no longer has parameter owners
    +	Model IoTDeviceEntity no longer has parameter purdue_layer
    +	Model IoTDeviceEntity no longer has parameter sensor
    +	Model IoTDeviceEntity no longer has parameter site
    +	Model IoTDeviceEntity no longer has parameter zone
    +	Model IoTDeviceEntityProperties no longer has parameter device_sub_type
    +	Model IoTDeviceEntityProperties no longer has parameter importance
    +	Model IoTDeviceEntityProperties no longer has parameter is_authorized
    +	Model IoTDeviceEntityProperties no longer has parameter is_programming
    +	Model IoTDeviceEntityProperties no longer has parameter is_scanner
    +	Model IoTDeviceEntityProperties no longer has parameter nic_entity_ids
    +	Model IoTDeviceEntityProperties no longer has parameter owners
    +	Model IoTDeviceEntityProperties no longer has parameter purdue_layer
    +	Model IoTDeviceEntityProperties no longer has parameter sensor
    +	Model IoTDeviceEntityProperties no longer has parameter site
    +	Model IoTDeviceEntityProperties no longer has parameter zone
    +	Model ScheduledAlertRule no longer has parameter sentinel_entities_mappings
    +	Model ScheduledAlertRuleCommonProperties no longer has parameter sentinel_entities_mappings
    +	Model ScheduledAlertRuleProperties no longer has parameter sentinel_entities_mappings
    +	Model ScheduledAlertRuleTemplate no longer has parameter sentinel_entities_mappings
    +	Model Watchlist no longer has parameter source_type
    +	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
    +	Removed operation DataConnectorsOperations.connect
    +	Removed operation DataConnectorsOperations.disconnect
    +	Removed operation IncidentsOperations.create_team
    +	Removed operation IncidentsOperations.run_playbook
    +	Removed operation group BookmarkOperations
    +	Removed operation group BookmarkRelationsOperations
    +	Removed operation group DataConnectorsCheckRequirementsOperations
    +	Removed operation group DomainWhoisOperations
    +	Removed operation group EntitiesGetTimelineOperations
    +	Removed operation group EntitiesOperations
    +	Removed operation group EntitiesRelationsOperations
    +	Removed operation group EntityQueriesOperations
    +	Removed operation group EntityQueryTemplatesOperations
    +	Removed operation group EntityRelationsOperations
    +	Removed operation group FileImportsOperations
    +	Removed operation group GetOperations
    +	Removed operation group GetRecommendationsOperations
    +	Removed operation group IPGeodataOperations
    +	Removed operation group IncidentTasksOperations
    +	Removed operation group OfficeConsentsOperations
    +	Removed operation group ProductSettingsOperations
    +	Removed operation group SourceControlOperations
    +	Removed operation group SourceControlsOperations
    +	Removed operation group UpdateOperations
    ⚠️azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.6
    +	Class SecurityInsights no longer has parameter apiVersion
    +	Class SecurityInsights no longer has parameter bookmarkOperations
    +	Class SecurityInsights no longer has parameter bookmarkRelations
    +	Class SecurityInsights no longer has parameter dataConnectorsCheckRequirementsOperations
    +	Class SecurityInsights no longer has parameter domainWhois
    +	Class SecurityInsights no longer has parameter entities
    +	Class SecurityInsights no longer has parameter entitiesGetTimeline
    +	Class SecurityInsights no longer has parameter entitiesRelations
    +	Class SecurityInsights no longer has parameter entityQueries
    +	Class SecurityInsights no longer has parameter entityQueryTemplates
    +	Class SecurityInsights no longer has parameter entityRelations
    +	Class SecurityInsights no longer has parameter fileImports
    +	Class SecurityInsights no longer has parameter iPGeodata
    +	Class SecurityInsights no longer has parameter officeConsents
    +	Class SecurityInsights no longer has parameter productSettings
    +	Class SecurityInsights no longer has parameter sourceControlOperations
    +	Class SecurityInsights no longer has parameter sourceControls
    +	Enum KnownAlertRuleKind no longer has value MLBehaviorAnalytics
    +	Enum KnownAlertRuleKind no longer has value NRT
    +	Enum KnownAlertRuleKind no longer has value ThreatIntelligence
    +	Enum KnownAutomationRulePropertyConditionSupportedProperty no longer has value IncidentCustomDetailsKey
    +	Enum KnownAutomationRulePropertyConditionSupportedProperty no longer has value IncidentCustomDetailsValue
    +	Enum KnownConditionType no longer has value Boolean
    +	Enum KnownConditionType no longer has value PropertyArray
    +	Enum KnownDataConnectorKind no longer has value APIPolling
    +	Enum KnownDataConnectorKind no longer has value AmazonWebServicesS3
    +	Enum KnownDataConnectorKind no longer has value Dynamics365
    +	Enum KnownDataConnectorKind no longer has value GenericUI
    +	Enum KnownDataConnectorKind no longer has value IOT
    +	Enum KnownDataConnectorKind no longer has value MicrosoftThreatIntelligence
    +	Enum KnownDataConnectorKind no longer has value MicrosoftThreatProtection
    +	Enum KnownDataConnectorKind no longer has value Office365Project
    +	Enum KnownDataConnectorKind no longer has value OfficeATP
    +	Enum KnownDataConnectorKind no longer has value OfficeIRM
    +	Enum KnownDataConnectorKind no longer has value OfficePowerBI
    +	Enum KnownDataConnectorKind no longer has value ThreatIntelligenceTaxii
    +	Enum KnownMicrosoftSecurityProductName no longer has value MicrosoftDefenderAdvancedThreatProtection
    +	Enum KnownMicrosoftSecurityProductName no longer has value Office365AdvancedThreatProtection
    +	Interface Bookmark no longer has parameter entityMappings
    +	Interface Bookmark no longer has parameter tactics
    +	Interface Bookmark no longer has parameter techniques
    +	Interface FusionAlertRule no longer has parameter scenarioExclusionPatterns
    +	Interface FusionAlertRule no longer has parameter sourceSettings
    +	Interface FusionAlertRuleTemplate no longer has parameter sourceSettings
    +	Interface Incident no longer has parameter providerIncidentId
    +	Interface Incident no longer has parameter providerName
    +	Interface Incident no longer has parameter teamInformation
    +	Interface IncidentAdditionalData no longer has parameter providerIncidentUrl
    +	Interface IncidentAdditionalData no longer has parameter techniques
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentCommentsListNextOptionalParams no longer has parameter top
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentRelationsListNextOptionalParams no longer has parameter top
    +	Interface IncidentsListNextOptionalParams no longer has parameter filter
    +	Interface IncidentsListNextOptionalParams no longer has parameter orderby
    +	Interface IncidentsListNextOptionalParams no longer has parameter skipToken
    +	Interface IncidentsListNextOptionalParams no longer has parameter top
    +	Interface IoTDeviceEntity no longer has parameter deviceSubType
    +	Interface IoTDeviceEntity no longer has parameter importance
    +	Interface IoTDeviceEntity no longer has parameter isAuthorized
    +	Interface IoTDeviceEntity no longer has parameter isProgramming
    +	Interface IoTDeviceEntity no longer has parameter isScanner
    +	Interface IoTDeviceEntity no longer has parameter nicEntityIds
    +	Interface IoTDeviceEntity no longer has parameter owners
    +	Interface IoTDeviceEntity no longer has parameter purdueLayer
    +	Interface IoTDeviceEntity no longer has parameter sensor
    +	Interface IoTDeviceEntity no longer has parameter site
    +	Interface IoTDeviceEntity no longer has parameter zone
    +	Interface IoTDeviceEntityProperties no longer has parameter deviceSubType
    +	Interface IoTDeviceEntityProperties no longer has parameter importance
    +	Interface IoTDeviceEntityProperties no longer has parameter isAuthorized
    +	Interface IoTDeviceEntityProperties no longer has parameter isProgramming
    +	Interface IoTDeviceEntityProperties no longer has parameter isScanner
    +	Interface IoTDeviceEntityProperties no longer has parameter nicEntityIds
    +	Interface IoTDeviceEntityProperties no longer has parameter owners
    +	Interface IoTDeviceEntityProperties no longer has parameter purdueLayer
    +	Interface IoTDeviceEntityProperties no longer has parameter sensor
    +	Interface IoTDeviceEntityProperties no longer has parameter site
    +	Interface IoTDeviceEntityProperties no longer has parameter zone
    +	Interface MetadataListNextOptionalParams no longer has parameter filter
    +	Interface MetadataListNextOptionalParams no longer has parameter orderby
    +	Interface MetadataListNextOptionalParams no longer has parameter skip
    +	Interface MetadataListNextOptionalParams no longer has parameter top
    +	Interface SecurityInsightsOptionalParams no longer has parameter apiVersion
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter filter
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter orderby
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter skipToken
    +	Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter top
    +	Interface Watchlist no longer has parameter sourceType
    +	Interface WatchlistItemsListNextOptionalParams no longer has parameter skipToken
    +	Interface WatchlistsListNextOptionalParams no longer has parameter skipToken
    +	Parameter logicAppResourceId of interface PlaybookActionProperties is now required
    +	Removed Enum KnownAutomationRuleBooleanConditionSupportedOperator
    +	Removed Enum KnownAutomationRulePropertyArrayConditionSupportedArrayConditionType
    +	Removed Enum KnownAutomationRulePropertyArrayConditionSupportedArrayType
    +	Removed Enum KnownConnectAuthKind
    +	Removed Enum KnownConnectivityType
    +	Removed Enum KnownContentType
    +	Removed Enum KnownCustomEntityQueryKind
    +	Removed Enum KnownDataConnectorAuthorizationState
    +	Removed Enum KnownDataConnectorLicenseState
    +	Removed Enum KnownDeleteStatus
    +	Removed Enum KnownDeploymentFetchStatus
    +	Removed Enum KnownDeploymentResult
    +	Removed Enum KnownDeploymentState
    +	Removed Enum KnownDeviceImportance
    +	Removed Enum KnownEntityItemQueryKind
    +	Removed Enum KnownEntityKind
    +	Removed Enum KnownEntityProviders
    +	Removed Enum KnownEntityQueryKind
    +	Removed Enum KnownEntityQueryTemplateKind
    +	Removed Enum KnownEntityTimelineKind
    +	Removed Enum KnownEntityType
    +	Removed Enum KnownEnum13
    +	Removed Enum KnownFileFormat
    +	Removed Enum KnownFileImportContentType
    +	Removed Enum KnownFileImportState
    +	Removed Enum KnownGetInsightsError
    +	Removed Enum KnownIngestionMode
    +	Removed Enum KnownKind
    +	Removed Enum KnownOutputType
    +	Removed Enum KnownPermissionProviderScope
    +	Removed Enum KnownPollingFrequency
    +	Removed Enum KnownProviderName
    +	Removed Enum KnownRepoType
    +	Removed Enum KnownSettingKind
    +	Removed Enum KnownSettingType
    +	Removed Enum KnownSourceType
    +	Removed Enum KnownThreatIntelligenceResourceKindEnum
    +	Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
    +	Removed Enum KnownUebaDataSources
    +	Removed Enum KnownVersion
    +	Removed operation DataConnectors.connect
    +	Removed operation DataConnectors.disconnect
    +	Removed operation Incidents.createTeam
    +	Removed operation Incidents.runPlaybook
    +	Removed operation group BookmarkOperations
    +	Removed operation group BookmarkRelations
    +	Removed operation group DataConnectorsCheckRequirementsOperations
    +	Removed operation group DomainWhois
    +	Removed operation group Entities
    +	Removed operation group EntitiesGetTimeline
    +	Removed operation group EntitiesRelations
    +	Removed operation group EntityQueries
    +	Removed operation group EntityQueryTemplates
    +	Removed operation group EntityRelations
    +	Removed operation group FileImports
    +	Removed operation group IPGeodata
    +	Removed operation group OfficeConsents
    +	Removed operation group ProductSettings
    +	Removed operation group SourceControlOperations
    +	Removed operation group SourceControls
    +	Type of parameter conditionType of interface AutomationRuleCondition is changed from "Boolean" | "PropertyArrayChanged" | "PropertyArray" | "PropertyChanged" | "Property" to "PropertyArrayChanged" | "PropertyChanged" | "Property"
    +	Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
    +	Type of parameter entityMapping of interface WatchlistItem is changed from {
            [propertyName: string]: any;
        } to Record
    +	Type of parameter itemsKeyValue of interface WatchlistItem is changed from {
            [propertyName: string]: any;
        } to Record
    +	Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
    +	Type of parameter kind of interface MetadataDependencies is changed from Kind to string
    +	Type of parameter kind of interface MetadataModel is changed from Kind to string
    +	Type of parameter kind of interface MetadataPatch is changed from Kind to string
    +	Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
    +	Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
    +	Type of parameter source of interface Watchlist is changed from string to Source
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model AlertDetailsOverride no longer has parameter alert_dynamic_properties
      info	[Changelog]   - Model Bookmark no longer has parameter entity_mappings
      info	[Changelog]   - Model Bookmark no longer has parameter tactics
      info	[Changelog]   - Model Bookmark no longer has parameter techniques
      info	[Changelog]   - Model FusionAlertRule no longer has parameter scenario_exclusion_patterns
      info	[Changelog]   - Model FusionAlertRule no longer has parameter source_settings
      info	[Changelog]   - Model FusionAlertRuleTemplate no longer has parameter source_settings
      info	[Changelog]   - Model Incident no longer has parameter provider_incident_id
      info	[Changelog]   - Model Incident no longer has parameter provider_name
      info	[Changelog]   - Model Incident no longer has parameter team_information
      info	[Changelog]   - Model IncidentAdditionalData no longer has parameter provider_incident_url
      info	[Changelog]   - Model IncidentAdditionalData no longer has parameter techniques
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter device_sub_type
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter importance
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter is_authorized
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter is_programming
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter is_scanner
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter nic_entity_ids
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter owners
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter purdue_layer
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter sensor
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter site
      info	[Changelog]   - Model IoTDeviceEntity no longer has parameter zone
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter device_sub_type
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter importance
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter is_authorized
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter is_programming
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter is_scanner
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter nic_entity_ids
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter owners
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter purdue_layer
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter sensor
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter site
      info	[Changelog]   - Model IoTDeviceEntityProperties no longer has parameter zone
      info	[Changelog]   - Model ScheduledAlertRule no longer has parameter sentinel_entities_mappings
      info	[Changelog]   - Model ScheduledAlertRuleCommonProperties no longer has parameter sentinel_entities_mappings
      info	[Changelog]   - Model ScheduledAlertRuleProperties no longer has parameter sentinel_entities_mappings
      info	[Changelog]   - Model ScheduledAlertRuleTemplate no longer has parameter sentinel_entities_mappings
      info	[Changelog]   - Model Watchlist no longer has parameter source_type
      info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
      info	[Changelog]   - Removed operation DataConnectorsOperations.connect
      info	[Changelog]   - Removed operation DataConnectorsOperations.disconnect
      info	[Changelog]   - Removed operation IncidentsOperations.create_team
      info	[Changelog]   - Removed operation IncidentsOperations.run_playbook
      info	[Changelog]   - Removed operation group BookmarkOperations
      info	[Changelog]   - Removed operation group BookmarkRelationsOperations
      info	[Changelog]   - Removed operation group DataConnectorsCheckRequirementsOperations
      info	[Changelog]   - Removed operation group DomainWhoisOperations
      info	[Changelog]   - Removed operation group EntitiesGetTimelineOperations
      info	[Changelog]   - Removed operation group EntitiesOperations
      info	[Changelog]   - Removed operation group EntitiesRelationsOperations
      info	[Changelog]   - Removed operation group EntityQueriesOperations
      info	[Changelog]   - Removed operation group EntityQueryTemplatesOperations
      info	[Changelog]   - Removed operation group EntityRelationsOperations
      info	[Changelog]   - Removed operation group FileImportsOperations
      info	[Changelog]   - Removed operation group GetOperations
      info	[Changelog]   - Removed operation group GetRecommendationsOperations
      info	[Changelog]   - Removed operation group IPGeodataOperations
      info	[Changelog]   - Removed operation group IncidentTasksOperations
      info	[Changelog]   - Removed operation group OfficeConsentsOperations
      info	[Changelog]   - Removed operation group ProductSettingsOperations
      info	[Changelog]   - Removed operation group SourceControlOperations
      info	[Changelog]   - Removed operation group SourceControlsOperations
      info	[Changelog]   - Removed operation group UpdateOperations
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Interface IoTDeviceEntity no longer has parameter sensor
      info	[Changelog]   - Interface IoTDeviceEntity no longer has parameter site
      info	[Changelog]   - Interface IoTDeviceEntity no longer has parameter zone
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter deviceSubType
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter importance
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter isAuthorized
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter isProgramming
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter isScanner
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter nicEntityIds
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter owners
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter purdueLayer
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter sensor
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter site
      info	[Changelog]   - Interface IoTDeviceEntityProperties no longer has parameter zone
      info	[Changelog]   - Interface MetadataListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface MetadataListNextOptionalParams no longer has parameter orderby
      info	[Changelog]   - Interface MetadataListNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface MetadataListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface SecurityInsightsOptionalParams no longer has parameter apiVersion
      info	[Changelog]   - Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter orderby
      info	[Changelog]   - Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface ThreatIntelligenceIndicatorsListNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface Watchlist no longer has parameter sourceType
      info	[Changelog]   - Interface WatchlistItemsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface WatchlistsListNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Parameter logicAppResourceId of interface PlaybookActionProperties is now required
      info	[Changelog]   - Type of parameter conditionType of interface AutomationRuleCondition is changed from "Boolean" | "PropertyArrayChanged" | "PropertyArray" | "PropertyChanged" | "Property" to "PropertyArrayChanged" | "PropertyChanged" | "Property"
      info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
      info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
      info	[Changelog]   - Type of parameter kind of interface MetadataDependencies is changed from Kind to string
      info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
      info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
      info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
      info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
      info	[Changelog]   - Type of parameter source of interface Watchlist is changed from string to Source
      info	[Changelog]   - Type of parameter entityMapping of interface WatchlistItem is changed from {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     } to Record<string, unknown>
      info	[Changelog]   - Type of parameter itemsKeyValue of interface WatchlistItem is changed from {
      info	[Changelog]         [propertyName: string]: any;
      info	[Changelog]     } to Record<string, unknown>
      info	[Changelog]   - Class SecurityInsights no longer has parameter apiVersion
      info	[Changelog]   - Class SecurityInsights no longer has parameter bookmarkOperations
      info	[Changelog]   - Class SecurityInsights no longer has parameter bookmarkRelations
      info	[Changelog]   - Class SecurityInsights no longer has parameter dataConnectorsCheckRequirementsOperations
      info	[Changelog]   - Class SecurityInsights no longer has parameter domainWhois
      info	[Changelog]   - Class SecurityInsights no longer has parameter entities
      info	[Changelog]   - Class SecurityInsights no longer has parameter entitiesGetTimeline
      info	[Changelog]   - Class SecurityInsights no longer has parameter entitiesRelations
      info	[Changelog]   - Class SecurityInsights no longer has parameter entityQueries
      info	[Changelog]   - Class SecurityInsights no longer has parameter entityQueryTemplates
      info	[Changelog]   - Class SecurityInsights no longer has parameter entityRelations
      info	[Changelog]   - Class SecurityInsights no longer has parameter fileImports
      info	[Changelog]   - Class SecurityInsights no longer has parameter iPGeodata
      info	[Changelog]   - Class SecurityInsights no longer has parameter officeConsents
      info	[Changelog]   - Class SecurityInsights no longer has parameter productSettings
      info	[Changelog]   - Class SecurityInsights no longer has parameter sourceControlOperations
      info	[Changelog]   - Class SecurityInsights no longer has parameter sourceControls
      info	[Changelog]   - Removed Enum KnownAutomationRuleBooleanConditionSupportedOperator
      info	[Changelog]   - Removed Enum KnownAutomationRulePropertyArrayConditionSupportedArrayConditionType
      info	[Changelog]   - Removed Enum KnownAutomationRulePropertyArrayConditionSupportedArrayType
      info	[Changelog]   - Removed Enum KnownConnectAuthKind
      info	[Changelog]   - Removed Enum KnownConnectivityType
      info	[Changelog]   - Removed Enum KnownContentType
      info	[Changelog]   - Removed Enum KnownCustomEntityQueryKind
      info	[Changelog]   - Removed Enum KnownDataConnectorAuthorizationState
      info	[Changelog]   - Removed Enum KnownDataConnectorLicenseState
      info	[Changelog]   - Removed Enum KnownDeleteStatus
      info	[Changelog]   - Removed Enum KnownDeploymentFetchStatus
      info	[Changelog]   - Removed Enum KnownDeploymentResult
      info	[Changelog]   - Removed Enum KnownDeploymentState
      info	[Changelog]   - Removed Enum KnownDeviceImportance
      info	[Changelog]   - Removed Enum KnownEntityItemQueryKind
      info	[Changelog]   - Removed Enum KnownEntityKind
      info	[Changelog]   - Removed Enum KnownEntityProviders
      info	[Changelog]   - Removed Enum KnownEntityQueryKind
      info	[Changelog]   - Removed Enum KnownEntityQueryTemplateKind
      info	[Changelog]   - Removed Enum KnownEntityTimelineKind
      info	[Changelog]   - Removed Enum KnownEntityType
      info	[Changelog]   - Removed Enum KnownEnum13
      info	[Changelog]   - Removed Enum KnownFileFormat
      info	[Changelog]   - Removed Enum KnownFileImportContentType
      info	[Changelog]   - Removed Enum KnownFileImportState
      info	[Changelog]   - Removed Enum KnownGetInsightsError
      info	[Changelog]   - Removed Enum KnownIngestionMode
      info	[Changelog]   - Removed Enum KnownKind
      info	[Changelog]   - Removed Enum KnownOutputType
      info	[Changelog]   - Removed Enum KnownPermissionProviderScope
      info	[Changelog]   - Removed Enum KnownPollingFrequency
      info	[Changelog]   - Removed Enum KnownProviderName
      info	[Changelog]   - Removed Enum KnownRepoType
      info	[Changelog]   - Removed Enum KnownSettingKind
      info	[Changelog]   - Removed Enum KnownSettingType
      info	[Changelog]   - Removed Enum KnownSourceType
      info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
      info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
      info	[Changelog]   - Removed Enum KnownUebaDataSources
      info	[Changelog]   - Removed Enum KnownVersion
      info	[Changelog]   - Enum KnownAlertRuleKind no longer has value MLBehaviorAnalytics
      info	[Changelog]   - Enum KnownAlertRuleKind no longer has value NRT
      info	[Changelog]   - Enum KnownAlertRuleKind no longer has value ThreatIntelligence
      info	[Changelog]   - Enum KnownAutomationRulePropertyConditionSupportedProperty no longer has value IncidentCustomDetailsKey
      info	[Changelog]   - Enum KnownAutomationRulePropertyConditionSupportedProperty no longer has value IncidentCustomDetailsValue
      info	[Changelog]   - Enum KnownConditionType no longer has value Boolean
      info	[Changelog]   - Enum KnownConditionType no longer has value PropertyArray
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value AmazonWebServicesS3
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value APIPolling
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value Dynamics365
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value GenericUI
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value IOT
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value MicrosoftThreatIntelligence
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value MicrosoftThreatProtection
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value Office365Project
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value OfficeATP
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value OfficeIRM
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value OfficePowerBI
      info	[Changelog]   - Enum KnownDataConnectorKind no longer has value ThreatIntelligenceTaxii
      info	[Changelog]   - Enum KnownMicrosoftSecurityProductName no longer has value MicrosoftDefenderAdvancedThreatProtection
      info	[Changelog]   - Enum KnownMicrosoftSecurityProductName no longer has value Office365AdvancedThreatProtection
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-securityinsights [View full logs]  [Preview SDK Changes]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • securityinsights/resource-manager [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 993f9c0f2421ed382840078ea42a7ebee6e7d9b5. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.securityinsights [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    .Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
    JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/5ff8e402b8ea4d448b191d14e8acb60f

    Hi @samuelkuangms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    The PR is not ready for review.

    samuelkuangms avatar Jan 11 '23 23:01 samuelkuangms