Azure
[Cognitive Services - Language] - Text CustomHealth - public preview
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Hi, @kayousef Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 584 Errors, 26 Warnings failed [Detail]
Only 0 items are rendered, please refer to log for more details.
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌Breaking Change(Cross-Version): 36 Errors, 38 Warnings failed [Detail]
Only 0 items are rendered, please refer to log for more details.
The following breaking changes are detected by comparison with the latest stable version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
The following breaking changes are detected by comparison with the latest preview version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
Only 0 items are rendered, please refer to log for more details.
️❌Avocado: 19 Errors, 11 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌ModelValidation: 551 Errors, 0 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌SemanticValidation: 16 Errors, 0 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your contribution kayousef! We will review the pull request and get back to you soon.
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️⚠️SDK Breaking Change Tracking warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-net-track2 failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-sdk-for-python warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-js failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-java failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-powershell failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-sdk-for-net failed [Detail]
Only 0 items are rendered, please refer to log for more details.
Generated ApiView
Hi @kayousef, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi @kayousef, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I would rather not do the API version bump here to simplify things but I don't feel strongly about it. I left a couple minor remarks but otherwise looks good to me. I did regenerate the JS SDK with it and it looks good.
Definitely. Once the other PR with the version rename merges, I'll rebase this so it will only has custom health changes.
Hi @kayousef, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
Replaced with this PR https://github.com/kayousef/azure-rest-api-specs/pull/1