azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Dev hybridcompute microsoft.hybrid compute 2022 12 27 preview

Open shubhammalhotra28 opened this issue 2 years ago • 10 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

shubhammalhotra28 avatar Jan 03 '23 21:01 shubhammalhotra28

Hi, @shubhammalhotra28 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 10 Errors, 10 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    HybridCompute.json 2022-12-27-preview(bbc20c3) 2022-11-10(main)
    HybridCompute.json 2022-12-27-preview(bbc20c3) 2022-08-11-preview(main)
    privateLinkScopes.json 2022-12-27-preview(bbc20c3) 2022-11-10(main)
    privateLinkScopes.json 2022-12-27-preview(bbc20c3) 2022-08-11-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L54:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L54:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L110:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L107:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L166:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L160:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L213:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L204:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L351:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L339:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L418:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L403:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L500:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L482:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L573:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L552:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L629:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L605:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L694:11
    Old: Microsoft.HybridCompute/stable/2022-11-10/HybridCompute.json#L667:11


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L54:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L54:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L110:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L107:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L166:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L160:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L213:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L204:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L351:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L339:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L418:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L403:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L500:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L467:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L573:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L522:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L629:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L575:11
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L694:11
    Old: Microsoft.HybridCompute/preview/2022-08-11-preview/HybridCompute.json#L637:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 3 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-12 package-preview-2022-12(bbc20c3) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    :warning: PageableOperation Based on the response model schema, operation 'NetworkProfile_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L912
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkProfileModel'. Consider using the plural form of 'NetworkProfile' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L916
    :warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L1247


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'extensionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L340
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L341
    LongRunningResponseStatusCode A 'put' operation 'MachineExtensions_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L341
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L384
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L391
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L391
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L490
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L678
    BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'Machine' has extra properties ['resources'].
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L1497
    ArmResourcePropertiesBag Top level property names should not be repeated inside the properties bag for ARM resource 'MachineExtension'. Properties [properties.type] conflict with ARM top level properties. Please rename these.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L1576
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L115
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L116
    LongRunningResponseStatusCode A 'delete' operation 'PrivateLinkScopes_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L116
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L311
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L356
    ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L356
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L401
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L401
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L449
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L484
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L491
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L491
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L508
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L575
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L659
    ResourceNameRestriction The resource name parameter 'machineName' should be defined with a 'pattern' restriction.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/privateLinkScopes.json#L659
    :warning: PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Machines_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L38
    :warning: PageableOperation Based on the response model schema, operation 'Machines_Get' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L197
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Machines by resource group
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L330
    :warning: PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'MachineExtensions_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.HybridCompute/preview/2022-12-27-preview/HybridCompute.json#L341
    ️❌Avocado: 5 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/machines/{}/reconnect is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/hybridcompute/resource-manager/readme.md
    json: Microsoft.HybridCompute/preview/2019-08-02/HybridCompute.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/machines/{}/assessPatches is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/hybridcompute/resource-manager/readme.md
    json: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/machines/{}/installPatches is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/hybridcompute/resource-manager/readme.md
    json: Microsoft.HybridCompute/preview/2020-08-15-preview/HybridCompute.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/privateLinkScopes/{}/scopedResources/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/hybridcompute/resource-manager/readme.md
    json: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HybridCompute/privateLinkScopes/{}/scopedResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/hybridcompute/resource-manager/readme.md
    json: Microsoft.HybridCompute/preview/2020-08-15-preview/privateLinkScopes.json
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.HybridCompute' for api version '2022-12-27-preview'. The supported api-versions are '2019-03-18-preview,
    2019-08-02-preview,
    2019-12-12,
    2020-03-11-preview,
    2020-07-30-preview,
    2020-08-02,
    2020-08-15-preview,
    2021-01-28-preview,
    2021-03-25-preview,
    2021-04-22-preview,
    2021-05-20,
    2021-05-17-preview,
    2021-06-10-preview,
    2021-12-10-preview,
    2022-03-10,
    2022-05-10-preview,
    2022-08-11-preview,
    2022-11-10'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-js - @azure/arm-hybridcompute - 4.0.0-beta.1
    +	Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 760 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.HybridCompute [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-hybridcompute [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group NetworkProfileOperations
      info	[Changelog]   - Model Machine has a new parameter agent_upgrade
      info	[Changelog]   - Model Machine has a new parameter extensions
      info	[Changelog]   - Model MachineUpdate has a new parameter agent_upgrade
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-hybridcompute [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New type alias `AgentConfigurationMode` with values `AgentConfigurationModeFull`, `AgentConfigurationModeMonitor`
      info	[Changelog] - New type alias `LastAttemptStatusEnum` with values `LastAttemptStatusEnumFailed`, `LastAttemptStatusEnumSuccess`
      info	[Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)`
      info	[Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)`
      info	[Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]`
      info	[Changelog] - New function `NewNetworkProfileClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkProfileClient, error)`
      info	[Changelog] - New function `*NetworkProfileClient.Get(context.Context, string, string, *NetworkProfileClientGetOptions) (NetworkProfileClientGetResponse, error)`
      info	[Changelog] - New struct `AgentUpgrade`
      info	[Changelog] - New struct `ErrorDetailAutoGenerated`
      info	[Changelog] - New struct `ErrorResponseAutoGenerated`
      info	[Changelog] - New struct `ExtensionMetadataClient`
      info	[Changelog] - New struct `ExtensionMetadataClientListResponse`
      info	[Changelog] - New struct `ExtensionValue`
      info	[Changelog] - New struct `ExtensionValueListResult`
      info	[Changelog] - New struct `ExtensionValueProperties`
      info	[Changelog] - New struct `IPAddress`
      info	[Changelog] - New struct `NetworkInterface`
      info	[Changelog] - New struct `NetworkProfile`
      info	[Changelog] - New struct `NetworkProfileClient`
      info	[Changelog] - New struct `Subnet`
      info	[Changelog] - New field `ConfigMode` in struct `AgentConfiguration`
      info	[Changelog] - New field `Resources` in struct `Machine`
      info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties`
      info	[Changelog] - New field `AgentUpgrade` in struct `MachineProperties`
      info	[Changelog] - New field `AgentUpgrade` in struct `MachineUpdateProperties`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 45 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-hybridcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ExtensionMetadata
      info	[Changelog]   - Added operation group NetworkProfileOperations
      info	[Changelog]   - Added Interface AgentConfiguration
      info	[Changelog]   - Added Interface AgentUpgrade
      info	[Changelog]   - Added Interface CloudMetadata
      info	[Changelog]   - Added Interface ConfigurationExtension
      info	[Changelog]   - Added Interface ErrorDetailAutoGenerated
      info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
      info	[Changelog]   - Added Interface ExtensionMetadataGetOptionalParams
      info	[Changelog]   - Added Interface ExtensionMetadataListOptionalParams
      info	[Changelog]   - Added Interface ExtensionValue
      info	[Changelog]   - Added Interface ExtensionValueListResult
      info	[Changelog]   - Added Interface HybridComputeManagementClientUpgradeExtensionsHeaders
      info	[Changelog]   - Added Interface HybridComputePrivateLinkScope
      info	[Changelog]   - Added Interface IpAddress
      info	[Changelog]   - Added Interface Machine
      info	[Changelog]   - Added Interface MachineExtension
      info	[Changelog]   - Added Interface MachineExtensionsDeleteHeaders
      info	[Changelog]   - Added Interface MachineExtensionsUpdateHeaders
      info	[Changelog]   - Added Interface MachineExtensionUpdate
      info	[Changelog]   - Added Interface MachineUpdate
      info	[Changelog]   - Added Interface NetworkInterface
      info	[Changelog]   - Added Interface NetworkProfile
      info	[Changelog]   - Added Interface NetworkProfileGetOptionalParams
      info	[Changelog]   - Added Interface OSProfileLinuxConfiguration
      info	[Changelog]   - Added Interface OSProfileWindowsConfiguration
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateEndpointConnectionDataModel
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface PrivateLinkScopesDeleteHeaders
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface ServiceStatus
      info	[Changelog]   - Added Interface ServiceStatuses
      info	[Changelog]   - Added Interface Subnet
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Type Alias AgentConfigurationMode
      info	[Changelog]   - Added Type Alias AssessmentModeTypes
      info	[Changelog]   - Added Type Alias ExtensionMetadataGetResponse
      info	[Changelog]   - Added Type Alias ExtensionMetadataListResponse
      info	[Changelog]   - Added Type Alias LastAttemptStatusEnum
      info	[Changelog]   - Added Type Alias NetworkProfileGetResponse
      info	[Changelog]   - Added Type Alias PatchModeTypes
      info	[Changelog]   - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections
      info	[Changelog]   - Interface OperationValue has a new optional parameter isDataAction
      info	[Changelog]   - Interface OSProfile has a new optional parameter linuxConfiguration
      info	[Changelog]   - Interface OSProfile has a new optional parameter windowsConfiguration
      info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownAgentConfigurationMode
      info	[Changelog]   - Added Enum KnownAssessmentModeTypes
      info	[Changelog]   - Added Enum KnownLastAttemptStatusEnum
      info	[Changelog]   - Added Enum KnownPatchModeTypes
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface MachineExtensionsListNextOptionalParams no longer has parameter expand
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️hybridcompute [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 794b03f1b40b6f7646528fbe06bcfce7b58223a9. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.HybridCompute [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/hybridcompute/armhybridcompute https://apiview.dev/Assemblies/Review/c19ea7be2d9840d9bc27d9f912b02979
    Java azure-resourcemanager-hybridcompute https://apiview.dev/Assemblies/Review/043e6b82f1324f5aae280ca0fe71bee0
    JavaScript @azure/arm-hybridcompute https://apiview.dev/Assemblies/Review/f1ea7757517041a6b40dfc524ad4fdfc

    Hi @shubhammalhotra28 and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected].

    Hi, @shubhammalhotra28, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Hi @shubhammalhotra28, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @shubhammalhotra28 - Can you please review and fix failed checks such as PrettierCheck, Lintdiff etc

    raghushantha avatar Jan 06 '23 20:01 raghushantha

    Hi @shubhammalhotra28, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    image For ARM and swagger team review: FYI those API are intentionally deleted

    dorothyhu avatar Jan 12 '23 00:01 dorothyhu

    Signed off from ARM side with minor comment

    raosuhas avatar Jan 18 '23 22:01 raosuhas

    @shubhammalhotra28 Please fix the Avocado errors, details can be found via https://github.com/Azure/azure-rest-api-specs/pull/22034#issuecomment-1370250196 And also, deploy the latest version of your service to fix ApiReadinessCheck.

    live1206 avatar Jan 29 '23 08:01 live1206

    /azp run

    live1206 avatar Jan 29 '23 08:01 live1206

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jan 29 '23 08:01 azure-pipelines[bot]

    /azp run

    live1206 avatar Jan 29 '23 12:01 live1206

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jan 29 '23 12:01 azure-pipelines[bot]

    @tadelesh Could you help to review the breaking change of go? Thanks!

    live1206 avatar Jan 30 '23 01:01 live1206

    @qiaozha Could you help to review the breaking change of JS? Thanks!

    live1206 avatar Jan 30 '23 01:01 live1206

    /azp run

    live1206 avatar Jan 31 '23 01:01 live1206

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jan 31 '23 01:01 azure-pipelines[bot]

    /azp run

    live1206 avatar Jan 31 '23 02:01 live1206

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jan 31 '23 02:01 azure-pipelines[bot]