azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Event Hub Geo DR - New API version 2023-01-01-preview

Open dsouzaarun opened this issue 2 years ago • 31 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [X] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [X] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [X] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [X] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

dsouzaarun avatar Dec 27 '22 21:12 dsouzaarun

Hi, @dsouzaarun Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    definitions.json 1.0(d92cb5e) 1.0(main)
    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: resource-manager/common/v1/definitions.json#L149:5
    Old: resource-manager/common/v1/definitions.json#L149:5
    ️❌Breaking Change(Cross-Version): 45 Errors, 48 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    ApplicationGroups.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    AuthorizationRules.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    AuthorizationRules.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    AvailableClusterRegions-preview.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    AvailableClusterRegions-preview.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    CheckNameAvailability.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    CheckNameAvailability.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    Clusters-preview.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    Clusters-preview.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    SchemaRegistry.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    SchemaRegistry.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    consumergroups.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    consumergroups.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    disasterRecoveryConfigs.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    disasterRecoveryConfigs.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    eventhubs.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    eventhubs.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    networkrulessets-preview.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    networkrulessets-preview.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    operations.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    operations.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)
    quotaConfiguration-preview.json 2023-01-01-preview(d92cb5e) 2021-11-01(main)
    quotaConfiguration-preview.json 2023-01-01-preview(d92cb5e) 2022-10-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 21 items are listed, please refer to log for more details.

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L49:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L49:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L94:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L94:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L146:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L146:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L189:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L189:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L234:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L234:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L279:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L279:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L333:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L333:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L381:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L381:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L429:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L429:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L477:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L477:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L525:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L525:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L580:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L580:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L626:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L626:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L674:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L674:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L722:9
    Old: Microsoft.EventHub/stable/2021-11-01/AuthorizationRules.json#L722:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: resource-manager/common/v1/definitions.json#L149:5
    Old: resource-manager/common/v1/definitions.json#L149:5
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/SchemaRegistry.json#L49:9
    Old: Microsoft.EventHub/stable/2021-11-01/SchemaRegistry.json#L49:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/SchemaRegistry.json#L100:9
    Old: Microsoft.EventHub/stable/2021-11-01/SchemaRegistry.json#L100:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/SchemaRegistry.json#L152:9
    Old: Microsoft.EventHub/stable/2021-11-01/SchemaRegistry.json#L152:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/SchemaRegistry.json#L195:9
    Old: Microsoft.EventHub/stable/2021-11-01/SchemaRegistry.json#L195:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: resource-manager/common/v1/definitions.json#L149:5
    Old: resource-manager/common/v1/definitions.json#L149:5


    The following breaking changes are detected by comparison with the latest preview version:

    Only 21 items are listed, please refer to log for more details.

    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/d92cb5e8f8e2d4b5d08ee66ba91ab76b4e038f34/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json",
    "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Schema violation: Data does not match any schemas from 'oneOf'\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json:334:10 ($.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.EventHub/namespaces/namespaceName/failover"].post["x-ms-examples"].NameSpaceCreate)\nFATAL: swagger-document/individual/schema-validator - FAILED\nFATAL: Error: [OperationAbortedException] Error occurred. Exiting.\nProcess() cancelled due to exception :"
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L49:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L49:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L95:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L95:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L147:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L147:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L190:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/ApplicationGroups.json#L190:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: resource-manager/common/v1/definitions.json#L149:5
    Old: resource-manager/common/v1/definitions.json#L149:5
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L49:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L49:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L94:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L94:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L146:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L146:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L189:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L189:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L234:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L234:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L279:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L279:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L333:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L333:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L381:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L381:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L429:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L429:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L477:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L477:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L525:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L525:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L580:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L580:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L626:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L626:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L674:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L674:9
    :warning: 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L722:9
    Old: Microsoft.EventHub/preview/2022-10-01-preview/AuthorizationRules.json#L722:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-2021-01-preview package-2021-01-preview(d92cb5e) package-2021-01-preview(main)
    package-2017-04 package-2017-04(d92cb5e) package-2017-04(main)
    profile-hybrid-2020-09-01 profile-hybrid-2020-09-01(d92cb5e) profile-hybrid-2020-09-01(main)
    package-2021-06-preview package-2021-06-preview(d92cb5e) package-2021-06-preview(main)
    package-2021-11 package-2021-11(d92cb5e) package-2021-11(main)
    package-2022-01-preview package-2022-01-preview(d92cb5e) package-2022-01-preview(main)
    package-2022-10-preview package-2022-10-preview(d92cb5e) package-2022-10-preview(main)
    package-2023-01-preview package-2023-01-preview(d92cb5e) default(main)
    package-2018-01-preview package-2018-01-preview(d92cb5e) package-2018-01-preview(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    :warning: ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json#L339
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json#L968
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json#L977
    :warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json#L1385


    The following errors/warnings exist before current PR submission:

    Only 21 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'applicationGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L82
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L83
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ApplicationGroup' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L87
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L121
    TrackedResourcePatchOperation Tracked resource 'ApplicationGroup' must have patch operation that at least supports the update of tags.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L243
    SystemDataDefinitionsCommonTypes System data references must utilize common types.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/ApplicationGroups.json#L274
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L82
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L83
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L120
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L222
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L267
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L369
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L417
    ResourceNameRestriction The resource name parameter 'eventHubName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L465
    ResourceNameRestriction The resource name parameter 'eventHubName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L513
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L513
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L514
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L554
    ResourceNameRestriction The resource name parameter 'eventHubName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L662
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L662
    ResourceNameRestriction The resource name parameter 'eventHubName' should be defined with a 'pattern' restriction.
    Location: Microsoft.EventHub/preview/2023-01-01-preview/AuthorizationRules.json#L710
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 712 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 805 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 712 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.EventHubs [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-eventhub [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration has a new parameter location
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-eventhubs-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/eventhub/armeventhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - `CleanupPolicyRetentionDescriptionCompaction` from enum `CleanupPolicyRetentionDescription` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `CleanupPolicyRetentionDescriptionCompact` added to enum type `CleanupPolicyRetentionDescription`
      info	[Changelog] - New enum type `CaptureIdentityType` with values `CaptureIdentityTypeSystemAssigned`, `CaptureIdentityTypeUserAssigned`
      info	[Changelog] - New enum type `GeoDRRoleType` with values `GeoDRRoleTypePrimary`, `GeoDRRoleTypeSecondary`
      info	[Changelog] - New enum type `ProvisioningState` with values `ProvisioningStateActive`, `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateScaling`, `ProvisioningStateSucceeded`, `ProvisioningStateUnknown`
      info	[Changelog] - New function `*NamespacesClient.BeginFailover(context.Context, string, string, FailOver, *NamespacesClientBeginFailoverOptions) (*runtime.Poller[NamespacesClientFailoverResponse], error)`
      info	[Changelog] - New struct `CaptureIdentity`
      info	[Changelog] - New struct `ErrorDetailAutoGenerated`
      info	[Changelog] - New struct `ErrorResponseAutoGenerated`
      info	[Changelog] - New struct `FailOver`
      info	[Changelog] - New struct `FailOverProperties`
      info	[Changelog] - New struct `GeoDataReplicationProperties`
      info	[Changelog] - New struct `NamespaceReplicaLocation`
      info	[Changelog] - New field `ProvisioningState` in struct `ClusterProperties`
      info	[Changelog] - New field `Identity` in struct `Destination`
      info	[Changelog] - New field `GeoDataReplication` in struct `EHNamespaceProperties`
      info	[Changelog] - New field `Location` in struct `NetworkSecurityPerimeterConfiguration`
      info	[Changelog] - New field `ApplicableFeatures`, `IsBackingResource`, `ParentAssociationName`, `SourceResourceID` in struct `NetworkSecurityPerimeterConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 36 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-eventhub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group ApplicationGroupOperations
      info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
      info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
      info	[Changelog]   - Added operation Namespaces.beginFailover
      info	[Changelog]   - Added operation Namespaces.beginFailoverAndWait
      info	[Changelog]   - Added Interface ApplicationGroup
      info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
      info	[Changelog]   - Added Interface ApplicationGroupListResult
      info	[Changelog]   - Added Interface ApplicationGroupPolicy
      info	[Changelog]   - Added Interface CaptureIdentity
      info	[Changelog]   - Added Interface ErrorDetailAutoGenerated
      info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
      info	[Changelog]   - Added Interface FailOver
      info	[Changelog]   - Added Interface GeoDataReplicationProperties
      info	[Changelog]   - Added Interface NamespaceReplicaLocation
      info	[Changelog]   - Added Interface NamespacesFailoverHeaders
      info	[Changelog]   - Added Interface NamespacesFailoverOptionalParams
      info	[Changelog]   - Added Interface NetworkSecurityPerimeter
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface NspAccessRule
      info	[Changelog]   - Added Interface NspAccessRuleProperties
      info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
      info	[Changelog]   - Added Interface ProvisioningIssue
      info	[Changelog]   - Added Interface ProvisioningIssueProperties
      info	[Changelog]   - Added Interface RetentionDescription
      info	[Changelog]   - Added Interface ThrottlingPolicy
      info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
      info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
      info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
      info	[Changelog]   - Added Type Alias CaptureIdentityType
      info	[Changelog]   - Added Type Alias CleanupPolicyRetentionDescription
      info	[Changelog]   - Added Type Alias GeoDRRoleType
      info	[Changelog]   - Added Type Alias MetricId
      info	[Changelog]   - Added Type Alias NamespacesFailoverResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
      info	[Changelog]   - Added Type Alias NspAccessRuleDirection
      info	[Changelog]   - Added Type Alias ProvisioningState
      info	[Changelog]   - Added Type Alias PublicNetworkAccess
      info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
      info	[Changelog]   - Added Type Alias TlsVersion
      info	[Changelog]   - Interface Cluster has a new optional parameter provisioningState
      info	[Changelog]   - Interface Cluster has a new optional parameter supportsScaling
      info	[Changelog]   - Interface Destination has a new optional parameter identity
      info	[Changelog]   - Interface EHNamespace has a new optional parameter geoDataReplication
      info	[Changelog]   - Interface EHNamespace has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Interface EHNamespace has a new optional parameter publicNetworkAccess
      info	[Changelog]   - Interface Eventhub has a new optional parameter retentionDescription
      info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
      info	[Changelog]   - Added Enum KnownCleanupPolicyRetentionDescription
      info	[Changelog]   - Added Enum KnownGeoDRRoleType
      info	[Changelog]   - Added Enum KnownMetricId
      info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
      info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
      info	[Changelog]   - Added Enum KnownProvisioningState
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
      info	[Changelog]   - Added Enum KnownTlsVersion
      info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
      info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
      info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️eventhub [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 01ae995b35fa5d29433d57bcc0ff508ae8f4bbcc. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.eventhub.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.eventhub.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/eventhub/armeventhub https://apiview.dev/Assemblies/Review/6b3907f88c1e4e4cbc45edb5c83c19c3
    Java azure-resourcemanager-eventhubs-generated https://apiview.dev/Assemblies/Review/6debd7877bb34a1d88c9174114892dc6
    JavaScript @azure/arm-eventhub https://apiview.dev/Assemblies/Review/232ee05f667f41368d8d7b43ac8f01c9

    Hi @dsouzaarun, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Hi @dsouzaarun, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi, @dsouzaarun, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jan 22 '23 16:01 ghost

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Feb 19 '23 16:02 ghost

    Hi, @dsouzaarun. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Mar 06 '23 05:03 ghost

    Change is still necessary. Reactivating this PR

    dsouzaarun avatar Mar 13 '23 23:03 dsouzaarun

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Apr 02 '23 16:04 ghost

    /azp run

    damodaravadhani avatar Apr 18 '23 18:04 damodaravadhani

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Apr 18 '23 18:04 azure-pipelines[bot]

    /azp run

    damodaravadhani avatar Apr 19 '23 05:04 damodaravadhani

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Apr 19 '23 05:04 azure-pipelines[bot]

    Patch model should be recreated with just the properties that can be updated. We recommend Patch model to be different from GET


    Refers to: specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json:1505 in b851ece. [](commit_id = b851ececeed7b1119302b7c7a30508a895362882, deletion_comment = False)

    sjanamma avatar Apr 21 '23 01:04 sjanamma

    Put cannot have 202 response code. Please remove it.


    Refers to: specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json:1505 in b851ece. [](commit_id = b851ececeed7b1119302b7c7a30508a895362882, deletion_comment = False)

    sjanamma avatar Apr 21 '23 01:04 sjanamma

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar May 14 '23 16:05 ghost

    Hi, @dsouzaarun. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar May 29 '23 05:05 ghost

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jun 18 '23 16:06 ghost

    Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - https://aka.ms/azsdk/support/specreview-channel.
    Please indicate that this is an ARM-related question in the title of your post by including "[ARM Query]" in the title.

    Hi @dsouzaarun! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    Patch model should be recreated with just the properties that can be updated. We recommend Patch model to be different from GET

    Refers to: specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json:1505 in b851ece. [](commit_id = b851ece, deletion_comment = False)

    Hey @sjanamma this is older API, Changes is this may results in breaking change.

    schaudhari6254888 avatar Jul 10 '23 11:07 schaudhari6254888

    Put cannot have 202 response code. Please remove it.

    Refers to: specification/eventhub/resource-manager/Microsoft.EventHub/preview/2023-01-01-preview/namespaces-preview.json:1505 in b851ece. [](commit_id = b851ece, deletion_comment = False)

    Hey @sjanamma this is older API, Changes is this may results in breaking change.

    schaudhari6254888 avatar Jul 10 '23 11:07 schaudhari6254888

    @schaudhari6254888 Did you add the previous version as the base commit ? This is explained in the checklist above :

    image

    I cant really review this PR in the current form since I cant make out the diff with the previous version

    raosuhas avatar Jul 10 '23 19:07 raosuhas

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

    @schaudhari6254888 Did you add the previous version as the base commit ? This is explained in the checklist above :

    image

    I cant really review this PR in the current form since I cant make out the diff with the previous version

    Hey @raosuhas , @sjanamma already reviewed the PR. We have responded all the comments. If this PR is unclear to you do you want to close this & create a new fresh PR for the same.

    schaudhari6254888 avatar Jul 11 '23 07:07 schaudhari6254888

    @schaudhari6254888 Did you add the previous version as the base commit ? This is explained in the checklist above : image I cant really review this PR in the current form since I cant make out the diff with the previous version

    Hey @raosuhas , @sjanamma already reviewed the PR. We have responded all the comments. If this PR is unclear to you do you want to close this & create a new fresh PR for the same.

    Hey @raosuhas, can we have any updates on this. thank you!

    schaudhari6254888 avatar Jul 13 '23 10:07 schaudhari6254888