azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Storage: local user `PermissionScope` add enums for `service`

Open magodo opened this issue 1 year ago • 56 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

magodo avatar Dec 12 '22 02:12 magodo

Hi, @magodo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Dec 12 '22 02:12 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    storage.json 2022-05-01(d86a46a) 2022-05-01(main)
    storage.json 2022-09-01(d86a46a) 2022-09-01(main)
    Rule Message
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Storage/stable/2022-05-01/storage.json#L5056:9
    Old: Microsoft.Storage/stable/2022-05-01/storage.json#L5056:9
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Storage/stable/2022-09-01/storage.json#L5134:9
    Old: Microsoft.Storage/stable/2022-09-01/storage.json#L5134:9
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2022-09 package-2022-09(d86a46a) package-2022-09(main)
    package-2022-05 package-2022-05(d86a46a) package-2022-05(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'BlobContainers_List' does not match the response definition in the individual GET operation 'BlobContainers_Get' .
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L18
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'FileShares_List' does not match the response definition in the individual GET operation 'FileShares_Get' .
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L18
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Queue_List' does not match the response definition in the individual GET operation 'Queue_Get' .
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L18
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L36
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L36
    ❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Storage/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L39
    ❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L40
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L69
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L69
    ❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L72
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L111
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L111
    ❌ ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L121
    ❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L122
    ❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'StorageAccounts_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L122
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L189
    ❌ PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L189
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L189
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L196
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L227
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L227
    ❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L256
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L285
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L285
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L349
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L349
    ❌ ResourceNameRestriction The resource name parameter 'deletedAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L398
    ❌ ParametersOrder The parameters:deletedAccountName,location should be kept in the same order as they present in the path.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L399
    ❌ MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L464
    ❌ RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Storage/stable/2022-05-01/storage.json#L464
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 85 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L20:14
    ExampleUrl: stable/2022-05-01/examples/OperationsList.json#L2:17
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: api-version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L559:28
    ExampleUrl: stable/2022-05-01/examples/OperationsList.json#L3:20
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L50:14
    ExampleUrl: stable/2022-05-01/examples/SKUList.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L83:15
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCheckNameAvailability.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreate.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/NfsV3AccountCreate.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateUserAssignedEncryptionIdentityWithCMK.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateWithImmutabilityPolicy.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateDisallowPublicNetworkAccess.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateEnablePublicNetworkAccess.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateUserAssignedIdentityWithFederatedIdentityClientId.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateAllowedCopyScopeToPrivateLink.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateAllowedCopyScopeToAAD.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreatePremiumBlockBlobStorage.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateDnsEndpointTypeToAzureDnsZone.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L122:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountCreateDnsEndpointTypeToStandard.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L202:17
    ExampleUrl: stable/2022-05-01/examples/StorageAccountDelete.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L236:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountGetProperties.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L236:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountGetPropertiesCMKEnabled.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L236:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountGetAsyncSkuConversionStatus.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L236:14
    ExampleUrl: stable/2022-05-01/examples/StorageAccountGetPropertiesCMKVersionExpirationTime.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdate.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountEnableAD.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountEnableCMK.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdateUserAssignedEncryptionIdentityWithCMK.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdateDisablePublicNetworkAccess.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdateWithImmutabilityPolicy.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdateUserAssignedIdentityWithFederatedIdentityClientId.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L294:16
    ExampleUrl: stable/2022-05-01/examples/StorageAccountUpdateAllowedCopyScopeToAAD.json#L2:17
    ❌ INVALID_REQUEST_PARAMETER api-version 2021-09-01 is not equal to swagger version
    Url: Microsoft.Storage/stable/2022-05-01/storage.json#L360:14
    ExampleUrl: stable/2022-05-01/examples/DeletedAccountList.json#L2:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Dec 12 '22 02:12 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/storage/armstorage - Approved - 2.0.0
    +	Type of `PermissionScope.Service` has been changed from `*string` to `*PermissionScopeServiceName`
    ❌azure-sdk-for-js - @azure/arm-storage - Approved - 19.0.0
    +	Interface BlobContainersListNextOptionalParams no longer has parameter filter
+	Interface BlobContainersListNextOptionalParams no longer has parameter include
+	Interface BlobContainersListNextOptionalParams no longer has parameter maxpagesize
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter filter
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter include
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter maxpagesize
+	Interface FileSharesListNextOptionalParams no longer has parameter expand
+	Interface FileSharesListNextOptionalParams no longer has parameter filter
+	Interface FileSharesListNextOptionalParams no longer has parameter maxpagesize
+	Interface QueueListNextOptionalParams no longer has parameter filter
+	Interface QueueListNextOptionalParams no longer has parameter maxpagesize
+	Type of parameter service of interface PermissionScope is changed from string to PermissionScopeServiceName

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 712 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • ❌Azure.ResourceManager.Storage [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Storage.Models.StoragePermissionScope.Service.set(System.String)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storage/Azure.ResourceManager.Storage/src/Azure.ResourceManager.Storage.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Storage/Debug/netstandard2.0/Azure.ResourceManager.Storage.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storage/Azure.ResourceManager.Storage/src/Azure.ResourceManager.Storage.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-storage [View full logs]  [Preview SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added model PermissionScopeServiceName
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-storage-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/storage/armstorage [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `PermissionScope.Service` has been changed from `*string` to `*PermissionScopeServiceName`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `PermissionScopeServiceName` with values `PermissionScopeServiceNameBlob`, `PermissionScopeServiceNameFile`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 3 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-storage [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias PermissionScopeServiceName
info	[Changelog]   - Added Enum KnownPermissionScopeServiceName
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter include
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter include
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter expand
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface QueueListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface QueueListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Type of parameter service of interface PermissionScope is changed from string to PermissionScopeServiceName
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️storage [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs] Generate from d9c0aacb76f51999a86d2e8e74e22268da974285. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.storage.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.storage.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Dec 12 '22 02:12 openapi-pipeline-app[bot]

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Storage https://apiview.dev/Assemblies/Review/cad852dd41f84a8b8319d41e98c4e132
    Go sdk/resourcemanager/storage/armstorage Create ApiView failed. Please ask PR assignee for help
    Java azure-resourcemanager-storage-generated Create ApiView failed. Please ask PR assignee for help
    .Net Azure.ResourceManager.Storage Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-storage Create ApiView failed. Please ask PR assignee for help

    openapi-pipeline-app[bot] avatar Dec 12 '22 02:12 openapi-pipeline-app[bot]

    Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    openapi-workflow-bot[bot] avatar Dec 12 '22 02:12 openapi-workflow-bot[bot]

    Hi @magodo, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    openapi-workflow-bot[bot] avatar Dec 12 '22 02:12 openapi-workflow-bot[bot]

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jan 01 '23 16:01 ghost

    Hi, @magodo. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Jan 16 '23 05:01 ghost

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Feb 05 '23 16:02 ghost

    Ping @JasonYang-MSFT

    magodo avatar Feb 06 '23 02:02 magodo

    @magodo Please get the approve for the potential breaking change. You can contact the PR assignee for more details.

    @ArthurMa1978
    Do you have any comments for the potential SDK breaking change from the swagger change in the PR?

    blueww avatar Feb 06 '23 02:02 blueww

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Feb 26 '23 16:02 ghost

    Ping ~@JasonYang-MSFT~ @jianyexi

    magodo avatar Feb 27 '23 02:02 magodo

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Mar 19 '23 16:03 ghost

    Ping @jianyexi

    magodo avatar Mar 21 '23 01:03 magodo

    /azp run

    raych1 avatar Mar 24 '23 01:03 raych1

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Mar 24 '23 01:03 azure-pipelines[bot]

    @magodo , can you fix ModelValidation check errors and PrettierCheck errors? In addition, please follow above breaking change review actions to get the approval.

    raych1 avatar Mar 24 '23 03:03 raych1

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Apr 09 '23 16:04 ghost

    Hi, @magodo. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Apr 24 '23 05:04 ghost

    @magodo any chance we could get this one reopened/fixed up so that we can get this merged/usable in the provider?

    tombuildsstuff avatar Apr 24 '23 07:04 tombuildsstuff

    @raych1 I've updated the PR to pass the Prettier CI. Regarding the breaking change, I saw the service team has approved it: https://github.com/Azure/azure-rest-api-specs/pull/21845#issuecomment-1418421342. Meanwhile, AFAIK the breaking change review is managed by the internal review board, should I email Jefferey, or?

    magodo avatar Apr 24 '23 09:04 magodo

    Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @magodo , please follow above action to get breaking change review approval.

    raych1 avatar Apr 28 '23 06:04 raych1

    @mikekistler @JeffreyRichter , can you review the breaking change?

    raych1 avatar Apr 28 '23 07:04 raych1

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar May 21 '23 16:05 ghost

    @magodo , let me know if this PR is ready to merge.

    raych1 avatar Jun 01 '23 06:06 raych1

    @raych1 I believe so as far as the service team confirms the API behaviors and adhere to not apply breaking changes.. So probably you'd like to double confirm with the SRP reviewers.

    magodo avatar Jun 02 '23 04:06 magodo

    Hi, @magodo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jun 18 '23 16:06 ghost

    Hi, @magodo. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Jul 11 '23 05:07 ghost

    this js sdk breaking is caused by this pr

    kazrael2119 avatar Jul 17 '23 01:07 kazrael2119