azure-rest-api-specs
azure-rest-api-specs copied to clipboard
recoveryservicessiterecovery: fixing an inconsistency in the segment naming
This being named both replicatedProtectedItemName
and replicationProtectedItemName
leads to spurious diff's, as can be seen here:
https://github.com/hashicorp/pandora/pull/1876/files#diff-769ff618512efcaf7271a5282d8cac1250e3ad381b060f86f2d6f209cedf8cf4L15
Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.
Swagger Validation Report
️❌
BreakingChange: 40 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.2)] | new version | base version |
---|---|---|
service.json | 2022-10-01(340626e) | 2022-10-01(main) |
Only 24 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L2883:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/addDisks' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3151:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/applyRecoveryPoint' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3228:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/failoverCancel' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3305:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/failoverCommit' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3370:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/plannedFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3435:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/recoveryPoints' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3512:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/recoveryPoints/{recoveryPointName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3576:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/remove' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3644:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/removeDisks' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3715:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/repairReplication' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3792:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/reProtect' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3857:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/resolveHealthErrors' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3934:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/switchProvider' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4011:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/targetComputeSizes' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4091:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/testFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4155:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/testFailoverCleanup' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4232:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/unplannedFailover' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4309:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateAppliance' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4386:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/replicationProtectionContainers/{protectionContainerName}/replicationProtectedItems/{replicatedProtectedItemName}/updateMobilityService' removed or restructured? Old: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L4463:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L2883:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3151:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3228:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.RecoveryServices/stable/2022-10-01/service.json#L3305:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
LintDiff inProgress [Detail]
️❌
Avocado: 20 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/addDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/applyRecoveryPoint is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/failoverCancel is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/failoverCommit is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/plannedFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/recoveryPoints is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/recoveryPoints/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/remove is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/removeDisks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/repairReplication is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/reProtect is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/resolveHealthErrors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/targetComputeSizes is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/testFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/testFailoverCleanup is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/unplannedFailover is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/updateMobilityService is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/updateAppliance is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.RecoveryServices/vaults/{}/replicationFabrics/{}/replicationProtectionContainers/{}/replicationProtectedItems/{}/switchProvider is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/recoveryservicessiterecovery/resource-manager/readme.md json: Microsoft.RecoveryServices/stable/2022-09-10/service.json |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 124 Errors, 0 Warnings failed [Detail]
Only 24 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
️❌
SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-python-track2 - track2_azure-mgmt-recoveryservicessiterecovery - 1.0.0b2+ Operation RecoveryPointsOperations.get has a new required parameter replication_protected_item_name + Operation RecoveryPointsOperations.get no longer has parameter replicated_protected_item_name + Operation RecoveryPointsOperations.list_by_replication_protected_items has a new required parameter replication_protected_item_name + Operation RecoveryPointsOperations.list_by_replication_protected_items no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_add_disks has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_add_disks no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_apply_recovery_point has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_apply_recovery_point no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_create has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_create no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_delete has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_delete no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_failover_cancel has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_failover_cancel no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_failover_commit has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_failover_commit no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_planned_failover has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_planned_failover no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_purge has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_purge no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_remove_disks has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_remove_disks no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_repair_replication has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_repair_replication no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_reprotect has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_reprotect no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_resolve_health_errors has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_resolve_health_errors no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_switch_provider has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_switch_provider no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_test_failover has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_test_failover no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_test_failover_cleanup has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_test_failover_cleanup no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_unplanned_failover has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_unplanned_failover no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update_appliance has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update_appliance no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update_mobility_service has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.begin_update_mobility_service no longer has parameter replicated_protected_item_name + Operation ReplicationProtectedItemsOperations.get has a new required parameter replication_protected_item_name + Operation ReplicationProtectedItemsOperations.get no longer has parameter replicated_protected_item_name + Operation TargetComputeSizesOperations.list_by_replication_protected_items has a new required parameter replication_protected_item_name + Operation TargetComputeSizesOperations.list_by_replication_protected_items no longer has parameter replicated_protected_item_name
Generated ApiView
Language | Package Name | ApiView Link |
---|---|---|
swagger | Microsoft.RecoveryServices | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Go | sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Python | track2_azure-mgmt-recoveryservicessiterecovery | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Java | azure-resourcemanager-recoveryservicessiterecovery | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
.Net | Azure.ResourceManager.RecoveryServicesSiteRecovery | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
JavaScript | @azure/arm-recoveryservices-siterecovery | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.
Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff
. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
Task | How to fix | Priority |
---|---|---|
Avocado | Fix-Avocado | High |
Semantic validation | Fix-SemanticValidation-Error | High |
Model validation | Fix-ModelValidation-Error | High |
LintDiff | Fix-LintDiff | high |
NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
There's no breaking changes in this PR, it's renaming a segment to be consistent, which is unfortunately flagged as a breaking change when it isn't - so this is waiting on the Service Team to review it
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity
label.
Still waiting on the service team here?
Next Steps to Merge
Next steps that must be taken to merge this PR:- ❌ Your PR has at least one breaking change (label:
BreakingChangeReviewRequired
). See the PR description for help.