azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
Make certficates/daprComponents/storages operations async
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [x] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @Juliehzl Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 8 Errors, 14 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| CommonDefinitions.json | 2022-11-01-preview(299fc09) | 2022-03-01(main) |
| CommonDefinitions.json | 2022-11-01-preview(299fc09) | 2022-06-01-preview(main) |
| ManagedEnvironments.json | 2022-11-01-preview(299fc09) | 2022-03-01(main) |
| ManagedEnvironments.json | 2022-11-01-preview(299fc09) | 2022-06-01-preview(main) |
| ManagedEnvironmentsDaprComponents.json | 2022-11-01-preview(299fc09) | 2022-06-01-preview(main) |
| ManagedEnvironmentsStorages.json | 2022-11-01-preview(299fc09) | 2022-03-01(main) |
| ManagedEnvironmentsStorages.json | 2022-11-01-preview(299fc09) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2022-11 | package-preview-2022-11(299fc09) | package-preview-2022-11(release-app-Microsoft.App-2022-11-01-preview) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️⚠️SDK Breaking Change Tracking warning [Detail]
Breaking Changes Tracking
⚠️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0-beta.2+ Function `*CertificatesClient.CreateOrUpdate` has been removed + Function `*CertificatesClient.Delete` has been removed + Function `*DaprComponentsClient.CreateOrUpdate` has been removed + Function `*DaprComponentsClient.Delete` has been removed + Function `*ManagedEnvironmentsStoragesClient.CreateOrUpdate` has been removed + Function `*ManagedEnvironmentsStoragesClient.Delete` has been removed + Struct `CertificatesClientCreateOrUpdateOptions` has been removed + Struct `CertificatesClientDeleteOptions` has been removed + Struct `DaprComponentsClientCreateOrUpdateOptions` has been removed + Struct `DaprComponentsClientDeleteOptions` has been removed + Struct `ManagedEnvironmentsStoragesClientCreateOrUpdateOptions` has been removed + Struct `ManagedEnvironmentsStoragesClientDeleteOptions` has been removed + Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - 2.0.0b1+ Renamed operation CertificatesOperations.create_or_update to CertificatesOperations.begin_create_or_update + Renamed operation CertificatesOperations.delete to CertificatesOperations.begin_delete + Renamed operation DaprComponentsOperations.create_or_update to DaprComponentsOperations.begin_create_or_update + Renamed operation DaprComponentsOperations.delete to DaprComponentsOperations.begin_delete + Renamed operation ManagedEnvironmentsStoragesOperations.create_or_update to ManagedEnvironmentsStoragesOperations.begin_create_or_update + Renamed operation ManagedEnvironmentsStoragesOperations.delete to ManagedEnvironmentsStoragesOperations.begin_delete
⚠️azure-sdk-for-js - @azure/arm-appcontainers - 2.0.0-beta.2+ Removed operation Certificates.createOrUpdate + Removed operation Certificates.delete + Removed operation DaprComponents.createOrUpdate + Removed operation DaprComponents.delete + Removed operation ManagedEnvironmentsStorages.createOrUpdate + Removed operation ManagedEnvironmentsStorages.delete
️❌ azure-sdk-for-python-track2 failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice cmdout [automation_generate.sh] [Autorest] 494 | "modelAsString": true cmdout [automation_generate.sh] [Autorest] 495 | }, cmdout [automation_generate.sh] [Autorest] 496 | "default": "Single" cmdout [automation_generate.sh] [Autorest] -----------------^ cmdout [automation_generate.sh] [Autorest] 497 | }, cmdout [automation_generate.sh] [Autorest] 498 | "ingress": { cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest] 494 | "modelAsString": true cmdout [automation_generate.sh] [Autorest] 495 | }, cmdout [automation_generate.sh] [Autorest] 496 | "default": "Single" cmdout [automation_generate.sh] [Autorest] -----------------^ cmdout [automation_generate.sh] [Autorest] 497 | }, cmdout [automation_generate.sh] [Autorest] 498 | "ingress": { cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh warn Skip package processing as generation is failed
️❌ azure-sdk-for-java failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
❌azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]
️❌ azure-sdk-for-go failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json cmderr [generator automation-v2] [ERROR] total 1 error(s): cmderr [generator automation-v2] [ERROR] failed to execute `go generate` '[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers[0m cmderr [generator automation-v2] [ERROR] Cannot find go module under resourcemanager/appcontainers/armappcontainers, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers cmderr [generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers cmderr [generator automation-v2] [ERROR] ##[command]Executing autorest.go in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers cmderr [generator automation-v2] [ERROR] autorest --version=3.8.2 --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/appcontainers/armappcontainers --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md cmderr [generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v16.17.1] cmderr [generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation. cmderr [generator automation-v2] [ERROR] https://aka.ms/autorest cmderr [generator automation-v2] [ERROR] info | AutoRest core version selected from configuration: 3.8.2. cmderr [generator automation-v2] [ERROR] There is a new version of AutoRest available (3.6.2). cmderr [generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest cmderr [generator automation-v2] [ERROR] info | Loading AutoRest core '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.8.2) cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.3.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.4.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.5.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.6.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.7.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.8.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.9.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.10.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/go' (4.0.0-preview.44 -> 4.0.0-preview.44) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/go' (4.0.0-preview.44->4.0.0-preview.44) cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/modelerfour' (4.23.1 -> 4.23.1) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/modelerfour' (4.23.1->4.23.1) cmderr [generator automation-v2] [ERROR] fatal | Process() cancelled due to failure cmderr [generator automation-v2] [ERROR] error | YAMLException: duplicated mapping key (496:11) cmderr [generator automation-v2] [ERROR] 493 | "name": "ActiveRevisionsMode", cmderr [generator automation-v2] [ERROR] 494 | "modelAsString": true cmderr [generator automation-v2] [ERROR] 495 | }, cmderr [generator automation-v2] [ERROR] 496 | "default": "Single" cmderr [generator automation-v2] [ERROR] -----------------^ cmderr [generator automation-v2] [ERROR] 497 | }, cmderr [generator automation-v2] [ERROR] 498 | "ingress": { cmderr [generator automation-v2] [ERROR] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmderr [generator automation-v2] [ERROR] ##[error]Error running autorest.go cmderr [generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1 cmderr [generator automation-v2] [ERROR] ': exit status 1 error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2 warn Skip package processing as generation is failed
️❌ azure-sdk-for-js failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json cmderr [automation_generate.sh] [ERROR] An error occurred while generating codes for readme file: "specification/app/resource-manager/readme.md": cmderr [automation_generate.sh] [ERROR] Err: Error: Command failed: autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/app/resource-manager/readme.md --use=@autorest/[email protected] cmderr [automation_generate.sh] [ERROR] Stderr: "null" cmderr [automation_generate.sh] [ERROR] Stdout: "null" cmderr [automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/app/resource-manager/readme.md --use=@autorest/[email protected] cmderr [automation_generate.sh] [ERROR] at checkExecSyncError (node:child_process:841:11) cmderr [automation_generate.sh] [ERROR] at Object.execSync (node:child_process:912:15) cmderr [automation_generate.sh] [ERROR] at Object.<anonymous> (/opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:39:33) cmderr [automation_generate.sh] [ERROR] at Generator.next (<anonymous>) cmderr [automation_generate.sh] [ERROR] at /opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:115:75 cmderr [automation_generate.sh] [ERROR] at new Promise (<anonymous>) cmderr [automation_generate.sh] [ERROR] at Object.__awaiter (/opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:111:16) cmderr [automation_generate.sh] [ERROR] at Object.generateMgmt (/opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:20:20) cmderr [automation_generate.sh] [ERROR] at /opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/autoGenerateInPipeline.js:43:34" error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh warn Skip package processing as generation is failed
️❌ azure-resource-manager-schemas failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
❌app/resource-manager [View full logs] [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from 11cfeeae00ca231e46395e7e87b1fe92e436b448. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.app [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| swagger | Microsoft.App | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Hi @Juliehzl, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi, @Juliehzl, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
Hi @Juliehzl, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
@JeffreyRichter please help review the breaking change detected. We want to make some operations in new preview api version. Otherwise, the api latency will be slow.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't understand what is going on here. Did this preview version ship already? If so, you cannot change an already-shipped api-version. You can make changes in a new api-version. Also, it looks like some breaking changes are being introduced from the last stable version (not just from 1 preview to the next). Azure services should not introduce breaking changes.
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
I don't understand what is going on here. Did this preview version ship already? If so, you cannot change an already-shipped api-version. You can make changes in a new api-version. Also, it looks like some breaking changes are being introduced from the last stable version (not just from 1 preview to the next). Azure services should not introduce breaking changes.
@JeffreyRichter The preview is not shipped and it is never exposed to customer. This is a new api verison
The first commit needs to be the previous api version (in your case: 2022-06-01-preview) and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version. It will help us to review only the changes between 2022-06-01-preview and 2022-11-01-preview versions, rather than reviewing whole swagger. Please remove the "ARMChangesRequested" label once you have fixed this issue.
Hi, @Juliehzl. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @Juliehzl. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.