azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

`compute` Gallery doesn't return `publicNamePrefix`

Open myc2h6o opened this issue 2 years ago • 6 comments

When using below request to create a community gallery, publicNamePrefix is set but not returned in the GET response. Though the value can be extracted from publicNames, it violates https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/Semantic-and-Model-Violations-Reference.md#roundtrip_missing_property.

PUT /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/galleries/{galleryName}
{
  "location": "eastus",
  "properties": {
    "sharingProfile": {
      "permissions": "Community",
      "communityGalleryInfo": {
        "publicNamePrefix": "prefix",
        "publisherUri": "publisherurl.net",
        "publisherContact": "[email protected]",
        "eula": "testeula"
      }
    }
  }
}

GET response:
{
  "properties": {
    "sharingProfile": {
      "communityGalleryInfo": {
...
        "publicNames": [
          "prefix-446a305e-2918-473a-8244-1a2fa18d9d5c"
        ]
      }
    }
  }
}

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L37 https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L1873

myc2h6o avatar Oct 31 '22 05:10 myc2h6o

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv, @vaibhav-agar, @amjads1.

Issue Details

When using below request to create a community gallery, publicNamePrefix is set but not returned in the GET response. Though the value can be extracted from publicNames, it violates https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/Semantic-and-Model-Violations-Reference.md#roundtrip_missing_property.

PUT /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/galleries/{galleryName}
{
  "location": "eastus",
  "properties": {
    "sharingProfile": {
      "permissions": "Community",
      "communityGalleryInfo": {
        "publicNamePrefix": "prefix",
        "publisherUri": "publisherurl.net",
        "publisherContact": "[email protected]",
        "eula": "testeula"
      }
    }
  }
}

GET response:
{
  "properties": {
    "sharingProfile": {
      "communityGalleryInfo": {
...
        "publicNames": [
          "prefix-446a305e-2918-473a-8244-1a2fa18d9d5c"
        ]
      }
    }
  }
}

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L37 https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L1873

Author: myc2h6o
Assignees: -
Labels:

question, Compute, Service Attention, customer-reported

Milestone: -

ghost avatar Nov 28 '22 05:11 ghost

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Drewm3, @avirishuv, @vaibhav-agar, @amjads1.

Issue Details

When using below request to create a community gallery, publicNamePrefix is set but not returned in the GET response. Though the value can be extracted from publicNames, it violates https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/Semantic-and-Model-Violations-Reference.md#roundtrip_missing_property.

PUT /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/galleries/{galleryName}
{
  "location": "eastus",
  "properties": {
    "sharingProfile": {
      "permissions": "Community",
      "communityGalleryInfo": {
        "publicNamePrefix": "prefix",
        "publisherUri": "publisherurl.net",
        "publisherContact": "[email protected]",
        "eula": "testeula"
      }
    }
  }
}

GET response:
{
  "properties": {
    "sharingProfile": {
      "communityGalleryInfo": {
...
        "publicNames": [
          "prefix-446a305e-2918-473a-8244-1a2fa18d9d5c"
        ]
      }
    }
  }
}

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L37 https://github.com/Azure/azure-rest-api-specs/blob/5fc05d0f0b15cbf16de942cadce464b495c66a58/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/gallery.json#L1873

Author: myc2h6o
Assignees: -
Labels:

question, Compute, Service Attention, customer-reported, needs-team-attention

Milestone: -

ghost avatar Nov 28 '22 05:11 ghost

Adding Service team to look into this.

@Drewm3, @avirishuv, @Vaibhav-Agar, @amjads1 Could you please look into this once you get a chance ?

navba-MSFT avatar Nov 28 '22 05:11 navba-MSFT

@sandeepraichura, could you please look into this issue.

Drewm3 avatar Nov 28 '22 07:11 Drewm3

@kangsun-ctrl - We had a thread with Yichun on this, can you take a look at this one ?

sandeepraichura avatar Dec 05 '22 03:12 sandeepraichura

Pr for this has been merged, rolling out right. This can be closed after fully rollout.

kangsun-ctrl avatar Dec 05 '22 19:12 kangsun-ctrl

@myc2h6o - Closing this out as it has been addressed

sandeepraichura avatar Feb 16 '23 18:02 sandeepraichura