azure-rest-api-specs
azure-rest-api-specs copied to clipboard
New API version for Microsoft.Resources stable/2022-11-01
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @meghanagupta95 Thanks for your PR. I am workflow bot for review process. Here are some small tips.
Swagger Validation Report
️️✔️
BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌
Breaking Change(Cross-Version): 6 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.1)] | new version | base version |
---|---|---|
resources.json | 2022-09-01(273244b) | 2021-04-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌
ModelValidation: 150 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
️🔄
ApiDocPreview inProgress [Detail]
️❌
SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-go - sdk/resourcemanager/resources/armresources - 2.0.0+ Function `*TagsClient.CreateOrUpdateAtScope` has been removed + Function `*TagsClient.DeleteAtScope` has been removed + Function `*TagsClient.UpdateAtScope` has been removed + Struct `CloudError` has been removed + Struct `TagsClientCreateOrUpdateAtScopeOptions` has been removed + Struct `TagsClientDeleteAtScopeOptions` has been removed + Struct `TagsClientUpdateAtScopeOptions` has been removed
❌
azure-sdk-for-go - sdk/resourcemanager/resources/armdeploymentscripts - 2.0.0+ Struct `DeploymentScriptPropertiesBase` has been removed + Struct `ScriptConfigurationBase` has been removed
❌
azure-sdk-for-go - sdk/resourcemanager/resources/armpolicy - 0.7.0+ Struct `CloudError` has been removed
❌
azure-sdk-for-go - sdk/resourcemanager/resources/armsubscriptions - 2.0.0+ Struct `CloudError` has been removed
❌
azure-sdk-for-js - @azure/arm-resources - 6.0.0+ Removed operation TagsOperations.createOrUpdateAtScope + Removed operation TagsOperations.deleteAtScope + Removed operation TagsOperations.updateAtScope
️⚠️
azure-sdk-for-net-track2 warning [Detail]
⚠️
Warning [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json warn No file changes detected after generation
️✔️
Azure.ResourceManager.Resources [View full logs]info [Changelog]
️⚠️
azure-sdk-for-python-track2 warning [Detail]
⚠️
Warning [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️
track2_azure-mgmt-resource [View full logs] [Release SDK Changes]info [Changelog]
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 12 items here, please refer to log for details.
️✔️
sdk/resourcemanager/resources/armresources [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Struct `TagsClientUpdateAtScopeOptions` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New function `*TagsClient.BeginUpdateAtScope(context.Context, string, TagsPatchResource, *TagsClientBeginUpdateAtScopeOptions) (*runtime.Poller[TagsClientUpdateAtScopeResponse], error)` info [Changelog] - New function `*TagsClient.BeginDeleteAtScope(context.Context, string, *TagsClientBeginDeleteAtScopeOptions) (*runtime.Poller[TagsClientDeleteAtScopeResponse], error)` info [Changelog] - New function `*TagsClient.BeginCreateOrUpdateAtScope(context.Context, string, TagsResource, *TagsClientBeginCreateOrUpdateAtScopeOptions) (*runtime.Poller[TagsClientCreateOrUpdateAtScopeResponse], error)` info [Changelog] - New struct `TagsClientBeginCreateOrUpdateAtScopeOptions` info [Changelog] - New struct `TagsClientBeginDeleteAtScopeOptions` info [Changelog] - New struct `TagsClientBeginUpdateAtScopeOptions` info [Changelog] info [Changelog] Total 11 breaking change(s), 9 additive change(s).
️✔️
sdk/resourcemanager/resources/armdeploymentscripts [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Struct `DeploymentScriptPropertiesBase` has been removed info [Changelog] - Struct `ScriptConfigurationBase` has been removed info [Changelog] info [Changelog] Total 4 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armfeatures [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armlinks [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armlocks [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armmanagedapplications [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
- Only show 12 items here, please refer to log for details.
️✔️
sdk/resourcemanager/resources/armpolicy [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - New struct `VariablesClientGetResponse` info [Changelog] - New struct `VariablesClientListForManagementGroupOptions` info [Changelog] - New struct `VariablesClientListForManagementGroupResponse` info [Changelog] - New struct `VariablesClientListOptions` info [Changelog] - New struct `VariablesClientListResponse` info [Changelog] - New field `ResourceSelectors` in struct `AssignmentProperties` info [Changelog] - New field `Overrides` in struct `AssignmentProperties` info [Changelog] - New field `Properties` in struct `AssignmentUpdate` info [Changelog] - New field `AssignmentScopeValidation` in struct `ExemptionProperties` info [Changelog] - New field `ResourceSelectors` in struct `ExemptionProperties` info [Changelog] info [Changelog] Total 2 breaking change(s), 135 additive change(s).
️✔️
sdk/resourcemanager/resources/armsubscriptions [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Struct `CloudError` has been removed info [Changelog] info [Changelog] Total 2 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armtemplatespecs [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️✔️
sdk/resourcemanager/resources/armchanges [View full logs] [Release SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json cmderr [automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
️✔️
@azure/arm-changes [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface ChangeResourceResult
️✔️
@azure/arm-features [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface SubscriptionFeatureRegistration
️✔️
@azure/arm-links [View full logs] [Release SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️✔️
@azure/arm-locks [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface ErrorAdditionalInfo info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponse info [Changelog] - Added Interface SystemData info [Changelog] - Added Type Alias CreatedByType info [Changelog] - Interface ManagementLockObject has a new optional parameter systemData info [Changelog] - Added Enum KnownCreatedByType
️✔️
@azure/arm-managedapplications [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface Application info [Changelog] - Added Interface ApplicationDefinition info [Changelog] - Added Interface ApplicationPatchable info [Changelog] - Added Interface GenericResource
- Only show 14 items here, please refer to log for details.
️✔️
@azure/arm-policy [View full logs] [Release SDK Changes]info [Changelog] - Added Type Alias VariableValuesListForManagementGroupResponse info [Changelog] - Added Type Alias VariableValuesListNextResponse info [Changelog] - Added Type Alias VariableValuesListResponse info [Changelog] - Interface PolicyAssignment has a new optional parameter overrides info [Changelog] - Interface PolicyAssignment has a new optional parameter resourceSelectors info [Changelog] - Interface PolicyAssignmentUpdate has a new optional parameter overrides info [Changelog] - Interface PolicyAssignmentUpdate has a new optional parameter resourceSelectors info [Changelog] - Interface PolicyExemption has a new optional parameter assignmentScopeValidation info [Changelog] - Interface PolicyExemption has a new optional parameter resourceSelectors info [Changelog] - Class PolicyClient has a new parameter variables info [Changelog] - Class PolicyClient has a new parameter variableValues info [Changelog] - Added Enum KnownAssignmentScopeValidation info [Changelog] - Added Enum KnownOverrideKind info [Changelog] - Added Enum KnownSelectorKind
️✔️
@azure/arm-resources-subscriptions [View full logs] [Release SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation Subscriptions.checkZonePeers info [Changelog] - Added Interface AvailabilityZonePeers info [Changelog] - Added Interface CheckZonePeersRequest info [Changelog] - Added Interface CheckZonePeersResult info [Changelog] - Added Interface ErrorDetail info [Changelog] - Added Interface ErrorResponseAutoGenerated info [Changelog] - Added Interface Peers info [Changelog] - Added Interface SubscriptionsCheckZonePeersOptionalParams info [Changelog] - Added Type Alias SubscriptionsCheckZonePeersResponse
- Only show 14 items here, please refer to log for details.
️✔️
@azure/arm-resources [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface TagsDeleteAtScopeHeaders info [Changelog] - Added Interface TagsUpdateAtScopeHeaders info [Changelog] - Interface TagsCreateOrUpdateAtScopeOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface TagsCreateOrUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface TagsDeleteAtScopeOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter resumeFrom info [Changelog] - Interface TagsUpdateAtScopeOptionalParams has a new optional parameter updateIntervalInMs info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation TagsOperations.createOrUpdateAtScope info [Changelog] - Removed operation TagsOperations.deleteAtScope info [Changelog] - Removed operation TagsOperations.updateAtScope
- Only show 14 items here, please refer to log for details.
️✔️
@azure/arm-templatespecs [View full logs] [Release SDK Changes]info [Changelog] - Added Interface TemplateSpecsListBuiltInsNextOptionalParams info [Changelog] - Added Interface TemplateSpecsListBuiltInsOptionalParams info [Changelog] - Added Interface TemplateSpecUpdateModel info [Changelog] - Added Interface TemplateSpecVersion info [Changelog] - Added Interface TemplateSpecVersionsGetBuiltInOptionalParams info [Changelog] - Added Interface TemplateSpecVersionsListBuiltInsNextOptionalParams info [Changelog] - Added Interface TemplateSpecVersionsListBuiltInsOptionalParams info [Changelog] - Added Interface TemplateSpecVersionUpdateModel info [Changelog] - Added Type Alias TemplateSpecsGetBuiltInResponse info [Changelog] - Added Type Alias TemplateSpecsListBuiltInsNextResponse info [Changelog] - Added Type Alias TemplateSpecsListBuiltInsResponse info [Changelog] - Added Type Alias TemplateSpecVersionsGetBuiltInResponse info [Changelog] - Added Type Alias TemplateSpecVersionsListBuiltInsNextResponse info [Changelog] - Added Type Alias TemplateSpecVersionsListBuiltInsResponse
️❌
azure-resource-manager-schemas failed [Detail]
❌
Failed [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository. Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
️✔️
resources [View full logs] [Release Schema Changes]️✔️
resources [View full logs]error Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository. error The following packages are still pending: error resources error resources error resources error resources
️✔️
resources️✔️
resources
️️✔️
azure-powershell succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 2097e719fdba665954e057d57bef61766a013218. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️
Az.Changes [View full logs] [Release SDK Changes]
Generated ApiView
Hi @meghanagupta95, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Adding Approved-BreakingChange label as it's been approved in https://github.com/Azure/azure-rest-api-specs/pull/20494
Hi @leni-msft , is there anything else we need to do from our end? Some of the checks are failing due to changes from before the current PR.
@meghanagupta95 please fix all the required CI check failure and get ARM review sign-off.
Please use 2022-09-01 as our new API version: Please refer to the PRs: [ARM] Introduce new api-version: 2022-09-01 [TagsController] Support tags api async operations with api-version: 2022-09-01
@NetRock we have to change the API version from 2022-11-01 to 2022-09-01 since it is being referenced elsewhere. The changes will have to be reviewed/approved after the latest commit.
Hi @meghanagupta95, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
Hi @meghanagupta95, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff
. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
Task | How to fix | Priority |
---|---|---|
Avocado | Fix-Avocado | High |
Semantic validation | Fix-SemanticValidation-Error | High |
Model validation | Fix-ModelValidation-Error | High |
LintDiff | Fix-LintDiff | high |
Hi, @meghanagupta95, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
@leni-msft the only error relevant to the changes introduced by us in the new API version are the R4009 RequiredReadOnlySystemData
error. We have filed a suppression request for the same. However, the remaining errors are present in the base API version as well, so we are not sure how to handle those. Could you tell us what we should be doing now?