azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

sample patch for room create

Open radubulboaca opened this issue 3 years ago • 4 comments

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

radubulboaca avatar Oct 18 '22 23:10 radubulboaca

Hi, @radubulboaca Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Oct 18 '22 23:10 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/d3be5db1a1dee5fc1c074f5c654f73446e3af658/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json",
    "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/autorest/dist/app.js --v2 --input-file=specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nFATAL: openapi-document/openapi-document-converter - FAILED\nFATAL: Error: Invalid reference token: roomId\n Error: Invalid reference token: roomId\n"
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail]
    Rule Message
    ❌ LintDiffToolException "details":""stack":"MissingPointerError: Token \"roomId\" does not exist.\n at Pointer.resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/pointer.js:94:13)\n at $Ref.resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/ref.js:124:20)\n at $Refs._resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/refs.js:156:15)\n at dereference$Ref (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:133:23)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:62:28)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at dereference (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:19:22)\n at $RefParser.dereference (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/index.js:269:5)\n at processTicksAndRejections (internal/process/task_queues.js:95:5)",
    "code":"EMISSINGPOINTER",
    "message":"Token \"roomId\" does not exist.",
    "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json",
    "path":null,
    "name":"MissingPointerError",
    "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json+EMISSINGPOINTER+Token \"roomId\" does not exist.""
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ UNRESOLVABLE_REFERENCE Reference could not be resolved: #/parameters/roomId
    Url: Rooms/preview/2022-02-01-preview/communicationservicesrooms.json#L24:11
    ️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ UNRESOLVABLE_REFERENCE Reference could not be resolved: #/parameters/roomId
    JsonUrl: Rooms/preview/2022-02-01-preview/communicationservicesrooms.json#L24:11
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️❌SDK Track2 Validation: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail]
    Rule Message
    ❌ LintRpaasToolException "details":""stack":"MissingPointerError: Token \"roomId\" does not exist.\n at Pointer.resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/pointer.js:94:13)\n at $Ref.resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/ref.js:124:20)\n at $Refs._resolve (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/refs.js:156:15)\n at dereference$Ref (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:133:23)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:62:28)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at crawl (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:71:30)\n at dereference (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/dereference.js:19:22)\n at $RefParser.dereference (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.42/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/index.js:269:5)\n at processTicksAndRejections (internal/process/task_queues.js:95:5)",
    "code":"EMISSINGPOINTER",
    "message":"Token \"roomId\" does not exist.",
    "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json",
    "path":null,
    "name":"MissingPointerError",
    "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/communication/data-plane/Rooms/preview/2022-02-01-preview/communicationservicesrooms.json+EMISSINGPOINTER+Token \"roomId\" does not exist.""
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Oct 18 '22 23:10 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Oct 18 '22 23:10 openapi-pipeline-app[bot]

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    openapi-pipeline-app[bot] avatar Oct 18 '22 23:10 openapi-pipeline-app[bot]