azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Added Response Schema for Runbook Operation
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [x] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @sushil490023 Thanks for your PR. I am workflow bot for review process. Here are some small tips.
Swagger Validation Report
️❌
BreakingChange: 17 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.1)] | new version | base version |
---|---|---|
runbook.json | 2022-08-08(6d4365e) | 2022-08-08(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-08-08 | package-2022-08-08(6d4365e) | package-2022-08-08(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
:warning: R1006 - PutInOperationName | 'PUT' operation 'RunbookDraft_ReplaceContent' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L98 |
:warning: R2004 - NonApplicationJsonType | Only 'application/json' content-type is supported by ARM. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L55 |
:warning: R2004 - NonApplicationJsonType | Only 'application/json' content-type is supported by ARM. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L109 |
:warning: R2004 - NonApplicationJsonType | Only 'application/json' content-type is supported by ARM. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L351 |
:warning: R2017 - PutRequestResponseScheme | A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Runbook_CreateOrUpdate' Request Model: 'RunbookCreateOrUpdateParameters' Response Model: 'Runbook' Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L443 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookDraftModel'. Consider using the plural form of 'RunbookDraft' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L44 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookDraftModel'. Consider using the plural form of 'RunbookDraft' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L98 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookDraftModel'. Consider using the plural form of 'RunbookDraft' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L177 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L230 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookDraftModel'. Consider using the plural form of 'RunbookDraft' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L287 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L340 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L396 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L447 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L516 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L576 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'RunbookModel'. Consider using the plural form of 'Runbook' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L629 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TestJobModel'. Consider using the plural form of 'TestJob' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L800 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TestJobModel'. Consider using the plural form of 'TestJob' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L860 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TestJobModel'. Consider using the plural form of 'TestJob' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L913 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TestJobModel'. Consider using the plural form of 'TestJob' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L963 |
:warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TestJobModel'. Consider using the plural form of 'TestJob' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1013 |
:warning: R2064 - LROStatusCodesReturnTypeSchema | 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'RunbookDraft_ReplaceContent', Response code: '200' Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L144 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'streams' with immediate parent 'DscCompilationJob', must have a list by immediate parent operation. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1060 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'streams' with immediate parent 'Job', must have a list by immediate parent operation. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1060 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'streams' with immediate parent 'Runbook', must have a list by immediate parent operation. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1060 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'runbooks' with immediate parent 'AutomationAccount', must have a list by immediate parent operation. Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1285 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: logVerbose Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1215 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: logProgress Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1219 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: logVerbose Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1325 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: logProgress Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1329 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
:warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/automation/resource-manager/readme.md tag: specification/automation/resource-manager/readme.md#tag-package-2022-08-08 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
️️✔️
ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌
SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌
azure-sdk-for-go - sdk/resourcemanager/automation/armautomation - 0.8.0+ Field `Value` of struct `DscConfigurationClientGetContentResponse` has been removed + Function `*DscConfigurationClient.UpdateWithJSON` parameter(s) have been changed from `(context.Context, string, string, string, DscConfigurationUpdateParameters, *DscConfigurationClientUpdateWithJSONOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithJSONOptions)` + Function `*DscConfigurationClient.UpdateWithText` parameter(s) have been changed from `(context.Context, string, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` + Struct `ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` has been removed + Type of `Identity.UserAssignedIdentities` has been changed from `map[string]*ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` to `map[string]*UserAssignedIdentitiesProperties`
❌
azure-sdk-for-python-track2 - track2_azure-mgmt-automation - 1.1.0b2+ Model HybridRunbookWorkerGroup no longer has parameter hybrid_runbook_workers + Operation DscConfigurationOperations.create_or_update no longer has parameter content_type + Operation DscConfigurationOperations.update no longer has parameter content_type + Operation HybridRunbookWorkerGroupOperations.update has a new parameter hybrid_runbook_worker_group_updation_parameters + Operation HybridRunbookWorkerGroupOperations.update no longer has parameter parameters
️️✔️
azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️
Azure.ResourceManager.Automation [View full logs] [Release SDK Changes]info [Changelog]
️❌
azure-sdk-for-python-track2 failed [Detail]
❌
Failed [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmdout [automation_generate.sh] [Autorest] File "src/black/_init__.py", line 1163, in formatstr cmdout [automation_generate.sh] [Autorest] File "src/black/_init__.py", line 1173, in _format_stronce cmdout [automation_generate.sh] [Autorest] File "src/black/parsing.py", line 128, in lib2to3_parse cmdout [automation_generate.sh] [Autorest] black.parsing.InvalidInput: Cannot parse: 33:24: runbook_content="<# cmdout [automation_generate.sh] [Autorest] fatal | Process() cancelled due to failure cmdout [automation_generate.sh] [Autorest] error | Error: Plugin black reported failure. cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest] File "src/black/_init__.py", line 1163, in formatstr cmdout [automation_generate.sh] [Autorest] File "src/black/_init__.py", line 1173, in _format_stronce cmdout [automation_generate.sh] [Autorest] File "src/black/parsing.py", line 128, in lib2to3_parse cmdout [automation_generate.sh] [Autorest] black.parsing.InvalidInput: Cannot parse: 33:24: runbook_content="<# cmdout [automation_generate.sh] [Autorest] fatal | Process() cancelled due to failure cmdout [automation_generate.sh] [Autorest] error | Error: Plugin black reported failure. cmdout [automation_generate.sh] [Autorest] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmdout [automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh warn Skip package processing as generation is failed
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/automation/armautomation [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*DscConfigurationClient.UpdateWithText` parameter(s) have been changed from `(context.Context, string, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` info [Changelog] - Function `*DscConfigurationClient.UpdateWithJSON` parameter(s) have been changed from `(context.Context, string, string, string, DscConfigurationUpdateParameters, *DscConfigurationClientUpdateWithJSONOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithJSONOptions)` info [Changelog] - Type of `Identity.UserAssignedIdentities` has been changed from `map[string]*ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` to `map[string]*UserAssignedIdentitiesProperties` info [Changelog] - Struct `ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` has been removed info [Changelog] - Field `Value` of struct `DscConfigurationClientGetContentResponse` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New function `*Python3PackageClient.Update(context.Context, string, string, string, PythonPackageUpdateParameters, *Python3PackageClientUpdateOptions) (Python3PackageClientUpdateResponse, error)` info [Changelog] - New function `*Python3PackageClient.Get(context.Context, string, string, string, *Python3PackageClientGetOptions) (Python3PackageClientGetResponse, error)` info [Changelog] - New function `*Python3PackageClient.NewListByAutomationAccountPager(string, string, *Python3PackageClientListByAutomationAccountOptions) *runtime.Pager[Python3PackageClientListByAutomationAccountResponse]` info [Changelog] - New function `*Python3PackageClient.Delete(context.Context, string, string, string, *Python3PackageClientDeleteOptions) (Python3PackageClientDeleteResponse, error)` info [Changelog] - New function `NewPython3PackageClient(string, azcore.TokenCredential, *arm.ClientOptions) (*Python3PackageClient, error)` info [Changelog] - New function `*Python3PackageClient.CreateOrUpdate(context.Context, string, string, string, PythonPackageCreateParameters, *Python3PackageClientCreateOrUpdateOptions) (Python3PackageClientCreateOrUpdateResponse, error)` info [Changelog] - New struct `Dimension` info [Changelog] - New struct `LogSpecification` info [Changelog] - New struct `MetricSpecification` info [Changelog] - New struct `OperationPropertiesFormat` info [Changelog] - New struct `OperationPropertiesFormatServiceSpecification` info [Changelog] - New struct `Python3PackageClient` info [Changelog] - New struct `Python3PackageClientCreateOrUpdateOptions` info [Changelog] - New struct `Python3PackageClientCreateOrUpdateResponse` info [Changelog] - New struct `Python3PackageClientDeleteOptions` info [Changelog] - New struct `Python3PackageClientDeleteResponse` info [Changelog] - New struct `Python3PackageClientGetOptions` info [Changelog] - New struct `Python3PackageClientGetResponse` info [Changelog] - New struct `Python3PackageClientListByAutomationAccountOptions` info [Changelog] - New struct `Python3PackageClientListByAutomationAccountResponse` info [Changelog] - New struct `Python3PackageClientUpdateOptions` info [Changelog] - New struct `Python3PackageClientUpdateResponse` info [Changelog] - New struct `UserAssignedIdentitiesProperties` info [Changelog] - New field `Description` in struct `OperationDisplay` info [Changelog] - New field `Parameters` in struct `DscConfigurationClientUpdateWithTextOptions` info [Changelog] - New field `Parameters` in struct `DscConfigurationClientUpdateWithJSONOptions` info [Changelog] - New field `Origin` in struct `Operation` info [Changelog] - New field `Properties` in struct `Operation` info [Changelog] info [Changelog] Total 6 breaking change(s), 44 additive change(s).
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️
@azure/arm-automation [View full logs] [Release SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️
azure-resource-manager-schemas warning [Detail]
⚠️
Warning [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️
automation [View full logs] [Release Schema Changes]
️❌
azure-powershell failed [Detail]
❌
Failed [Logs]Release - Generate from 00ea1cdee06eb16e8befcbb8ffa8abf35ba99f4d. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌
Az.automation [View full logs] [Release SDK Changes]
Generated ApiView
Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/automation/armautomation | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
.Net | Azure.ResourceManager.Automation | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
JavaScript | @azure/arm-automation | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Thank you for your contribution sushil490023! We will review the pull request and get back to you soon.
Hi @sushil490023, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff
. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
Task | How to fix | Priority |
---|---|---|
Avocado | Fix-Avocado | High |
Semantic validation | Fix-SemanticValidation-Error | High |
Model validation | Fix-ModelValidation-Error | High |
LintDiff | Fix-LintDiff | high |
Hi @sushil490023, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Are the changes to the 2018-06-30 examples necessary? There is no change to the REST API definition for that version, so I would not expect changes in the examples either. Can you please revert these?
The changes to 2022-08-08 look fine and I can sign off on the breaking changes if needed (it looks like the label was removed so might not be needed).
Are the changes to the 2018-06-30 examples necessary? There is no change to the REST API definition for that version, so I would not expect changes in the examples either. Can you please revert these?
The changes to 2022-08-08 look fine and I can sign off on the breaking changes if needed (it looks like the label was removed so might not be needed).
Hey Thanks for reviewing the changes., WAS getting avacado errors
so updated them
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Hi @sushil490023, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
@msyyc to help check why python track 2 generation failure
@jianyexi We need a new release of Python codegen to fix the failure which may need some time and please ignore the failure for this PR
@microsoft-github-policy-service agree [company="microsoft"]
@microsoft-github-policy-service agree
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@microsoft-github-policy-service agree company="microsoft"
@microsoft-github-policy-service agree company="microsoft"