azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

[Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview

Open davidgamero opened this issue 3 years ago • 18 comments

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

davidgamero avatar Oct 11 '22 22:10 davidgamero

Hi, @davidgamero Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.2)] new version base version
    workflow.json 2022-10-11-preview(0295bcc) 2022-04-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-10 package-preview-2022-10(0295bcc) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L405
    :warning: PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L38
    :warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getgithuboauthinfo' in:'GitHubOAuth'. Consider updating the operationId
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L77
    :warning: ParameterDescription Parameter should have a description.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L89
    :warning: GetInOperationName 'GET' operation 'GitHubOAuthCallback' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L124
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L165
    :warning: PageableOperation Based on the response model schema, operation 'ListGitHubOAuth' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L165
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L208
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L247
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Workflows
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L280
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L292
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L332
    :warning: ParameterDescription Parameter should have a description.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L347
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L386
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'WorkflowModel'. Consider using the plural form of 'Workflow' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L429
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L640
    :warning: SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L889
    :warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.DevHub/preview/2022-10-11-preview/workflow.json#L892
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    ️❌~[Staging] ServiceAPIReadinessTest: 9 Errors, 0 Warnings failed [Detail]

    Tag package-preview-2022-10; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 10, untested: 0, failed: 9, passed: 1

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    CLIENT_ERROR "statusCode: 400,
    errorCode: NoRegisteredProviderFound,
    errorMessage: No registered resource provider found for location 'eastus2euap' and API version '2022-10-11-preview' for type 'workflows'. The supported api-versions are '2022-04-01-preview'. The supported locations are 'westcentralus,
    uksouth,
    eastus,
    australiacentral,
    australiaeast,
    brazilsouth,
    canadacentral,
    centralindia,
    eastasia,
    eastus2,
    francecentral,
    japaneast,
    jioindiawest,
    koreacentral,
    northcentralus,
    northeurope,
    norwayeast,
    qatarcentral,
    southafricanorth,
    swedencentral,
    switzerlandnorth,
    uaenorth,
    ukwest,
    westus2,
    australiacentral2,
    australiasoutheast,
    brazilsoutheast,
    canadaeast,
    centralus,
    francesouth,
    germanynorth,
    japanwest,
    jioindiacentral,
    koreasouth,
    norwaywest,
    southcentralus,
    southeastasia,
    southindia,
    switzerlandwest,
    uaecentral,
    westeurope,
    westus,
    westus3,
    eastus2euap,
    centraluseuap'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'workflows' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DevHub/workflows/workflowoq250x' under resource group 'apiTest-yQckDN-21071' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'workflows' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DevHub/workflows/workflowoq250x' under resource group 'apiTest-yQckDN-21071' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'operations' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'locations/githuboauth' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'locations/githuboauth' could not be found in the namespace 'Microsoft.DevHub' for api version '2022-10-11-preview'. The supported api-versions are '2022-04-01-preview'."
    CLIENT_ERROR "statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DevHub/locations/githuboauth/getGitHubOAuthInfo/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted,
    please refresh your credentials."
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/devhub/armdevhub - 0.2.0
    +	Const `PullRequestStatusRemoved` has been removed
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 52a702221e2ec849b9af51843ed77e4b55ab49be. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/devhub/armdevhub [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `PullRequestStatusRemoved` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `GenerationLanguageJava`
      info	[Changelog] - New const `GenerationLanguageJavascript`
      info	[Changelog] - New const `GenerationLanguageRust`
      info	[Changelog] - New const `GenerationLanguageGo`
      info	[Changelog] - New const `GenerationLanguagePython`
      info	[Changelog] - New const `GenerationLanguageSwift`
      info	[Changelog] - New const `GenerationLanguageGradle`
      info	[Changelog] - New const `GenerationLanguagePhp`
      info	[Changelog] - New const `GenerationLanguageGomodule`
      info	[Changelog] - New const `GenerationLanguageCsharp`
      info	[Changelog] - New const `GenerationLanguageRuby`
      info	[Changelog] - New const `GenerationLanguageClojure`
      info	[Changelog] - New const `GenerationLanguageErlang`
      info	[Changelog] - New type alias `GenerationLanguage`
      info	[Changelog] - New function `PossibleGenerationLanguageValues() []GenerationLanguage`
      info	[Changelog] - New struct `ArtifactGenerationProperties`
      info	[Changelog] - New field `ArtifactGenerationProperties` in struct `GitHubWorkflowProfile`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 18 additive change(s).
    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-js inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.DevHub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/devhub/armdevhub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-devhub Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi @davidgamero, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    /azp run unifiedPipeline

    davidgamero avatar Oct 11 '22 23:10 davidgamero

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 11 '22 23:10 azure-pipelines[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/devhub/armdevhub - Approved - 0.3.0
    +	Field `ManagedClusterResource` of struct `WorkflowClientListByResourceGroupOptions` has been removed
    +	Function `*DeveloperHubServiceClient.GitHubOAuthCallback` parameter(s) have been changed from `(context.Context, string, string, string, *DeveloperHubServiceClientGitHubOAuthCallbackOptions)` to `(context.Context, string, *DeveloperHubServiceClientGitHubOAuthCallbackOptions)`
    +	Function `NewDeveloperHubServiceClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, string, string, azcore.TokenCredential, *arm.ClientOptions)`
    +	Function `NewWorkflowClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, *string, azcore.TokenCredential, *arm.ClientOptions)`
    +	Type of `GitHubWorkflowProfile.AuthStatus` has been changed from `*ManifestType` to `*AuthorizationStatus`

    azure-sdk-for-js - @azure/arm-devhub - 1.0.0-beta.2
    +	Class DeveloperHubServiceClient has a new signature
    +	Interface WorkflowListByResourceGroupNextOptionalParams no longer has parameter managedClusterResource
    +	Interface WorkflowListByResourceGroupOptionalParams no longer has parameter managedClusterResource
    +	Type of parameter authStatus of interface Workflow is changed from ManifestType to AuthorizationStatus
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ae5784c4355f5a43ee71561dbbe4bc0768289fe0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/devhub/armdevhub [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `NewDeveloperHubServiceClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, string, string, azcore.TokenCredential, *arm.ClientOptions)`
      info	[Changelog] - Function `*DeveloperHubServiceClient.GitHubOAuthCallback` parameter(s) have been changed from `(context.Context, string, string, string, *DeveloperHubServiceClientGitHubOAuthCallbackOptions)` to `(context.Context, string, *DeveloperHubServiceClientGitHubOAuthCallbackOptions)`
      info	[Changelog] - Function `NewWorkflowClient` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, *string, azcore.TokenCredential, *arm.ClientOptions)`
      info	[Changelog] - Type of `GitHubWorkflowProfile.AuthStatus` has been changed from `*ManifestType` to `*AuthorizationStatus`
      info	[Changelog] - Field `ManagedClusterResource` of struct `WorkflowClientListByResourceGroupOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ManifestTypeKustomize` added to type alias `ManifestType`
      info	[Changelog] - New type alias `AuthorizationStatus` with values `AuthorizationStatusAuthorized`, `AuthorizationStatusError`, `AuthorizationStatusNotFound`
      info	[Changelog] - New type alias `DockerfileGenerationMode` with values `DockerfileGenerationModeDisabled`, `DockerfileGenerationModeEnabled`
      info	[Changelog] - New type alias `GenerationLanguage` with values `GenerationLanguageClojure`, `GenerationLanguageCsharp`, `GenerationLanguageErlang`, `GenerationLanguageGo`, `GenerationLanguageGomodule`, `GenerationLanguageGradle`, `GenerationLanguageJava`, `GenerationLanguageJavascript`, `GenerationLanguagePhp`, `GenerationLanguagePython`, `GenerationLanguageRuby`, `GenerationLanguageRust`, `GenerationLanguageSwift`
      info	[Changelog] - New type alias `ManifestGenerationMode` with values `ManifestGenerationModeDisabled`, `ManifestGenerationModeEnabled`
      info	[Changelog] - New struct `ArtifactGenerationProperties`
      info	[Changelog] - New field `ArtifactGenerationProperties` in struct `GitHubWorkflowProfile`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 28 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from ae5784c4355f5a43ee71561dbbe4bc0768289fe0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-devhub [View full logs]  [Preview SDK Changes]
      info	[Changelog]   - Initial Release
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from ae5784c4355f5a43ee71561dbbe4bc0768289fe0. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-devhub [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ArtifactGenerationProperties
      info	[Changelog]   - Added Type Alias AuthorizationStatus
      info	[Changelog]   - Added Type Alias DockerfileGenerationMode
      info	[Changelog]   - Added Type Alias GenerationLanguage
      info	[Changelog]   - Added Type Alias ManifestGenerationMode
      info	[Changelog]   - Interface DeveloperHubServiceClientOptionalParams has a new optional parameter managedClusterResource
      info	[Changelog]   - Interface Workflow has a new optional parameter artifactGenerationProperties
      info	[Changelog]   - Added Enum KnownAuthorizationStatus
      info	[Changelog]   - Added Enum KnownDockerfileGenerationMode
      info	[Changelog]   - Added Enum KnownGenerationLanguage
      info	[Changelog]   - Added Enum KnownManifestGenerationMode
      info	[Changelog]   - Enum KnownManifestType has a new value Kustomize
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class DeveloperHubServiceClient has a new signature
      info	[Changelog]   - Interface WorkflowListByResourceGroupNextOptionalParams no longer has parameter managedClusterResource
      info	[Changelog]   - Interface WorkflowListByResourceGroupOptionalParams no longer has parameter managedClusterResource
      info	[Changelog]   - Type of parameter authStatus of interface Workflow is changed from ManifestType to AuthorizationStatus
    Posted by Swagger Pipeline | How to fix these errors?

    Hi, @davidgamero your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    /azp run unifiedPipeline

    davidgamero avatar Oct 12 '22 02:10 davidgamero

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 12 '22 02:10 azure-pipelines[bot]

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    /azp run unifiedPipeline

    davidgamero avatar Oct 14 '22 18:10 davidgamero

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 14 '22 18:10 azure-pipelines[bot]

    Approved for Go breakings because it is a preview version.

    tadelesh avatar Oct 19 '22 04:10 tadelesh

    /azp run

    xiaoxuqi-ms avatar Oct 26 '22 03:10 xiaoxuqi-ms

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Oct 26 '22 03:10 azure-pipelines[bot]

    @davidgamero please take a look at the api tests and make sure all apis are deployed to prod.

    xiaoxuqi-ms avatar Oct 26 '22 05:10 xiaoxuqi-ms

    Hi, @davidgamero. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 13 '22 16:11 ghost

    Hi, @davidgamero. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Nov 28 '22 05:11 ghost

    the api is now deploying

    davidgamero avatar Dec 13 '22 20:12 davidgamero

    /azp run

    xiaoxuqi-ms avatar Dec 16 '22 09:12 xiaoxuqi-ms

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Dec 16 '22 09:12 azure-pipelines[bot]

    @leni-msft , could you help to take a look at the api readiness check, I just rerun our pipeline and it still fails

    xiaoxuqi-ms avatar Dec 16 '22 09:12 xiaoxuqi-ms

    @davidgamero is the new apiVersion deployed? or is it bebind some feature flag? The API Readiness test error is caused by not able to access the workflows API on 2022-10-11-preview version.

    leni-msft avatar Dec 16 '22 09:12 leni-msft

    Hi, @davidgamero. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jan 01 '23 16:01 ghost

    Hi, @davidgamero. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Jan 16 '23 05:01 ghost