[Purview - Account API] API Review

[azure-sdk]

New API Review meeting has been requested.

Service Name: Microsoft Purview Review Created By: Phani Kumar Vadali Review Date: 10/26/2022 9:00 AM PT PR: https://github.com/Azure/azure-rest-api-specs/pull/21055 Hero Scenarios Link: Not Provided Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here

[azure-sdk]

Meeting updated by Phani Kumar Vadali

Service Name: Microsoft Purview Review Created By: Phani Kumar Vadali Review Date: 10/26/2022 9:00 AM PT PR: https://github.com/Azure/azure-rest-api-specs/pull/21055 Hero Scenarios Link: Not Provided Core Concepts Doc Link: Not Provided

Description:

Detailed meeting information and documents provided can be accessed here

[markweitzel]

API Stewardship Board Review: 26-Oct-22

• Cobranding status should be an enumeration, but the issue is that we should not model an enumeration as an enum. This should be a boolean and we should not follow the ARM rules. This is meant for customers to be settable. Consider changing this to an enabled property that can be true/false. This leaves the status field to be used in the future if there are values that will be added. Some potential values of status can follow the long running operation
• Need an example of #color and a better description of what's expected.
• For the base64 encoding, use the proper format, type: string, format: byte, see: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/2.0.md#data-types
• It sounds more like we should maybe have: preferences/account and preferences/users/{id}
  • Should have a currentUser or "me" as the value
• Add a : to the POST for regenerateKeys

[mikekistler]

@pvadali-az What's the status of this API change?

[pvadali-az]

Hi @mikekistler can you close this issue for now? I haven't heard from UX yet and I will have UserLevelPreferences coming up. I will add these endpoints along with the feedback in a new PR