azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
Service Fabric Managed Clusters - api version 2022-10-01-preview
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. 10/29/2022
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 10/31/2022
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- [] Adding a new service
- [] Adding new API(s)
- [x] Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 5 Errors, 1 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| managedapplication.json | 2022-10-01-preview(116ca3e) | 2022-01-01(main) |
| managedapplication.json | 2022-10-01-preview(116ca3e) | 2022-08-01-preview(main) |
| managedcluster.json | 2022-10-01-preview(116ca3e) | 2022-01-01(main) |
| managedcluster.json | 2022-10-01-preview(116ca3e) | 2022-08-01-preview(main) |
| nodetype.json | 2022-10-01-preview(116ca3e) | 2022-01-01(main) |
| nodetype.json | 2022-10-01-preview(116ca3e) | 2022-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| :warning: 1025 - RequiredStatusChange | The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2022-10-01-preview/nodetype.json#L712:7 Old: Microsoft.ServiceFabric/preview/2022-08-01-preview/nodetype.json#L712:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-10-preview | package-2022-10-preview(116ca3e) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 49 Errors, 0 Warnings failed [Detail]
Tag package-2022-10-preview; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 45, untested: 0, failed: 39, passed: 6
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 400, errorCode: InvalidParameter, errorMessage: Value cannot be null. Parameter name: Sku Source: runtime OperationId: ManagedClusters_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusterno9nhuc' under resource group 'apiTest-tBOVNS-21033' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedClusters_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ServiceFabric/managedclusters/clusterno9nhuc' under resource group 'apiTest-tBOVNS-21033' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedClusters_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_CreateOrUpdate |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_List |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: Applications_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_CreateOrUpdate |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_List |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: ApplicationTypes_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_CreateOrUpdate |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_ListByManagedClusters |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Reimage |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_DeleteNode |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc' not found. Source: runtime OperationId: NodeTypes_Restart |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_CreateOrUpdate |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_ListByApplicationTypes |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicatu0e4fu' not found. Source: runtime OperationId: ApplicationTypeVersions_Update |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_CreateOrUpdate |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_ListByApplications |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_Get |
|
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'clusterno9nhuc/applicats1yvwf' not found. Source: runtime OperationId: Services_Update |
|
statusCode: 400, errorCode: InvalidRequestFormat, errorMessage: Cannot parse the request. Source: runtime OperationId: ManagedClusterVersion_ListByEnvironment |
|
Additional properties not allowed: details Source: response OperationId: ManagedClusterVersion_ListByEnvironment |
|
statusCode: 400, errorCode: InvalidRequestFormat, errorMessage: Cannot parse the request. Source: runtime OperationId: ManagedClusterVersion_GetByEnvironment |
|
Additional properties not allowed: details Source: response OperationId: ManagedClusterVersion_GetByEnvironment |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from ccdee2b681bd2d7a1a6cbb3fee83a5f80c7e6a03. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.ServiceFabricManagedClusters [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from ccdee2b681bd2d7a1a6cbb3fee83a5f80c7e6a03. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs] [Release SDK Changes]- azure-mgmt-servicefabricmanagedclusters-0.1.0.zip
- azure_mgmt_servicefabricmanagedclusters-0.1.0-py3-none-any.whl
info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model ManagedCluster has a new parameter use_custom_vnet info [Changelog] - Model ManagedCluster has a new parameter zonal_update_mode info [Changelog] - Model NodeType has a new parameter subnet_id info [Changelog] - Model NodeType has a new parameter vm_setup_actions info [Changelog] - Model NodeTypeActionParameters has a new parameter update_type info [Changelog] - Model ServiceResourceProperties has a new parameter service_dns_name info [Changelog] - Model StatefulServiceProperties has a new parameter service_dns_name info [Changelog] - Model StatelessServiceProperties has a new parameter service_dns_name
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs]Release - Generate from ccdee2b681bd2d7a1a6cbb3fee83a5f80c7e6a03. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️servicefabricmanagedclusters [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs]Release - Generate from ccdee2b681bd2d7a1a6cbb3fee83a5f80c7e6a03. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.servicefabricmanagedclusters [View full logs] [Release SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| .Net | Azure.ResourceManager.ServiceFabricManagedClusters | There is no API change compared with the previous version |
Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
Hi @a-santamaria, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.
Hi, @a-santamaria, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline
Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@live1206, could you help me understand why this validation is failing? https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9209480618 it looks to me that the allowedResources is correct with respect of the example. Is it a bug or am I missing somethings?
Object didn't pass validation for format arm-id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/applicationGateways/appgw-test/backendAddressPools/appgwBepoolTest
"allowedResources": [ { "type": "Microsoft.Network/applicationGateways/backendAddressPools" }
@live1206, could you help me understand why this validation is failing? https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9209480618 it looks to me that the allowedResources is correct with respect of the example. Is it a bug or am I missing somethings?
Object didn't pass validation for format arm-id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/applicationGateways/appgw-test/backendAddressPools/appgwBepoolTest
"allowedResources": [ { "type": "Microsoft.Network/applicationGateways/backendAddressPools" }
@live1206, could you help me understand why this validation is failing? https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9209480618 it looks to me that the allowedResources is correct with respect of the example. Is it a bug or am I missing somethings?
Object didn't pass validation for format arm-id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/applicationGateways/appgw-test/backendAddressPools/appgwBepoolTest
"allowedResources": [ { "type": "Microsoft.Network/applicationGateways/backendAddressPools" }
@a-santamaria , there is an extra space after beginning quotation mark ", e.g. "loadBalancerInboundNatPoolId": " /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/inboundNatPools/LoadBalancerNATPool"
@live1206, could you help me understand why this validation is failing? https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9209480618 it looks to me that the allowedResources is correct with respect of the example. Is it a bug or am I missing somethings? Object didn't pass validation for format arm-id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/applicationGateways/appgw-test/backendAddressPools/appgwBepoolTest "allowedResources": [ { "type": "Microsoft.Network/applicationGateways/backendAddressPools" }
@live1206, could you help me understand why this validation is failing? https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9209480618 it looks to me that the allowedResources is correct with respect of the example. Is it a bug or am I missing somethings? Object didn't pass validation for format arm-id: /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/applicationGateways/appgw-test/backendAddressPools/appgwBepoolTest "allowedResources": [ { "type": "Microsoft.Network/applicationGateways/backendAddressPools" }
@a-santamaria , there is an extra space after beginning quotation mark ", e.g. "loadBalancerInboundNatPoolId": " /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resRg/providers/Microsoft.Network/loadBalancers/test-LB/inboundNatPools/LoadBalancerNATPool"
Thanks, @live1206, I missed that. fixed
@a-santamaria Please kick off the breaking change review as the previous comment required. The API Readiness Check is failing due to lack of deployment, the PR can't be merged until the deployment is in place.
@a-santamaria Please kick off the breaking change review as the previous comment required. The API Readiness Check is failing due to lack of deployment, the PR can't be merged until the deployment is in place.
@live1206, Thanks. I have created this intake for the first breaking change reported: https://msazure.visualstudio.com/One/_workitems/edit/16129392 which is removing a property from the required list. But for the next 4 https://github.com/Azure/azure-rest-api-specs/pull/21033/checks?check_run_id=9231300908 which are AddedXmsEnum why are we getting flagged? these changes were introduced back in the feb api version 2022-02-01-preview
@a-santamaria for the AddedXmsEnum, you should step into the '$refs', actually its accurate error location is the https://github.com/Azure/azure-rest-api-specs/blob/5f2ea681f89b207fc9d46f4c40346f03a0b26624/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2022-10-01-preview/managedcluster.json#L770,
@jianyexi what do you mean by "step into the '$refs',"? the x-ms-enum are already inside the definitions that are called by $ref, aren't they?
@jianyexi what do you mean by "step into the '$refs',"? the x-ms-enum are already inside the definitions that are called by $ref, aren't they?
Yes, it was flagged is because the breaking change tool will compare the current swagger with the latest stable version which doesn't contain the 'x-ms-enum' , see https://github.com/Azure/azure-rest-api-specs/blob/8c9845c7190792cb95c0deda1cb787512c4c7ca1/specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L722
Hi, @a-santamaria. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @a-santamaria. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.
Hi, @a-santamaria. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @a-santamaria. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.
app deployment will finish by the end of this week and we will start the RP manifest upgrade next week
@live1206 can you please merge the pr? the RP manifest is already deployed.