azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[IoT Central] API Review

Open azure-sdk opened this issue 3 years ago • 2 comments
trafficstars

New API Review meeting has been requested.

Service Name: IoT Central Review Created By: Johnson Yang Review Date: 10/20/2022 4:00 PM PT PR: https://github.com/Azure/azure-rest-api-specs/pull/20981 Hero Scenarios Link: Not Provided Core Concepts Doc Link: here

Description: Add new 2022-10-31-preview version for following changes:

• Add Edge Device Deployment Manifest List, Create, Update, Remove support. • Replace $top with maxpagesize from legacy preview version. (users, jobs, scheduled jobs, devices, device templates, device groups, dashboards) • Replace $filter with filter from legacy preview version. (devices, device groups, dashboards, device templates) • Replace $orderby with orderby from legacy preview version. (devices, device groups, device templates) • Add read only id scope from Enrollment Group. • Add optional read access from File Upload Configuration, default is false. • Add new route for edge device to apply manifest. • Add new expand parameter for device route to retrieve deployment manifest when specify ?expand=deploymentManifest • Remove deploymentManifest from legacy device template contract. • Add new type: string[] for device creation, currently only allow iotEdge, type can't be changed after creation.

Detailed meeting information and documents provided can be accessed here

azure-sdk avatar Oct 06 '22 16:10 azure-sdk

API Stewardship Board Review: 20-Oct-22

  • Use additionalProperties = true to give better indication to code gen for the SDKs See: https://swagger.io/specification/v2/#model-with-mapdictionary-properties

  • Support the standard conditional requests pattern using the If-Match header

  • Check the use of model as string false -- some of these should be true

  • Open question on ETag that we will follow up async.

Next Steps

No blockers for preview.

Meeting Chat

markweitzel avatar Oct 21 '22 12:10 markweitzel

@markweitzel

I have fixed "modelAsString" from false to true for any enumeration value consider to be extended in future, we also exposed if-match header as our API already supported, but we throws errors when etag in body and header are different, final cases are:

  1. specified from if-match header only.
  2. specified from body only
  3. if both are specified, they should be same, otherwise throws error.

Would you please take a look on these changes? please let us know if there is any issues with this change.

Thanks, Johnson

yang-hai-feng avatar Oct 26 '22 17:10 yang-hai-feng