azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

`ResourceGuardProxy` - missing `PUT` parameter `resourceGuardResourceId`

Open ziyeqf opened this issue 2 years ago • 4 comments

swagger link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4362

example link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/examples/ResourceGuardProxyCRUD/PutResourceGuardProxy.json

In the swagger file, there is no parameter named resourceGuardResourceId in ResourceGuardProxy_Put while in the example there is. the parameter is needed to create.

ziyeqf avatar Sep 30 '22 06:09 ziyeqf

@ziyeqf Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

navba-MSFT avatar Oct 26 '22 04:10 navba-MSFT

@ziyeqf AFAIK, the PUT operation is using the schema definition from ResourceGuardProxyBaseResource which inturn gets the definition reference from ResourceGuardProxyBase which has the property resourceGuardResourceId.

Sending you the below details if that helps.

https://github.com/Azure/azure-rest-api-specs/blob/21426cf85836ec17aaa4f20f58324a8666925e34/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4392-L4397

https://github.com/Azure/azure-rest-api-specs/blob/21426cf85836ec17aaa4f20f58324a8666925e34/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L12551-L12564

https://github.com/Azure/azure-rest-api-specs/blob/21426cf85836ec17aaa4f20f58324a8666925e34/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L12528-L12534

navba-MSFT avatar Oct 26 '22 08:10 navba-MSFT

@navba-MSFT Thanks for your insight.

But it seems the ResourceGuardProxyBase is referenced in response of ResourceGuardProxy_Put, rather than parameters. and it's needed in parameters.

ziyeqf avatar Oct 26 '22 08:10 ziyeqf

@ziyeqf The above PR is currently under review.

navba-MSFT avatar Oct 27 '22 03:10 navba-MSFT