azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
[Hub Generated] Publish private branch 'dev-logic-Microsoft.Logic-2022-09-01-preview'
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/7415
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 2 Errors, 112 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| logic.json | 2022-09-01-preview(7f4f0e5) | 2019-05-01(main) |
| logic.json | 2022-09-01-preview(7f4f0e5) | 2018-07-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a client parameter that was found in the old version. Was 'subscriptionId' removed or renamed? New: azure-rest-api-specs/blob/7f4f0e5e037b76d8fd045d11ed0bd98775033100/revision#L22147:2 Old: Microsoft.Logic/stable/2019-05-01/logic.json#L13101:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed? New: azure-rest-api-specs/blob/7f4f0e5e037b76d8fd045d11ed0bd98775033100/revision#L22147:2 Old: Microsoft.Logic/stable/2019-05-01/logic.json#L13101:3 |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️⚠️LintDiff: 255 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2022-09 | package-preview-2022-09(7f4f0e5) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L154 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L363 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L410 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L457 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L516 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L575 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L625 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L626 |
|
A 202 response should include an Location response header. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L673 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L679 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L685 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L741 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L797 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L858 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L915 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L984 |
|
The resource name parameter 'triggerName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L984 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1041 |
|
The resource name parameter 'triggerName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1041 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1095 |
|
The resource name parameter 'triggerName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1095 |
|
Operations with a 202 response must specify x-ms-long-running-operation: true.Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1096 |
|
An async POST operation must set ''x-ms-long-running-operation' : true'. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1096 |
|
A 202 response should include an Location response header. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1140 |
|
The path for nested resource doest not meet the valid resource pattern. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1152 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1152 |
|
The resource name parameter 'triggerName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1152 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1209 |
|
The resource name parameter 'triggerName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1209 |
|
The resource name parameter 'workflowName' should be defined with a 'pattern' restriction. Location: Microsoft.Logic/preview/2022-09-01-preview/logic.json#L1272 |
️❌Avocado: 6 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/run is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/accessKeys is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/accessKeys/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/accessKeys/{}/list is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/accessKeys/{}/regenerate is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Logic/workflows/{}/triggers/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/logic/resource-manager/readme.md json: Microsoft.Logic/preview/2015-02-01-preview/logic.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Logic [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: There was an error checking the latest version of pip. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-logic [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group LocationsOperations
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-logic [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/logic/armlogic [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New enum type `ExportDetailCategory` with values `ExportDetailCategoryInformation`, `ExportDetailCategoryNotSpecified`, `ExportDetailCategoryRequiredStep` info [Changelog] - New enum type `ExportDetailCode` with values `ExportDetailCodeConnectionCloningUnsupported`, `ExportDetailCodeNotSpecified` info [Changelog] - New enum type `ValidationState` with values `ValidationStateFailed`, `ValidationStateNotSpecified`, `ValidationStateSucceeded`, `ValidationStateSucceededWithWarning` info [Changelog] - New enum type `WorkflowExportOptions` with values `WorkflowExportOptionsCloneConnections`, `WorkflowExportOptionsCloneConnectionsGenerateInfrastructureTemplates`, `WorkflowExportOptionsGenerateInfrastructureTemplates` info [Changelog] - New function `*ClientFactory.NewLocationsClient() *LocationsClient` info [Changelog] - New function `NewLocationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*LocationsClient, error)` info [Changelog] - New function `*LocationsClient.ValidateWorkflowExport(context.Context, string, WorkflowExportRequest, *LocationsClientValidateWorkflowExportOptions) (LocationsClientValidateWorkflowExportResponse, error)` info [Changelog] - New function `*LocationsClient.WorkflowExport(context.Context, string, WorkflowExportRequest, *LocationsClientWorkflowExportOptions) (LocationsClientWorkflowExportResponse, error)` info [Changelog] - New struct `ConnectionExportValidity` info [Changelog] - New struct `ExportDetail` info [Changelog] - New struct `ResourceExportValidity` info [Changelog] - New struct `WorkflowExportRequest` info [Changelog] - New struct `WorkflowExportResult` info [Changelog] - New struct `WorkflowExportValidity` info [Changelog] - New struct `WorkflowExportValidityResult` info [Changelog] info [Changelog] Total 0 breaking change(s), 34 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-logic [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group Locations info [Changelog] - Added Interface ConnectionExportValidity info [Changelog] - Added Interface ExportDetail info [Changelog] - Added Interface LocationsValidateWorkflowExportOptionalParams info [Changelog] - Added Interface LocationsWorkflowExportOptionalParams info [Changelog] - Added Interface ResourceExportValidity info [Changelog] - Added Interface WorkflowExportRequest info [Changelog] - Added Interface WorkflowExportResult info [Changelog] - Added Interface WorkflowExportValidity info [Changelog] - Added Interface WorkflowExportValidityResult info [Changelog] - Added Type Alias ExportDetailCategory info [Changelog] - Added Type Alias ExportDetailCode info [Changelog] - Added Type Alias LocationsValidateWorkflowExportResponse info [Changelog] - Added Type Alias LocationsWorkflowExportResponse info [Changelog] - Added Type Alias ValidationState info [Changelog] - Added Type Alias WorkflowExportOptions info [Changelog] - Added Enum KnownExportDetailCategory info [Changelog] - Added Enum KnownExportDetailCode info [Changelog] - Added Enum KnownValidationState info [Changelog] - Added Enum KnownWorkflowExportOptions
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.1 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️❌ azure-powershell failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from 5e63ea4dcbe1caeb95f1d88f026a94a116108281. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json SSL error: syscall failure: Broken pipe Error: SSL error: syscall failure: Broken pipe
⚠️Az.logic.DefaultTag [View full logs]error Fatal error: SSL error: syscall failure: Broken pipe error The following packages are still pending: error Az.logic.DefaultTag
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/logic/armlogic | https://apiview.dev/Assemblies/Review/0bdaa0e24ea342968ec210e2a9ed0127 |
| Java | azure-resourcemanager-logic | https://apiview.dev/Assemblies/Review/074743611b0a41129b1f71164aec4a9b |
| .Net | Azure.ResourceManager.Logic | https://apiview.dev/Assemblies/Review/d5f621b4538c4c07bcb00e111ed815af |
| JavaScript | @azure/arm-logic | https://apiview.dev/Assemblies/Review/21a52b72e43d40b997709302521febc9 |
| Swagger | Microsoft.Logic | https://apiview.dev/Assemblies/Review/8b89c632c3a0413d9a43555f4dd9bb2d |
"/subscriptions/{subscriptionId}/providers/Microsoft.Logic/locations/{location}/workflowExport": {
This looks like this defined as a POST action on the locations resource and takes the workflowid as input.
Few points here :
-
If you do it this way , do you plan to add linked access checks to make sure that the called has permissions on the workflow itself ?
-
why did you choose to not instead go adding this as a post action on the workflow instead ? That way you dont have to worry about such RBAC issues
Refers to: specification/logic/resource-manager/Microsoft.Logic/preview/2022-09-01-preview/logic.json:6454 in 7f4f0e5. [](commit_id = 7f4f0e5e037b76d8fd045d11ed0bd98775033100, deletion_comment = False)
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
- We did add the linked access check necessary, ping me on teams and I can share the manifest in our repo that has this check.
- The reason is that the workflow export API here can take in 1 or more workflows. So the input is an array of workflows and not a single workflow id. For the same reason, we thought the API shouldn't be on a workflow resource since you can export multiple in the same request. We chose location because the workflows you choose to export have to be from the same location. Let me know if that makes sense, I can share more info if needed.
- We did add the linked access check necessary, ping me on teams and I can share the manifest in our repo that has this check.
- The reason is that the workflow export API here can take in 1 or more workflows. So the input is an array of workflows and not a single workflow id. For the same reason, we thought the API shouldn't be on a workflow resource since you can export multiple in the same request. We chose location because the workflows you choose to export have to be from the same location. Let me know if that makes sense, I can share more info if needed.
Thanks this makes sense
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @AbodeSaafan, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi @AbodeSaafan
- There are some CredScan errors in your PR, it may cause credential leak, you can see details in pipeline log.
- Service seems not deployed, before merge, service should be deployed.
Hi, @AbodeSaafan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @AbodeSaafan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.
Next Steps to Merge
Next steps that must be taken to merge this PR:- ❌ Your PR has breaking changes (label:
BreakingChangeReviewRequired). See the PR description for help. - ❌ The required check named
Swagger ModelValidationhas failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it.
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
Hi, @AbodeSaafan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
![microsoft-github-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/95686?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, @AbodeSaafan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @AbodeSaafan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.