azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Utkarshjain/elastic private repo sync 09 2022
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [x] Other, please clarify : The new API version are already merged in the private repo (azure-rest-api-specs-pr). This PR sync the repo and to generate required SDKs.
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @utkarshjain1508 Thanks for your PR. I am workflow bot for review process. Here are some small tips.
Hi, @utkarshjain1508 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
Swagger Validation Report
️️✔️
BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
elastic.json | 2022-05-05-preview(3bb20fc) | 2020-07-01(main) |
elastic.json | 2022-05-05-preview(3bb20fc) | 2021-10-01-preview(main) |
elastic.json | 2022-07-01-preview(3bb20fc) | 2020-07-01(main) |
elastic.json | 2022-07-01-preview(3bb20fc) | 2021-10-01-preview(main) |
️⌛
CredScan pending [Detail]
️⚠️
LintDiff: 24 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-05-05-preview | package-2022-05-05-preview(3bb20fc) | default(main) |
package-2022-07-01-preview | package-2022-07-01-preview(3bb20fc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
:warning: R1003 - ListInOperationName | Since operation 'UpgradableVersionsDetails' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L863 |
|
:warning: R1003 - ListInOperationName | Since operation 'UpgradableVersionsDetails' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createorupdateexternaluser' in:'ExternalUser_CreateOrUpdate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L464 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listupgradableversions' in:'UpgradableVersions_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listalltrafficfilters' in:'AllTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L962 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listassociatedtrafficfilters' in:'listAssociatedTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1007 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateipfilter' in:'createAndAssociateIPFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1052 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateplfilter' in:'createAndAssociatePLFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1107 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'associatetrafficfilter' in:'AssociateTrafficFilter_Associate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1168 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachtrafficfilter' in:'DetachTrafficFilter_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1269 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createorupdateexternaluser' in:'ExternalUser_CreateOrUpdate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L464 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listupgradableversions' in:'UpgradableVersions_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listalltrafficfilters' in:'AllTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L962 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listassociatedtrafficfilters' in:'listAssociatedTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1007 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateipfilter' in:'createAndAssociateIPFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1052 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateplfilter' in:'createAndAssociatePLFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1107 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'associatetrafficfilter' in:'AssociateTrafficFilter_Associate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1168 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachanddeletetrafficfilter' in:'DetachAndDeleteTrafficFilter_Delete'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1217 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachtrafficfilter' in:'DetachTrafficFilter_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1265 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'deletetrafficfilter' in:'TrafficFilters_Delete'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1314 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: created Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L2028 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeByDefault Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L2201 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: created Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2021 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeByDefault Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2194 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listmonitoredresources' in:'MonitoredResources_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L371 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listdeploymentinfo' in:'DeploymentInfo_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L419 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listvmhost' in:'VMHost_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L720 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmingestiondetails' in:'VMIngestion_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L768 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmcollectionupdate' in:'VMCollection_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L813 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listmonitoredresources' in:'MonitoredResources_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L371 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listdeploymentinfo' in:'DeploymentInfo_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L419 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listvmhost' in:'VMHost_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L720 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmingestiondetails' in:'VMIngestion_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L768 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmcollectionupdate' in:'VMCollection_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L813 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'tagRules' with immediate parent 'ElasticMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1936 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'tagRules' with immediate parent 'ElasticMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1929 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1433 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1900 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1904 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1908 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1426 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1893 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1897 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1901 |
:warning: R4021 - DescriptionAndTitleMissing | 'LiftrResourceCategories' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1647 |
:warning: R4021 - DescriptionAndTitleMissing | 'LiftrResourceCategories' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1640 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 46 Errors, 0 Warnings failed [Detail]
Tag package-2022-07-01-preview; Prod region: Deployed
Test run on region: centralindia; Operation coverage: total: 27, untested: 0, failed: 23, passed: 4
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
"statusCode: 400, errorCode: InvalidResource, errorMessage: The resource definition is invalid." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 400" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 400, errorCode: InvalidResource, errorMessage: The resource definition is invalid." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 400" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornam8f67yf' not found." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornam8f67yf' not found." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Can not perform requested operation on nested resource. Parent resource 'monitornam8f67yf' not found." |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
CLIENT_ERROR |
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Elastic/monitors/monitornam8f67yf' under resource group 'apiTest-uehWaO-20791' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
ASSERTION_ERROR |
"expected response code to be 2XX but found 404" |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⌛
PoliCheck pending [Detail]
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/3bb20fc20c8cbf05ea1a4e397d30cd360b179358/specification/elastic/resource-manager/readme.md#tag-package-2022-05-05-preview">elastic/resource-manager/readme.md#package-2022-05-05-preview
- "https://github.com/Azure/azure-rest-api-specs/blob/3bb20fc20c8cbf05ea1a4e397d30cd360b179358/specification/elastic/resource-manager/readme.md#tag-package-2022-07-01-preview">elastic/resource-manager/readme.md#package-2022-07-01-preview
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️🔄
PR Summary inProgress [Detail]
Swagger Generation Artifacts
️️✔️
ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️⚠️
azure-sdk-for-python-track2 warning [Detail]
⚠️
Warning [Logs]Release - Generate from 628535ee1851f6be02f73223bf371bbad930090d. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️
track2_azure-mgmt-elastic [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group AllTrafficFiltersOperations info [Changelog] - Added operation group AssociateTrafficFilterOperations info [Changelog] - Added operation group CreateAndAssociateIPFilterOperations info [Changelog] - Added operation group CreateAndAssociatePLFilterOperations info [Changelog] - Added operation group DetachAndDeleteTrafficFilterOperations info [Changelog] - Added operation group DetachTrafficFilterOperations info [Changelog] - Added operation group ExternalUserOperations info [Changelog] - Added operation group ListAssociatedTrafficFiltersOperations info [Changelog] - Added operation group MonitorOperations info [Changelog] - Added operation group TrafficFiltersOperations info [Changelog] - Added operation group UpgradableVersionsOperations info [Changelog] - Model MonitorProperties has a new parameter version
️️✔️
azure-sdk-for-java succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 628535ee1851f6be02f73223bf371bbad930090d. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️
azure-resourcemanager-elastic [View full logs] [Release SDK Changes]
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 628535ee1851f6be02f73223bf371bbad930090d. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️
sdk/resourcemanager/elastic/armelastic [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `APIVersionParameterTwoThousandTwenty0701` info [Changelog] - New const `TypeAzurePrivateEndpoint` info [Changelog] - New const `APIVersionParameterTwoThousandTwentyOne0901Preview` info [Changelog] - New const `APIVersionParameterTwoThousandTwentyOne1001Preview` info [Changelog] - New const `TypeIP` info [Changelog] - New const `APIVersionParameterTwoThousandTwentyTwo0505Preview` info [Changelog] - New const `APIVersionParameterTwoThousandTwenty0701Preview` info [Changelog] - New type alias `APIVersionParameter` info [Changelog] - New type alias `Type` info [Changelog] - New function `*ListAssociatedTrafficFiltersClient.List(context.Context, string, string, *ListAssociatedTrafficFiltersClientListOptions) (ListAssociatedTrafficFiltersClientListResponse, error)` info [Changelog] - New function `NewListAssociatedTrafficFiltersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ListAssociatedTrafficFiltersClient, error)` info [Changelog] - New function `NewAssociateTrafficFilterClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AssociateTrafficFilterClient, error)` info [Changelog] - New function `*AllTrafficFiltersClient.List(context.Context, string, string, *AllTrafficFiltersClientListOptions) (AllTrafficFiltersClientListResponse, error)` info [Changelog] - New function `*MonitorClient.BeginUpgrade(context.Context, string, string, *MonitorClientBeginUpgradeOptions) (*runtime.Poller[MonitorClientUpgradeResponse], error)` info [Changelog] - New function `NewUpgradableVersionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpgradableVersionsClient, error)` info [Changelog] - New function `*UpgradableVersionsClient.Details(context.Context, string, string, *UpgradableVersionsClientDetailsOptions) (UpgradableVersionsClientDetailsResponse, error)` info [Changelog] - New function `*CreateAndAssociateIPFilterClient.BeginCreate(context.Context, string, string, *CreateAndAssociateIPFilterClientBeginCreateOptions) (*runtime.Poller[CreateAndAssociateIPFilterClientCreateResponse], error)` info [Changelog] - New function `*ExternalUserClient.CreateOrUpdate(context.Context, string, string, *ExternalUserClientCreateOrUpdateOptions) (ExternalUserClientCreateOrUpdateResponse, error)` info [Changelog] - New function `*DetachAndDeleteTrafficFilterClient.Delete(context.Context, string, string, *DetachAndDeleteTrafficFilterClientDeleteOptions) (DetachAndDeleteTrafficFilterClientDeleteResponse, error)` info [Changelog] - New function `NewDetachTrafficFilterClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DetachTrafficFilterClient, error)` info [Changelog] - New function `NewDetachAndDeleteTrafficFilterClient(string, azcore.TokenCredential, *arm.ClientOptions) (*DetachAndDeleteTrafficFilterClient, error)` info [Changelog] - New function `PossibleTypeValues() []Type` info [Changelog] - New function `*CreateAndAssociatePLFilterClient.BeginCreate(context.Context, string, string, *CreateAndAssociatePLFilterClientBeginCreateOptions) (*runtime.Poller[CreateAndAssociatePLFilterClientCreateResponse], error)` info [Changelog] - New function `*DetachTrafficFilterClient.BeginUpdate(context.Context, string, string, *DetachTrafficFilterClientBeginUpdateOptions) (*runtime.Poller[DetachTrafficFilterClientUpdateResponse], error)` info [Changelog] - New function `NewMonitorClient(string, azcore.TokenCredential, *arm.ClientOptions) (*MonitorClient, error)` info [Changelog] - New function `*TrafficFiltersClient.Delete(context.Context, string, string, *TrafficFiltersClientDeleteOptions) (TrafficFiltersClientDeleteResponse, error)` info [Changelog] - New function `NewTrafficFiltersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*TrafficFiltersClient, error)` info [Changelog] - New function `PossibleAPIVersionParameterValues() []APIVersionParameter` info [Changelog] - New function `*AssociateTrafficFilterClient.BeginAssociate(context.Context, string, string, *AssociateTrafficFilterClientBeginAssociateOptions) (*runtime.Poller[AssociateTrafficFilterClientAssociateResponse], error)` info [Changelog] - New function `NewExternalUserClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExternalUserClient, error)` info [Changelog] - New function `NewCreateAndAssociatePLFilterClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CreateAndAssociatePLFilterClient, error)` info [Changelog] - New function `NewAllTrafficFiltersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AllTrafficFiltersClient, error)` info [Changelog] - New function `NewCreateAndAssociateIPFilterClient(string, azcore.TokenCredential, *arm.ClientOptions) (*CreateAndAssociateIPFilterClient, error)` info [Changelog] - New struct `AllTrafficFiltersClient` info [Changelog] - New struct `AllTrafficFiltersClientListOptions` info [Changelog] - New struct `AllTrafficFiltersClientListResponse` info [Changelog] - New struct `AssociateTrafficFilterClient` info [Changelog] - New struct `AssociateTrafficFilterClientAssociateResponse` info [Changelog] - New struct `AssociateTrafficFilterClientBeginAssociateOptions` info [Changelog] - New struct `CreateAndAssociateIPFilterClient` info [Changelog] - New struct `CreateAndAssociateIPFilterClientBeginCreateOptions` info [Changelog] - New struct `CreateAndAssociateIPFilterClientCreateResponse` info [Changelog] - New struct `CreateAndAssociatePLFilterClient` info [Changelog] - New struct `CreateAndAssociatePLFilterClientBeginCreateOptions` info [Changelog] - New struct `CreateAndAssociatePLFilterClientCreateResponse` info [Changelog] - New struct `DetachAndDeleteTrafficFilterClient` info [Changelog] - New struct `DetachAndDeleteTrafficFilterClientDeleteOptions` info [Changelog] - New struct `DetachAndDeleteTrafficFilterClientDeleteResponse` info [Changelog] - New struct `DetachTrafficFilterClient` info [Changelog] - New struct `DetachTrafficFilterClientBeginUpdateOptions` info [Changelog] - New struct `DetachTrafficFilterClientUpdateResponse` info [Changelog] - New struct `ExternalUserClient` info [Changelog] - New struct `ExternalUserClientCreateOrUpdateOptions` info [Changelog] - New struct `ExternalUserClientCreateOrUpdateResponse` info [Changelog] - New struct `ExternalUserCreationResponse` info [Changelog] - New struct `ExternalUserInfo` info [Changelog] - New struct `ListAssociatedTrafficFiltersClient` info [Changelog] - New struct `ListAssociatedTrafficFiltersClientListOptions` info [Changelog] - New struct `ListAssociatedTrafficFiltersClientListResponse` info [Changelog] - New struct `MonitorClient` info [Changelog] - New struct `MonitorClientBeginUpgradeOptions` info [Changelog] - New struct `MonitorClientUpgradeResponse` info [Changelog] - New struct `MonitorUpgrade` info [Changelog] - New struct `TrafficFilter` info [Changelog] - New struct `TrafficFilterResponse` info [Changelog] - New struct `TrafficFilterRule` info [Changelog] - New struct `TrafficFiltersClient` info [Changelog] - New struct `TrafficFiltersClientDeleteOptions` info [Changelog] - New struct `TrafficFiltersClientDeleteResponse` info [Changelog] - New struct `UpgradableVersionsClient` info [Changelog] - New struct `UpgradableVersionsClientDetailsOptions` info [Changelog] - New struct `UpgradableVersionsClientDetailsResponse` info [Changelog] - New struct `UpgradableVersionsList` info [Changelog] - New field `Version` in struct `MonitorProperties` info [Changelog] info [Changelog] Total 0 breaking change(s), 114 additive change(s).
️⚠️
azure-resource-manager-schemas warning [Detail]
⚠️
Warning [Logs]Release - Generate from 628535ee1851f6be02f73223bf371bbad930090d. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️
elastic [View full logs] [Release Schema Changes]
️️✔️
azure-powershell succeeded [Detail] [Expand]
️✔️
Succeeded [Logs]Release - Generate from 628535ee1851f6be02f73223bf371bbad930090d. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️
Az.Elastic [View full logs] [Release SDK Changes]
Generated ApiView
Language | Package Name | ApiView Link |
---|---|---|
Go | sdk/resourcemanager/elastic/armelastic | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Python | track2_azure-mgmt-elastic | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Java | azure-resourcemanager-elastic | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Hi @utkarshjain1508, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff
. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
Task | How to fix | Priority |
---|---|---|
Avocado | Fix-Avocado | High |
Semantic validation | Fix-SemanticValidation-Error | High |
Model validation | Fix-ModelValidation-Error | High |
LintDiff | Fix-LintDiff | high |
Could you fix the lint errors in https://github.com/Azure/azure-rest-api-specs/pull/20791/checks?check_run_id=8503659102 , these are required by new ARM guideline
@msyyc could you help with the Python SDK failure ?
@jianyexi Regarding the linting errors, we have made the same changes in the private swagger repo which were approved and merged (in PR1 and PR2 ). Can this be suppressed, or can we get an exception?
@msyyc could you help with the Python SDK failure ?
Will fix it soon
@jianyexi Can you take a look at the Breaking Change test which is failing? I have checked the error which says XmsEnumChanged . However, I am not finding any different in the swagger versions mentioned in the error. Also, can you help us explain why the Staging Service Api Readiness and TrafficValidation test is failing but same is passing for non-staging ones
@jianyexi Can you take a look at the Breaking Change test which is failing? I have checked the error which says XmsEnumChanged . However, I am not finding any different in the swagger versions mentioned in the error. Also, can you help us explain why the Staging Service Api Readiness and TrafficValidation test is failing but same is passing for non-staging ones
@jianyexi Do we have any update on this ?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@jianyexi Can you take a look at the Breaking Change test which is failing? I have checked the error which says XmsEnumChanged . However, I am not finding any different in the swagger versions mentioned in the error. Also, can you help us explain why the Staging Service Api Readiness and TrafficValidation test is failing but same is passing for non-staging ones
@jianyexi Do we have any update on this ?
Sorry for the delay, it's false alarm, already fixed
Swagger Validation Report
️️✔️
BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.9.7)] | new version | base version |
---|---|---|
elastic.json | 2022-05-05-preview(e700c08) | 2020-07-01(main) |
elastic.json | 2022-05-05-preview(e700c08) | 2021-10-01-preview(main) |
elastic.json | 2022-07-01-preview(e700c08) | 2020-07-01(main) |
elastic.json | 2022-07-01-preview(e700c08) | 2021-10-01-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 24 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-05-05-preview | package-2022-05-05-preview(e700c08) | default(main) |
package-2022-07-01-preview | package-2022-07-01-preview(e700c08) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
:warning: R1003 - ListInOperationName | Since operation 'UpgradableVersionsDetails' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L863 |
|
:warning: R1003 - ListInOperationName | Since operation 'UpgradableVersionsDetails' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createorupdateexternaluser' in:'ExternalUser_CreateOrUpdate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L464 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listupgradableversions' in:'UpgradableVersions_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listalltrafficfilters' in:'AllTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L962 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listassociatedtrafficfilters' in:'listAssociatedTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1007 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateipfilter' in:'createAndAssociateIPFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1052 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateplfilter' in:'createAndAssociatePLFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1107 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'associatetrafficfilter' in:'AssociateTrafficFilter_Associate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1168 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachtrafficfilter' in:'DetachTrafficFilter_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1272 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createorupdateexternaluser' in:'ExternalUser_CreateOrUpdate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L464 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listupgradableversions' in:'UpgradableVersions_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L863 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listalltrafficfilters' in:'AllTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L962 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listassociatedtrafficfilters' in:'listAssociatedTrafficFilters_list'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1007 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateipfilter' in:'createAndAssociateIPFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1052 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'createandassociateplfilter' in:'createAndAssociatePLFilter_Create'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1107 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'associatetrafficfilter' in:'AssociateTrafficFilter_Associate'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1168 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachanddeletetrafficfilter' in:'DetachAndDeleteTrafficFilter_Delete'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1217 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'detachtrafficfilter' in:'DetachTrafficFilter_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1265 |
|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'deletetrafficfilter' in:'TrafficFilters_Delete'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1314 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: created Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L2031 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeByDefault Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L2204 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: created Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2021 |
|
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includeByDefault Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L2194 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listmonitoredresources' in:'MonitoredResources_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L371 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listdeploymentinfo' in:'DeploymentInfo_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L419 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listvmhost' in:'VMHost_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L720 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmingestiondetails' in:'VMIngestion_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L768 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmcollectionupdate' in:'VMCollection_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L813 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listmonitoredresources' in:'MonitoredResources_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L371 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listdeploymentinfo' in:'DeploymentInfo_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L419 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'listvmhost' in:'VMHost_List'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L720 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmingestiondetails' in:'VMIngestion_Details'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L768 |
:warning: R2066 - PostOperationIdContainsUrlVerb | OperationId should contain the verb: 'vmcollectionupdate' in:'VMCollection_Update'. Consider updating the operationId Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L813 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'tagRules' with immediate parent 'ElasticMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1939 |
:warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'tagRules' with immediate parent 'ElasticMonitorResource', must have a list by immediate parent operation. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1929 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1436 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1903 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1907 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1911 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1426 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1893 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1897 |
:warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendActivityLogs Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1901 |
:warning: R4021 - DescriptionAndTitleMissing | 'LiftrResourceCategories' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Elastic/preview/2022-05-05-preview/elastic.json#L1650 |
:warning: R4021 - DescriptionAndTitleMissing | 'LiftrResourceCategories' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Elastic/preview/2022-07-01-preview/elastic.json#L1640 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/e700c08583ccb9bb81d69a0d4bc7fafc52b7f66d/specification/elastic/resource-manager/readme.md#tag-package-2022-05-05-preview">elastic/resource-manager/readme.md#package-2022-05-05-preview
- "https://github.com/Azure/azure-rest-api-specs/blob/e700c08583ccb9bb81d69a0d4bc7fafc52b7f66d/specification/elastic/resource-manager/readme.md#tag-package-2022-07-01-preview">elastic/resource-manager/readme.md#package-2022-07-01-preview
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested
@raosuhas Can you please review the responses to your comments ?
@raosuhas Responded to the review comments. As with most of the comments these concerns were not raised in the ARM review of the private swagger PR. As the changes are in production this will be a breaking change.
@raosuhas Can you please review the responses to your comments ?
@jianyexi Can we proceed with the merge? We have got the ARM sign off
@jianyexi do we have any update on this? Is anything else needed for PR approval?
Hi @utkarshjain1508, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.