azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Service Bus API version 2022-10-01-preview

Open dsouzaarun opened this issue 3 years ago • 12 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [x] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. October 12th
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 12th October
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [X] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [X] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

dsouzaarun avatar Sep 15 '22 02:09 dsouzaarun

Hi, @dsouzaarun Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 12 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    AuthorizationRules.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    AuthorizationRules.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    CheckNameAvailability.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    CheckNameAvailability.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    DisasterRecoveryConfig.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    DisasterRecoveryConfig.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    Queue.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    Queue.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    Rules.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    Rules.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    migrationconfigs.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    migrationconfigs.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    namespace-preview.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    namespace-preview.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    networksets.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    networksets.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    operations.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    operations.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    subscriptions.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    subscriptions.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)
    topics.json 2022-10-01-preview(013c8d6) 2021-11-01(main)
    topics.json 2022-10-01-preview(013c8d6) 2022-01-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L1155:15
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1155:15
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L1232:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/AuthorizationRules.json#L1232:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/CheckNameAvailability.json#L160:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/CheckNameAvailability.json#L160:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/CheckNameAvailability.json#L167:5
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/CheckNameAvailability.json#L167:5
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/DisasterRecoveryConfig.json#L326:13
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L326:13
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/DisasterRecoveryConfig.json#L354:13
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/DisasterRecoveryConfig.json#L354:13
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/Rules.json#L288:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/Rules.json#L288:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/Rules.json#L320:5
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/Rules.json#L320:5
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/namespace-preview.json#L849:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L844:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/namespace-preview.json#L862:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L857:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/namespace-preview.json#L900:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L895:9
    :warning: 1047 - XmsEnumChanged The new version has a different x-ms-enum 'modelAsString' than the previous one.
    New: Microsoft.ServiceBus/preview/2022-10-01-preview/namespace-preview.json#L954:9
    Old: Microsoft.ServiceBus/preview/2022-01-01-preview/namespace-preview.json#L949:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-10-preview package-2022-10-preview(013c8d6) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L37
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L37
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L85
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L85
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L85
    TrackedResourcePatchOperation Tracked resource 'SBAuthorizationRule' must have patch operation that at least supports the update of tags.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L85
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/listKeys'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L234
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L234
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L234
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/AuthorizationRules/{authorizationRuleName}/regenerateKeys'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L282
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L282
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L282
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L339
    ResourceNameRestriction The resource name parameter 'queueName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L339
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L390
    ResourceNameRestriction The resource name parameter 'queueName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L390
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L390
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/queues/{queueName}/authorizationRules/{authorizationRuleName}/ListKeys'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L545
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L545
    ResourceNameRestriction The resource name parameter 'queueName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L545
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L545
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L596
    ResourceNameRestriction The resource name parameter 'queueName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L596
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L596
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L656
    ResourceNameRestriction The resource name parameter 'topicName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L656
    ResourceNameRestriction The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L707
    ResourceNameRestriction The resource name parameter 'topicName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L707
    ResourceNameRestriction The resource name parameter 'authorizationRuleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L707
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/topics/{topicName}/authorizationRules/{authorizationRuleName}/ListKeys'
    Location: Microsoft.ServiceBus/preview/2022-10-01-preview/AuthorizationRules.json#L865
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 61 Errors, 0 Warnings failed [Detail]

    Tag package-2022-10-preview; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 66, untested: 0, failed: 61, passed: 5

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 400,
    errorCode: BadRequest,
    errorMessage: Create failed because Namespaces with PremiumMessagingPartitions greater than one is not supported in the region westcentralus yet. CorrelationId: b025da62-43a8-4b29-b58d-c526cb1e88bd"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ServiceBus/namespaces/namespactip268' under resource group 'apiTest-QwsWay-20725' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ServiceBus/namespaces/namespactip268' under resource group 'apiTest-QwsWay-20725' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268/topicnamvf3ukk' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268/queuenamextojx' not found."
    CLIENT_ERROR "statusCode: 400,
    errorCode: LinkedInvalidPropertyId,
    errorMessage: Property id 'sdk-Namespace-37' at path 'properties.partnerNamespace' is invalid. Expect fully qualified resource Id that start with '/subscriptions/subscriptionId' or '/providers/resourceProviderNamespace/'."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268/topicnamvf3ukk' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268/topicnamvf3ukk' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268/topicnamvf3ukk' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    CLIENT_ERROR "statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'namespactip268' not found."
    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/servicebus/armservicebus - Approved - 2.0.0-beta.2
    +	Type alias `KeySource` has been removed
    +	Type of `Encryption.KeySource` has been changed from `*KeySource` to `*string`

    azure-sdk-for-js - @azure/arm-servicebus - Approved - 7.0.0-beta.1
    +	Interface QueuesListByNamespaceNextOptionalParams no longer has parameter skip
    +	Interface QueuesListByNamespaceNextOptionalParams no longer has parameter top
    +	Interface RulesListBySubscriptionsNextOptionalParams no longer has parameter skip
    +	Interface RulesListBySubscriptionsNextOptionalParams no longer has parameter top
    +	Interface SubscriptionsListByTopicNextOptionalParams no longer has parameter skip
    +	Interface SubscriptionsListByTopicNextOptionalParams no longer has parameter top
    +	Interface TopicsListByNamespaceNextOptionalParams no longer has parameter skip
    +	Interface TopicsListByNamespaceNextOptionalParams no longer has parameter top
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.ServiceBus [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-servicebus [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-servicebus-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/servicebus/armservicebus [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `Encryption.KeySource` has been changed from `*KeySource` to `*string`
      info	[Changelog] - Type alias `KeySource` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `PremiumMessagingPartitions` in struct `SBNamespaceProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 1 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-servicebus [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Type Alias PublicNetworkAccess
      info	[Changelog]   - Added Type Alias TlsVersion
      info	[Changelog]   - Interface SBNamespace has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Interface SBNamespace has a new optional parameter premiumMessagingPartitions
      info	[Changelog]   - Interface SBNamespace has a new optional parameter publicNetworkAccess
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownTlsVersion
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️servicebus [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9065e80b5fa2dc66a9f5285d1cb3676828017ce. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ServiceBus [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/servicebus/armservicebus https://apiview.dev/Assemblies/Review/a8312327161d42b69ac32ce6a6d821a3
    Java azure-resourcemanager-servicebus-generated https://apiview.dev/Assemblies/Review/9fb6d6af8efb4b3b9788c3ddd630ac82
    .Net Azure.ResourceManager.ServiceBus There is no API change compared with the previous version
    JavaScript @azure/arm-servicebus https://apiview.dev/Assemblies/Review/80e6a352f85d43b8a70e8d3026ff8445

    Hi @dsouzaarun, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @dsouzaarun - You haven't filled out the submission form above. This is a hard requirement for reviewers and automation to help handle your PR correctly.

    mentat9 avatar Sep 27 '22 01:09 mentat9

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    /azp run

    v-Ajnava avatar Oct 11 '22 20:10 v-Ajnava

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Oct 11 '22 21:10 azure-pipelines[bot]

    /azp run

    xiaoxuqi-ms avatar Oct 26 '22 03:10 xiaoxuqi-ms

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Oct 26 '22 03:10 azure-pipelines[bot]

    Hi @dsouzaarun, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Hi, @dsouzaarun. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 13 '22 16:11 ghost

    /azp run

    v-Ajnava avatar Nov 27 '22 04:11 v-Ajnava

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Nov 27 '22 04:11 azure-pipelines[bot]

    /azp run

    v-Ajnava avatar Nov 27 '22 23:11 v-Ajnava

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Nov 27 '22 23:11 azure-pipelines[bot]

    /azp run

    v-Ajnava avatar Dec 01 '22 19:12 v-Ajnava

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Dec 01 '22 19:12 azure-pipelines[bot]

    @dsouzaarun , please fix the model validation errors and please request breaking change review board to review.

    xiaoxuqi-ms avatar Dec 05 '22 08:12 xiaoxuqi-ms

    Hi @xiaoxuqi-ms , can you please review the PR.

    v-Ajnava avatar Dec 14 '22 02:12 v-Ajnava

    @v-Ajnava , thanks for fix the CI failures and @qiaozha @ArcturusZhang please help to review this pr for SDK breaking changes, thanks.

    xiaoxuqi-ms avatar Dec 15 '22 02:12 xiaoxuqi-ms

    Despite the changelog says the KeySource type alias is removed in Go SDK, I found it in the swagger. I am not sure what is happening. Considering the swagger is actually not removing that, and it is a relative tiny change that could easily revert using directive, I approved the breaking change

    ArcturusZhang avatar Dec 15 '22 06:12 ArcturusZhang