azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Review request for Microsoft.Insights to add package 2022-08-23

Open tokaplan opened this issue 2 years ago • 17 comments

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

tokaplan avatar Sep 13 '22 20:09 tokaplan

Hi, @tokaplan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 10 Errors, 4 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-08-23 package-2022-08-23(efe00a0) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L112
    RPC-Uri-V1-05
    LongRunningResponseStatusCode A 'delete' operation 'PrivateLinkScopes_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L113
    RPC-Async-V1-01
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L347
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L389
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L389
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L434
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L434
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L609
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L651
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'scopeName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L832
    RPC-Uri-V1-05
    :warning: PageableOperation Based on the response model schema, operation 'PrivateLinkResources_ListByPrivateLinkScope' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L348
    :warning: ParameterDescription Parameter should have a description.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L512
    :warning: PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_ListByPrivateLinkScope' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L610
    :warning: ParameterDescription Parameter should have a description.
    Location: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L729
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/applicationinsights/resource-manager/readme.md
    tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-08-23
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L134:22
    ExampleUrl: stable/2021-09-01/examples/PrivateLinkScopesDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L580:22
    ExampleUrl: stable/2021-09-01/examples/PrivateEndpointConnectionDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L803:22
    ExampleUrl: stable/2021-09-01/examples/PrivateLinkScopedResourceDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L134:22
    ExampleUrl: stable/2021-09-01/examples/PrivateLinkScopesDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L580:22
    ExampleUrl: stable/2021-09-01/examples/PrivateEndpointConnectionDelete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: Microsoft.Insights/stable/2021-09-01/privateLinkScopes_API.json#L803:22
    ExampleUrl: stable/2021-09-01/examples/PrivateLinkScopedResourceDelete.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/applicationinsights/armapplicationinsights - 2.0.0-beta.2
    +	Type of `WorkbookErrorDefinition.InnerError` has been changed from `interface{}` to `*WorkbookInnerErrorTrace`

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.ApplicationInsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.2.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.2.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-applicationinsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-applicationinsights [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/applicationinsights/armapplicationinsights [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `WorkbookErrorDefinition.InnerError` has been changed from `interface{}` to `*WorkbookInnerErrorTrace`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `WebTestKindStandard` added to type alias `WebTestKind`
      info	[Changelog] - New type alias `AccessMode` with values `AccessModeOpen`, `AccessModePrivateOnly`
      info	[Changelog] - New type alias `AzureMonitorPrivateLinkScopePropertiesProvisioningState` with values `AzureMonitorPrivateLinkScopePropertiesProvisioningStateCanceled`, `AzureMonitorPrivateLinkScopePropertiesProvisioningStateFailed`, `AzureMonitorPrivateLinkScopePropertiesProvisioningStateProvisioning`, `AzureMonitorPrivateLinkScopePropertiesProvisioningStateSucceeded`
      info	[Changelog] - New type alias `PrivateEndpointConnectionProvisioningState` with values `PrivateEndpointConnectionProvisioningStateCreating`, `PrivateEndpointConnectionProvisioningStateDeleting`, `PrivateEndpointConnectionProvisioningStateFailed`, `PrivateEndpointConnectionProvisioningStateSucceeded`
      info	[Changelog] - New type alias `PrivateEndpointServiceConnectionStatus` with values `PrivateEndpointServiceConnectionStatusApproved`, `PrivateEndpointServiceConnectionStatusPending`, `PrivateEndpointServiceConnectionStatusRejected`
      info	[Changelog] - New type alias `ScopedResourcePropertiesProvisioningState` with values `ScopedResourcePropertiesProvisioningStateCanceled`, `ScopedResourcePropertiesProvisioningStateFailed`, `ScopedResourcePropertiesProvisioningStateProvisioning`, `ScopedResourcePropertiesProvisioningStateSucceeded`
      info	[Changelog] - New function `NewOperationsClient(azcore.TokenCredential, *arm.ClientOptions) (*OperationsClient, error)`
      info	[Changelog] - New function `*OperationsClient.NewListPager(*OperationsClientListOptions) *runtime.Pager[OperationsClientListResponse]`
      info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionsClient, error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions) (*runtime.Poller[PrivateEndpointConnectionsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionsClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionsClientDeleteResponse], error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.Get(context.Context, string, string, string, *PrivateEndpointConnectionsClientGetOptions) (PrivateEndpointConnectionsClientGetResponse, error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.ListByPrivateLinkScope(context.Context, string, string, *PrivateEndpointConnectionsClientListByPrivateLinkScopeOptions) (PrivateEndpointConnectionsClientListByPrivateLinkScopeResponse, error)`
      info	[Changelog] - New function `NewPrivateLinkResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkResourcesClient, error)`
      info	[Changelog] - New function `*PrivateLinkResourcesClient.Get(context.Context, string, string, string, *PrivateLinkResourcesClientGetOptions) (PrivateLinkResourcesClientGetResponse, error)`
      info	[Changelog] - New function `*PrivateLinkResourcesClient.ListByPrivateLinkScope(context.Context, string, string, *PrivateLinkResourcesClientListByPrivateLinkScopeOptions) (PrivateLinkResourcesClientListByPrivateLinkScopeResponse, error)`
      info	[Changelog] - New function `NewPrivateLinkScopeOperationStatusClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkScopeOperationStatusClient, error)`
      info	[Changelog] - New function `*PrivateLinkScopeOperationStatusClient.Get(context.Context, string, string, *PrivateLinkScopeOperationStatusClientGetOptions) (PrivateLinkScopeOperationStatusClientGetResponse, error)`
      info	[Changelog] - New function `NewPrivateLinkScopedResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkScopedResourcesClient, error)`
      info	[Changelog] - New function `*PrivateLinkScopedResourcesClient.BeginCreateOrUpdate(context.Context, string, string, string, ScopedResource, *PrivateLinkScopedResourcesClientBeginCreateOrUpdateOptions) (*runtime.Poller[PrivateLinkScopedResourcesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*PrivateLinkScopedResourcesClient.BeginDelete(context.Context, string, string, string, *PrivateLinkScopedResourcesClientBeginDeleteOptions) (*runtime.Poller[PrivateLinkScopedResourcesClientDeleteResponse], error)`
      info	[Changelog] - New function `*PrivateLinkScopedResourcesClient.Get(context.Context, string, string, string, *PrivateLinkScopedResourcesClientGetOptions) (PrivateLinkScopedResourcesClientGetResponse, error)`
      info	[Changelog] - New function `*PrivateLinkScopedResourcesClient.NewListByPrivateLinkScopePager(string, string, *PrivateLinkScopedResourcesClientListByPrivateLinkScopeOptions) *runtime.Pager[PrivateLinkScopedResourcesClientListByPrivateLinkScopeResponse]`
      info	[Changelog] - New function `NewPrivateLinkScopesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkScopesClient, error)`
      info	[Changelog] - New function `*PrivateLinkScopesClient.CreateOrUpdate(context.Context, string, string, AzureMonitorPrivateLinkScope, *PrivateLinkScopesClientCreateOrUpdateOptions) (PrivateLinkScopesClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*PrivateLinkScopesClient.BeginDelete(context.Context, string, string, *PrivateLinkScopesClientBeginDeleteOptions) (*runtime.Poller[PrivateLinkScopesClientDeleteResponse], error)`
      info	[Changelog] - New function `*PrivateLinkScopesClient.Get(context.Context, string, string, *PrivateLinkScopesClientGetOptions) (PrivateLinkScopesClientGetResponse, error)`
      info	[Changelog] - New function `*PrivateLinkScopesClient.NewListByResourceGroupPager(string, *PrivateLinkScopesClientListByResourceGroupOptions) *runtime.Pager[PrivateLinkScopesClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*PrivateLinkScopesClient.NewListPager(*PrivateLinkScopesClientListOptions) *runtime.Pager[PrivateLinkScopesClientListResponse]`
      info	[Changelog] - New function `*PrivateLinkScopesClient.UpdateTags(context.Context, string, string, TagsResourcePrivateLinkScope, *PrivateLinkScopesClientUpdateTagsOptions) (PrivateLinkScopesClientUpdateTagsResponse, error)`
      info	[Changelog] - New struct `AccessModeSettings`
      info	[Changelog] - New struct `AccessModeSettingsExclusion`
      info	[Changelog] - New struct `AzureMonitorPrivateLinkScope`
      info	[Changelog] - New struct `AzureMonitorPrivateLinkScopeListResult`
      info	[Changelog] - New struct `AzureMonitorPrivateLinkScopeProperties`
      info	[Changelog] - New struct `DefaultErrorResponse`
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorFieldContract`
      info	[Changelog] - New struct `HeaderField`
      info	[Changelog] - New struct `OperationStatus`
      info	[Changelog] - New struct `OperationsClient`
      info	[Changelog] - New struct `OperationsClientListResponse`
      info	[Changelog] - New struct `PrivateEndpoint`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClient`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientDeleteResponse`
      info	[Changelog] - New struct `PrivateLinkResource`
      info	[Changelog] - New struct `PrivateLinkResourceListResult`
      info	[Changelog] - New struct `PrivateLinkResourceProperties`
      info	[Changelog] - New struct `PrivateLinkResourcesClient`
      info	[Changelog] - New struct `PrivateLinkScopeOperationStatusClient`
      info	[Changelog] - New struct `PrivateLinkScopedResourcesClient`
      info	[Changelog] - New struct `PrivateLinkScopedResourcesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `PrivateLinkScopedResourcesClientDeleteResponse`
      info	[Changelog] - New struct `PrivateLinkScopedResourcesClientListByPrivateLinkScopeResponse`
      info	[Changelog] - New struct `PrivateLinkScopesClient`
      info	[Changelog] - New struct `PrivateLinkScopesClientDeleteResponse`
      info	[Changelog] - New struct `PrivateLinkScopesClientListByResourceGroupResponse`
      info	[Changelog] - New struct `PrivateLinkScopesClientListResponse`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
      info	[Changelog] - New struct `ScopedResource`
      info	[Changelog] - New struct `ScopedResourceListResult`
      info	[Changelog] - New struct `ScopedResourceProperties`
      info	[Changelog] - New struct `TagsResourcePrivateLinkScope`
      info	[Changelog] - New struct `WebTestPropertiesRequest`
      info	[Changelog] - New struct `WebTestPropertiesValidationRules`
      info	[Changelog] - New struct `WebTestPropertiesValidationRulesContentValidation`
      info	[Changelog] - New field `Details` in struct `ErrorResponse`
      info	[Changelog] - New field `Request` in struct `WebTestProperties`
      info	[Changelog] - New field `ValidationRules` in struct `WebTestProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 131 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appinsights [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • applicationinsights/resource-manager [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7e296ea0ba08dd77fc190dc67fa96fb861dec86a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ApplicationInsights [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.Insights Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/applicationinsights/armapplicationinsights Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-applicationinsights Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.ApplicationInsights Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-appinsights Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi, @tokaplan your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    Hi @tokaplan, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @akning-ms @raosuhas I fixed all the issues I could. The checks that fail - I don't really understand them, and not sure if they are internal tooling issues or relevant problems. Can you please take a look? I've organized the PR so that you can easily review the actual changes.

    tokaplan avatar Sep 14 '22 21:09 tokaplan

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Oct 02 '22 16:10 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Oct 23 '22 16:10 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 13 '22 16:11 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Dec 04 '22 16:12 ghost

    @jianyexi to help take the exception in Linter validation

    akning-ms avatar Dec 09 '22 06:12 akning-ms

    /azp run

    jianyexi avatar Dec 21 '22 08:12 jianyexi

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Dec 21 '22 08:12 azure-pipelines[bot]

    Hi, @tokaplan, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jan 08 '23 16:01 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Feb 05 '23 16:02 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Feb 26 '23 16:02 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Mar 19 '23 16:03 ghost

    Hi, @tokaplan. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Apr 09 '23 16:04 ghost

    Hi, @tokaplan. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Apr 24 '23 05:04 ghost