azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
Fix AMA swagger for completeness. R3007
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [x] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @vayada Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 52 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| managedapplications.json | 2018-09-01-preview(e158ad6) | 2018-09-01-preview(main) |
| managedapplications.json | 2020-08-21-preview(e158ad6) | 2020-08-21-preview(main) |
| managedapplications.json | 2021-02-01-preview(e158ad6) | 2021-02-01-preview(main) |
| managedapplications.json | 2017-09-01(e158ad6) | 2017-09-01(main) |
| managedapplications.json | 2017-12-01(e158ad6) | 2017-12-01(main) |
| managedapplications.json | 2018-02-01(e158ad6) | 2018-02-01(main) |
| managedapplications.json | 2018-03-01(e158ad6) | 2018-03-01(main) |
| managedapplications.json | 2018-06-01(e158ad6) | 2018-06-01(main) |
| managedapplications.json | 2019-07-01(e158ad6) | 2019-07-01(main) |
| managedapplications.json | 2021-07-01(e158ad6) | 2021-07-01(main) |
Only 14 items are listed, please refer to log for more details.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: R4009 - RequiredReadOnlySystemData | The response of operation:'Applications_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L263 |
|
| :warning: R4009 - RequiredReadOnlySystemData | The response of operation:'Applications_UpdateById' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L890 |
The following errors/warnings exist before current PR submission:
Only 14 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-02-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-03-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L37 |
|
The response schema of operations API '/providers/Microsoft.Solutions/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Solutions/stable/2019-07-01/managedapplications.json#L37 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L119 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L375 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L772 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2018-09-01-preview/managedapplications.json#L990 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L113 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L371 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L768 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2020-08-21-preview/managedapplications.json#L986 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Solutions/preview/2021-02-01-preview/managedapplications.json#L100 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"ResourceType 'applications' should be deployed in 'West Central US' on apiVersion '2018-09-01-preview'.: expected [ Array(7) ] to satisfy [Function]" |
️❌~[Staging] TrafficValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"ResourceType 'applications' should be deployed in 'West Central US' on apiVersion '2018-09-01-preview'.: expected [ Array(7) ] to satisfy [Function]" |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-07">solutions/resource-manager/readme.md#package-managedapplications-2021-07
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2021-02">solutions/resource-manager/readme.md#package-managedapplications-2021-02
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2020-08">solutions/resource-manager/readme.md#package-managedapplications-2020-08
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2019-07">solutions/resource-manager/readme.md#package-managedapplications-2019-07
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-09">solutions/resource-manager/readme.md#package-managedapplications-2018-09
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-06">solutions/resource-manager/readme.md#package-managedapplications-2018-06
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-03">solutions/resource-manager/readme.md#package-managedapplications-2018-03
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2018-02">solutions/resource-manager/readme.md#package-managedapplications-2018-02
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-12">solutions/resource-manager/readme.md#package-managedapplications-2017-12
- "https://github.com/Azure/azure-rest-api-specs/blob/e158ad614cec0d24c7c04d5795080719ab27bfe0/specification/solutions/resource-manager/readme.md#tag-package-managedapplications-2017-09">solutions/resource-manager/readme.md#package-managedapplications-2017-09
Only 14 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:243"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:245"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:252"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2021-02", "details":"Error: 3 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation' (10 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:272"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:274"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: localized friendly description of the operation; suitable for tool tips and detailed views."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Duplicate Schema named 'OperationListResult' (7 differences):\n - properties.value.$ref: "#/components/schemas/schemas:148" => "#/components/schemas/schemas:281"\n - properties.value.description: "List of Microsoft.Solutions operations." => "List of operations supported by the resource provider"\n - properties.value.x-ms-identifiers: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2020-08", "details":"Error: 3 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:141" => "#/components/schemas/schemas:268"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: "type":"boolean", "readOnly":true\n - properties.origin: "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:143" => "#/components/schemas/schemas:270"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2019-07", "details":"Error: 2 errors occured -- cannot continue." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation' (9 differences):\n - properties.name.$ref: "#/components/schemas/schemas:129" => "#/components/schemas/schemas:251"\n - properties.name.description: "Operation name: provider/resource/operation" => "The name of the operation, as per Resource-Based Access Control (RBAC). Examples: \"Microsoft.Compute/virtualMachines/write\", \"Microsoft.Compute/virtualMachines/capture/action\""\n - properties.name.readOnly: "type":"boolean", "readOnly":true\n - properties.origin: "modelAsString":true, "$ref":"#/components/schemas/Origin", "description":"The intended executor of the operation; as in Resource Based Access Control (RBAC) and audit logs UX. Default value is \"user, system\"", "readOnly":true\n - properties.actionType: "modelAsString":true, "$ref":"#/components/schemas/ActionType", "description":"Enum. Indicates the action type. \"Internal\" refers to actions that are for internal only APIs.", "readOnly":true\n - title: |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Duplicate Schema named 'Operation-display' (10 differences):\n - properties.provider.$ref: "#/components/schemas/schemas:131" => "#/components/schemas/schemas:253"\n - properties.provider.description: "Service provider: Microsoft.Solutions" => "The localized friendly form of the resource provider name, e.g. \"Microsoft Monitoring Insights\" or \"Microsoft Compute\"."\n - properties.provider.readOnly: JitRequest, etc." => "The localized friendly name of the resource type related to this operation. E.g. \"Virtual Machines\" or \"Job Schedule Collections\"."\n - properties.resource.readOnly: write, delete, etc." => "The concise, localized friendly name for the operation; suitable for dropdowns. E.g. \"Create or Update Virtual Machine\", \"Restart Virtual Machine\"."\n - properties.operation.readOnly: "description":"The short, localized friendly description of the operation; suitable for tool tips and detailed views.", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"solutions/resource-manager/readme.md", "tag":"package-managedapplications-2018-09", "details":"Error: 2 errors occured -- cannot continue." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️❌Lint(RPaaS): 3 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
[RPaaS] An async PUT operation must set ''x-ms-long-running-operation' : true''. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368 |
|
[RPaaS] An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L368 |
|
[RPaaS] The resource ApplicationDefinition is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1614 |
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/solutions/armmanagedapplications - Approved - 2.0.0+ Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed + Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed + Function `*ApplicationDefinitionsClient.BeginDelete` has been removed + Function `*ApplicationsClient.Update` has been removed + Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed + Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed + Struct `ApplicationPropertiesPatchable` has been removed + Struct `ApplicationsClientUpdateOptions` has been removed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from e790a6a51a602ea1b9acdbe9764d53e65e6e2109. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-managedapplication [View full logs] [Preview SDK Changes]info [Changelog] - Initial Release
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from e790a6a51a602ea1b9acdbe9764d53e65e6e2109. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-solutions [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from e790a6a51a602ea1b9acdbe9764d53e65e6e2109. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/solutions/armmanagedapplications [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*ApplicationsClient.Update` has been removed info [Changelog] - Function `*ApplicationDefinitionsClient.BeginCreateOrUpdate` has been removed info [Changelog] - Function `*ApplicationDefinitionsClient.BeginDelete` has been removed info [Changelog] - Struct `ApplicationDefinitionsClientBeginCreateOrUpdateOptions` has been removed info [Changelog] - Struct `ApplicationDefinitionsClientBeginDeleteOptions` has been removed info [Changelog] - Struct `ApplicationPropertiesPatchable` has been removed info [Changelog] - Struct `ApplicationsClientUpdateOptions` has been removed info [Changelog] - Field `ProvisioningState` of struct `ApplicationDefinitionProperties` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `SubstatusApproved` info [Changelog] - New const `SubstatusFailed` info [Changelog] - New const `StatusElevate` info [Changelog] - New const `SubstatusDenied` info [Changelog] - New const `SubstatusTimeout` info [Changelog] - New const `StatusNotSpecified` info [Changelog] - New const `SubstatusExpired` info [Changelog] - New const `StatusRemove` info [Changelog] - New const `SubstatusNotSpecified` info [Changelog] - New type alias `Status` info [Changelog] - New type alias `Substatus` info [Changelog] - New function `*ApplicationDefinitionsClient.DeleteByID(context.Context, string, string, *ApplicationDefinitionsClientDeleteByIDOptions) (ApplicationDefinitionsClientDeleteByIDResponse, error)` info [Changelog] - New function `PossibleStatusValues() []Status` info [Changelog] - New function `*ApplicationDefinitionsClient.GetByID(context.Context, string, string, *ApplicationDefinitionsClientGetByIDOptions) (ApplicationDefinitionsClientGetByIDResponse, error)` info [Changelog] - New function `*ApplicationsClient.BeginCreateOrUpdateByID(context.Context, string, Application, *ApplicationsClientBeginCreateOrUpdateByIDOptions) (*runtime.Poller[ApplicationsClientCreateOrUpdateByIDResponse], error)` info [Changelog] - New function `*ApplicationsClient.ListTokens(context.Context, string, string, ListTokenRequest, *ApplicationsClientListTokensOptions) (ApplicationsClientListTokensResponse, error)` info [Changelog] - New function `*ApplicationDefinitionsClient.Delete(context.Context, string, string, *ApplicationDefinitionsClientDeleteOptions) (ApplicationDefinitionsClientDeleteResponse, error)` info [Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdateByID(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateByIDOptions) (ApplicationDefinitionsClientCreateOrUpdateByIDResponse, error)` info [Changelog] - New function `*ApplicationsClient.BeginUpdateAccess(context.Context, string, string, UpdateAccessDefinition, *ApplicationsClientBeginUpdateAccessOptions) (*runtime.Poller[ApplicationsClientUpdateAccessResponse], error)` info [Changelog] - New function `*ApplicationDefinitionsClient.UpdateByID(context.Context, string, string, ApplicationDefinitionPatchable, *ApplicationDefinitionsClientUpdateByIDOptions) (ApplicationDefinitionsClientUpdateByIDResponse, error)` info [Changelog] - New function `*ApplicationsClient.GetByID(context.Context, string, *ApplicationsClientGetByIDOptions) (ApplicationsClientGetByIDResponse, error)` info [Changelog] - New function `*ApplicationsClient.BeginUpdate(context.Context, string, string, *ApplicationsClientBeginUpdateOptions) (*runtime.Poller[ApplicationsClientUpdateResponse], error)` info [Changelog] - New function `*ApplicationDefinitionsClient.CreateOrUpdate(context.Context, string, string, ApplicationDefinition, *ApplicationDefinitionsClientCreateOrUpdateOptions) (ApplicationDefinitionsClientCreateOrUpdateResponse, error)` info [Changelog] - New function `PossibleSubstatusValues() []Substatus` info [Changelog] - New function `*ApplicationsClient.BeginUpdateByID(context.Context, string, *ApplicationsClientBeginUpdateByIDOptions) (*runtime.Poller[ApplicationsClientUpdateByIDResponse], error)` info [Changelog] - New function `*ApplicationsClient.BeginDeleteByID(context.Context, string, *ApplicationsClientBeginDeleteByIDOptions) (*runtime.Poller[ApplicationsClientDeleteByIDResponse], error)` info [Changelog] - New struct `AllowedUpgradePlansResult` info [Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDOptions` info [Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateByIDResponse` info [Changelog] - New struct `ApplicationDefinitionsClientCreateOrUpdateOptions` info [Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDOptions` info [Changelog] - New struct `ApplicationDefinitionsClientDeleteByIDResponse` info [Changelog] - New struct `ApplicationDefinitionsClientDeleteOptions` info [Changelog] - New struct `ApplicationDefinitionsClientGetByIDOptions` info [Changelog] - New struct `ApplicationDefinitionsClientGetByIDResponse` info [Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDOptions` info [Changelog] - New struct `ApplicationDefinitionsClientUpdateByIDResponse` info [Changelog] - New struct `ApplicationsClientBeginCreateOrUpdateByIDOptions` info [Changelog] - New struct `ApplicationsClientBeginDeleteByIDOptions` info [Changelog] - New struct `ApplicationsClientBeginUpdateAccessOptions` info [Changelog] - New struct `ApplicationsClientBeginUpdateByIDOptions` info [Changelog] - New struct `ApplicationsClientBeginUpdateOptions` info [Changelog] - New struct `ApplicationsClientCreateOrUpdateByIDResponse` info [Changelog] - New struct `ApplicationsClientDeleteByIDResponse` info [Changelog] - New struct `ApplicationsClientGetByIDOptions` info [Changelog] - New struct `ApplicationsClientGetByIDResponse` info [Changelog] - New struct `ApplicationsClientListTokensOptions` info [Changelog] - New struct `ApplicationsClientListTokensResponse` info [Changelog] - New struct `ApplicationsClientUpdateAccessResponse` info [Changelog] - New struct `ApplicationsClientUpdateByIDResponse` info [Changelog] - New struct `JitRequestMetadata` info [Changelog] - New struct `ListTokenRequest` info [Changelog] - New struct `ManagedIdentityToken` info [Changelog] - New struct `ManagedIdentityTokenResult` info [Changelog] - New struct `UpdateAccessDefinition` info [Changelog] - New anonymous field `AllowedUpgradePlansResult` in struct `ApplicationsClientListAllowedUpgradePlansResponse` info [Changelog] info [Changelog] Total 12 breaking change(s), 85 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
⚠️Warning [Logs] Generate from e790a6a51a602ea1b9acdbe9764d53e65e6e2109. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from e790a6a51a602ea1b9acdbe9764d53e65e6e2109. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.solutions [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/solutions/armmanagedapplications | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Python | track2_azure-mgmt-managedapplication | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Java | azure-resourcemanager-solutions | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
This fix is being made for following S360 for swagger completeness. https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=721D62A4-4696-4718-A8E1-3CC05D1AAA7A
Hi @vayada, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
@jianyexi please help reivew this PR fixing Lint R3007 PutGetPatchResponseSchema
Hi @vayada, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
@vayada please request breaking change approval following Action in https://github.com/Azure/azure-rest-api-specs/pull/20667#issuecomment-1244931406 . and fix the Lint(RPaaS) error
@vayada please request breaking change approval following Action in #20667 (comment) . and fix the Lint(RPaaS) error
@leni-msft RPaaS Linter errors are false alarm as agreed with RPaaS team. As you can see this is not coming from current change. We have exception for this since starting. I will request Breaking Change Approval for this.
@tadelesh please help check go sdk breaking changes
Will review after breaking change arch review.
@tadelesh Breaking Change ARCH review wants you to review first. So, can you please do that.
@tadelesh Breaking Change ARCH review wants you to review first. So, can you please do that.
The Go breaking is from this old PR. @leni-msft I don't know how to handle the swagger breaking from this PR, could you help?
@josefree Could you give guidance here? This PR is to fix S360 Lint error, and may cause breaking changes to both API and SDK.
@vayada Go SDK breaking changes have been approved, please request BC board review
Hi, @vayada. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @vayada. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.