azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Property to enable/disable OCSP revocation check on client certificate

Open 3quanfeng opened this issue 2 years ago • 5 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [x] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. The service/feature has been deployed to public regions already, the change is to support configure via PS and CLI
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. September, 2022
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [x] PowerShell
    • [x] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

3quanfeng avatar Aug 18 '22 23:08 3quanfeng

Hi, @3quanfeng Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 3 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    applicationGateway.json 2022-05-01(459921c) 2022-01-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'ddosCustomPolicy' renamed or removed?
    New: Microsoft.Network/stable/2022-05-01/publicIpAddress.json#L613:7
    Old: Microsoft.Network/stable/2022-01-01/publicIpAddress.json#L559:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'protectionCoverage' renamed or removed?
    New: Microsoft.Network/stable/2022-05-01/publicIpAddress.json#L613:7
    Old: Microsoft.Network/stable/2022-01-01/publicIpAddress.json#L559:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'protectedIP' renamed or removed?
    New: Microsoft.Network/stable/2022-05-01/publicIpAddress.json#L613:7
    Old: Microsoft.Network/stable/2022-01-01/publicIpAddress.json#L559:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-05 package-2022-05(459921c) package-2022-05(network-2022-05-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L919
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L955
    R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L991
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L2567
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L2567
    R4037 - MissingTypeObject The schema 'ApplicationGatewayOnDemandProbe' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1156
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthOnDemand' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1194
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealth' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1207
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthPool' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1219
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthHttpSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1235
    R4037 - MissingTypeObject The schema 'ApplicationGatewayBackendHealthServer' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1251
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1283
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1283
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1324
    R4037 - MissingTypeObject The schema 'ApplicationGatewaySslPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1324
    R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1365
    R4037 - MissingTypeObject The schema 'ApplicationGatewayClientAuthConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1365
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    R4037 - MissingTypeObject The schema 'ApplicationGatewayIPConfigurationPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/applicationGateway.json#L1386
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/459921c221d9b40d4d5cd84468125276a6f72315/specification/network/resource-manager/readme.md#tag-package-2022-05">network/resource-manager/readme.md#package-2022-05
    The following errors/warnings exist before current PR submission:
    Rule Message
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'id' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ExpressRouteProviderPort"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ExpressRouteProviderPort' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from ExpressRouteProviderPort"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'NetworkManagerConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from NetworkManagerConnection"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ScopeConnection' has a property 'etag' that is already declared the parent schema 'ChildResource' but isn't significantly different. The property has been removed from ScopeConnection"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink"
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration"
    :warning: UnkownSecurityScheme "readme":"network/resource-manager/readme.md",
    "tag":"package-2022-05",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - armnetwork - 2.0.0
    +	Const `DdosCustomPolicyProtocolSyn` has been removed
    +	Const `DdosCustomPolicyProtocolTCP` has been removed
    +	Const `DdosCustomPolicyProtocolUDP` has been removed
    +	Const `DdosCustomPolicyTriggerSensitivityOverrideDefault` has been removed
    +	Const `DdosCustomPolicyTriggerSensitivityOverrideHigh` has been removed
    +	Const `DdosCustomPolicyTriggerSensitivityOverrideLow` has been removed
    +	Const `DdosCustomPolicyTriggerSensitivityOverrideRelaxed` has been removed
    +	Const `DdosSettingsProtectionCoverageBasic` has been removed
    +	Const `DdosSettingsProtectionCoverageStandard` has been removed
    +	Field `DdosCustomPolicy` of struct `DdosSettings` has been removed
    +	Field `ProtectedIP` of struct `DdosSettings` has been removed
    +	Field `ProtectionCoverage` of struct `DdosSettings` has been removed
    +	Field `ProtocolCustomSettings` of struct `DdosCustomPolicyPropertiesFormat` has been removed
    +	Field `PublicIPAddresses` of struct `DdosCustomPolicyPropertiesFormat` has been removed
    +	Function `PossibleDdosCustomPolicyProtocolValues` has been removed
    +	Function `PossibleDdosCustomPolicyTriggerSensitivityOverrideValues` has been removed
    +	Function `PossibleDdosSettingsProtectionCoverageValues` has been removed
    +	Struct `ProtocolCustomSettingsFormat` has been removed
    +	Type alias `DdosCustomPolicyProtocol` has been removed
    +	Type alias `DdosCustomPolicyTriggerSensitivityOverride` has been removed
    +	Type alias `DdosSettingsProtectionCoverage` has been removed
    ⚠️azure-sdk-for-js - @azure/arm-network - 30.0.0
    +	Interface DdosCustomPolicy no longer has parameter protocolCustomSettings
    +	Interface DdosCustomPolicy no longer has parameter publicIPAddresses
    +	Interface DdosSettings no longer has parameter ddosCustomPolicy
    +	Interface DdosSettings no longer has parameter protectedIP
    +	Interface DdosSettings no longer has parameter protectionCoverage
    +	Removed Enum KnownDdosCustomPolicyProtocol
    +	Removed Enum KnownDdosCustomPolicyTriggerSensitivityOverride
    +	Removed Enum KnownDdosSettingsProtectionCoverage
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Network [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!Error happened during package
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armnetwork [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `DdosCustomPolicyTriggerSensitivityOverrideDefault` has been removed
      info	[Changelog] - Const `DdosSettingsProtectionCoverageBasic` has been removed
      info	[Changelog] - Const `DdosSettingsProtectionCoverageStandard` has been removed
      info	[Changelog] - Const `DdosCustomPolicyTriggerSensitivityOverrideHigh` has been removed
      info	[Changelog] - Const `DdosCustomPolicyTriggerSensitivityOverrideRelaxed` has been removed
      info	[Changelog] - Const `DdosCustomPolicyProtocolSyn` has been removed
      info	[Changelog] - Const `DdosCustomPolicyProtocolTCP` has been removed
      info	[Changelog] - Const `DdosCustomPolicyProtocolUDP` has been removed
      info	[Changelog] - Const `DdosCustomPolicyTriggerSensitivityOverrideLow` has been removed
      info	[Changelog] - Type alias `DdosCustomPolicyTriggerSensitivityOverride` has been removed
      info	[Changelog] - Type alias `DdosSettingsProtectionCoverage` has been removed
      info	[Changelog] - Type alias `DdosCustomPolicyProtocol` has been removed
      info	[Changelog] - Function `PossibleDdosSettingsProtectionCoverageValues` has been removed
      info	[Changelog] - Function `PossibleDdosCustomPolicyProtocolValues` has been removed
      info	[Changelog] - Function `PossibleDdosCustomPolicyTriggerSensitivityOverrideValues` has been removed
      info	[Changelog] - Struct `ExplicitProxySettings` has been removed
      info	[Changelog] - Struct `ProtocolCustomSettingsFormat` has been removed
      info	[Changelog] - Field `ExplicitProxySettings` of struct `FirewallPolicyPropertiesFormat` has been removed
      info	[Changelog] - Field `ProtocolCustomSettings` of struct `DdosCustomPolicyPropertiesFormat` has been removed
      info	[Changelog] - Field `PublicIPAddresses` of struct `DdosCustomPolicyPropertiesFormat` has been removed
      info	[Changelog] - Field `DdosCustomPolicy` of struct `DdosSettings` has been removed
      info	[Changelog] - Field `ProtectedIP` of struct `DdosSettings` has been removed
      info	[Changelog] - Field `ProtectionCoverage` of struct `DdosSettings` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `SlotTypeStaging`
      info	[Changelog] - New const `IsWorkloadProtectedFalse`
      info	[Changelog] - New const `DdosSettingsProtectionModeEnabled`
      info	[Changelog] - New const `ActionTypeLog`
      info	[Changelog] - New const `IsWorkloadProtectedTrue`
      info	[Changelog] - New const `ActionTypeAllow`
      info	[Changelog] - New const `ActionTypeBlock`
      info	[Changelog] - New const `ExpressRoutePortsBillingTypeUnlimitedData`
      info	[Changelog] - New const `ExpressRoutePortsBillingTypeMeteredData`
      info	[Changelog] - New const `SlotTypeProduction`
      info	[Changelog] - New const `ActionTypeAnomalyScoring`
      info	[Changelog] - New const `ManagedRuleEnabledStateEnabled`
      info	[Changelog] - New const `DdosSettingsProtectionModeDisabled`
      info	[Changelog] - New const `ApplicationGatewayClientRevocationOptionsOCSP`
      info	[Changelog] - New const `DdosSettingsProtectionModeVirtualNetworkInherited`
      info	[Changelog] - New const `ApplicationGatewayClientRevocationOptionsNone`
      info	[Changelog] - New type alias `ActionType`
      info	[Changelog] - New type alias `ApplicationGatewayClientRevocationOptions`
      info	[Changelog] - New type alias `DdosSettingsProtectionMode`
      info	[Changelog] - New type alias `SlotType`
      info	[Changelog] - New type alias `IsWorkloadProtected`
      info	[Changelog] - New type alias `ExpressRoutePortsBillingType`
      info	[Changelog] - New function `PossibleActionTypeValues() []ActionType`
      info	[Changelog] - New function `PossibleIsWorkloadProtectedValues() []IsWorkloadProtected`
      info	[Changelog] - New function `PossibleDdosSettingsProtectionModeValues() []DdosSettingsProtectionMode`
      info	[Changelog] - New function `*VipSwapClient.List(context.Context, string, string, *VipSwapClientListOptions) (VipSwapClientListResponse, error)`
      info	[Changelog] - New function `PossibleSlotTypeValues() []SlotType`
      info	[Changelog] - New function `NewVipSwapClient(string, azcore.TokenCredential, *arm.ClientOptions) (*VipSwapClient, error)`
      info	[Changelog] - New function `PossibleExpressRoutePortsBillingTypeValues() []ExpressRoutePortsBillingType`
      info	[Changelog] - New function `PossibleApplicationGatewayClientRevocationOptionsValues() []ApplicationGatewayClientRevocationOptions`
      info	[Changelog] - New function `*VirtualNetworksClient.BeginListDdosProtectionStatus(context.Context, string, string, *VirtualNetworksClientBeginListDdosProtectionStatusOptions) (*runtime.Poller[*runtime.Pager[VirtualNetworksClientListDdosProtectionStatusResponse]], error)`
      info	[Changelog] - New function `*VipSwapClient.BeginCreate(context.Context, string, string, SwapResource, *VipSwapClientBeginCreateOptions) (*runtime.Poller[VipSwapClientCreateResponse], error)`
      info	[Changelog] - New function `*PublicIPAddressesClient.BeginDdosProtectionStatus(context.Context, string, string, *PublicIPAddressesClientBeginDdosProtectionStatusOptions) (*runtime.Poller[PublicIPAddressesClientDdosProtectionStatusResponse], error)`
      info	[Changelog] - New function `*VipSwapClient.Get(context.Context, string, string, *VipSwapClientGetOptions) (VipSwapClientGetResponse, error)`
      info	[Changelog] - New struct `ExplicitProxy`
      info	[Changelog] - New struct `PublicIPAddressesClientBeginDdosProtectionStatusOptions`
      info	[Changelog] - New struct `PublicIPAddressesClientDdosProtectionStatusResponse`
      info	[Changelog] - New struct `PublicIPDdosProtectionStatusResult`
      info	[Changelog] - New struct `SwapResource`
      info	[Changelog] - New struct `SwapResourceListResult`
      info	[Changelog] - New struct `SwapResourceProperties`
      info	[Changelog] - New struct `VipSwapClient`
      info	[Changelog] - New struct `VipSwapClientBeginCreateOptions`
      info	[Changelog] - New struct `VipSwapClientCreateResponse`
      info	[Changelog] - New struct `VipSwapClientGetOptions`
      info	[Changelog] - New struct `VipSwapClientGetResponse`
      info	[Changelog] - New struct `VipSwapClientListOptions`
      info	[Changelog] - New struct `VipSwapClientListResponse`
      info	[Changelog] - New struct `VirtualNetworkDdosProtectionStatusResult`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroup`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroupMember`
      info	[Changelog] - New struct `VirtualNetworkGatewayPolicyGroupProperties`
      info	[Changelog] - New struct `VirtualNetworksClientBeginListDdosProtectionStatusOptions`
      info	[Changelog] - New struct `VirtualNetworksClientListDdosProtectionStatusResponse`
      info	[Changelog] - New struct `VngClientConnectionConfiguration`
      info	[Changelog] - New struct `VngClientConnectionConfigurationProperties`
      info	[Changelog] - New field `ExplicitProxy` in struct `FirewallPolicyPropertiesFormat`
      info	[Changelog] - New field `PublicIPAddresses` in struct `DdosProtectionPlanPropertiesFormat`
      info	[Changelog] - New field `VngClientConnectionConfigurations` in struct `VPNClientConfiguration`
      info	[Changelog] - New field `DisableTCPStateTracking` in struct `InterfacePropertiesFormat`
      info	[Changelog] - New field `ProtectionMode` in struct `DdosSettings`
      info	[Changelog] - New field `DdosProtectionPlan` in struct `DdosSettings`
      info	[Changelog] - New field `ColoLocation` in struct `ExpressRouteLinkPropertiesFormat`
      info	[Changelog] - New field `VirtualNetworkGatewayPolicyGroups` in struct `VirtualNetworkGatewayPropertiesFormat`
      info	[Changelog] - New field `Action` in struct `ManagedRuleOverride`
      info	[Changelog] - New field `BillingType` in struct `ExpressRoutePortPropertiesFormat`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `VirtualNetworkGatewayConnectionListEntityPropertiesFormat`
      info	[Changelog] - New field `ProbeThreshold` in struct `ProbePropertiesFormat`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `ExpressRouteConnectionProperties`
      info	[Changelog] - New field `VerifyClientRevocation` in struct `ApplicationGatewayClientAuthConfiguration`
      info	[Changelog] - New field `EnablePrivateLinkFastPath` in struct `VirtualNetworkGatewayConnectionPropertiesFormat`
      info	[Changelog]
      info	[Changelog] Total 22 breaking change(s), 92 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-network [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group VipSwap
      info	[Changelog]   - Added operation PublicIPAddresses.beginDdosProtectionStatus
      info	[Changelog]   - Added operation PublicIPAddresses.beginDdosProtectionStatusAndWait
      info	[Changelog]   - Added operation VirtualNetworks.beginListDdosProtectionStatusAndWait
      info	[Changelog]   - Added Interface PublicIPAddressesDdosProtectionStatusOptionalParams
      info	[Changelog]   - Added Interface PublicIpDdosProtectionStatusResult
      info	[Changelog]   - Added Interface SwapResource
      info	[Changelog]   - Added Interface SwapResourceListResult
      info	[Changelog]   - Added Interface SwapResourceProperties
      info	[Changelog]   - Added Interface VipSwapCreateOptionalParams
      info	[Changelog]   - Added Interface VipSwapGetOptionalParams
      info	[Changelog]   - Added Interface VipSwapListOptionalParams
      info	[Changelog]   - Added Interface VirtualNetworkDdosProtectionStatusResult
      info	[Changelog]   - Added Interface VirtualNetworkGatewayPolicyGroup
      info	[Changelog]   - Added Interface VirtualNetworkGatewayPolicyGroupMember
      info	[Changelog]   - Added Interface VirtualNetworksListDdosProtectionStatusNextOptionalParams
      info	[Changelog]   - Added Interface VirtualNetworksListDdosProtectionStatusOptionalParams
      info	[Changelog]   - Added Interface VngClientConnectionConfiguration
      info	[Changelog]   - Added Type Alias ActionType
      info	[Changelog]   - Added Type Alias ApplicationGatewayClientRevocationOptions
      info	[Changelog]   - Added Type Alias DdosSettingsProtectionMode
      info	[Changelog]   - Added Type Alias ExpressRoutePortsBillingType
      info	[Changelog]   - Added Type Alias IsWorkloadProtected
      info	[Changelog]   - Added Type Alias PublicIPAddressesDdosProtectionStatusResponse
      info	[Changelog]   - Added Type Alias SlotType
      info	[Changelog]   - Added Type Alias VipSwapGetResponse
      info	[Changelog]   - Added Type Alias VipSwapListResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListDdosProtectionStatusNextResponse
      info	[Changelog]   - Added Type Alias VirtualNetworksListDdosProtectionStatusResponse
      info	[Changelog]   - Interface ApplicationGatewayClientAuthConfiguration has a new optional parameter verifyClientRevocation
      info	[Changelog]   - Interface DdosProtectionPlan has a new optional parameter publicIpAddresses
      info	[Changelog]   - Interface DdosSettings has a new optional parameter ddosProtectionPlan
      info	[Changelog]   - Interface DdosSettings has a new optional parameter protectionMode
      info	[Changelog]   - Interface ExpressRouteConnection has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface ExpressRouteLink has a new optional parameter coloLocation
      info	[Changelog]   - Interface ExpressRoutePort has a new optional parameter billingType
      info	[Changelog]   - Interface ManagedRuleOverride has a new optional parameter action
      info	[Changelog]   - Interface NetworkInterface has a new optional parameter disableTcpStateTracking
      info	[Changelog]   - Interface Probe has a new optional parameter probeThreshold
      info	[Changelog]   - Interface VirtualNetworkGateway has a new optional parameter virtualNetworkGatewayPolicyGroups
      info	[Changelog]   - Interface VirtualNetworkGatewayConnection has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface VirtualNetworkGatewayConnectionListEntity has a new optional parameter enablePrivateLinkFastPath
      info	[Changelog]   - Interface VpnClientConfiguration has a new optional parameter vngClientConnectionConfigurations
      info	[Changelog]   - Class NetworkManagementClient has a new parameter vipSwap
      info	[Changelog]   - Added Enum KnownActionType
      info	[Changelog]   - Added Enum KnownApplicationGatewayClientRevocationOptions
      info	[Changelog]   - Added Enum KnownDdosSettingsProtectionMode
      info	[Changelog]   - Added Enum KnownExpressRoutePortsBillingType
      info	[Changelog]   - Added Enum KnownIsWorkloadProtected
      info	[Changelog]   - Enum KnownManagedRuleEnabledState has a new value Enabled
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface DdosCustomPolicy no longer has parameter protocolCustomSettings
      info	[Changelog]   - Interface DdosCustomPolicy no longer has parameter publicIPAddresses
      info	[Changelog]   - Interface DdosSettings no longer has parameter ddosCustomPolicy
      info	[Changelog]   - Interface DdosSettings no longer has parameter protectedIP
      info	[Changelog]   - Interface DdosSettings no longer has parameter protectionCoverage
      info	[Changelog]   - Removed Enum KnownDdosCustomPolicyProtocol
      info	[Changelog]   - Removed Enum KnownDdosCustomPolicyTriggerSensitivityOverride
      info	[Changelog]   - Removed Enum KnownDdosSettingsProtectionCoverage
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 80695deeecbf35f5ee69e738e048796d0aa49813. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.network [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-network-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi @3quanfeng, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    No breaking change introduced by this PR. Remove related labels.

    lirenhe avatar Aug 22 '22 01:08 lirenhe