azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

[Hub Generated] Publish private branch 'RPSaaSMaster-easm'

Open soniaab opened this issue 2 years ago • 5 comments

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

soniaab avatar Aug 18 '22 16:08 soniaab

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/6901

soniaab avatar Aug 18 '22 16:08 soniaab

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 10 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) new version base version
package-preview-2022-04-01 package-preview-2022-04-01(d075731) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'labels' with immediate parent 'WorkspaceResource', must have a list by immediate parent operation.
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L701
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workspaces
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L111
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workspaces
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L153
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workspaces
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L211
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workspaces
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L259
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workspaces
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L303
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Labels
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L393
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Labels
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L454
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Labels
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L505
:warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Labels
Location: Microsoft.Easm/preview/2022-04-01-preview/easm.json#L552
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

Hi, @soniaab Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 900d8ea363b77ef90a7661b00a19ddf547b20307. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @dw511214992 saw the staging readiness error - all I did was pull this PR from the private repo to this public repo. Was there anything else that needs to be done? Our manifest was rolled out to all regions but we do not have the workspaces resource type registered in west central us, only in a handful of other regions...

    ResourceType 'workspaces' should be deployed in 'West Central US' on apiVersion '2022-04-01'.: expected [ Array(3) ] to satisfy [Function]

    soniaab avatar Aug 30 '22 20:08 soniaab

    Hi, @soniaab. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 18 '22 16:09 ghost

    @dw511214992 Could we get some movement on this PR? As @soniaab mentioned, we are failing one of the readiness tests but we do not deploy to that region so it's unclear why this is occurring. Any help would be appreciated.

    eqtip avatar Sep 27 '22 16:09 eqtip

    @dw511214992 Another ping ...

    eqtip avatar Oct 03 '22 21:10 eqtip

    Hi, there are conflict files, pls resolve conflict.

    ruowan avatar Oct 07 '22 01:10 ruowan

    Are you publish your service to public? If so, could you pls paste your private signed off PR here.

    ruowan avatar Oct 07 '22 01:10 ruowan

    Are you publish your service to public? If so, could you pls paste your private signed off PR here.

    https://github.com/Azure/azure-rest-api-specs-pr/pull/6901

    eqtip avatar Oct 14 '22 16:10 eqtip

    Hi @soniaab, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @ruowan The conflicts have been resolved.

    eqtip avatar Oct 24 '22 18:10 eqtip

    @soniaab Sorry, I missed your messages. Are you ready to merge this PR?

    dw511214992 avatar Oct 25 '22 09:10 dw511214992

    @dw511214992 I've actually taken over the PR for @soniaab but yes ... we are ready to merge.

    eqtip avatar Oct 25 '22 16:10 eqtip