azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Review request for Microsoft.ContainerService to add version 2022-07-01

Open FumingZhang opened this issue 1 year ago • 8 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. Already deployed to all global regions on 2022/08/11.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. ASAP, 08/19.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [x] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

FumingZhang avatar Aug 18 '22 06:08 FumingZhang

Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Aug 18 '22 06:08 openapi-workflow-bot[bot]

    Hi, @FumingZhang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    openapi-workflow-bot[bot] avatar Aug 18 '22 06:08 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 1 Errors, 72 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    managedClusters.json 2022-07-01(062b523) 2022-06-01(main)
    managedClusters.json 2022-07-01(062b523) 2022-06-02-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1212:11


    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/rotateServiceAccountSigningKeys' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L1399:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2305:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2344:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName}' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2386:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/locations/{location}/trustedAccessRoles' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2572:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/trustedAccessRoleBindings' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2614:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/trustedAccessRoleBindings/{trustedAccessRoleBindingName}' removed or restructured?
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2659:5
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterOIDCIssuerProfile' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfile' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfileWebAppRouting' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileWorkloadIdentity' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileNodeRestriction' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterStorageProfileBlobCSIDriver' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshot' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshotProperties' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterPropertiesForSnapshot' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'NetworkProfileForSnapshot' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'NetworkPlugin' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'NetworkPluginMode' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'NetworkPolicy' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'NetworkMode' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'LoadBalancerSku' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CapacityReservationGroupID' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TrustedAccessRoleBindingProperties' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'TrustedAccessRoleBinding' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterWorkloadAutoScalerProfile' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedClusterWorkloadAutoScalerProfileKeda' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2239:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L2800:3
    :warning: 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'IgnorePodDisruptionBudgetParameter' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L5769:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L6729:3
    :warning: 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'TrustedAccessRoleBindingNameParameter' removed or renamed?
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L5769:3
    Old: Microsoft.ContainerService/preview/2022-06-02-preview/managedClusters.json#L6729:3
    :warning: 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1212:11
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-07 package-2022-07(062b523) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L37
    ❌ R4035 - PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4974
    :warning: R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1188
    :warning: R1006 - PutInOperationName 'PUT' operation 'PrivateEndpointConnections_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1559
    :warning: R2007 - LongRunningOperationsWithLongRunningExtension The operation 'ManagedClusters_GetCommandResult' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1871
    :warning: R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1660
    :warning: R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1814
    :warning: R2029 - PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1464
    :warning: R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1721
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L244
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L1768
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'agentPools' with immediate parent 'ManagedCluster', must have a list by immediate parent operation.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2945
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'commandResults' with immediate parent 'ManagedCluster', must have a list by immediate parent operation.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3391
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'ManagedCluster', must have a list by immediate parent operation.
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4878
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAutoScaling
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2696
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableNodePublicIP
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2748
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableEncryptionAtHost
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2813
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableUltraSSD
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2818
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFIPS
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2822
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableCSIProxy
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L2994
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3012
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableMultipleStandardLoadBalancers
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3559
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3623
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRBAC
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3776
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePodSecurityPolicy
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3780
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAccounts
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L3946
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePrivateCluster
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4018
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePrivateClusterPublicFQDN
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4028
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableRunCommand
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4032
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: managed
    Location: Microsoft.ContainerService/stable/2022-07-01/managedClusters.json#L4266
    ️❌Avocado: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerservice/resource-manager/readme.md
    json: Microsoft.ContainerService/stable/2017-07-01/containerService.json
    ❌ MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerservice/resource-manager/readme.md
    json: Microsoft.ContainerService/stable/2017-08-31/managedClusters.json
    ❌ MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerservice/resource-manager/readme.md
    json: Microsoft.ContainerService/stable/2019-08-01/location.json
    ❌ MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.
    readme: specification/containerservice/resource-manager/readme.md
    json: Microsoft.ContainerService/stable/2019-04-30/openShiftManagedClusters.json
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 78 Errors, 0 Warnings failed [Detail] Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ RUNTIME_ERROR "statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-lpkq1v/providers/Microsoft.ContainerService/managedClusters/resourcenadncjm9',
    however the linked subscription 'subid1' was not found. "
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 403"
    ❌ OBJECT_ADDITIONAL_PROPERTIES "Additional properties not allowed: os-sku"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: PatchResourceNotFound,
    errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-lpkq1v/providers/Microsoft.ContainerService/managedClusters/resourcenadncjm9' was not found when evaluating policies for a PATCH operation."
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.ContainerService/managedClusters/resourcenadncjm9' under resource group 'apiTest-lpkq1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/062b5235415b30ecdb4566353719cf8247f709e8/specification/containerservice/resource-manager/readme.md#tag-package-2022-07">containerservice/resource-manager/readme.md#package-2022-07
    The following errors/warnings are introduced by current PR:
    Rule Message
    :warning: UnkownSecurityScheme "readme":"containerservice/resource-manager/readme.md",
    "tag":"package-2022-07",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Aug 18 '22 06:08 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armcontainerservice - 2.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 20.2.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation AgentPoolsOperations.abort_latest_operation
info	[Changelog]   - Added operation ManagedClustersOperations.abort_latest_operation
info	[Changelog]   - Model ManagedCluster has a new parameter azure_monitor_profile
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter image_cleaner
info	[Changelog]   - Model ManagedClusterWorkloadAutoScalerProfile has a new parameter vertical_pod_autoscaler
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcontainerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `OSSKUWindows2019`
info	[Changelog] - New const `OSSKUWindows2022`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerservice [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownOssku has a new value Windows2019
info	[Changelog]   - Enum KnownOssku has a new value Windows2022
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerservice/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ResourceIdentityType' and different values: SystemAssigned,UserAssigned,None vs. SystemAssigned
cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerservice [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from 217094c81516ef845bb934304899627ff7c0ee30. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.containerservice [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Aug 18 '22 06:08 openapi-pipeline-app[bot]

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-containerservice-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-containerservice Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-containerservice Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    openapi-pipeline-app[bot] avatar Aug 18 '22 06:08 openapi-pipeline-app[bot]

    Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    openapi-workflow-bot[bot] avatar Aug 18 '22 06:08 openapi-workflow-bot[bot]

    Hi @FumingZhang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    openapi-workflow-bot[bot] avatar Aug 18 '22 06:08 openapi-workflow-bot[bot]

    Dear review board, I would like to clarify the failures in the CI checks.

    For SDK azure-powershell, it happened in our previous PRs 2022-06-01 and 2022-07-02-preview, from log it seems that the reason for the failure lies in the build tool /home/cloudtest/.autorest/@[email protected]/node_modules/@autorest/powershell/dist/plugins/llcsharp-v2.js - TypeError: value.replace is not a function. This CI used to be optional and is enabled recently.

    For SDK azure-sdk-for-net, it happened in our previous PRs 2022-06-01 and 2022-07-02-preview. I suppose this should be a known issue. Besides it's going to be replaced by track 2 SDK, which is expected to be GA in mid-August.

    For Swagger Avocado, it happened in our previous PR 2022-06-01. I've listed the detailed explanation for each error in comment. These errors started appearing after this update of Avocado. Would really appreciate if some mechanism could be provided to disable the alarms, cc owner @ruowan.

    For Breaking Change(Cross-Version), it's caused by Fix violated rule R4010: Add default error response for AgentPools_GetAvailableAgentPoolVersions in 2022-07-01. This is a trivial change, just adding a default error response for the operation. Unfortunately, since the fix requires a new response, it would violate rule 1011 of breaking change. Here's the work item used to track the progress of the breaking change review.

    For ~[Staging] Service API Readiness Test, it's a newly added CI.

    FumingZhang avatar Aug 18 '22 09:08 FumingZhang