azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Merging agrifood RP latest swagger for public preview readiness.

Open priyankajayaswal1 opened this issue 2 years ago • 15 comments

This is to merge the already approved PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/6079

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [x] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - October for public preview
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. By August month end
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [x] SDK of Python
    • [x] SDK of Java
    • [x] SDK of Js
    • [x] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

priyankajayaswal1 avatar Aug 15 '22 22:08 priyankajayaswal1

Hi, @priyankajayaswal1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    agfood.json 2021-09-01-preview(a151a44) 2020-05-12-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L559:11
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L517:7
    Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L517:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2021-09 package-preview-2021-09(a151a44) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1598
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationResults' with immediate parent 'FarmBeats', must have a list by immediate parent operation.
    Location: Microsoft.AgFoodPlatform/preview/2021-09-01-preview/agfood.json#L1629
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]"
    RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]"
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 2 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/a151a445a127d62617af65828117e3a6c3f88afe/specification/agrifood/resource-manager/readme.md#tag-package-preview-2021-09">agrifood/resource-manager/readme.md#package-preview-2021-09
    The following errors/warnings are introduced by current PR:
    Rule Message
    :warning: PreCheck/PropertyRedeclarationWarning "readme":"agrifood/resource-manager/readme.md",
    "tag":"package-preview-2021-09",
    "details":"Schema 'Extension' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Extension"
    :warning: UnkownSecurityScheme "readme":"agrifood/resource-manager/readme.md",
    "tag":"package-preview-2021-09",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armagrifood - Approved - 0.7.0
    +	Function `*FarmBeatsModelsClient.Update` has been removed
    +	Struct `FarmBeatsModelsClientUpdateOptions` has been removed
    azure-sdk-for-python-track2 - track2_azure-mgmt-agrifood - Approved - 1.0.0b1
    +	Client name is changed
    +	Removed operation FarmBeatsModelsOperations.update
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6080b0126065467abbb3e096b25ed4ad6c22fa1f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.18.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.18.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-agrifood [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation FarmBeatsModelsOperations.begin_update
      info	[Changelog]   - Added operation FarmBeatsModelsOperations.get_operation_result
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]   - Model FarmBeats has a new parameter identity
      info	[Changelog]   - Model FarmBeats has a new parameter private_endpoint_connections
      info	[Changelog]   - Model FarmBeats has a new parameter public_network_access
      info	[Changelog]   - Model FarmBeats has a new parameter sensor_integration
      info	[Changelog]   - Model FarmBeatsUpdateRequestModel has a new parameter identity
      info	[Changelog]   - Model FarmBeatsUpdateRequestModel has a new parameter properties
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Client name is changed
      info	[Changelog]   - Removed operation FarmBeatsModelsOperations.update
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6080b0126065467abbb3e096b25ed4ad6c22fa1f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armagrifood [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*FarmBeatsModelsClient.Update` has been removed
      info	[Changelog] - Struct `FarmBeatsModelsClientUpdateOptions` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusPending`
      info	[Changelog] - New const `ProvisioningStateUpdating`
      info	[Changelog] - New const `PublicNetworkAccessEnabled`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateSucceeded`
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusApproved`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCreating`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateFailed`
      info	[Changelog] - New const `PrivateEndpointServiceConnectionStatusRejected`
      info	[Changelog] - New const `PublicNetworkAccessHybrid`
      info	[Changelog] - New const `ProvisioningStateCreating`
      info	[Changelog] - New const `ProvisioningStateDeleting`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateDeleting`
      info	[Changelog] - New type alias `PrivateEndpointServiceConnectionStatus`
      info	[Changelog] - New type alias `PublicNetworkAccess`
      info	[Changelog] - New type alias `PrivateEndpointConnectionProvisioningState`
      info	[Changelog] - New function `*PrivateLinkResourcesClient.NewListByResourcePager(string, string, *PrivateLinkResourcesClientListByResourceOptions) *runtime.Pager[PrivateLinkResourcesClientListByResourceResponse]`
      info	[Changelog] - New function `NewPrivateEndpointConnectionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateEndpointConnectionsClient, error)`
      info	[Changelog] - New function `PossiblePublicNetworkAccessValues() []PublicNetworkAccess`
      info	[Changelog] - New function `*FarmBeatsModelsClient.GetOperationResult(context.Context, string, string, string, *FarmBeatsModelsClientGetOperationResultOptions) (FarmBeatsModelsClientGetOperationResultResponse, error)`
      info	[Changelog] - New function `NewPrivateLinkResourcesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrivateLinkResourcesClient, error)`
      info	[Changelog] - New function `PossiblePrivateEndpointServiceConnectionStatusValues() []PrivateEndpointServiceConnectionStatus`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionsClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionsClientDeleteResponse], error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.NewListByResourcePager(string, string, *PrivateEndpointConnectionsClientListByResourceOptions) *runtime.Pager[PrivateEndpointConnectionsClientListByResourceResponse]`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.Get(context.Context, string, string, string, *PrivateEndpointConnectionsClientGetOptions) (PrivateEndpointConnectionsClientGetResponse, error)`
      info	[Changelog] - New function `*PrivateLinkResourcesClient.Get(context.Context, string, string, string, *PrivateLinkResourcesClientGetOptions) (PrivateLinkResourcesClientGetResponse, error)`
      info	[Changelog] - New function `PossiblePrivateEndpointConnectionProvisioningStateValues() []PrivateEndpointConnectionProvisioningState`
      info	[Changelog] - New function `*FarmBeatsModelsClient.BeginUpdate(context.Context, string, string, FarmBeatsUpdateRequestModel, *FarmBeatsModelsClientBeginUpdateOptions) (*runtime.Poller[FarmBeatsModelsClientUpdateResponse], error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsClient.CreateOrUpdate(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientCreateOrUpdateOptions) (PrivateEndpointConnectionsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New struct `ArmAsyncOperation`
      info	[Changelog] - New struct `FarmBeatsModelsClientBeginUpdateOptions`
      info	[Changelog] - New struct `FarmBeatsModelsClientGetOperationResultOptions`
      info	[Changelog] - New struct `FarmBeatsModelsClientGetOperationResultResponse`
      info	[Changelog] - New struct `FarmBeatsUpdateProperties`
      info	[Changelog] - New struct `Identity`
      info	[Changelog] - New struct `PrivateEndpoint`
      info	[Changelog] - New struct `PrivateEndpointConnection`
      info	[Changelog] - New struct `PrivateEndpointConnectionListResult`
      info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClient`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientBeginDeleteOptions`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientDeleteResponse`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientGetOptions`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientGetResponse`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientListByResourceOptions`
      info	[Changelog] - New struct `PrivateEndpointConnectionsClientListByResourceResponse`
      info	[Changelog] - New struct `PrivateLinkResource`
      info	[Changelog] - New struct `PrivateLinkResourceListResult`
      info	[Changelog] - New struct `PrivateLinkResourceProperties`
      info	[Changelog] - New struct `PrivateLinkResourcesClient`
      info	[Changelog] - New struct `PrivateLinkResourcesClientGetOptions`
      info	[Changelog] - New struct `PrivateLinkResourcesClientGetResponse`
      info	[Changelog] - New struct `PrivateLinkResourcesClientListByResourceOptions`
      info	[Changelog] - New struct `PrivateLinkResourcesClientListByResourceResponse`
      info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
      info	[Changelog] - New struct `SensorIntegration`
      info	[Changelog] - New field `Properties` in struct `FarmBeatsUpdateRequestModel`
      info	[Changelog] - New field `Identity` in struct `FarmBeatsUpdateRequestModel`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `FarmBeatsProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `FarmBeatsProperties`
      info	[Changelog] - New field `SensorIntegration` in struct `FarmBeatsProperties`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `Identity` in struct `FarmBeats`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 92 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6080b0126065467abbb3e096b25ed4ad6c22fa1f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-agrifood [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 6080b0126065467abbb3e096b25ed4ad6c22fa1f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.agrifood [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-agrifood Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-agrifood Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-agrifood Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi @priyankajayaswal1, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi @priyankajayaswal1, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Latest approved PR in private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/6079

    priyankajayaswal1 avatar Aug 16 '22 05:08 priyankajayaswal1

    Rest all other errors are intentional changes for which we even got approval. I remember getting breakingchange approval for few things here: Review request for Microsoft.AgFoodPlatform to update sensor related parameters in version preview/2021-09-01-preview by priyankajayaswal1 · Pull Request #5517 · Azure/azure-rest-api-specs-pr (github.com)

    Let me know how I may navigate further.

    I have requested python SDK owner ([email protected]) & go SDK owner ([email protected]) for approving Breaking Change in the respective languages.

    priyankajayaswal1 avatar Aug 16 '22 10:08 priyankajayaswal1

    Rest all other errors are intentional changes for which we even got approval. I remember getting breakingchange approval for few things here: Review request for Microsoft.AgFoodPlatform to update sensor related parameters in version preview/2021-09-01-preview by priyankajayaswal1 · Pull Request #5517 · Azure/azure-rest-api-specs-pr (github.com)

    Let me know how I may navigate further.

    I have requested python SDK owner ([email protected]) & go SDK owner ([email protected]) for approving Breaking Change in the respective languages.

    Hi @priyankajayaswal1 , there are still failures against ARM rules: https://github.com/Azure/azure-rest-api-specs/pull/20243/checks?check_run_id=7853677189 . I'm not sure whether ARM catch them in your latest PR in Feb since the tooling didn't report these failures that time.

    Would you please choose below option in top comment to involve ARM review for this PR if they do be current service logic: image

    changlong-liu avatar Aug 17 '22 01:08 changlong-liu

    approve for python breaking change

    msyyc avatar Aug 17 '22 03:08 msyyc

    An update, I got all required labels for merging it for the PR version of this PR here: https://github.com/Azure/azure-rest-api-specs-pr/pull/6079#issuecomment-1219216020

    priyankajayaswal1 avatar Aug 18 '22 13:08 priyankajayaswal1

    An update, I got all required labels for merging it for the PR version of this PR here: Azure/azure-rest-api-specs-pr#6079 (comment)

    Hi @jianyexi , would you help take a look at the LintDiff failure here: https://github.com/Azure/azure-rest-api-specs/pull/20243/checks?check_run_id=7870731280

    I guess they are new rules added recently, so they are not reported at Feb. in the private PR. Do they block this PR? Or do we need ARM review again in this case?

    changlong-liu avatar Aug 19 '22 02:08 changlong-liu

    Could you fix the first error in the [Staging] Swagger Lint Diff , others doesn't need to fix

    jianyexi avatar Aug 19 '22 07:08 jianyexi

    Regarding below:

    DETAILS

    Rule Message
    ❌ RUNTIME_ERROR "errorCode: AssertionError,errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]"

    We have deployed our RP in west central us already. Link to arm manifest file for prod for reference: link

    priyankajayaswal1 avatar Aug 19 '22 08:08 priyankajayaswal1

    Regarding below:

    DETAILS

    Rule Message ❌ RUNTIME_ERROR "errorCode: AssertionError,errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]" ❌ RUNTIME_ERROR "errorCode: AssertionError,errorMessage: ResourceType 'farmBeats' should be deployed in 'West Central US' on apiVersion '2021-09-01'.: expected [ Array(3) ] to satisfy [Function]" We have deployed our RP in west central us already. Link to arm manifest file for prod for reference: link

    Hi @ruowan , would you help take a look whether the "Service API Readiness Test" failure block this PR? the author mentioned service is deployed.

    changlong-liu avatar Aug 19 '22 08:08 changlong-liu