azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
S360 Fixes: Dev containerinstance microsoft.container instance 2021 09 01
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [x] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [x] No refresh required for updates in this PR
Contribution checklist:
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [x] I have reviewed the documentation for the workflow.
- [x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
- [ ] Removing API(s) in a stable version
- [ ] Removing properties in a stable version
- [ ] Removing API version(s) in a stable version
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Hi, @joseph-porter Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 3 Errors, 8 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| containerInstance.json | 2021-09-01(8f9674a) | 2021-09-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2021-09 | package-2021-09(8f9674a) | package-2021-09(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.ContainerInstance/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L418 |
|
The schema 'GitRepoVolume' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L1143 |
|
The schema 'ContainerGroupIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L1462 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L2265 |
|
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L2274 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: timestamps Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L531 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: readOnly Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L1117 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: readOnly Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L1208 |
| :warning: R4009 - RequiredReadOnlySystemData | The response of operation:'ContainerGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L114 |
| :warning: R4009 - RequiredReadOnlySystemData | The response of operation:'ContainerGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L155 |
| :warning: R4009 - RequiredReadOnlySystemData | The response of operation:'ContainerGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json#L209 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/containerinstance/resource-manager/readme.md json: Microsoft.ContainerInstance/stable/2021-09-01/containerInstance.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 21 Errors, 0 Warnings failed [Detail]
Service API Readiness Test failed. Check pipeline artifact for detail report.
| Rule | Message |
|---|---|
|
"statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.ManagedIdentity/userAssignedIdentities/assign/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-5lun1v/providers/Microsoft.ContainerInstance/containerGroups/containergn5dyoq', however the linked subscription '00000000-0000-0000-0000-000000000000' was not found. " |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 403" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"Additional properties not allowed: osVersion" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.ContainerInstance/containerGroups/containergn5dyoq' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
|
"statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Network/virtualNetworks/virtualnetdx9ipn' under resource group 'apiTest-5lun1v' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix" |
|
"errorCode: AssertionError, errorMessage: expected response code to be 2XX but found 404" |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/8f9674a9aa842f71e5f90f0061d4a9586726c9d2/specification/containerinstance/resource-manager/readme.md#tag-package-2021-09">containerinstance/resource-manager/readme.md#package-2021-09
| Rule | Message |
|---|---|
| :warning: UnkownSecurityScheme | "readme":"containerinstance/resource-manager/readme.md", "tag":"package-2021-09", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - armcontainerinstance - 2.0.0❌azure-sdk-for-python-track2 - track2_azure-mgmt-containerinstance - 9.2.0❌azure-sdk-for-js - @azure/arm-containerinstance - 9.0.0+ Interface ContainerGroup no longer has parameter containers + Interface ContainerGroup no longer has parameter diagnostics + Interface ContainerGroup no longer has parameter dnsConfig + Interface ContainerGroup no longer has parameter encryptionProperties + Interface ContainerGroup no longer has parameter identity + Interface ContainerGroup no longer has parameter imageRegistryCredentials + Interface ContainerGroup no longer has parameter initContainers + Interface ContainerGroup no longer has parameter instanceView + Interface ContainerGroup no longer has parameter ipAddress + Interface ContainerGroup no longer has parameter osType + Interface ContainerGroup no longer has parameter provisioningState + Interface ContainerGroup no longer has parameter restartPolicy + Interface ContainerGroup no longer has parameter sku + Interface ContainerGroup no longer has parameter subnetIds + Interface ContainerGroup no longer has parameter volumes
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.ContainerInstance [View full logs] [Release SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-containerinstance [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group SubnetServiceAssociationLinkOperations info [Changelog] - Model IpAddress has a new parameter auto_generated_domain_name_label_scope info [Changelog] - Model Usage has a new parameter id info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model IpAddress no longer has parameter dns_name_label_reuse_policy
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-containerinstance-generated [View full logs] [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armcontainerinstance [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `ContainerGroup.Properties` has been changed from `*ContainerGroupProperties` to `*ContainerGroupPropertiesProperties` info [Changelog] - Type of `ContainerGroupIdentity.UserAssignedIdentities` has been changed from `map[string]*Components10Wh5UdSchemasContainergroupidentityPropertiesUserassignedidentitiesAdditionalproperties` to `map[string]*UserAssignedIdentities` info [Changelog] - Const `AutoGeneratedDomainNameLabelScopeTenantReuse` has been removed info [Changelog] - Const `AutoGeneratedDomainNameLabelScopeNoreuse` has been removed info [Changelog] - Const `AutoGeneratedDomainNameLabelScopeSubscriptionReuse` has been removed info [Changelog] - Const `AutoGeneratedDomainNameLabelScopeUnsecure` has been removed info [Changelog] - Const `AutoGeneratedDomainNameLabelScopeResourceGroupReuse` has been removed info [Changelog] - Type alias `AutoGeneratedDomainNameLabelScope` has been removed info [Changelog] - Function `PossibleAutoGeneratedDomainNameLabelScopeValues` has been removed info [Changelog] - Struct `Components10Wh5UdSchemasContainergroupidentityPropertiesUserassignedidentitiesAdditionalproperties` has been removed info [Changelog] - Field `DNSNameLabelReusePolicy` of struct `IPAddress` has been removed info [Changelog] - Field `DNSConfig` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `ImageRegistryCredentials` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `SubnetIDs` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `ProvisioningState` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `OSType` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `InstanceView` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `Volumes` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `Containers` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `RestartPolicy` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `InitContainers` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `IPAddress` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `SKU` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `Diagnostics` of struct `ContainerGroupProperties` has been removed info [Changelog] - Field `EncryptionProperties` of struct `ContainerGroupProperties` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New const `DNSNameLabelReusePolicySubscriptionReuse` info [Changelog] - New const `DNSNameLabelReusePolicyNoreuse` info [Changelog] - New const `DNSNameLabelReusePolicyUnsecure` info [Changelog] - New const `DNSNameLabelReusePolicyTenantReuse` info [Changelog] - New const `DNSNameLabelReusePolicyResourceGroupReuse` info [Changelog] - New type alias `DNSNameLabelReusePolicy` info [Changelog] - New function `NewSubnetServiceAssociationLinkClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SubnetServiceAssociationLinkClient, error)` info [Changelog] - New function `PossibleDNSNameLabelReusePolicyValues() []DNSNameLabelReusePolicy` info [Changelog] - New function `*SubnetServiceAssociationLinkClient.BeginDelete(context.Context, string, string, string, *SubnetServiceAssociationLinkClientBeginDeleteOptions) (*runtime.Poller[SubnetServiceAssociationLinkClientDeleteResponse], error)` info [Changelog] - New struct `ContainerGroupPropertiesProperties` info [Changelog] - New struct `SubnetServiceAssociationLinkClient` info [Changelog] - New struct `SubnetServiceAssociationLinkClientBeginDeleteOptions` info [Changelog] - New struct `SubnetServiceAssociationLinkClientDeleteResponse` info [Changelog] - New struct `UserAssignedIdentities` info [Changelog] - New field `Properties` in struct `ContainerGroupProperties` info [Changelog] - New field `Identity` in struct `ContainerGroupProperties` info [Changelog] - New field `AutoGeneratedDomainNameLabelScope` in struct `IPAddress` info [Changelog] - New field `ID` in struct `Usage` info [Changelog] info [Changelog] Total 13 breaking change(s), 22 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-containerinstance [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation group SubnetServiceAssociationLink info [Changelog] - Added Interface ContainerGroupProperties info [Changelog] - Added Interface SubnetServiceAssociationLinkDeleteOptionalParams info [Changelog] - Added Interface UserAssignedIdentities info [Changelog] - Added Type Alias DnsNameLabelReusePolicy info [Changelog] - Interface IpAddress has a new optional parameter autoGeneratedDomainNameLabelScope info [Changelog] - Interface Usage has a new optional parameter id info [Changelog] - Class ContainerInstanceManagementClient has a new parameter subnetServiceAssociationLink info [Changelog] - Added Enum KnownDnsNameLabelReusePolicy info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface ContainerGroup no longer has parameter containers info [Changelog] - Interface ContainerGroup no longer has parameter diagnostics info [Changelog] - Interface ContainerGroup no longer has parameter dnsConfig info [Changelog] - Interface ContainerGroup no longer has parameter encryptionProperties info [Changelog] - Interface ContainerGroup no longer has parameter identity info [Changelog] - Interface ContainerGroup no longer has parameter imageRegistryCredentials info [Changelog] - Interface ContainerGroup no longer has parameter initContainers info [Changelog] - Interface ContainerGroup no longer has parameter instanceView info [Changelog] - Interface ContainerGroup no longer has parameter ipAddress info [Changelog] - Interface ContainerGroup no longer has parameter osType info [Changelog] - Interface ContainerGroup no longer has parameter provisioningState info [Changelog] - Interface ContainerGroup no longer has parameter restartPolicy info [Changelog] - Interface ContainerGroup no longer has parameter sku info [Changelog] - Interface ContainerGroup no longer has parameter subnetIds info [Changelog] - Interface ContainerGroup no longer has parameter volumes info [Changelog] - Interface IpAddress no longer has parameter dnsNameLabelReusePolicy info [Changelog] - Removed Enum KnownAutoGeneratedDomainNameLabelScope
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️containerinstance [View full logs] [Release Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from fc5c9985c2868a3064a778886bb6f422c886b933. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.ContainerInstance [View full logs] [Release SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Python | track2_azure-mgmt-containerinstance | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| .Net | Azure.ResourceManager.ContainerInstance | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Java | azure-resourcemanager-containerinstance-generated | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| JavaScript | @azure/arm-containerinstance | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Hi @joseph-porter, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
Hi @joseph-porter, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
Hi, @joseph-porter your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).
@tianxchen-ms I have gotten ARM breaking change approval. This PR contains only Swagger S360 fixes.
What additional approval do I need for you to merge? The "~[Staging] Service API Readiness Test" is a new check that is still in progress, I was told that it could be ignored. I think the Avacado check failure is because this is not the most recent API version tag, but this is just an older version.
Please provide next steps for us to get this merged.