azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Adding VMAgentVersioning property

Open kamusta-msft opened this issue 2 years ago • 8 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [x] SDK of .NET (need service team to ensure code readiness)
    • [x] SDK of Python
    • [x] SDK of Java
    • [x] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

kamusta-msft avatar Aug 03 '22 18:08 kamusta-msft

Hi, @kamusta-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 9 Errors, 5 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    computeRPCommon.json 2022-08-01(5c07448) 2022-03-01(main)
    virtualMachine.json 2022-08-01(5c07448) 2022-03-01(main)
    virtualMachineScaleSet.json 2022-08-01(5c07448) 2022-03-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/computeRPCommon.json#L678:7
    1034 - AddedRequiredProperty The new version has new required property 'sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/computeRPCommon.json#L678:7
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl, sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L1955:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L1955:9
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl, sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L2000:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L2000:9
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/computeRPCommon.json#L678:7
    1034 - AddedRequiredProperty The new version has new required property 'sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/computeRPCommon.json#L678:7
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl, sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4500:9
    Old: ComputeRP/stable/2022-03-01/virtualMachineScaleSet.json#L4500:9
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl, sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L1955:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L1955:9
    1034 - AddedRequiredProperty The new version has new required property 'secretUrl, sourceVault' that was not found in the old version.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L2000:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L2000:9
    :warning: 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L1955:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L1955:9
    :warning: 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L2000:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L2000:9
    :warning: 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L4500:9
    Old: ComputeRP/stable/2022-03-01/virtualMachineScaleSet.json#L4500:9
    :warning: 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L1955:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L1955:9
    :warning: 1026 - TypeChanged The new version has a different type '' than the previous one 'object'.
    New: ComputeRP/stable/2022-08-01/virtualMachine.json#L2000:9
    Old: ComputeRP/stable/2022-03-01/virtualMachine.json#L2000:9
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-08-01 package-2022-08-01(5c07448) package-2022-08-01(feature/cplat-2022-08-01)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableVMAgentPlatformUpdates
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L1268
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableVMAgentPlatformUpdates
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L1321


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L1908
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json#L5653
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Compute/operations' does not match the ARM specification. Please standardize the schema.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L37
    R4037 - MissingTypeObject The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L178
    R4037 - MissingTypeObject The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L194
    R4037 - MissingTypeObject The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L213
    R4037 - MissingTypeObject The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L238
    R4037 - MissingTypeObject The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L251
    R4037 - MissingTypeObject The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L287
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'InstanceViewStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L319
    R4037 - MissingTypeObject The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L354
    R4037 - MissingTypeObject The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L354
    R4037 - MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L367
    R4037 - MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L367
    R4037 - MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L367
    R4037 - MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L401
    R4037 - MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L401
    R4037 - MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L401
    R4037 - MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L416
    R4037 - MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L416
    R4037 - MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L416
    R4037 - MissingTypeObject The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-08-01/computeRPCommon.json#L437
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-08-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/5c0744848dc4f09ff3fa1c9a82c599d2e098be67/specification/compute/resource-manager/readme.md#tag-package-2022-08-01">compute/resource-manager/readme.md#package-2022-08-01
      • "https://github.com/Azure/azure-rest-api-specs/blob/5c0744848dc4f09ff3fa1c9a82c599d2e098be67/specification/compute/resource-manager/readme.md#tag-package-2022-08-01-only">compute/resource-manager/readme.md#package-2022-08-01-only
    The following errors/warnings are introduced by current PR:
    Rule Message
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-08-01",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1397",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."


    The following errors/warnings exist before current PR submission:

    Rule Message
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-08-01",
    "details":"Error: 1 errors occured -- cannot continue."
    :warning: UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-08-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - armcompute - 4.0.0
    +	Function `*CloudServicesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudService, *CloudServicesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginCreateOrUpdateOptions)`
    +	Function `*CloudServicesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudServiceUpdate, *CloudServicesClientBeginUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginUpdateOptions)`
    +	Function `*CloudServicesUpdateDomainClient.BeginWalkUpdateDomain` parameter(s) have been changed from `(context.Context, string, string, int32, UpdateDomain, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)` to `(context.Context, string, string, int32, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)`
    +	Type of `SharingProfile.CommunityGalleryInfo` has been changed from `interface{}` to `*CommunityGalleryInfo`
    +	Type of `VirtualMachineExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
    +	Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
    +	Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
    ⚠️azure-sdk-for-js - @azure/arm-compute - 20.0.0
    +	Enum KnownOrchestrationServiceNames no longer has value DummyOrchestrationServiceName
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 27.2.0
    +	Model PurchasePlan no longer has parameter promotion_code
    +	Operation VirtualMachineRunCommandsOperations.begin_create_or_update no longer has parameter content_type
    +	Operation VirtualMachineRunCommandsOperations.begin_update no longer has parameter content_type
    +	Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_create_or_update no longer has parameter content_type
    +	Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_update no longer has parameter content_type
    +	Operation VirtualMachineScaleSetVMsOperations.begin_run_command no longer has parameter content_type
    +	Operation VirtualMachinesOperations.begin_run_command no longer has parameter content_type
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Compute [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model LinuxConfiguration has a new parameter enable_vm_agent_platform_updates
      info	[Changelog]   - Model WindowsConfiguration has a new parameter enable_vm_agent_platform_updates
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model PurchasePlan no longer has parameter promotion_code
      info	[Changelog]   - Operation VirtualMachineRunCommandsOperations.begin_create_or_update no longer has parameter content_type
      info	[Changelog]   - Operation VirtualMachineRunCommandsOperations.begin_update no longer has parameter content_type
      info	[Changelog]   - Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_create_or_update no longer has parameter content_type
      info	[Changelog]   - Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_update no longer has parameter content_type
      info	[Changelog]   - Operation VirtualMachineScaleSetVMsOperations.begin_run_command no longer has parameter content_type
      info	[Changelog]   - Operation VirtualMachinesOperations.begin_run_command no longer has parameter content_type
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Interface LinuxConfiguration has a new optional parameter enableVMAgentPlatformUpdates
      info	[Changelog]   - Interface WindowsConfiguration has a new optional parameter enableVMAgentPlatformUpdates
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcompute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*CloudServicesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudService, *CloudServicesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginCreateOrUpdateOptions)`
      info	[Changelog] - Function `*CloudServicesUpdateDomainClient.BeginWalkUpdateDomain` parameter(s) have been changed from `(context.Context, string, string, int32, UpdateDomain, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)` to `(context.Context, string, string, int32, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)`
      info	[Changelog] - Function `*CloudServicesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudServiceUpdate, *CloudServicesClientBeginUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginUpdateOptions)`
      info	[Changelog] - Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Type of `VirtualMachineExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
      info	[Changelog] - Type of `SharingProfile.CommunityGalleryInfo` has been changed from `interface{}` to `*CommunityGalleryInfo`
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `EnableVMAgentPlatformUpdates` in struct `WindowsConfiguration`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions`
      info	[Changelog] - New field `EnableVMAgentPlatformUpdates` in struct `LinuxConfiguration`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesClientBeginUpdateOptions`
      info	[Changelog] - New field `Parameters` in struct `CloudServicesClientBeginCreateOrUpdateOptions`
      info	[Changelog]
      info	[Changelog] Total 7 breaking change(s), 5 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from a76e8e63edc0db5f05efebb609d82abf1a52f154. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.compute [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/e0705b763b6b41988389354ced2b70d0
    .Net Azure.ResourceManager.Compute There is no API change compared with the previous version
    JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/8c1bd0ea97b549a293b197a6e71b0750
    Python track2_azure-mgmt-compute Create ApiView timeout. Package is too large and we cannot create ApiView for it.

    Hi @kamusta-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi, @kamusta-msft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @kamusta-msft since a breaking change, will you comment justification/reason for breaking change and then tag @ JeffreyRichter to get approval?

    grizzlytheodore avatar Aug 14 '22 00:08 grizzlytheodore

    Hi @kamusta-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.