azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2019-05-05-preview
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [x] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @khaledaboasbe Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| ActionRules.json | 2019-05-05-preview(868a4cd) | 2019-05-05-preview(main) |
| Rule | Message |
|---|---|
|
The new version has a new property 'alertRuleName' in response that was not found in the old version. New: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L672:7 Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L672:7 |
|
The new version has a new optional property 'alertRuleName' that was not found in the old version. New: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L672:7 Old: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L672:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2019-06-preview | package-2019-06-preview(868a4cd) | package-2019-06-preview(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L856 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L877 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L307 |
|
The integer type does not have a format, please add it. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L758 |
|
The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L536 |
|
The schema 'errorResponseBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L544 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L568 |
|
The schema 'ManagedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L589 |
|
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L605 |
|
The schema 'ActionRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L764 |
|
The schema 'ActionRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L778 |
|
The schema 'ActionRulesList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L900 |
|
The schema 'PatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L916 |
|
The schema 'PatchObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L933 |
|
Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L559 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L772 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: schema Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L316 |
| :warning: R3027 - TrackedResourceListByResourceGroup | The tracked resource, 'ManagedResource', must have a list by resource group operation.(This rule does not apply for tenant level resources.) Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L589 |
| :warning: R3028 - TrackedResourceListBySubscription | The tracked resource, 'ManagedResource', must have a list by subscriptions operation. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L589 |
| :warning: R4024 - PreviewVersionOverOneYear | The API version:2019-05-05-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.AlertsManagement/preview/2019-05-05-preview/ActionRules.json#L4 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/868a4cd1d18f1a2ca568cbedd22264c3f0e18978/specification/alertsmanagement/resource-manager/readme.md#tag-package-2019-06-preview">alertsmanagement/resource-manager/readme.md#package-2019-06-preview
- "https://github.com/Azure/azure-rest-api-specs/blob/868a4cd1d18f1a2ca568cbedd22264c3f0e18978/specification/alertsmanagement/resource-manager/readme.md#tag-package-preview-2019-05">alertsmanagement/resource-manager/readme.md#package-preview-2019-05
| Rule | Message |
|---|---|
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:107"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:191"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:111"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:195"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Error: 4 errors occured -- cannot continue." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:107"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponse' (1 differences):\n - properties.error.$ref: "#/components/schemas/schemas:13" => "#/components/schemas/schemas:191"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:111"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Duplicate Schema named 'errorResponseBody' (1 differences):\n - properties.details.$ref: "#/components/schemas/schemas:17" => "#/components/schemas/schemas:195"; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Error: 4 errors occured -- cannot continue." |
| :warning: PreCheck/EmptyParentSchemaWarning | "readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-2019-06-preview", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it." |
| :warning: PreCheck/EmptyParentSchemaWarning | "readme":"alertsmanagement/resource-manager/readme.md", "tag":"package-preview-2019-05", "details":"Schema 'MonitorServiceList' has an allOf list with an empty object schema as a parent, removing it." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-go - armalertsmanagement - 0.7.0❌azure-sdk-for-python-track2 - track2_azure-mgmt-alertsmanagement - Approved - 1.0.0️❌ azure-sdk-for-net failed [Detail]
❌Failed [Logs]Release - Generate from 261132757bc9806f4aa90bd5b176ecfa6a447726. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 command autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/alertsmanagement/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] No usable version of the libssl was found cmderr [Autorest] FATAL: csharp/simplifier - FAILED cmderr [Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. cmderr [Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated. error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest warn Skip package processing as generation is failed
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs]Release - Generate from 261132757bc9806f4aa90bd5b176ecfa6a447726. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead. cmderr [automation_generate.sh] notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.18.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.18.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-alertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group AlertProcessingRulesOperations info [Changelog] - Model Condition has a new parameter field info [Changelog] - Model Essentials has a new parameter action_status info [Changelog] - Model Essentials has a new parameter description info [Changelog] - Model Operation has a new parameter origin info [Changelog] - Model PatchObject has a new parameter enabled info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model PatchObject no longer has parameter status info [Changelog] - Operation AlertsOperations.change_state has a new parameter comment info [Changelog] - Removed operation group ActionRulesOperations info [Changelog] - Removed operation group SmartDetectorAlertRulesOperations
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs]Release - Generate from 261132757bc9806f4aa90bd5b176ecfa6a447726. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armalertsmanagement [View full logs] [Release SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `Comment` in struct `AlertsClientChangeStateOptions` info [Changelog] - New field `Origin` in struct `Operation` info [Changelog] info [Changelog] Total 0 breaking change(s), 2 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs]Release - Generate from 261132757bc9806f4aa90bd5b176ecfa6a447726. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️alertsmanagement [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs]Release - Generate from 261132757bc9806f4aa90bd5b176ecfa6a447726. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.alertsmanagement [View full logs] [Release SDK Changes]
NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
Hi, @khaledaboasbe. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
