azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

(ARMSubscription) fixes Azure/azure-sdk-for-go#18620

Open navba-MSFT opened this issue 3 years ago • 13 comments

fixes Azure/azure-sdk-for-go#18620

The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct:

tenantId - The subscription tenant ID. tags - The tags attached to the subscription.

Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [x] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

navba-MSFT avatar Jul 21 '22 08:07 navba-MSFT

Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Jul 21 '22 08:07 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    subscriptions.json 2016-06-01(07ecbe5) 2016-06-01(main)
    Rule Message
    ❌ 1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'tenantId' in response that was not found in the old version.
    New: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L211:7
    Old: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L211:7
    ❌ 1041 - AddedPropertyInResponse The new version has a new property 'tags' in response that was not found in the old version.
    New: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L211:7
    Old: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L211:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-10 package-2021-10(07ecbe5) package-2021-10(main)
    package-2020-09 package-2020-09(07ecbe5) package-2020-09(main)
    package-2019-10-preview package-2019-10-preview(07ecbe5) package-2019-10-preview(main)
    package-2018-03-preview package-2018-03-preview(07ecbe5) package-2018-03-preview(main)
    package-2019-03-preview package-2019-03-preview(07ecbe5) package-2019-03-preview(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R3023 - OperationsAPIImplementation Operations API must be implemented for '/providers/Microsoft.Subscription/operations'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L36
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148
    ❌ R4037 - MissingTypeObject The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
    ❌ R4037 - MissingTypeObject The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
    ❌ R4037 - MissingTypeObject The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
    ❌ R4037 - MissingTypeObject The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
    ❌ R4037 - MissingTypeObject The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163
    ❌ R4037 - MissingTypeObject The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
    ❌ R4037 - MissingTypeObject The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
    ❌ R4037 - MissingTypeObject The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
    ❌ R4037 - MissingTypeObject The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/subscription/resource-manager/readme.md
    tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 19 Errors, 0 Warnings failed [Detail] Service API Readiness Test failed. Check pipeline artifact for detail report.
    Rule Message
    ❌ RUNTIME_ERROR "statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: Something went wrong in our systems. Please try again later or contact Azure Support(http://aka.ms/createazuresupport) if issue persists"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 500"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: SubscriptionAliasNotFound,
    errorMessage: Subscription alias not found"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 401,
    errorCode: UserNotAuthorized,
    errorMessage: User doesn't have 'UserAccessAdministrator' role at root scope (/)"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 401"
    ❌ RUNTIME_ERROR "statusCode: 400,
    errorCode: InvalidBillingAccountName,
    errorMessage: Invalid billing account name."
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 400"
    ❌ RUNTIME_ERROR "statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: Something went wrong in our systems. Please try again later or contact Azure Support(http://aka.ms/createazuresupport) if issue persists"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 500"
    ❌ RUNTIME_ERROR "statusCode: 404,
    errorCode: SubscriptionNotFound,
    errorMessage: Subscription_V2021Controller.ValidateInvitation: No invitation found with subscription id db5eb68e-73e2-4fa8-b18a-46cd1be4cce5 and tenant id 72f988bf-86f1-41af-91ab-2d7cd011db47"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 404"
    ❌ RUNTIME_ERROR "statusCode: 401,
    errorCode: UserNotAuthorized,
    errorMessage: Only subscription owners can perform this operation. Contact your subscription owner to perform this operation"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 401"
    ❌ RUNTIME_ERROR "statusCode: 400,
    errorCode: NotAllowed,
    errorMessage: Subscription has been marked as active already. Subscription should reflect the correct state shortly. If this doesn't resolve in the next 15 minutes,
    contact Azure Support(http://aka.ms/createazuresupport)"
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 400"
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY "Missing required property: nextLink"
    ❌ RUNTIME_ERROR "statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '0a32c980-8601-446c-843e-9411a8f586c7' with object id '0a32c980-8601-446c-843e-9411a8f586c7' does not have authorization to perform action 'Microsoft.Subscription/aliases/delete' over scope '/providers/Microsoft.Subscription/aliases/aliasnamelk1md8' or the scope is invalid. If access was recently granted,
    please refresh your credentials."
    ❌ RUNTIME_ERROR "errorCode: AssertionError,
    errorMessage: expected response code to be 2XX but found 403"
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2021-10">subscription/resource-manager/readme.md#package-2021-10
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2020-09">subscription/resource-manager/readme.md#package-2020-09
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2019-10-preview">subscription/resource-manager/readme.md#package-2019-10-preview
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2019-03-preview">subscription/resource-manager/readme.md#package-2019-03-preview
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2018-11-preview">subscription/resource-manager/readme.md#package-2018-11-preview
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2018-03-preview">subscription/resource-manager/readme.md#package-2018-03-preview
      • "https://github.com/Azure/azure-rest-api-specs/blob/07ecbe547740e6ec7ecd7fd285e9cf4a93c33982/specification/subscription/resource-manager/readme.md#tag-package-2016-06-01">subscription/resource-manager/readme.md#package-2016-06-01
    The following errors/warnings exist before current PR submission:
    Rule Message
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2020-09",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-10-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2019-03-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2018-11-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2018-03-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    :warning: UnkownSecurityScheme "readme":"subscription/resource-manager/readme.md",
    "tag":"package-2016-06-01",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Jul 21 '22 08:07 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking



    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/subscription/armsubscription [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ProvisioningAccepted`
info	[Changelog] - New const `ProvisioningSucceeded`
info	[Changelog] - New const `ProvisioningPending`
info	[Changelog] - New type alias `Provisioning`
info	[Changelog] - New function `PossibleProvisioningValues() []Provisioning`
info	[Changelog] - New field `ProvisioningState` in struct `AcceptOwnershipStatusResponse`
info	[Changelog] - New field `TenantID` in struct `Subscription`
info	[Changelog] - New field `Tags` in struct `Subscription`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 7 additive change(s).
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-subscription [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Subscription has a new parameter tags
info	[Changelog]   - Model Subscription has a new parameter tenant_id
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-subscriptions [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias Provisioning
info	[Changelog]   - Interface AcceptOwnershipStatusResponse has a new optional parameter provisioningState
info	[Changelog]   - Interface Subscription has a new optional parameter tags
info	[Changelog]   - Interface Subscription has a new optional parameter tenantId
info	[Changelog]   - Added Enum KnownProvisioning
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️subscription [View full logs] 
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 13568d0799d329786bb7e8c5c8adf6d7cc346b24. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Subscription [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Jul 21 '22 08:07 openapi-pipeline-app[bot]

    Hi @navba-MSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    openapi-workflow-bot[bot] avatar Jul 21 '22 08:07 openapi-workflow-bot[bot]

    @navba-MSFT Could you please let service team to approve? Thanks.

    tadelesh avatar Jul 22 '22 06:07 tadelesh

    /azp run

    chunyu3 avatar Jul 25 '22 01:07 chunyu3

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jul 25 '22 01:07 azure-pipelines[bot]

    @ShilpiGautam Could you please review this once you get a chance ? Thanks in advance.

    navba-MSFT avatar Jul 27 '22 03:07 navba-MSFT

    @chunyu3 Could you please review this once you get a chance ? Thanks in advance.

    navba-MSFT avatar Aug 01 '22 03:08 navba-MSFT

    @chunyu3 Could you please review this once you get a chance ? Thanks in advance.

    navba-MSFT avatar Aug 08 '22 04:08 navba-MSFT

    @josephkwchan @jennyhunter-msft Could you please review this PR ?

    navba-MSFT avatar Aug 16 '22 04:08 navba-MSFT

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/subscription/armsubscription Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-subscription Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-subscriptions Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    openapi-pipeline-app[bot] avatar Aug 19 '22 09:08 openapi-pipeline-app[bot]

    NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    openapi-workflow-bot[bot] avatar Aug 19 '22 09:08 openapi-workflow-bot[bot]

    Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 11 '22 16:09 ghost

    Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    openapi-workflow-bot[bot] avatar Sep 13 '22 05:09 openapi-workflow-bot[bot]