azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[DoNotMerge] New api version for resource mover 2022-01-01
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [x] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No refresh required for updates in this PR
Contribution checklist:
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
- [ ] Removing API(s) in a stable version
- [ ] Removing properties in a stable version
- [ ] Removing API version(s) in a stable version
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Hi, @snehachebrolu23 Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| resourcemovercollection.json | 2022-01-01(f8d795a) | 2021-08-01(main) |
| resourcemovercollection.json | 2022-01-01(f8d795a) | 2019-10-01(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-01-01 | package-2022-01-01(f8d795a) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'MoveResourceFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1618 |
|
The schema 'MoveResourceFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1626 |
|
The schema 'UnresolvedDependenciesFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1634 |
|
The schema 'UnresolvedDependenciesFilterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1642 |
|
The schema 'MoveResourceError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1821 |
|
The schema 'MoveResourceErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1831 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L2489 |
|
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L2499 |
| :warning: R1001 - OperationIdNounVerb | Per the Noun_Verb convention for Operation Ids, the noun 'MoveCollections' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L919 |
| :warning: R1001 - OperationIdNounVerb | Per the Noun_Verb convention for Operation Ids, the noun 'MoveCollections' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L959 |
| :warning: R1003 - ListInOperationName | Since operation 'UnresolvedDependenciesGet' response has model definition 'x-ms-pageable', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L575 |
| :warning: R1003 - ListInOperationName | Since operation 'OperationsDiscoveryGet' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L885 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1353 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1480 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1621 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1637 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1796 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1823 |
| :warning: R2001 - AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L2559 |
| :warning: R2029 - PageableOperation | Based on the response model schema, operation 'OperationsDiscovery_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L881 |
| :warning: R2029 - PageableOperation | Based on the response model schema, operation 'MoveCollections_ListRequiredFor' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L999 |
| :warning: R2063 - OperationIdNounConflictingModelNames | OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'OperationsDiscoveryModel'. Consider using the plural form of 'OperationsDiscovery' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L885 |
| :warning: R3010 - TrackedResourceListByImmediateParent | The child tracked resource, 'moveResources' with immediate parent 'MoveCollection', must have a list by immediate parent operation. Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1333 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isResolveRequired Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1317 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1513 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1536 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1559 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1582 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validateOnly Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1602 |
| :warning: R3018 - EnumInsteadOfBoolean | Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json#L1785 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/resourcemover/resource-manager/readme.md json: Microsoft.Migrate/stable/2022-01-01/resourcemovercollection.json |
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.Migrate' for api version '2021-08-01'. The supported api-versions are '2018-02-02, 2017-11-11-preview, 2017-09-25-privatepreview, 2018-06-30-preview, 2019-05-01, 2019-10-01'." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/f8d795a7b907e16d2ccd9775601fdf0c0f35a903/specification/resourcemover/resource-manager/readme.md#tag-package-2022-01-01">resourcemover/resource-manager/readme.md#package-2022-01-01
| Rule | Message |
|---|---|
| :warning: UnkownSecurityScheme | "readme":"resourcemover/resource-manager/readme.md", "tag":"package-2022-01-01", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - armresourcemover - Approved - 2.0.0+ Field `Body` of struct `MoveCollectionsClientCreateOptions` has been removed + Field `Body` of struct `MoveCollectionsClientUpdateOptions` has been removed + Field `Body` of struct `MoveResourcesClientBeginCreateOptions` has been removed + Function `*MoveCollectionsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *MoveCollectionsClientCreateOptions)` to `(context.Context, string, string, MoveCollection, *MoveCollectionsClientCreateOptions)` + Function `*MoveCollectionsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *MoveCollectionsClientUpdateOptions)` to `(context.Context, string, string, UpdateMoveCollectionRequest, *MoveCollectionsClientUpdateOptions)` + Function `*MoveResourcesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, *MoveResourcesClientBeginCreateOptions)` to `(context.Context, string, string, string, MoveResource, *MoveResourcesClientBeginCreateOptions)`
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-resourcemover - 1.1.0b2️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
️✔️track2_azure-mgmt-resourcemover [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model AvailabilitySetResourceSettings has a new parameter tags info [Changelog] - Model LoadBalancerResourceSettings has a new parameter tags info [Changelog] - Model MoveCollection has a new parameter system_data info [Changelog] - Model MoveResource has a new parameter system_data info [Changelog] - Model NetworkInterfaceResourceSettings has a new parameter tags info [Changelog] - Model NetworkSecurityGroupResourceSettings has a new parameter tags info [Changelog] - Model PublicIPAddressResourceSettings has a new parameter tags info [Changelog] - Model SqlDatabaseResourceSettings has a new parameter tags info [Changelog] - Model SqlElasticPoolResourceSettings has a new parameter tags info [Changelog] - Model VirtualMachineResourceSettings has a new parameter tags info [Changelog] - Model VirtualMachineResourceSettings has a new parameter user_managed_identities info [Changelog] - Model VirtualNetworkResourceSettings has a new parameter tags
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-resourcemover [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armresourcemover [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*MoveCollectionsClient.Create` parameter(s) have been changed from `(context.Context, string, string, *MoveCollectionsClientCreateOptions)` to `(context.Context, string, string, MoveCollection, *MoveCollectionsClientCreateOptions)` info [Changelog] - Function `*MoveResourcesClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, string, *MoveResourcesClientBeginCreateOptions)` to `(context.Context, string, string, string, MoveResource, *MoveResourcesClientBeginCreateOptions)` info [Changelog] - Function `*MoveCollectionsClient.Update` parameter(s) have been changed from `(context.Context, string, string, *MoveCollectionsClientUpdateOptions)` to `(context.Context, string, string, UpdateMoveCollectionRequest, *MoveCollectionsClientUpdateOptions)` info [Changelog] - Field `Body` of struct `MoveCollectionsClientCreateOptions` has been removed info [Changelog] - Field `Body` of struct `MoveResourcesClientBeginCreateOptions` has been removed info [Changelog] - Field `Body` of struct `MoveCollectionsClientUpdateOptions` has been removed info [Changelog] info [Changelog] Total 6 breaking change(s), 0 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
⚠️Warning [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json cmderr [automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist cmderr [automation_init.sh] [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details. cmderr [automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js cmderr [automation_init.sh] deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest cmderr [automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself. warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-resourcemover [View full logs] [Preview SDK Changes]info [Changelog] error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️resourcemover [View full logs] [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 69495223e506fbfb7bc06b13339408604e036a68. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.ResourceMoverServiceApi [View full logs] [Preview SDK Changes]
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
:x: snehachebrolu23 sign now
You have signed the CLA already but the status is still pending? Let us recheck it.
Hi @snehachebrolu23, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
@snehachebrolu23 Please change the default tag to the new version to resolve the avocado error. And is this version not onboard yet? You titled the PR with DoNotMerge and API readiness check failed.
Hi, @snehachebrolu23. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @snehachebrolu23. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.