azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
Added sizeInGb and sizeInBytes properties to OSDiskImage
Related issue: https://github.com/Azure/azure-sdk-for-net/issues/15705
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No refresh required for updates in this PR
Contribution checklist:
- [x] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
- [ ] Removing API(s) in a stable version
- [ ] Removing properties in a stable version
- [ ] Removing API version(s) in a stable version
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Hi, @davidomid Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| virtualMachineImage.json | 2022-03-01(c34d580) | 2022-03-01(main) |
| Rule | Message |
|---|---|
|
The new version has a new property 'sizeInGb' in response that was not found in the old version. New: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L866:7 Old: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L866:7 |
|
The new version has a new property 'sizeInBytes' in response that was not found in the old version. New: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L866:7 Old: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L866:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-03-01 | package-2022-03-01(c34d580) | package-2022-03-01(main) |
| package-2022-01-03 | package-2022-01-03(c34d580) | package-2022-01-03(main) |
| package-2022-04-04 | package-2022-04-04(c34d580) | package-2022-04-04(main) |
| package-2022-03-02 | package-2022-03-02(c34d580) | package-2022-03-02(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L793 |
|
The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L793 |
|
The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L793 |
|
The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L793 |
|
The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L810 |
|
The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L810 |
|
The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L810 |
|
The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L810 |
|
The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L843 |
|
The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L843 |
|
The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L843 |
|
The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L843 |
|
The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L865 |
|
The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L865 |
|
The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L865 |
|
The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L865 |
|
The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L895 |
|
The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L895 |
|
The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L895 |
|
The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L895 |
|
The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L906 |
|
The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L906 |
|
The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L906 |
|
The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L906 |
|
The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L918 |
|
The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L918 |
|
The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L918 |
|
The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L918 |
|
The schema 'VirtualMachineImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L931 |
|
The schema 'VirtualMachineImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: ComputeRP/stable/2022-03-01/virtualMachineImage.json#L931 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-04-04 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]
Service API Readiness Test failed. Check pipeline artifact for detail report.️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SDK Track2 Validation: 4 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/c34d580d364333e148fc7fddb38b98d457ac550f/specification/compute/resource-manager/readme.md#tag-package-2022-04-04">compute/resource-manager/readme.md#package-2022-04-04
- "https://github.com/Azure/azure-rest-api-specs/blob/c34d580d364333e148fc7fddb38b98d457ac550f/specification/compute/resource-manager/readme.md#tag-package-2022-03-02">compute/resource-manager/readme.md#package-2022-03-02
- "https://github.com/Azure/azure-rest-api-specs/blob/c34d580d364333e148fc7fddb38b98d457ac550f/specification/compute/resource-manager/readme.md#tag-package-2022-01-03">compute/resource-manager/readme.md#package-2022-01-03
- "https://github.com/Azure/azure-rest-api-specs/blob/c34d580d364333e148fc7fddb38b98d457ac550f/specification/compute/resource-manager/readme.md#tag-package-2022-03-01">compute/resource-manager/readme.md#package-2022-03-01
- "https://github.com/Azure/azure-rest-api-specs/blob/c34d580d364333e148fc7fddb38b98d457ac550f/specification/compute/resource-manager/readme.md#tag-package-2022-03-01-only">compute/resource-manager/readme.md#package-2022-03-01-only
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Error: 1 errors occured -- cannot continue." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Error: 1 errors occured -- cannot continue." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Error: 1 errors occured -- cannot continue." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Error: 1 errors occured -- cannot continue." |
| :warning: UnkownSecurityScheme | "readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - armcompute - 4.0.0- Type of `VirtualMachineExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
- Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`
- Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettingsFromKeyVault` has been changed from `interface{}` to `*KeyVaultSecretReference`❌azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 27.2.0+ Operation VirtualMachineRunCommandsOperations.begin_create_or_update no longer has parameter content_type + Operation VirtualMachineRunCommandsOperations.begin_update no longer has parameter content_type + Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_create_or_update no longer has parameter content_type + Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_update no longer has parameter content_type + Operation VirtualMachineScaleSetVMsOperations.begin_run_command no longer has parameter content_type + Operation VirtualMachinesOperations.begin_run_command no longer has parameter content_type
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [91mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515 cmderr [Invoke-GenerateAndBuildV2.ps1] [96mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] [96m 515 | [0m [96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] [96m | [91m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] [91m[96m | [91mFailed to build sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] [0m
❌Azure.ResourceManager.Compute [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Model OSDiskImage has a new parameter size_in_bytes info [Changelog] - Model OSDiskImage has a new parameter size_in_gb info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Operation VirtualMachineRunCommandsOperations.begin_create_or_update no longer has parameter content_type info [Changelog] - Operation VirtualMachineRunCommandsOperations.begin_update no longer has parameter content_type info [Changelog] - Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_create_or_update no longer has parameter content_type info [Changelog] - Operation VirtualMachineScaleSetVMRunCommandsOperations.begin_update no longer has parameter content_type info [Changelog] - Operation VirtualMachineScaleSetVMsOperations.begin_run_command no longer has parameter content_type info [Changelog] - Operation VirtualMachinesOperations.begin_run_command no longer has parameter content_type
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Interface OSDiskImage has a new optional parameter sizeInBytes info [Changelog] - Interface OSDiskImage has a new optional parameter sizeInGb error breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️armcompute [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*CloudServicesClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudServiceUpdate, *CloudServicesClientBeginUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginUpdateOptions)` info [Changelog] - Function `*CloudServicesUpdateDomainClient.BeginWalkUpdateDomain` parameter(s) have been changed from `(context.Context, string, string, int32, UpdateDomain, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)` to `(context.Context, string, string, int32, *CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions)` info [Changelog] - Function `*CloudServicesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, CloudService, *CloudServicesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *CloudServicesClientBeginCreateOrUpdateOptions)` info [Changelog] - Type of `SharingProfile.CommunityGalleryInfo` has been changed from `interface{}` to `*CommunityGalleryInfo` info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `Parameters` in struct `CloudServicesUpdateDomainClientBeginWalkUpdateDomainOptions` info [Changelog] - New field `SizeInBytes` in struct `OSDiskImage` info [Changelog] - New field `SizeInGb` in struct `OSDiskImage` info [Changelog] - New field `Parameters` in struct `CloudServicesClientBeginUpdateOptions` info [Changelog] - New field `Parameters` in struct `CloudServicesClientBeginCreateOrUpdateOptions` info [Changelog] info [Changelog] Total 4 breaking change(s), 4 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️compute [View full logs]
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from 31def82171c0ae0e5c079250367b1c1f330a5207. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.compute [View full logs] [Preview SDK Changes]
NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.
Hi @davidomid, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
:x: davidomid sign now
You have signed the CLA already but the status is still pending? Let us recheck it.
@ArcturusZhang I'm having issues with this PR and was wondering if you could advise on what changes I need to make?
The goal of the PR is to just add these properties which are being returned from the API but are not in the spec or the SDKs.
I tried adding these properties to the 2022-03-01 version and the CI pipeline complained that this is a breaking change and I need a new version.
I tried adding a new 2022-07-11 version and I had to include a lot of files which were referenced even though I haven't had to change them. Also, the CI pipeline is complaining that there should be a corresponding 2022-07-11 API version.
Is there something I'm missing? Does this really need a new API version despite the correct properties being returned already?
I've also noticed in a couple of other PRs that some changes like this can just be added to the original version and a preview version. Is this something I could do instead?
EDIT: I've simplified the changeset now to just modify the old 2022-03-01 version.
Thanks!
Hi, @davidomid. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Java | azure-resourcemanager-compute-generated | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| JavaScript | @azure/arm-compute | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| .Net | Azure.ResourceManager.Compute | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
| Python | track2_azure-mgmt-compute | Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. |
Hi, @davidomid. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @davidomid. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @davidomid. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @davidomid. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @davidomid. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.