azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

recoveryservicesbackup: marking the LRO operations as LROs

Open tombuildsstuff opened this issue 2 years ago • 23 comments

These not being marked as an LRO means that consumers of the API need to instead manually parse the header to make these work, as can be seen in this commit:

https://github.com/hashicorp/terraform-provider-azurerm/blob/4d39dde5bd2ff7b40ecbed0db93d35bf4ea5646d/internal/services/recoveryservices/backup_container_storage_account_resource.go#L97-L117

This PR fixes this by correctly marking these operations as LROs - which is a bug as the operation description explicitly defines these operations are an LRO

tombuildsstuff avatar Mar 15 '22 15:03 tombuildsstuff

Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    Swagger Validation Report

    ️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    bms.json 2021-07-01(a22f94e) 2021-07-01(main)
    bms.json 2021-08-01(a22f94e) 2021-08-01(main)
    bms.json 2021-10-01(a22f94e) 2021-10-01(main)
    bms.json 2021-12-01(a22f94e) 2021-12-01(main)
    bms.json 2022-01-01(a22f94e) 2022-01-01(main)
    Rule Message
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L1373:7
    Old: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L1373:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L1453:7
    Old: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L1452:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L1373:7
    Old: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L1373:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L1453:7
    Old: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L1452:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L1373:7
    Old: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L1373:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L1453:7
    Old: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L1452:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1373:7
    Old: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1373:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1453:7
    Old: Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L1452:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2022-01-01/bms.json#L1373:7
    Old: Microsoft.RecoveryServices/stable/2022-01-01/bms.json#L1373:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.RecoveryServices/stable/2022-01-01/bms.json#L1453:7
    Old: Microsoft.RecoveryServices/stable/2022-01-01/bms.json#L1452:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: protectionIntentItemType
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureWorkload/BackupProtectionIntent_Get.json
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "" not found
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureWorkload/BackupProtectionIntent_Get.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: protectionIntentItemType
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureIaasVm/ProtectionIntent_CreateOrUpdate.json
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "" not found
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureIaasVm/ProtectionIntent_CreateOrUpdate.json
    OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: protectionIntentItemType
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureWorkload/BackupProtectionIntent_List.json
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "" not found
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9911:25
    ExampleUrl: 2021-07-01/examples/AzureWorkload/BackupProtectionIntent_List.json
    DISCRIMINATOR_VALUE_NOT_FOUND Discriminator value "" not found
    Url: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L7662:50
    ExampleUrl: 2021-07-01/examples/BackupDataMove/PrepareDataMoveOperationResult_Get.json#L19:23
    ️❌SemanticValidation: 14 Errors, 0 Warnings failed [Detail]
    Rule Message
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9143:43
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L10848:24
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9163:36
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L10049:31
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L9116:43
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L10821:24
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L9136:36
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L10022:31
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadAutoProtectionIntent
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9947:42
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadSQLAutoProtectionIntent
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9957:45
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9483:43
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L11220:24
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9503:36
    INVALID_XMS_DISCRIMINATOR_VALUE The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer
    JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L10421:31
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 10 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    :warning: OutdatedExtension "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)"
    :warning: IgnoredPropertyNextToRef "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > CloudError > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    :warning: OutdatedExtension "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)"
    :warning: IgnoredPropertyNextToRef "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > CloudError > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    :warning: OutdatedExtension "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)"
    :warning: IgnoredPropertyNextToRef "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > CloudError > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    :warning: OutdatedExtension "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)"
    :warning: IgnoredPropertyNextToRef "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > CloudError > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    :warning: OutdatedExtension "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings)"
    :warning: IgnoredPropertyNextToRef "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > CloudError > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"Autorest completed in 15.26s. 0 files generated."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"Autorest completed in 8.48s. 0 files generated."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"Autorest completed in 7.94s. 0 files generated."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Autorest completed in 7.99s. 0 files generated."


    The following errors/warnings exist before current PR submission:

    Rule Message
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    :warning: DeprecatedConfig "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2022-01",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-12",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-10",
    "details":"Autorest completed in 8.25s. 0 files generated."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-08",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    :speech_balloon: "readme":"recoveryservicesbackup/resource-manager/readme.md",
    "tag":"package-2021-07",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.

    msftbot[bot] avatar Mar 15 '22 15:03 msftbot[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Apr 03 '22 16:04 msftbot[bot]

    Waiting on the Service Team..

    tombuildsstuff avatar Apr 04 '22 08:04 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Apr 24 '22 16:04 msftbot[bot]

    Waiting on the Service Team..

    tombuildsstuff avatar Apr 26 '22 03:04 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar May 15 '22 16:05 msftbot[bot]

    As above

    tombuildsstuff avatar May 17 '22 06:05 tombuildsstuff

    /azp run

    jianyexi avatar Jul 07 '22 02:07 jianyexi

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Jul 07 '22 02:07 azure-pipelines[bot]

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Aug 07 '22 16:08 msftbot[bot]

    As above..

    tombuildsstuff avatar Aug 08 '22 04:08 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Aug 28 '22 16:08 msftbot[bot]

    As above..

    tombuildsstuff avatar Aug 28 '22 20:08 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Sep 18 '22 16:09 msftbot[bot]

    As above..

    tombuildsstuff avatar Sep 19 '22 06:09 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Oct 16 '22 16:10 msftbot[bot]

    Still waiting for a review..

    tombuildsstuff avatar Oct 16 '22 20:10 tombuildsstuff

    Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    msftbot[bot] avatar Nov 06 '22 16:11 msftbot[bot]

    https://github.com/Azure/azure-rest-api-specs/pull/18269#issuecomment-1280051552

    tombuildsstuff avatar Nov 08 '22 10:11 tombuildsstuff