azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
recoveryservicesbackup: marking the LRO operations as LROs
These not being marked as an LRO means that consumers of the API need to instead manually parse the header to make these work, as can be seen in this commit:
https://github.com/hashicorp/terraform-provider-azurerm/blob/4d39dde5bd2ff7b40ecbed0db93d35bf4ea5646d/internal/services/recoveryservices/backup_container_storage_account_resource.go#L97-L117
This PR fixes this by correctly marking these operations as LROs - which is a bug as the operation description explicitly defines these operations are an LRO
Hi, @tombuildsstuff Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.
Swagger Validation Report
️❌BreakingChange: 10 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| bms.json | 2021-07-01(a22f94e) | 2021-07-01(main) |
| bms.json | 2021-08-01(a22f94e) | 2021-08-01(main) |
| bms.json | 2021-10-01(a22f94e) | 2021-10-01(main) |
| bms.json | 2021-12-01(a22f94e) | 2021-12-01(main) |
| bms.json | 2022-01-01(a22f94e) | 2022-01-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 18 Errors, 0 Warnings failed [Detail]
️❌SemanticValidation: 14 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9143:43 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L10848:24 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L9163:36 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-07-01/bms.json#L10049:31 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L9116:43 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L10821:24 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L9136:36 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-08-01/bms.json#L10022:31 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadAutoProtectionIntent JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9947:42 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadSQLAutoProtectionIntent JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9957:45 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.ClassicCompute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9483:43 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: IaaSVMContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L11220:24 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: Microsoft.Compute/virtualMachines JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L9503:36 |
|
The value of x-ms-dicriminator-value is not in the discriminator enum list: AzureWorkloadContainer JsonUrl: Microsoft.RecoveryServices/stable/2021-10-01/bms.json#L10421:31 |
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for your contribution tombuildsstuff! We will review the pull request and get back to you soon.
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️❌SDK Breaking Change Tracking failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-net-track2 failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-sdk-for-python-track2 warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-sdk-for-java warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-js failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️⚠️ azure-resource-manager-schemas warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-powershell failed [Detail]
Only 0 items are rendered, please refer to log for more details.
Hi @tombuildsstuff, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.
| Task | How to fix | Priority |
|---|---|---|
| Avocado | Fix-Avocado | High |
| Semantic validation | Fix-SemanticValidation-Error | High |
| Model validation | Fix-ModelValidation-Error | High |
| LintDiff | Fix-LintDiff | high |
Hi @tombuildsstuff, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
https://github.com/Azure/azure-rest-api-specs/pull/18269#issuecomment-1280051552
Hi, @tombuildsstuff. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Sorry, just because the PR has no activity for over half a year and I am not PR reviewer now. please re-open it if necessary,
@jianyexi the PR is valid and up to date, it's just waiting for a review from the Service Team - unfortunately I can't re-open this PR since you've closed it, so can you please re-open this PR. Thanks.