azure-quickstart-templates icon indicating copy to clipboard operation
azure-quickstart-templates copied to clipboard

FinOps toolkit 0.9 - optimization-workbook update

Open flanakin opened this issue 8 months ago • 2 comments

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • [x] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

  1. On the Storage tab, included the RSVaultBackup tag in the list of non-idle disks.
  2. On the Commitment discounts tab, fixed RI ROWS Limited.
  3. On the Compute tab, fixed incorrect VM processor in processors query.
  4. On the Database tab, removed the idle SQL databases query.

flanakin avatar Apr 16 '25 18:04 flanakin

The failure is saying that it couldn't parse an output variable: Screenshot of the error message

Here's validation of the output after deploying the template: Screenshot of the deployment outputs

And here's the result of the URL loading correctly in the browser: Screenshot of the URL loading correctly

flanakin avatar Apr 16 '25 21:04 flanakin

That's not the error causing the CI failure. The only test that will fail the CI is "Deploy mainTemplate": https://dev.azure.com/azurequickstarts/azure-quickstart-templates/_build/results?buildId=173414&view=logs&j=275f1d19-1bd8-5591-b06b-07d489ea915a&t=326f581a-4b46-5a6e-a0f1-758ebdd2feec&l=42

image

Looks like a parameter may be missing

alex-frankel avatar Apr 17 '25 11:04 alex-frankel