azure-quickstart-templates icon indicating copy to clipboard operation
azure-quickstart-templates copied to clipboard

Update azuredeploy.json

Open vhorne opened this issue 2 years ago • 1 comments

requestRoutingRules priority is required now.

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

vhorne avatar Aug 09 '22 17:08 vhorne

@vhorne - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts avatar Aug 09 '22 17:08 azure-quickstarts

@vhorne - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

azure-quickstarts avatar Aug 11 '22 14:08 azure-quickstarts

@bmoore-msft OK, but the bicep file was previously updated and included this change, yet I still have a busted azuredeply.json file that customers are complaining about. Thus, my attempt to directly fix the azuredeploy.json file./

vhorne avatar Aug 11 '22 14:08 vhorne

We recently started generating azuredeploy.json during CI, so it's going to get overwritten anyway. We have been seeing problems with CI not executing, but in those cases another PR to bicep (or any other file in the sample) is the current workaround.

If you just change the json, we have no idea what's going to happen as a result of the PR...

bmoore-msft avatar Aug 11 '22 17:08 bmoore-msft

Closing to open another PR in attempt to get an updated auto-generated auzuredeploy.json file

vhorne avatar Aug 12 '22 13:08 vhorne