azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Remove ShouldProcess Parameter from Azure Firewall related Resources

Open bewatersmsft opened this issue 2 months ago • 10 comments

Description

Multiple customers have complained of applying test changes to production workloads due to the What-If parameter being passed which comes from ShouldProcess. After reviewing the code, it is apparent there is no support for ShouldProcess and should be removed.

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [x] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

bewatersmsft avatar Oct 28 '25 17:10 bewatersmsft

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

/azp run

isra-fel avatar Oct 28 '25 17:10 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '25 17:10 azure-pipelines[bot]

/azp run

isra-fel avatar Oct 28 '25 18:10 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '25 18:10 azure-pipelines[bot]

/azp run

isra-fel avatar Oct 28 '25 18:10 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '25 18:10 azure-pipelines[bot]

To the author of the pull request, This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • [ ] Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

github-actions[bot] avatar Oct 29 '25 02:10 github-actions[bot]

@bewatersmsft There are breaking changes detected that have not been preannounced. Either target the next breaking change window May 2026, or make sure the PR contains no breaking change.

Check the log of the static analysis pipeline for details.

dolauli avatar Oct 29 '25 02:10 dolauli

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Nov 18 '25 04:11 github-actions[bot]