azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[Az.Dns] Add NAPTR support and tests

Open WhiteHorseV opened this issue 1 year ago • 2 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [ ] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

WhiteHorseV avatar Oct 08 '24 19:10 WhiteHorseV

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsDnssecConfig Get-AzDnsDnssecConfig changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

I will update the test runs after the NAPTR feature is enabled in the PPE/Prod region.

WhiteHorseV avatar Oct 08 '24 22:10 WhiteHorseV

/azp run

Nickcandy avatar Oct 22 '24 10:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 10:10 azure-pipelines[bot]

Hi @WhiteHorseV , you need to add the suppress for the cmdlets to avoid ci checking

Nickcandy avatar Oct 29 '24 07:10 Nickcandy

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Oct 29 '24 07:10 github-actions[bot]

Hi @Nickcandy, I have updated the PR with test recordings. Can you please help review the PR?

WhiteHorseV avatar Oct 30 '24 05:10 WhiteHorseV

LGTM

Nickcandy avatar Oct 31 '24 09:10 Nickcandy

/azp run azure-powershell - security-tools

Nickcandy avatar Oct 31 '24 20:10 Nickcandy

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 31 '24 20:10 azure-pipelines[bot]