azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Generation of GA PowerShell module for Workloads 2024-09-01 api

Open jaskisin opened this issue 1 year ago • 5 comments

Description

Generation of GA PowerShell module for Workloads 2024-09-01 api

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [x] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

jaskisin avatar Oct 08 '24 04:10 jaskisin

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Workloads
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderDB2InstanceObject New-AzWorkloadsProviderDB2InstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderHanaDbInstanceObject New-AzWorkloadsProviderHanaDbInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusHaClusterInstanceObject New-AzWorkloadsProviderPrometheusHaClusterInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusOSInstanceObject New-AzWorkloadsProviderPrometheusOSInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject New-AzWorkloadsProviderSapNetWeaverInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject New-AzWorkloadsProviderSqlServerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorSidMappingObject New-AzWorkloadsSapLandscapeMonitorSidMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

/azp run

jaskisin avatar Oct 08 '24 15:10 jaskisin

Commenter does not have sufficient privileges for PR 26228 in repo Azure/azure-powershell

azure-pipelines[bot] avatar Oct 08 '24 15:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 14 '24 17:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 14 '24 17:10 azure-pipelines[bot]

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead.

Please find migration guide and document below:

If you have open PR or on going development If you are about to start new development and have prior experience Starting from scratch

JoyerJin avatar Feb 24 '25 02:02 JoyerJin

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead.

Please find migration guide and document below:

github-actions[bot] avatar Feb 24 '25 03:02 github-actions[bot]

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead.

Please find migration guide and document below:

If you have open PR or on going development If you are about to start new development and have prior experience Starting from scratch

Hello @JoyerJin ,

I tried to create PR with main branch but it is showing lot of changes and conflicts(https://github.com/Azure/azure-powershell/pull/27206), looks like a lot of work needs to be done. We need this new GA version to be part of release train starting tomorrow. Do we have any work arounds?

Regards, Jaskirat Singh

jaskisin avatar Feb 24 '25 08:02 jaskisin

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead. Please find migration guide and document below: If you have open PR or on going development If you are about to start new development and have prior experience Starting from scratch

Hello @JoyerJin ,

I tried to create PR with main branch but it is showing lot of changes and conflicts(#27206), looks like a lot of work needs to be done. We need this new GA version to be part of release train starting tomorrow. Do we have any work arounds?

Regards, Jaskirat Singh

Please follow the 'If your PR contains changes for autogen modules only' Guidance steps.

Thank you, you can post issues which you met on our channel to solve.

JoyerJin avatar Feb 24 '25 08:02 JoyerJin

To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead. Please find migration guide and document below: If you have open PR or on going development If you are about to start new development and have prior experience Starting from scratch

Hello @JoyerJin , I tried to create PR with main branch but it is showing lot of changes and conflicts(#27206), looks like a lot of work needs to be done. We need this new GA version to be part of release train starting tomorrow. Do we have any work arounds? Regards, Jaskirat Singh

Please follow the 'If your PR contains changes for autogen modules only' Guidance steps.

Thank you, you can post issues which you met on our channel to solve.

Thanks a lot for the help. create new PR after migrating to new process. #https://github.com/Azure/azure-powershell/pull/27209

jaskisin avatar Feb 24 '25 11:02 jaskisin

Replaced by https://github.com/Azure/azure-powershell/pull/27209 Thanks!

NoriZC avatar Feb 24 '25 14:02 NoriZC