azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[ARM] New cmdlets for DataBoundaries

Open skadhiresan opened this issue 1 year ago • 10 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [x] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

skadhiresan avatar Sep 23 '24 18:09 skadhiresan

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
❌Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzADGroupOwner Get-AzADGroupOwner Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzADGroupOwner Get-AzADGroupOwner changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzADServicePrincipalAppRoleAssignment Get-AzADServicePrincipalAppRoleAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzADServicePrincipalAppRoleAssignment Get-AzADServicePrincipalAppRoleAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataBoundaryScope Get-AzDataBoundaryScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataBoundaryScope Get-AzDataBoundaryScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDataBoundaryTenant Get-AzDataBoundaryTenant Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDataBoundaryTenant Get-AzDataBoundaryTenant changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzPolicyAssignment Get-AzPolicyAssignment Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzPolicyAssignment Get-AzPolicyAssignment changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzPolicyDefinition Get-AzPolicyDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzPolicyDefinition Get-AzPolicyDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzPolicyExemption Get-AzPolicyExemption Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzPolicyExemption Get-AzPolicyExemption changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzPolicySetDefinition Get-AzPolicySetDefinition Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzPolicySetDefinition Get-AzPolicySetDefinition changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Resources. Add a changelog record under Upcoming Release section with past tense.
❌UX Metadata Check
❌PowerShell Core - Windows
Type Module ResourceType SubResourceType Command Description
Az.Resources Microsoft.Resources dataBoundaries ArrayItemNotValid: #/commands[1]\n{\n ArrayItemNotValid: #/commands[1].help.parameterSets[0]\n {\n ArrayExpected: #/commands[1].help.parameterSets[0].parameters\n }\n \n ArrayItemNotValid: #/commands[1].examples[0]\n {\n ArrayExpected: #/commands[1].examples[0].parameters\n }\n \n}\n
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1462 review was accepted

skadhiresan avatar Sep 27 '24 00:09 skadhiresan

/azp run

Nickcandy avatar Oct 15 '24 16:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 15 '24 16:10 azure-pipelines[bot]

/azp run

skadhiresan avatar Oct 16 '24 18:10 skadhiresan

Commenter does not have sufficient privileges for PR 26158 in repo Azure/azure-powershell

azure-pipelines[bot] avatar Oct 16 '24 18:10 azure-pipelines[bot]

/azp run

isra-fel avatar Oct 17 '24 06:10 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 17 '24 06:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 18 '24 07:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 18 '24 07:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 21 '24 18:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 21 '24 19:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 29 '24 07:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 29 '24 07:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 29 '24 07:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 29 '24 07:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 30 '24 05:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 30 '24 05:10 azure-pipelines[bot]

Force merging because of known issue in ux metadata analyzer

isra-fel avatar Oct 30 '24 06:10 isra-fel