azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Update SDK to CosmosDB RP API Version 2024-09-01-preview

Open carjackson-msft opened this issue 1 year ago • 7 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [ ] General release
    • [x] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

carjackson-msft avatar Sep 16 '24 16:09 carjackson-msft

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44 % 85.63% Test coverage cannot be lower than the number of the last release.
❌ - MacOS
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44% 85.63% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44% 85.63% Test coverage cannot be lower than the number of the last release.
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Hi @VeryEarly, could you please assist in reviewing?

ghost avatar Oct 02 '24 15:10 ghost

@carjackson-msft Hi, please add your changelog

Nickcandy avatar Oct 12 '24 08:10 Nickcandy

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Oct 12 '24 08:10 github-actions[bot]

@Nickcandy @VeryEarly Added the changelog. Please take a look and merge.

pjohari-ms avatar Oct 15 '24 23:10 pjohari-ms

/azp run

pjohari-ms avatar Oct 18 '24 16:10 pjohari-ms

Commenter does not have sufficient privileges for PR 26110 in repo Azure/azure-powershell

azure-pipelines[bot] avatar Oct 18 '24 16:10 azure-pipelines[bot]

/azp run

Nickcandy avatar Oct 22 '24 16:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 16:10 azure-pipelines[bot]

Accoading to the ci pipelines, your tests failed in MacOS env. Could you find the root cause? https://dev.azure.com/azclitools/public/_build/results?buildId=199405&view=logs&j=e44bd064-d8d9-5feb-6343-09b8c49ab1a8&t=85a1ad8e-4daf-5689-e663-871501e587ee

Nickcandy avatar Oct 22 '24 18:10 Nickcandy

/azp run

Nickcandy avatar Oct 23 '24 06:10 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 23 '24 06:10 azure-pipelines[bot]

Hi @pjohari-ms , we have several changes to fix our CI pipelines. But there are several conflicts when I try to merge it. https://github.com/Azure/azure-powershell/pull/26464 Could you raise a pr to merge main branch to Az.CosmosDB-preview?

Nickcandy avatar Oct 24 '24 06:10 Nickcandy

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Oct 28 '24 08:10 github-actions[bot]

Hi @pjohari-ms, please raise a new PR for this feature since the author of this PR is ghost now.

YanaXu avatar Jan 08 '25 05:01 YanaXu