azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard
verified publisher icon Azure

Add 2024-06-01-preview for redis enterprise

Open revanthballa1188 opened this issue 1 year ago • 6 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [ ] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release

  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

revanthballa1188 avatar Jul 05 '24 08:07 revanthballa1188

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.RedisEnterpriseCache
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzRedisEnterpriseCache Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRedisEnterpriseCache Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRedisEnterpriseCacheDatabase Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRedisEnterpriseCacheDatabase Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzRedisEnterpriseCacheOperationStatus Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzRedisEnterpriseCacheOperationStatus Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args:'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type. -Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.IModule. Now the type is string.(Static).
⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.ILinkedDatabase. Now the type is string.(Static).
⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args:'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type. -Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.IModule. Now the type is string.(Static).
⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.ILinkedDatabase. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.RedisEnterpriseCache. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️Test
⚠️ - Linux
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 47.06 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 47.06% Test coverage for the module cannot be lower than 50%.
⚠️PowerShell Core - Windows
Type Title Current Coverage Description
⚠️ Test Coverage Less Than 50% 47.06% Test coverage for the module cannot be lower than 50%.

azure-client-tools-bot-prd[bot] avatar Jul 05 '24 08:07 azure-client-tools-bot-prd[bot]

/azp run

VeryEarly avatar Jul 23 '24 01:07 VeryEarly

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 23 '24 01:07 azure-pipelines[bot]

please record tests after API upgrade

VeryEarly avatar Jul 23 '24 02:07 VeryEarly

Test recordings have been added

revanthballa1188 avatar Aug 06 '24 06:08 revanthballa1188

@revanthballa1188 Please fix issues in examples that lead to the CI failure.

dolauli avatar Aug 07 '24 02:08 dolauli

/azp run

revanthballa1188 avatar Aug 29 '24 07:08 revanthballa1188

Commenter does not have sufficient privileges for PR 25460 in repo Azure/azure-powershell

azure-pipelines[bot] avatar Aug 29 '24 07:08 azure-pipelines[bot]

/azp run

dolauli avatar Aug 29 '24 09:08 dolauli

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 29 '24 09:08 azure-pipelines[bot]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Aug 29 '24 10:08 github-actions[bot]

@revanthballa1188 Please provide the change log for this PR

msJinLei avatar Sep 05 '24 18:09 msJinLei