azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

add scheduledevent acknowledge command

Open rbandi124 opened this issue 9 months ago • 4 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [ ] General release
    • [ ] Public preview
    • [x] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

rbandi124 avatar Apr 25 '24 23:04 rbandi124

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Set-AzScheduledEvent 1 1 Unassigned_Parameter Set-AzScheduledEvent -ScheduledEventId must be assigned with a value. -ScheduledEventId Assign value for the parameter -ScheduledEventId.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Set-AzScheduledEvent 1 1 Unassigned_Parameter Set-AzScheduledEvent -ScheduledEventId must be assigned with a value. -ScheduledEventId Assign value for the parameter -ScheduledEventId.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌ - Linux
❌ - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows

Hi @rbandi124, could you please double-check this page to choose the right release type: https://github.com/Azure/azure-powershell/blob/main/CONTRIBUTING.md#target-release-types ? And please add changelog and fix the tests.

image

YanaXu avatar Apr 26 '24 08:04 YanaXu

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Apr 26 '24 08:04 github-actions[bot]

@YanaXu this is for private preview which includes external customers.

rbandi124 avatar May 01 '24 21:05 rbandi124

Hi @rbandi124 , please check my former comment and fix the CI.

YanaXu avatar May 07 '24 07:05 YanaXu

‼️ DO NOT MERGE THIS PR ‼️ This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

github-actions[bot] avatar May 07 '24 07:05 github-actions[bot]